trains 0.0.9 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2862732986e24d80f6fe47f3035e206cc033354767902260e7003c983b30ce3d
-  data.tar.gz: 0fd7fbb15a6e12d2bdc61f8753b0f9c7fbe85f9a2a43639089c166364255a27e
+  metadata.gz: 706372a84f876f65aec9c638d6ad2c17dd6255f6dbc942bccbe1f0f81b86e069
+  data.tar.gz: 431b9033167ed91a657dd00ca806c16c1c3df454f74ec276eb7e79baf8407adf
 SHA512:
-  metadata.gz: 151eeb6f6a3c4a1494d40e8e231c6dcaa2b5f66673e59fbf26623d5054a74e514f3d02385b752f2d1cb20145c3ce06794286de3f34b3b11b002d4991419b7d10
-  data.tar.gz: 555e8794465a0f4ea87e05ebad167d3248e4263cb4a9de02736b3003fb06eb40f8fd20a88cda681e78f1803294d025a815c9fed80c1f00a62a0799b3bfb5d39e
+  metadata.gz: a9b1de71a3735c43afee1f793ad0af94e9d8d7d0fced82023c3927d52e2821cf730b997ae7eeab53816208c11320ed4168c381d3d5fa18d0c1c8c8cb3f008006
+  data.tar.gz: c3eac1a413ece2f2ff937f642843aefb7188b63cd25c03d6f394a223b63a1ebb8c25c0a05e7d63c6c903d94687b2f59beb2eebed7b196c7f2e2405573a363075

data/lib/trains/scanner.rb

@@ -49,7 +49,7 @@ module Trains
     def generate_models
       return get_models if File.exist?(File.join(@dir, 'db', 'schema.rb'))
 
-      migrations = get_migrations
+      migrations = get_migrations.flatten.reject(&:nil?)
       Utils::MigrationTailor.stitch(migrations)
     end
 

data/lib/trains/utils/args.rb

@@ -5,6 +5,8 @@ module Trains
     # utility module to deal with parsing of arguments
     module Args
       def parse_args(node)
+        return if node.nil?
+
         case node.type
         when :hash
           parse_hash(node)
@@ -19,6 +21,8 @@ module Trains
 
         node.each_pair { |key, value| options[key.value] = parse_value(value) }
       rescue StandardError => e
+        puts 'Error boi'
+        puts e
         puts node.parent
       ensure
         return options
@@ -34,7 +38,13 @@ module Trains
           if node.method_name == :redirect
             { redirect: node.arguments.first.value }
           end
-        else
+        # skipcq: RB-LI1006
+        when :true
+          true
+        # skipcq: RB-LI1006
+        when :false
+          false
+        when :sym, :str, :integer
           node.value
         end
       end

data/lib/trains/utils/logger.rb

@@ -1,6 +1,14 @@
-module Logger
-  def debug(log)
-    puts '[DEBUG]:'.bold.blue
-    pp log
+# frozen_string_literal: true
+
+module Trains
+  module Utils
+    # Module with logging basics
+    module Logger
+      def self.debug(log)
+        puts '[DEBUG]:'
+        # skipcq: RB-RB-LI1008
+        pp log
+      end
+    end
   end
 end

data/lib/trains/utils/migration_tailor.rb

@@ -6,14 +6,14 @@ module Trains
 
         migrations.each do |mig|
           case mig.modifier
-          when :create_table
+          when :create_table, :create_join_table
             models[mig.table_name] = {}
             models[mig.table_name] = Trains::DTO::Model.new(
               name: mig.table_name,
               fields: mig.fields,
               version: mig.version
             )
-          when :add_column
+          when :add_column, :add_reference
             models[mig.table_name].fields.push(*mig.fields)
           when :remove_column
             column =
@@ -34,6 +34,9 @@ module Trains
 
             models[mig.table_name].fields << mig.fields.first
           end
+
+        rescue NoMethodError
+          next
         end
 
         models

data/lib/trains/version.rb

@@ -1,3 +1,3 @@
 module Trains
-  VERSION = '0.0.9'.freeze
+  VERSION = '0.0.10'.freeze
 end

data/lib/trains/visitor/migration.rb

@@ -4,19 +4,23 @@ module Trains
   module Visitor
     # Visitor that parses DB migration and associates them with Rails models
     class Migration < Base
+      include Utils::Args
+
       def_node_matcher :send_node?, '(send nil? ...)'
       attr_reader :is_migration, :model, :result
 
-      ALLOWED_METHOD_NAMES = %i[change up down].freeze
+      ALLOWED_METHOD_NAMES = %i[change up].freeze
       ALLOWED_TABLE_MODIFIERS = %i[
         create_table
+        create_join_table
         change_table
+        safety_assured
         update_column
-        add_index
       ].freeze
       COLUMN_MODIFIERS = %i[
         add_column
         change_column
+        add_reference
         remove_column
       ].freeze
 
@@ -35,7 +39,12 @@ module Trains
         @migration_class = node.children.first.source
         @migration_version = extract_version(node.parent_class.source)
 
-        process_def_node(node.body)
+        node.each_descendant(:def) do |child_node|
+          next if child_node.body.nil?
+          next unless ALLOWED_METHOD_NAMES.include?(child_node.method_name)
+
+          process_migration(child_node)
+        end
       end
 
       private
@@ -47,21 +56,13 @@ module Trains
         match.to_s.to_f
       end
 
-      def process_def_node(node)
-        return unless node.def_type?
-
-        method_name = node.method_name
-        unless ALLOWED_METHOD_NAMES.include?(method_name) || COLUMN_MODIFIERS.include?(method_name)
-          return
-        end
-        return if node.body.nil?
-
+      def process_migration(node)
         case node.body.type
         when :send
           @result << parse_one_liner_migration(node.body)
         when :begin
           if node.body.children.map(&:type).include?(:block)
-            migration = parse_block_migration(node)
+            migration = parse_block_migration(node.body)
             @result = [*@result, *migration] if migration
           else
             node.body.each_descendant(:send) do |send_node|
@@ -71,8 +72,12 @@ module Trains
           end
         when :block
           @result = [*@result, *parse_block_migration(node)]
+        when :if, :until
+          puts "Using unsupported logic within Rails migration: #{node.body.type}"
         else
-          LOGGER.debug(node)
+          puts "[process_migration]: Unable to parse the following node:"
+          # skipcq: RB-RB-LI1008
+          pp node
         end
       end
 
@@ -82,7 +87,13 @@ module Trains
         arguments = node.arguments
         table_name = arguments[0].value.to_s.singularize.camelize
         column_name = arguments[1].value
-        type = arguments[2].value unless node.method_name == :remove_column
+
+        if node.method_name == :add_reference
+          type = :bigint
+          column_name = "#{arguments[1].value}_id".to_sym
+        else
+          type = arguments[2].value unless node.method_name == :remove_column
+        end
 
         DTO::Migration.new(
           table_name,
@@ -95,13 +106,38 @@ module Trains
       def parse_block_migration(node)
         migrations = []
         # Visit every send_node that performs DDL tasks
-        node.each_descendant do |ddl_node|
-          fields = []
+        node.children.each do |ddl_node|
+          next if ddl_node.is_a?(Symbol)
 
-          if ddl_node.block_type?
+          fields = []
+          if ddl_node.is_a?(RuboCop::AST::BlockNode)
             next unless ALLOWED_TABLE_MODIFIERS.include?(ddl_node.method_name)
 
+            if ddl_node.method_name == :safety_assured
+              ddl_node.each_descendant(:send) do |send_node|
+                migrations = [*migrations,
+                              *parse_one_liner_migration(send_node)]
+              end
+
+              next
+            end
+
             table_name = ddl_node.send_node.arguments[0].value.to_s.singularize.camelize
+            case ddl_node.method_name
+            when :create_join_table
+              field_one = ddl_node.send_node.arguments[0].value.to_s
+              field_two = ddl_node.send_node.arguments[1].value.to_s
+
+              table_name = field_one.camelize + field_two.camelize
+
+              fields << DTO::Field.new("#{field_one.singularize}_id".to_sym,
+                                       :bigint)
+              fields << DTO::Field.new("#{field_two.singularize}_id".to_sym,
+                                       :bigint)
+            when :create_table
+              fields << DTO::Field.new(:id, :bigint)
+            end
+
             ddl_node.body.each_descendant(:send) do |send_node|
               fields = [*fields, *parse_migration_field(send_node)]
             end
@@ -112,7 +148,7 @@ module Trains
               fields,
               @migration_version
             )
-          elsif ddl_node.send_type?
+          elsif ddl_node.is_a?(RuboCop::AST::SendNode)
             migrations = [*migrations, *parse_one_liner_migration(ddl_node)]
           end
         end
@@ -122,6 +158,7 @@ module Trains
 
       def parse_migration_field(node)
         fields = []
+        # t.timestamps
         if node.children[1] == :timestamps
           fields << DTO::Field.new(:created_at, :datetime)
           fields << DTO::Field.new(:updated_at, :datetime)
@@ -130,9 +167,27 @@ module Trains
 
         return [] if node.arguments.nil? || node.arguments.empty?
 
-        type = node.children[1]
-        value = node.children[2].value unless node.children[2].hash_type?
-        fields << DTO::Field.new(value, type)
+        # method used to create the column
+        # string is the col_method in t.string
+        col_method = node.children[1]
+        case col_method
+        when :column
+          # t.column col_name, col_type
+          type = node.children[3].value
+          value = node.children[2].value
+          fields << DTO::Field.new(value, type)
+        when :references, :belongs_to
+          # t.references
+          type = :bigint
+          value = "#{node.children[2].value}_id".to_sym
+          fields << DTO::Field.new(value, type)
+        when :index
+        else
+          # t.string, t.integer etc.
+          type = node.children[1]
+          value = parse_args(node.children[2])
+          fields << DTO::Field.new(value, type)
+        end
 
         fields
       end

data/lib/trains/visitor/route.rb

@@ -36,7 +36,6 @@ module Trains
             end
           end
         end
-
       end
 
       private
@@ -48,7 +47,7 @@ module Trains
           when :sym, :str
             node.arguments[0].value
           end
-        options = parse_hash(node.arguments[1])
+        options = parse_args(node.arguments[1]) || {}
         DTO::Route.new(method:, param:, options:)
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trains
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Syed Faraaz Ahmad
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-13 00:00:00.000000000 Z
+date: 2023-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport