train 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '095b1ae4856669cbe224dffbfa09f555ce7c0d05'
-  data.tar.gz: ee6cc55a500e4466e497e853e49963a05b1f85d2
+  metadata.gz: f666a5aa2bb040f3bc662ef2881d2a3778764cc9
+  data.tar.gz: 6e84e3102772ea858d8f4827f959e74f0d7a396f
 SHA512:
-  metadata.gz: ea321b3f07afc791e16628f7d4f26277dc7caed537e29f8351dd8934741af77b8ee137ce35184d820c2aca2e02b335d6fdb538784577f11a06e9c7be1924ef07
-  data.tar.gz: d3a80455ea2819ccdb0ba1e92fdd94c7525604d6dfe49345902531e44eef9c06fd08d39b7911ac9464d44da4f762cd46fe10ab377804327237e4ba7e6405f987
+  metadata.gz: 376156ec17342f41fb82f5a1e8888e1c19b31f8760fd0ceaed4b664f68acf54c759129d3a458c0343c19d0925c70a09f715d1c8f18171d82b506c6ab331267f9
+  data.tar.gz: 5bce1e60af8264a419c68898e8efca072e0f5004313a9aabb1b83a978956618e21d6d3bc9de9ee848a93b482bfe6ec751d713bda18035074814b15294d5502da

data/CHANGELOG.md

@@ -1,7 +1,21 @@
 # Change Log
 
-## [1.3.0](https://github.com/chef/train/tree/1.3.0) (2018-03-29)
-[Full Changelog](https://github.com/chef/train/compare/v1.2.0...1.3.0)
+## [1.4.0](https://github.com/chef/train/tree/1.4.0) (2018-04-12)
+[Full Changelog](https://github.com/chef/train/compare/v1.3.0...1.4.0)
+
+**Closed issues:**
+
+- Train reports directories with the archive bit set as files on the windows platform [\#274](https://github.com/chef/train/issues/274)
+
+**Merged pull requests:**
+
+- Add CloudLinux as a detected platform [\#281](https://github.com/chef/train/pull/281) ([tarcinil](https://github.com/tarcinil))
+- Move Cisco IOS connection under SSH transport [\#279](https://github.com/chef/train/pull/279) ([jerryaldrichiii](https://github.com/jerryaldrichiii))
+- Initialize FileManager using '@service' [\#278](https://github.com/chef/train/pull/278) ([marcparadise](https://github.com/marcparadise))
+- small fix to make sure windows directories with the archive bit set a… [\#275](https://github.com/chef/train/pull/275) ([devoptimist](https://github.com/devoptimist))
+
+## [v1.3.0](https://github.com/chef/train/tree/v1.3.0) (2018-03-29)
+[Full Changelog](https://github.com/chef/train/compare/v1.2.0...v1.3.0)
 
 **Implemented enhancements:**
 
@@ -13,6 +27,7 @@
 
 **Merged pull requests:**
 
+- Release Train 1.3.0 [\#276](https://github.com/chef/train/pull/276) ([jquick](https://github.com/jquick))
 - Add MSI connection option for azure. [\#272](https://github.com/chef/train/pull/272) ([jquick](https://github.com/jquick))
 - Add transport for Cisco IOS [\#271](https://github.com/chef/train/pull/271) ([jerryaldrichiii](https://github.com/jerryaldrichiii))
 - Add platform uuid information. [\#270](https://github.com/chef/train/pull/270) ([jquick](https://github.com/jquick))

data/lib/train/file/remote/windows.rb

@@ -39,7 +39,7 @@ module Train
         end
 
         def type
-          if attributes.include?('Archive')
+          if attributes.include?('Archive') && !attributes.include?('Directory')
             return :file
           elsif attributes.include?('ReparsePoint')
             return :symlink

data/lib/train/platforms/detect/specifications/os.rb

@@ -195,6 +195,18 @@ module Train::Platforms::Detect::Specifications
               true
             end
           }
+      plat.name('cloudlinux').title('CloudLinux').in_family('redhat')
+          .detect {
+            lsb = read_linux_lsb
+            if lsb && lsb[:id] =~ /cloudlinux/i
+              @platform[:release] = lsb[:release]
+              true
+            elsif (raw = unix_file_contents('/etc/redhat-release')) =~ /cloudlinux/i
+              @platform[:name] = redhatish_platform(raw)
+              @platform[:release] = redhatish_version(raw)
+              true
+            end
+          }
       # keep redhat at the end as a fallback for anything with a redhat-release
       plat.name('redhat').title('Red Hat Linux').in_family('redhat')
           .detect {

data/lib/train/transports/cisco_ios_connection.rb

@@ -0,0 +1,119 @@
+# encoding: utf-8
+
+class Train::Transports::SSH
+  class CiscoIOSConnection < BaseConnection
+    class BadEnablePassword < Train::TransportError; end
+
+    def initialize(options)
+      super(options)
+
+      # Extract options to avoid passing them in to `Net::SSH.start` later
+      @host = options.delete(:host)
+      @user = options.delete(:user)
+      @port = options.delete(:port)
+      @enable_password = options.delete(:enable_password)
+
+      # Use all options left that are not `nil` for `Net::SSH.start` later
+      @ssh_options = options.reject { |_key, value| value.nil? }
+
+      @prompt = /^\S+[>#]\r\n.*$/
+    end
+
+    def uri
+      "ssh://#{@user}@#{@host}:#{@port}"
+    end
+
+    private
+
+    def establish_connection
+      logger.debug("[SSH] opening connection to #{self}")
+
+      Net::SSH.start(@host, @user, @ssh_options)
+    end
+
+    def session
+      return @session unless @session.nil?
+
+      @session = open_channel(establish_connection)
+
+      # Escalate privilege to enable mode if password is given
+      if @enable_password
+        run_command_via_connection("enable\r\n#{@enable_password}")
+      end
+
+      # Prevent `--MORE--` by removing terminal length limit
+      run_command_via_connection('terminal length 0')
+
+      @session
+    end
+
+    def run_command_via_connection(cmd)
+      # Ensure buffer is empty before sending data
+      @buf = ''
+
+      logger.debug("[SSH] Running `#{cmd}` on #{self}")
+      session.send_data(cmd + "\r\n")
+
+      logger.debug('[SSH] waiting for prompt')
+      until @buf =~ @prompt
+        raise BadEnablePassword if @buf =~ /Bad secrets/
+        session.connection.process(0)
+      end
+
+      # Save the buffer and clear it for the next command
+      output = @buf.dup
+      @buf = ''
+
+      format_result(format_output(output, cmd))
+    end
+
+    ERROR_MATCHERS = [
+      'Bad IP address',
+      'Incomplete command',
+      'Invalid input detected',
+      'Unrecognized host',
+    ].freeze
+
+    # IOS commands do not have an exit code so we must compare the command
+    # output with partial segments of known errors. Then, we return a
+    # `CommandResult` with arguments in the correct position based on the
+    # result.
+    def format_result(result)
+      if ERROR_MATCHERS.none? { |e| result.include?(e) }
+        CommandResult.new(result, '', 0)
+      else
+        CommandResult.new('', result, 1)
+      end
+    end
+
+    # The buffer (@buf) contains all data sent/received on the SSH channel so
+    # we need to format the data to match what we would expect from Train
+    def format_output(output, cmd)
+      leading_prompt = /(\r\n|^)\S+[>#]/
+      command_string = /#{Regexp.quote(cmd)}\r\n/
+      trailing_prompt = /\S+[>#](\r\n|$)/
+      trailing_line_endings = /(\r\n)+$/
+
+      output
+        .sub(leading_prompt, '')
+        .sub(command_string, '')
+        .gsub(trailing_prompt, '')
+        .gsub(trailing_line_endings, '')
+    end
+
+    # Create an SSH channel that writes to @buf when data is received
+    def open_channel(ssh)
+      logger.debug("[SSH] opening SSH channel to #{self}")
+      ssh.open_channel do |ch|
+        ch.on_data do |_, data|
+          @buf += data
+        end
+
+        ch.send_channel_request('shell') do |_, success|
+          raise 'Failed to open SSH shell' unless success
+          logger.debug('[SSH] shell opened')
+        end
+      end
+    end
+  end
+end

data/lib/train/transports/ssh.rb

@@ -37,6 +37,7 @@ module Train::Transports
     name 'ssh'
 
     require 'train/transports/ssh_connection'
+    require 'train/transports/cisco_ios_connection'
 
     # add options for submodules
     include_options Train::Extras::CommandWrapper
@@ -193,6 +194,19 @@ module Train::Transports
 
       @connection_options = options
       conn = Connection.new(options, &block)
+
+      # Cisco IOS requires a special implementation of `Net:SSH`. This uses the
+      # SSH transport to identify the platform, but then replaces SSHConnection
+      # with a CiscoIOSConnection in order to behave as expected for the user.
+      if defined?(conn.platform.cisco_ios?) && conn.platform.cisco_ios?
+        ios_options = {}
+        ios_options[:host] = @options[:host]
+        ios_options[:user] = @options[:user]
+        ios_options[:enable_password] = @options[:enable_password]
+        ios_options.merge!(@connection_options)
+        conn = CiscoIOSConnection.new(ios_options)
+      end
+
       @connection = conn unless conn.nil?
     end
 

data/lib/train/transports/winrm_connection.rb

@@ -80,7 +80,7 @@ class Train::Transports::WinRM
         retry_limit: @max_wait_until_ready / delay,
         retry_delay: delay,
       )
-      run_command(PING_COMMAND.dup)
+      run_command_via_connection(PING_COMMAND.dup)
     end
 
     def uri
@@ -129,7 +129,11 @@ class Train::Transports::WinRM
     # @return [Winrm::FileManager] a file transporter
     # @api private
     def file_manager
-      @file_manager ||= WinRM::FS::FileManager.new(session)
+      @file_manager ||= begin
+        # Ensure @service is available:
+        wait_until_ready
+        WinRM::FS::FileManager.new(@service)
+      end
     end
 
     # Builds a `LoginCommand` for use by Linux-based platforms.

data/lib/train/version.rb

@@ -3,5 +3,5 @@
 # Author:: Dominik Richter (<dominik.richter@gmail.com>)
 
 module Train
-  VERSION = '1.3.0'.freeze
+  VERSION = '1.4.0'.freeze
 end

data/test/unit/platforms/os_detect_test.rb

@@ -54,6 +54,16 @@ describe 'os_detect' do
         platform[:family].must_equal('redhat')
         platform[:release].must_equal('7.4')
       end
+      it 'sets the correct family, name, and release on CloudLinux' do
+        files = {
+          '/etc/redhat-release' => "CloudLinux release 7.4 (Georgy Grechko)\n",
+          '/etc/os-release' => "NAME=\"CloudLinux\"\nVERSION=\"7.4 (Georgy Grechko)\"\nID=\"cloudlinux\"\nID_LIKE=\"rhel fedora centos\"\nVERSION_ID=\"7.4\"\nPRETTY_NAME=\"CloudLinux 7.4 (Georgy Grechko)\"\nANSI_COLOR=\"0;31\"\nCPE_NAME=\"cpe:/o:cloudlinux:cloudlinux:7.4:GA:server\"\nHOME_URL=\"https://www.cloudlinux.com//\"\nBUG_REPORT_URL=\"https://www.cloudlinux.com/support\"\n",
+        }
+        platform = scan_with_files('linux', files)
+        platform[:name].must_equal('cloudlinux')
+        platform[:family].must_equal('redhat')
+        platform[:release].must_equal('7.4')
+      end
     end
   end
 

data/test/unit/platforms/platform_test.rb

@@ -133,6 +133,15 @@ describe 'platform' do
     it { os.unix?.must_equal(true) }
   end
 
+  describe 'with platform set to cloudlinux' do
+    let(:os) { mock_platform('cloudlinux') }
+    it { os.redhat?.must_equal(true) }
+    it { os.debian?.must_equal(false) }
+    it { os.suse?.must_equal(false) }
+    it { os.linux?.must_equal(true) }
+    it { os.unix?.must_equal(true) }
+  end
+
   describe 'with platform set to fedora' do
     let(:os) { mock_platform('fedora') }
     it { os.fedora?.must_equal(true) }

data/test/unit/transports/cisco_ios_connection.rb

@@ -0,0 +1,81 @@
+# encoding: utf-8
+
+require 'helper'
+require 'train/transports/ssh'
+
+describe 'CiscoIOSConnection' do
+  let(:cls) do
+    Train::Platforms::Detect::Specifications::OS.load
+    plat = Train::Platforms.name('mock').in_family('cisco_ios')
+    plat.add_platform_methods
+    plat.stubs(:cisco_ios?).returns(true)
+    Train::Platforms::Detect.stubs(:scan).returns(plat)
+    Train::Transports::SSH
+  end
+
+  let(:opts) do
+    {
+      host: 'fakehost',
+      user: 'fakeuser',
+      password: 'fakepassword',
+    }
+  end
+
+  let(:connection) do
+    cls.new(opts).connection
+  end
+
+  describe '#initialize' do
+    it 'provides a uri' do
+      connection.uri.must_equal 'ssh://fakeuser@fakehost:22'
+    end
+  end
+
+  describe '#format_result' do
+    it 'returns correctly when result is `good`' do
+      output = 'good'
+      Train::Extras::CommandResult.expects(:new).with(output, '', 0)
+      connection.send(:format_result, 'good')
+    end
+
+    it 'returns correctly when result matches /Bad IP address/' do
+      output = "Translating \"nope\"\r\n\r\nTranslating \"nope\"\r\n\r\n% Bad IP address or host name\r\n% Unknown command or computer name, or unable to find computer address\r\n"
+      Train::Extras::CommandResult.expects(:new).with('', output, 1)
+      connection.send(:format_result, output)
+    end
+
+    it 'returns correctly when result matches /Incomplete command/' do
+      output = "% Incomplete command.\r\n\r\n"
+      Train::Extras::CommandResult.expects(:new).with('', output, 1)
+      connection.send(:format_result, output)
+    end
+
+    it 'returns correctly when result matches /Invalid input detected/' do
+      output = "             ^\r\n% Invalid input detected at '^' marker.\r\n\r\n"
+      Train::Extras::CommandResult.expects(:new).with('', output, 1)
+      connection.send(:format_result, output)
+    end
+
+    it 'returns correctly when result matches /Unrecognized host/' do
+      output = "Translating \"nope\"\r\n% Unrecognized host or address, or protocol not running.\r\n\r\n"
+      Train::Extras::CommandResult.expects(:new).with('', output, 1)
+      connection.send(:format_result, output)
+    end
+  end
+
+  describe '#format_output' do
+    it 'returns the correct output' do
+      cmd = 'show calendar'
+      output = "show calendar\r\n10:35:50 UTC Fri Mar 23 2018\r\n7200_ios_12#\r\n7200_ios_12#"
+      result = connection.send(:format_output, output, cmd)
+      result.must_equal '10:35:50 UTC Fri Mar 23 2018'
+    end
+
+    it 'returns the correct output when a pipe is used' do
+      cmd = 'show running-config | section line con 0'
+      output = "show running-config | section line con 0\r\nline con 0\r\n exec-timeout 0 0\r\n privilege level 15\r\n logging synchronous\r\n stopbits 1\r\n7200_ios_12#\r\n7200_ios_12#"
+      result = connection.send(:format_output, output, cmd)
+      result.must_equal "line con 0\r\n exec-timeout 0 0\r\n privilege level 15\r\n logging synchronous\r\n stopbits 1"
+    end
+  end
+end

data/test/unit/transports/ssh_test.rb

@@ -5,10 +5,10 @@ require 'train/transports/ssh'
 
 describe 'ssh transport' do
   let(:cls) do
-      plat = Train::Platforms.name('mock').in_family('linux')
-      plat.add_platform_methods
-      Train::Platforms::Detect.stubs(:scan).returns(plat)
-      Train::Transports::SSH
+    plat = Train::Platforms.name('mock').in_family('linux')
+    plat.add_platform_methods
+    Train::Platforms::Detect.stubs(:scan).returns(plat)
+    Train::Transports::SSH
   end
   let(:conf) {{
     host: rand.to_s,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: train
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Dominik Richter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-29 00:00:00.000000000 Z
+date: 2018-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -225,7 +225,7 @@ files:
 - lib/train/plugins/transport.rb
 - lib/train/transports/aws.rb
 - lib/train/transports/azure.rb
-- lib/train/transports/cisco_ios.rb
+- lib/train/transports/cisco_ios_connection.rb
 - lib/train/transports/docker.rb
 - lib/train/transports/local.rb
 - lib/train/transports/mock.rb
@@ -292,7 +292,7 @@ files:
 - test/unit/train_test.rb
 - test/unit/transports/aws_test.rb
 - test/unit/transports/azure_test.rb
-- test/unit/transports/cisco_ios.rb
+- test/unit/transports/cisco_ios_connection.rb
 - test/unit/transports/local_test.rb
 - test/unit/transports/mock_test.rb
 - test/unit/transports/ssh_test.rb
@@ -383,7 +383,7 @@ test_files:
 - test/unit/train_test.rb
 - test/unit/transports/aws_test.rb
 - test/unit/transports/azure_test.rb
-- test/unit/transports/cisco_ios.rb
+- test/unit/transports/cisco_ios_connection.rb
 - test/unit/transports/local_test.rb
 - test/unit/transports/mock_test.rb
 - test/unit/transports/ssh_test.rb

data/lib/train/transports/cisco_ios.rb

@@ -1,140 +0,0 @@
-# encoding: utf-8
-
-require 'train/plugins'
-require 'train/transports/ssh'
-
-module Train::Transports
-  class BadEnablePassword < Train::TransportError; end
-
-  class CiscoIOS < SSH
-    name 'cisco_ios'
-
-    option :host, required: true
-    option :user, required: true
-    option :port, default: 22, required: true
-
-    option :password, required: true
-
-    # Used to elevate to enable mode (similar to `sudo su` in Linux)
-    option :enable_password
-
-    def connection
-      @connection ||= Connection.new(validate_options(@options).options)
-    end
-
-    class Connection < BaseConnection
-      def initialize(options)
-        super(options)
-
-        # Delete options to avoid passing them in to `Net::SSH.start` later
-        @host = @options.delete(:host)
-        @user = @options.delete(:user)
-        @port = @options.delete(:port)
-        @enable_password = @options.delete(:enable_password)
-
-        @prompt = /^\S+[>#]\r\n.*$/
-      end
-
-      def uri
-        "ssh://#{@user}@#{@host}:#{@port}"
-      end
-
-      private
-
-      def establish_connection
-        logger.debug("[SSH] opening connection to #{self}")
-
-        Net::SSH.start(
-          @host,
-          @user,
-          @options.reject { |_key, value| value.nil? },
-        )
-      end
-
-      def session
-        return @session unless @session.nil?
-
-        @session = open_channel(establish_connection)
-
-        # Escalate privilege to enable mode if password is given
-        if @enable_password
-          run_command_via_connection("enable\r\n#{@enable_password}")
-        end
-
-        # Prevent `--MORE--` by removing terminal length limit
-        run_command_via_connection('terminal length 0')
-
-        @session
-      end
-
-      def run_command_via_connection(cmd)
-        # Ensure buffer is empty before sending data
-        @buf = ''
-
-        logger.debug("[SSH] Running `#{cmd}` on #{self}")
-        session.send_data(cmd + "\r\n")
-
-        logger.debug('[SSH] waiting for prompt')
-        until @buf =~ @prompt
-          raise BadEnablePassword if @buf =~ /Bad secrets/
-          session.connection.process(0)
-        end
-
-        # Save the buffer and clear it for the next command
-        output = @buf.dup
-        @buf = ''
-
-        format_result(format_output(output, cmd))
-      end
-
-      ERROR_MATCHERS = [
-        'Bad IP address',
-        'Incomplete command',
-        'Invalid input detected',
-        'Unrecognized host',
-      ].freeze
-
-      # IOS commands do not have an exit code so we must compare the command
-      # output with partial segments of known errors. Then, we return a
-      # `CommandResult` with arguments in the correct position based on the
-      # result.
-      def format_result(result)
-        if ERROR_MATCHERS.none? { |e| result.include?(e) }
-          CommandResult.new(result, '', 0)
-        else
-          CommandResult.new('', result, 1)
-        end
-      end
-
-      # The buffer (@buf) contains all data sent/received on the SSH channel so
-      # we need to format the data to match what we would expect from Train
-      def format_output(output, cmd)
-        leading_prompt = /(\r\n|^)\S+[>#]/
-        command_string = /#{cmd}\r\n/
-        trailing_prompt = /\S+[>#](\r\n|$)/
-        trailing_line_endings = /(\r\n)+$/
-
-        output
-          .sub(leading_prompt, '')
-          .sub(command_string, '')
-          .gsub(trailing_prompt, '')
-          .gsub(trailing_line_endings, '')
-      end
-
-      # Create an SSH channel that writes to @buf when data is received
-      def open_channel(ssh)
-        logger.debug("[SSH] opening SSH channel to #{self}")
-        ssh.open_channel do |ch|
-          ch.on_data do |_, data|
-            @buf += data
-          end
-
-          ch.send_channel_request('shell') do |_, success|
-            raise 'Failed to open SSH shell' unless success
-            logger.debug('[SSH] shell opened')
-          end
-        end
-      end
-    end
-  end
-end

data/test/unit/transports/cisco_ios.rb

@@ -1,94 +0,0 @@
-# encoding: utf-8
-
-require 'helper'
-require 'train/transports/cisco_ios'
-
-describe 'Train::Transports::CiscoIOS' do
-  let(:cls) do
-    plat = Train::Platforms.name('mock').in_family('cisco_ios')
-    plat.add_platform_methods
-    Train::Platforms::Detect.stubs(:scan).returns(plat)
-    Train::Transports::CiscoIOS
-  end
-
-  let(:opts) do
-    {
-      host: 'fakehost',
-      user: 'fakeuser',
-      password: 'fakepassword',
-    }
-  end
-
-  let(:cisco_ios) do
-    cls.new(opts)
-  end
-
-  describe 'CiscoIOS::Connection' do
-    let(:connection) { cls.new(opts).connection }
-
-    describe '#initialize' do
-      it 'raises an error when user is missing' do
-        opts.delete(:user)
-        err = proc { cls.new(opts).connection }.must_raise(Train::ClientError)
-        err.message.must_match(/must provide.*user/)
-      end
-
-      it 'raises an error when host is missing' do
-        opts.delete(:host)
-        err = proc { cls.new(opts).connection }.must_raise(Train::ClientError)
-        err.message.must_match(/must provide.*host/)
-      end
-
-      it 'raises an error when password is missing' do
-        opts.delete(:password)
-        err = proc { cls.new(opts).connection }.must_raise(Train::ClientError)
-        err.message.must_match(/must provide.*password/)
-      end
-
-      it 'provides a uri' do
-        connection.uri.must_equal 'ssh://fakeuser@fakehost:22'
-      end
-    end
-
-    describe '#format_result' do
-      it 'returns correctly when result is `good`' do
-        output = 'good'
-        Train::Extras::CommandResult.expects(:new).with(output, '', 0)
-        connection.send(:format_result, 'good')
-      end
-
-      it 'returns correctly when result matches /Bad IP address/' do
-        output = "Translating \"nope\"\r\n\r\nTranslating \"nope\"\r\n\r\n% Bad IP address or host name\r\n% Unknown command or computer name, or unable to find computer address\r\n"
-        Train::Extras::CommandResult.expects(:new).with('', output, 1)
-        connection.send(:format_result, output)
-      end
-
-      it 'returns correctly when result matches /Incomplete command/' do
-        output = "% Incomplete command.\r\n\r\n"
-        Train::Extras::CommandResult.expects(:new).with('', output, 1)
-        connection.send(:format_result, output)
-      end
-
-      it 'returns correctly when result matches /Invalid input detected/' do
-        output = "             ^\r\n% Invalid input detected at '^' marker.\r\n\r\n"
-        Train::Extras::CommandResult.expects(:new).with('', output, 1)
-        connection.send(:format_result, output)
-      end
-
-      it 'returns correctly when result matches /Unrecognized host/' do
-        output = "Translating \"nope\"\r\n% Unrecognized host or address, or protocol not running.\r\n\r\n"
-        Train::Extras::CommandResult.expects(:new).with('', output, 1)
-        connection.send(:format_result, output)
-      end
-    end
-
-    describe '#format_output' do
-      it 'returns output containing only the output of the command executed' do
-        cmd = 'show calendar'
-        output = "show calendar\r\n10:35:50 UTC Fri Mar 23 2018\r\n7200_ios_12#\r\n7200_ios_12#"
-        result = connection.send(:format_output, output, cmd)
-        result.must_equal '10:35:50 UTC Fri Mar 23 2018'
-      end
-    end
-  end
-end