trailguide 0.1.28 → 0.1.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8eecb369ec0dd47b99230b32e78929f9479862de0e2b9c8013dfd45c4e4b93d7
-  data.tar.gz: 9754f8ab2a1eb80b020595949feff5124b109f30f9016910e443eada520dc94f
+  metadata.gz: 0b540b83cf83733890a8bcceaad5036b17c25909e63d55d1f38da77be6549c3a
+  data.tar.gz: 045acd10dfef88c01b955c81ae8808e4bd00a5177411a10c5491461f540ce256
 SHA512:
-  metadata.gz: b4f58b05e4c39e597452ec00da760ce1b4575f7e1dfe56e843ae8de0f67c5520514e28976db14e3109e7aa3969cd201dc86b9d04452160e4511e5791c34cb804
-  data.tar.gz: 49f47539b13be165d39ed577ac4ebe22fd87917d7243ded62d9cba75c61c3de4ce77d06b9552a3150d8094d43d22c22a739d359960921c08dd49df5c0136f946
+  metadata.gz: 9984483fce25ab0a2c3082cdea31235c10e32b5dd5d2f993bfa501f299efdc932e1d2c214898b12e2f675f1b04af2343978ceeb0d62a3f9edf91b4482a4758c5
+  data.tar.gz: a0fb4822dfa753142886e1cbb8dd34fb17173518314562e2f1e2f90ad8ac9927ebe0dc412d94a94ba1b3f85bfa74367eeb5cbc93cfdfb3f27c845b900ae0afd1

data/lib/trail_guide/adapters/participants/anonymous.rb

@@ -1,34 +1,8 @@
 module TrailGuide
   module Adapters
     module Participants
-      class Anonymous
-        include Canfig::Instance
-
-        class << self
-          alias_method :configure, :new
-          def new(_context, &block)
-            configure(&block).new(_context)
-          end
-        end
-
-        def initialize(&block)
-          configure do |config|
-            yield(config) if block_given?
-          end
-        end
-
-        # instance method, creates a new adapter and passes through config
-        def new(_context)
-          Adapter.new(configuration)
-        end
-
-        class Adapter
-          attr_reader :config
-
-          def initialize(config)
-            @config = config
-          end
-
+      class Anonymous < Base
+        class Adapter < Base::Adapter
           def [](key)
             hash[key]
           end

data/lib/trail_guide/adapters/participants/base.rb

@@ -0,0 +1,62 @@
+module TrailGuide
+  module Adapters
+    module Participants
+      class Base
+        include Canfig::Instance
+
+        class << self
+          alias_method :configure, :new
+          def new(context, &block)
+            configure(&block).new(context)
+          end
+        end
+
+        def initialize(&block)
+          configure(&block) if block_given?
+        end
+
+        def new(context)
+          self.class::Adapter.new(context, configuration)
+        end
+
+        class Adapter
+          attr_reader :context, :config
+          alias_method :configuration, :config
+
+          def initialize(context, config)
+            @context = context
+            @config = config
+          end
+
+          def [](key)
+            raise NotImplementedError, "You must override the `[]` method in your inheriting adapter class"
+          end
+
+          def []=(key, value)
+            raise NotImplementedError, "You must override the `[]=` method in your inheriting adapter class"
+          end
+
+          def delete(key)
+            raise NotImplementedError, "You must override the `delete` method in your inheriting adapter class"
+          end
+
+          def destroy!
+            raise NotImplementedError, "You must override the `destroy!` method in your inheriting adapter class"
+          end
+
+          def keys
+            raise NotImplementedError, "You must override the `keys` method in your inheriting adapter class"
+          end
+
+          def key?(key)
+            raise NotImplementedError, "You must override the `key?` method in your inheriting adapter class"
+          end
+
+          def to_h
+            raise NotImplementedError, "You must override the `to_h` method in your inheriting adapter class"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/trail_guide/adapters/participants/cookie.rb

@@ -1,17 +1,7 @@
 module TrailGuide
   module Adapters
     module Participants
-      class Cookie
-        include Canfig::Instance
-
-        # TODO maybe be a little better about checking for action dispatch, etc.?
-
-        class << self
-          alias_method :configure, :new
-          def new(context, &block)
-            configure(&block).new(context)
-          end
-        end
+      class Cookie < Base
 
         def initialize(&block)
           configure do |config|
@@ -24,18 +14,10 @@ module TrailGuide
           end
         end
 
-        # instance method, creates a new adapter and passes through config
-        def new(context)
-          raise UnsupportedContextError, "Your current context (#{context}) does not support cookies" unless context.respond_to?(:cookies, true)
-          Adapter.new(context, configuration)
-        end
-
-        class Adapter
-          attr_reader :context, :config
-
+        class Adapter < Base::Adapter
           def initialize(context, config)
-            @context = context
-            @config = config
+            raise UnsupportedContextError, "Your current context (#{context}) does not support cookies" unless context.respond_to?(:cookies, true)
+            super
           end
 
           def [](key)

data/lib/trail_guide/adapters/participants/multi.rb

@@ -1,15 +1,7 @@
 module TrailGuide
   module Adapters
     module Participants
-      class Multi
-        include Canfig::Instance
-
-        class << self
-          alias_method :configure, :new
-          def new(context, &block)
-            configure(&block).new(context)
-          end
-        end
+      class Multi < Base
 
         def initialize(&block)
           configure do |config|
@@ -29,7 +21,6 @@ module TrailGuide
           end
         end
 
-        # instance method, creates a new adapter and passes through config
         def new(context)
           adapter = configuration.adapter.call(context)
           adapter = configuration.send(adapter) if adapter.is_a?(Symbol)

data/lib/trail_guide/adapters/participants/redis.rb

@@ -1,15 +1,7 @@
 module TrailGuide
   module Adapters
     module Participants
-      class Redis
-        include Canfig::Instance
-
-        class << self
-          alias_method :configure, :new
-          def new(context, **opts, &block)
-            configure(&block).new(context, **opts)
-          end
-        end
+      class Redis < Base
 
         def initialize(&block)
           configure do |config|
@@ -21,16 +13,11 @@ module TrailGuide
           end
         end
 
-        # instance method, creates a new adapter and passes through config
-        def new(context, **opts)
-          Adapter.new(context, configuration, **opts)
-        end
-
-        class Adapter
-          attr_reader :config, :storage_key
+        class Adapter < Base::Adapter
+          attr_reader :storage_key
 
           def initialize(context, config, key: nil)
-            @config = config
+            super(context, config)
 
             if key
               @storage_key = "#{config.namespace}:#{key}"

data/lib/trail_guide/adapters/participants/session.rb

@@ -1,15 +1,7 @@
 module TrailGuide
   module Adapters
     module Participants
-      class Session
-        include Canfig::Instance
-
-        class << self
-          alias_method :configure, :new
-          def new(context, &block)
-            configure(&block).new(context)
-          end
-        end
+      class Session < Base
 
         def initialize(&block)
           configure do |config|
@@ -19,18 +11,11 @@ module TrailGuide
           end
         end
 
-        # instance method, creates a new adapter and passes through config
-        def new(context)
-          raise UnsupportedContextError, "Your current context (#{context}) does not support sessions" unless context.respond_to?(:session, true)
-          Adapter.new(context, configuration)
-        end
-
-        class Adapter
-          attr_reader :context, :config
+        class Adapter < Base::Adapter
 
           def initialize(context, config)
-            @context = context
-            @config = config
+            raise UnsupportedContextError, "Your current context (#{context}) does not support sessions" unless context.respond_to?(:session, true)
+            super
           end
 
           def [](key)

data/lib/trail_guide/adapters/participants.rb

@@ -1,3 +1,4 @@
+require "trail_guide/adapters/participants/base"
 require "trail_guide/adapters/participants/anonymous"
 require "trail_guide/adapters/participants/session"
 require "trail_guide/adapters/participants/cookie"

data/lib/trail_guide/experiments/base.rb

@@ -237,9 +237,7 @@ module TrailGuide
         return control unless allow_participation?(metadata)
 
         variant = algorithm_choose!(metadata: metadata)
-        variant.increment_participation!
-        participant.participating!(variant)
-        run_callbacks(:on_choose, variant, metadata)
+        variant_chosen!(variant, metadata: metadata)
         variant
       end
 
@@ -247,6 +245,12 @@ module TrailGuide
         algorithm.choose!(metadata: metadata)
       end
 
+      def variant_chosen!(variant, metadata: nil)
+        variant.increment_participation!
+        participant.participating!(variant)
+        run_callbacks(:on_choose, variant, metadata)
+      end
+
       def convert!(checkpoint=nil, metadata: nil)
         return false if !running? || (winner? && !track_winner_conversions?)
         return false unless participant.participating?

data/lib/trail_guide/version.rb

@@ -2,7 +2,7 @@ module TrailGuide
   module Version
     MAJOR = 0
     MINOR = 1
-    PATCH = 28
+    PATCH = 29
     VERSION = "#{MAJOR}.#{MINOR}.#{PATCH}"
 
     class << self

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailguide
 version: !ruby/object:Gem::Version
-  version: 0.1.28
+  version: 0.1.29
 platform: ruby
 authors:
 - Mark Rebec
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-28 00:00:00.000000000 Z
+date: 2019-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -138,6 +138,7 @@ files:
 - lib/trail_guide/adapters.rb
 - lib/trail_guide/adapters/participants.rb
 - lib/trail_guide/adapters/participants/anonymous.rb
+- lib/trail_guide/adapters/participants/base.rb
 - lib/trail_guide/adapters/participants/cookie.rb
 - lib/trail_guide/adapters/participants/multi.rb
 - lib/trail_guide/adapters/participants/redis.rb