trailblazer 2.1.0.beta5 → 2.1.0.beta6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 67b2416a21aa39d031596bd5f301f8f84c8dd19978404e1ea2bdfd7a08eeb9fc
-  data.tar.gz: 942f65a213e4a7cf6ca7607f3f1e811ac2b01d86a3cbba5f35107a6ab6d4192c
+  metadata.gz: d9c583449b74afae6004cbba4994c44c509c378756e5cac39d3c0ed0979fc583
+  data.tar.gz: 1730091f6a3ffcc87cd6f2c548899d347db6d3e2a62e9850a07e5d9ed2c91cab
 SHA512:
-  metadata.gz: 47ada0d5e002f653d3ed0e06f8c566d315f62ee4cea8d1c04a0514517a79bbf7838042e4e80111f3378fc54ea9363b43fb9c42d8df9feccbf53d978bed215639
-  data.tar.gz: 521ab294e4a93a2ad6c24ecf931aa53ad6d40e2d5f90b22e18855d07f62583f4ba8bb4ed1c1ea8c2d1f4249274c903916e5a2c6f6897fe83bfa4823ce999aa03
+  metadata.gz: c5eaafc11c6c4e8b14ab62089564e7372304fc4482396301f4f1c2fd6a0228f4d18a3d50d0352974ee81584353128f9de1f2db78883f8cfa80dad2786c28a4d9
+  data.tar.gz: 91a20c9bc960ecb65805a1c4aba086ef5c65f44915f446ba7b0b8a322f2e7d466928444c474426b925011a8f687f81165962fba7a43e15ee3764da3cbca62470

data/CHANGES.md

@@ -30,6 +30,10 @@ document Task API and define step API
 deprecate step->(options) ?
 injectable, per-operation step arguments strategy?
 
+# 2.1.0.beta6
+
+* Use new `activity-0.3.0`.
+
 # 2.1.0.beta5
 
 * All macros are now cleanly extracted to `trailblazer-macro` and `trailblazer-macro-contract`.

data/CONTRIBUTING.md

@@ -125,6 +125,15 @@ git push origin my-feature-branch -f
 #### Check on Your Pull Request
 Go back to your pull request after a few minutes and see whether it passed muster with Travis-CI. Everything should look green, otherwise fix issues and amend your commit as described above.
 
+## Quality
+
+Commiting to OSS projects is always difficult, because all maintainers will adhere to their own quality standards that you don't know. Every projects wants "good code design", and so do we, so here are a few things that you should follow when contributing.
+
+* Good design matters: sometimes a feature could be added with a simple `if <my new case>` to an existing block of code. Usually, an `if` implies that the original design didn't plan on handling multiple cases, or in other words, **a refactoring of the code structure might be necessary**. If you're unsure: [Talk to us!](https://gitter.im/trailblazer/chat)
+* Make smaller pull requests. It is so much easier to discuss something graspable and not a "37 files changed" PR. The sooner we see your code, the earlier we can decide about which way to go. It is incredibly appreciated, though, to send us a link to a branch of yours where we can see the desired changes in total. We can then help splitting those into smaller steps.
+* **Never ever use `if respond_to?`** to add a feature. This is a pattern as seen a lot in Rails core that causes incredibly hard to find ~bugs~ behavior. In Trailblazer, we use "Tell, don't ask!", which means, never try to find out the type of an object via `respond_to?`. If you really have to introspect the type, use `is_a?`. Treat it as a duck, ducks don't speak.
+
+
 ## Releasing
 
 When you have release rights, please follow these rules.

data/Gemfile

@@ -15,15 +15,14 @@ gem "dry-matcher"
 gem "dry-validation"
 
 # gem "trailblazer-operation", path: "../operation"
-gem "trailblazer-macro", github: "trailblazer/trailblazer-macro"
-gem "trailblazer-macro-contract", github: "trailblazer/trailblazer-macro-contract"
-gem "trailblazer-operation", path: "../operation"
 # gem "trailblazer-operation", github: "trailblazer/trailblazer-operation"
+# gem "trailblazer-macro", github: "trailblazer/trailblazer-macro"
+# gem "trailblazer-macro-contract", github: "trailblazer/trailblazer-macro-contract"
 
 gem "minitest-line"
 
 gem "rubocop", require: false
-gem "trailblazer-activity", path: "../trailblazer-circuit"
+# gem "trailblazer-activity", path: "../trailblazer-circuit"
 # gem "trailblazer-activity", github: "trailblazer/trailblazer-activity"
 # gem "trailblazer-activity", path: "../trailblazer-circuit"
 # gem "trailblazer-activity", github: "trailblazer/trailblazer-activity"

data/lib/trailblazer/operation/auto_inject.rb

@@ -29,7 +29,7 @@ class Trailblazer::Operation
 
       def define_call
         class_mod.class_exec(container, dependency_map) do |container, dependency_map|
-          define_method :call do |ctx={}, *dependencies|
+          define_method :call_with_public_interface do |ctx={}, *dependencies|
             ctx_with_deps = dependency_map.to_h.each_with_object({}) { |(name, identifier), obj|
               obj[name] = ctx[name] || container[identifier]
             }.merge(ctx)

data/lib/trailblazer/version.rb

@@ -1,3 +1,3 @@
 module Trailblazer
-  VERSION = "2.1.0.beta5"
+  VERSION = "2.1.0.beta6"
 end

data/test/docs/trace_test.rb

@@ -38,10 +38,11 @@ class DocsTraceTest < Minitest::Spec
     # `-- End.success
     #:trace end
 
-    result.wtf.gsub(/0x\w+/, "").must_equal %{|-- #<Trailblazer::Activity::Start semantic=:default>
-|-- model.build
-|-- contract.build
-`-- #<Trailblazer::Operation::Railway::End::Success semantic=:success>}
+    result.wtf.gsub(/0x\w+/, "").must_equal %{`-- DocsTraceTest::Create::Present
+    |-- Start.default
+    |-- model.build
+    |-- contract.build
+    `-- End.success}
   end
 
   it do

data/test/test_helper.rb

@@ -1,4 +1,5 @@
 require "pp"
+require "delegate"
 require "trailblazer"
 require "minitest/autorun"
 

data/test/variables_test.rb

@@ -141,18 +141,19 @@ the scoping.
   it "with tracing" do
     result = DiscreetOrganization.trace("public_opinion" => "Freedom!")
 
-    result.wtf.gsub(/0x\w+/, "").gsub(/\d+/, "").must_equal %{|-- #<Trailblazer::Activity::Start semantic=:default>
-|-- set.rumours
-|-- set.secret
-|-- Nested(VariablesTest::Whistleblower)
-|   |-- #<Trailblazer::Activity::Start semantic=:default>
-|   |-- edward.public_opinion
-|   |-- edward.secret
-|   |-- edward.test
-|   |-- edward.read.public_knowledge
-|   `-- #<Trailblazer::Operation::Railway::End::Success semantic=:success>
-|-- read.edward.rumours
-|-- read.edward.secret
-`-- #<Trailblazer::Operation::Railway::End::Failure semantic=:failure>}
+    result.wtf.gsub(/0x\w+/, "").gsub(/\d+/, "").must_equal %{`-- VariablesTest::DiscreetOrganization
+    |-- Start.default
+    |-- set.rumours
+    |-- set.secret
+    |-- Nested(VariablesTest::Whistleblower)
+    |   |-- Start.default
+    |   |-- edward.public_opinion
+    |   |-- edward.secret
+    |   |-- edward.test
+    |   |-- edward.read.public_knowledge
+    |   `-- End.success
+    |-- read.edward.rumours
+    |-- read.edward.secret
+    `-- End.failure}
   end
 end

data/trailblazer.gemspec

@@ -17,9 +17,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "trailblazer-operation", ">= 0.2.4", "< 0.3.0"
-  spec.add_dependency "trailblazer-macro", ">= 2.1.0.beta2", "< 2.2.0"
-  spec.add_dependency "trailblazer-macro-contract", ">= 2.1.0.beta2", "< 2.2.0"
+  spec.add_dependency "trailblazer-operation", ">= 0.3.0", "< 0.4.0"
+  spec.add_dependency "trailblazer-macro", ">= 2.1.0.beta6", "< 2.2.0"
+  spec.add_dependency "trailblazer-macro-contract", ">= 2.1.0.beta4", "< 2.2.0"
 
   spec.add_dependency "declarative"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer
 version: !ruby/object:Gem::Version
-  version: 2.1.0.beta5
+  version: 2.1.0.beta6
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-09 00:00:00.000000000 Z
+date: 2018-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trailblazer-operation
@@ -16,27 +16,27 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.2.4
+        version: 0.3.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.2.4
+        version: 0.3.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.4.0
 - !ruby/object:Gem::Dependency
   name: trailblazer-macro
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.1.0.beta2
+        version: 2.1.0.beta6
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.2.0
@@ -46,7 +46,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.1.0.beta2
+        version: 2.1.0.beta6
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.2.0
@@ -56,7 +56,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.1.0.beta2
+        version: 2.1.0.beta4
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.2.0
@@ -66,7 +66,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.1.0.beta2
+        version: 2.1.0.beta4
     - - "<"
       - !ruby/object:Gem::Version
         version: 2.2.0