trailblazer 2.0.0.rc1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cb0eb777dc5afb25cb6200169ca06bf75a18db94
-  data.tar.gz: 8ca6d1c9b0a5491ea9fa282cf5766552fcf8462a
+  metadata.gz: 9113e6cd01913594963d2bdd2007df2d82b1a162
+  data.tar.gz: 6f9970934e06c98054d76635cfb0dd9353f03bb3
 SHA512:
-  metadata.gz: 939adb355c6875cf922f6dda5056ee2d13664c386149c3afd7d62c5f0a0b77b51d1c487e62ac4ea1c5af39aa481e9d1b7bef891bca55a0dc6af92fb5d764786a
-  data.tar.gz: 5e1f1f2de36e85c4f6a0c84e655c329e22073027130c079e6f3b776de84c1046867056a8fb40aa915919ac83a6ec74300428d45c24a1b65eb06031c8d20d3296
+  metadata.gz: 5252542b46421e3972eda278e6184ee4dffb478db5682918706474d9e4dff31c6ba93c23c3ca3ab34334a05df1ef7e1c30ccf04a1cec16f8935a62f9066f259c
+  data.tar.gz: 03b85c2c94497c52f4017160fdedd11c670cbd22c2adc03af4fd920d266b5ddde1459aa3e03e3dabb0555b87b41c39c555add65796996d697486556de10bf713

data/CHANGES.md

@@ -1,54 +1,10 @@
-
 # 2.0.0
 
-## Operation API change:
-
-* You can now have any number of contracts, `contract [:name], constant/block`.
-
-`Contract`, Setup, Model
-expose via `result[:_invocations] = _invocations`
-
-* Changed `Operation#validate`: the signature now is `validate(params, model=self.model, options={}, contract_class)`.
-* Changed `Operation#contract`: the signature now is `contract(model=self.model, options={}, contract_class)`.
-
-Both changes simplify injecting additional dependencies into the contract, or making use of `Composition` contracts. Read more [here](http://trailblazer.to/gems/operation/contract.html). Note that in 1.2, there are deprecation mechanics to handle old code.
-
-* Added `Trailblazer::Builder` for a builder-and-call mechanism decoupled from the operation.
-* Finally removed `Operation::[]`. Be careful, this is now replaced and will return the specified competence.
-
-TRB 1.1
-  build_operation(params).run
-    process(@params)
-TRB 1.2
-  build_operation(params, *).call(params)
-
-* Removed `Operation::reject`. This is available in `trailblazer-compat`.
-* `Operation#invalid!` is now an optional module `Trailblazer::Operation::Invalid`.
-* `Operation::present` is now optional. Include `Present`.
-
-# CHANGES:
-# * Removed `Operation::[]` in favor of `Operation::()`.
-# * `Operation#invalid!` doesn't accept a result anymore.
-# * Removed `Operation#valid?` in favor of the result object.
-#
-
-## Model
-
-* The `model` method doesn't exist anymore, use `self["model"]` or write your own.
-* `find_by` diverts to left track.
-* `:create` is `:new` now.
-
-## DI
-
-You can now inject the following objects via `::call`:
-
-* `"contract.default.class"`
-* `"contract"`: The contract instance.
-* `"model.class"`
+All old semantics will be available via [trailblazer-compat](https://github.com/trailblazer/trailblazer-compat).
 
 * Removed `Operation::run` as it was a bad decision. Raising an exception on invalid is a very test-specific scenario and shouldn't have been handled in the core doce.
 * Removed `Operation::present`, since you can simply call `Operation::new` (without builders) or `Operation::build_operation` (with builders).
-* Removed `Operation::valid?`. This is in the result object via `result[:valid]`.
+* Removed `Operation::valid?`. This is in the result object via `result.success?`.
 * Removed `Operation#errors`. This is in the result object via `result[:errors]` if the operation was invalid.
 * Removed the private option `:raise_on_invalid`. Use `Contract::Raise` instead, if you need it in tests.
 
@@ -57,6 +13,12 @@ You can now inject the following objects via `::call`:
 * Removed `Operation::contract_class`. Please use `Operation::["contract.default.class"]`.
 * Removed `Operation::contract_class=`. Please use `Operation::["contract.default.class"]=`. Doesn't inherit.
 
+## Model
+
+* The `model` method doesn't exist anymore, use `self["model"]` or write your own.
+* `:find_by` diverts to left track.
+* `:create` is `:new` now.
+
 ## Builder
 
 * It's `include Builder` now, not `extend Builder`.
@@ -66,7 +28,7 @@ You can now inject the following objects via `::call`:
 
 * No exception anymore, but `Operation#["policy.result"]`.
 * Access the current user via `self["current_user"]` now.
-* `Policy` is `Policy::Pundit` now as `Policy` is Trailblazer's authorization style.
+* `Policy` is `Policy::Pundit` now as `Policy` is Trailblazer's (upcoming) authorization style.
 
 ## Representer
 
@@ -82,13 +44,6 @@ You can now inject the following objects via `::call`:
 
 * Removed `Operation::Dispatch`, it's called `Operation::Callback`.
 
-## #call
-* You can return whatever you want now by overriding `Op::call`.
-* Removed `Op.call().contract`, you now have to do `Op.call()[:operation].contract`.
-
-
-* Removed the deprecation for `validate`, signature is `(params[, model, options, contract_class])`.
-* Removed the deprecation for `contract`, signature is `([model, options, contract_class])`.
 
 ## Collection
 
@@ -96,16 +51,22 @@ You can now inject the following objects via `::call`:
 
 ## Controller
 
-* Removed `Controller#params!`, no one was using it.
+* Removed `Controller`, this is now in [trailblazer-rails](https://github.com/trailblazer/trailblazer-rails/).
 
 ## Contract
 
-* You can't call `Create.().contract` anymore. The contract instance(s) are available through the `Result` object.
+* You can't call `Create.().contract` anymore. The contract instance(s) are available through the `Result` object via `["contract.default"]`.
+* Removed the deprecation for `validate`, signature is `(params[, model, options, contract_class])`.
+* Removed the deprecation for `contract`, signature is `([model, options, contract_class])`.
 
 # 2.0.0.rc1
 
 * `consider` got removed since `step` now evaluates the step's result and deviates (or not).
 
+# 2.0.0.rc2
+
+* It's now Contract::Persist( name: "params" ) instead of ( name: "contract.params" ).
+
 # 2.0.0.beta3
 
 * New, very slick keyword arguments for steps.

data/lib/trailblazer/operation/contract.rb

@@ -13,11 +13,11 @@ class Trailblazer::Operation
       def self.build_contract!(operation, options, name:"default", constant:nil, builder: nil)
         # TODO: we could probably clean this up a bit at some point.
         contract_class = constant || options["contract.#{name}.class"]
-        model          = operation["model"] # FIXME: model.default
+        model          = options["model"] # FIXME: model.default
 
-        return operation["contract.#{name}"] = Uber::Option[builder].(operation, constant: contract_class, model: model) if builder
+        return options["contract.#{name}"] = Uber::Option[builder].(operation, constant: contract_class, model: model) if builder
 
-        operation["contract.#{name}"] = contract_class.new(model)
+        options["contract.#{name}"] = contract_class.new(model)
       end
 
       def self.import!(operation, import, **args)

data/lib/trailblazer/operation/persist.rb

@@ -1,11 +1,10 @@
 class Trailblazer::Operation
   module Contract
     module Persist
-      def self.import!(operation, import, options={})
-        save_method   = options[:method] || :save
-        contract_name = options[:name] || "contract.default"
+      def self.import!(operation, import, method: :save, name: "default")
+        path = "contract.#{name}"
 
-        import.(:&, ->(input, options) { options[contract_name].send(save_method) }, # TODO: test me.
+        import.(:&, ->(input, options) { options[path].send(method) }, # TODO: test me.
           name: "persist.save")
       end
     end

data/lib/trailblazer/operation/validate.rb

@@ -32,10 +32,10 @@ class Trailblazer::Operation
 
       def self.validate!(operation, options, name: nil, representer:false, from: "document", params_path:nil, **)
         path     = "contract.#{name}"
-        contract = operation[path]
+        contract = options[path]
 
         # this is for 1.1-style compatibility and should be removed once we have Deserializer in place:
-        operation["result.#{path}"] = result =
+        options["result.#{path}"] = result =
           if representer
             # use "document" as the body and let the representer deserialize to the contract.
             # this will be simplified once we have Deserializer.

data/lib/trailblazer/version.rb

@@ -1,3 +1,3 @@
 module Trailblazer
-  VERSION = "2.0.0.rc1"
+  VERSION = "2.0.0"
 end

data/test/docs/contract_test.rb

@@ -217,7 +217,7 @@ class ContractNamedConstantTest < Minitest::Spec
     step Model( Song, :new )
     step Contract::Build( constant: MyContract, name: "form" )
     step Contract::Validate( name: "form" )
-    step Contract::Persist( method: :sync, name: "contract.form" )
+    step Contract::Persist( method: :sync, name: "form" )
   end
   #:constant-name end
 
@@ -285,7 +285,7 @@ class DryValidationContractTest < Minitest::Spec
     step Model( Song, :new )                             # create the op's main model.
     step Contract::Build( name: "form" )                 # create the Reform contract.
     step Contract::Validate( name: "form" )              # validate the Reform contract.
-    step Contract::Persist( method: :sync, name: "contract.form" ) # persist the contract's data via the model.
+    step Contract::Persist( method: :sync, name: "form" ) # persist the contract's data via the model.
     #~form end
   end
   #:dry-schema end

data/test/operation/dsl/contract_test.rb

@@ -17,7 +17,7 @@ class DslContractTest < MiniTest::Spec
       includer.| Trailblazer::Operation::Model( OpenStruct, :new )
       includer.| Trailblazer::Operation::Contract::Build()
       includer.| Trailblazer::Operation::Contract::Validate()
-      includer.| Trailblazer::Operation::Contract::Persist( save_method: :sync )
+      includer.| Trailblazer::Operation::Contract::Persist( method: :sync )
       # includer.> ->(op, *) { op["x"] = [] }
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer
 version: !ruby/object:Gem::Version
-  version: 2.0.0.rc1
+  version: 2.0.0
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-13 00:00:00.000000000 Z
+date: 2016-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trailblazer-operation
@@ -179,10 +179,8 @@ files:
 - README.md
 - Rakefile
 - THOUGHTS
-- TODO.md
 - doc/Trb-The-Stack.png
 - doc/trb.jpg
-- draft-1.2.rb
 - lib/trailblazer.rb
 - lib/trailblazer/dsl.rb
 - lib/trailblazer/operation/auto_inject.rb
@@ -193,7 +191,6 @@ files:
 - lib/trailblazer/operation/model.rb
 - lib/trailblazer/operation/module.rb
 - lib/trailblazer/operation/nested.rb
-- lib/trailblazer/operation/params.rb
 - lib/trailblazer/operation/persist.rb
 - lib/trailblazer/operation/policy.rb
 - lib/trailblazer/operation/procedural/contract.rb
@@ -255,12 +252,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.3
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: A high-level architecture for Ruby and Rails.

data/TODO.md

@@ -1,11 +0,0 @@
-# Operation: External API
-
-* allow `Op[{body: "Great!"}, {additional: true}]` to save merge.
-* make `Op[]` not require wrap like `comment: {}`
-* in tests, make Op[].model return the reloaded model!
-
-# Operation: Internal API
-
-* don't populate the form in #present context, we don't need it (only the representer goes nuts)
-* don't pass contract in validate, we have #contract.
-* abstract validate/success/fail into methods to make it easily overrideable.

data/draft-1.2.rb

@@ -1,7 +0,0 @@
-representer :deserializer, Representer::Create (do)
-  or
-Op.(representer.deserializer.class: Representer::Create)
-
-
-representer!(name)
-  @options[representer.deserializer.class] || self.class[representer.deserializer.class]

data/lib/trailblazer/operation/params.rb

@@ -1,13 +0,0 @@
-class Trailblazer::Operation
-  module Params
-    def self.included(includer)
-      includer.> Replace, after: New
-    end
-  end
-
-  # Returned object will replace "params". Original is saved in "params.original".
-  Params::Replace = ->(input, options) {
-    options["params.original"] = original = options["params"]
-     options["params"] = input.params!(original)
-   }
-end