trailblazer-rails 2.1.6 → 2.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9e1891b66e4c2f50c71a3c65cec7b4dff7f4040
-  data.tar.gz: 23787f269aa73d368c78a238f866f38289bfb061
+  metadata.gz: 18afeb5b07e00792db1d1486feda5119161b8539
+  data.tar.gz: 9e143a9876e82b0d00d3bcd0755ac352f2348a95
 SHA512:
-  metadata.gz: 34fb697f432010c8a1e5d44b6e15bec35778637d72e888b7add5ce3bf11dc3373863324db0ca1f9a32bb383e5cf02c3707bebeae3a458c474eca6b4046d8dfbe
-  data.tar.gz: a864ca3525562e60080f472b08395949a88fd6fb571ef1a8705dfc417cf0458c1a3cdb494c37a34df887b9a3363f6a51c1300392c4eb1e3c017723178a54152c
+  metadata.gz: 14970570ae213e72a73545ad334ac86b523e0ebeae96801956adf2b01b22127d792c4c752b85fdd8c1fc26fdd0fe7dca629d1207b318a66569c1f94d17edbad6
+  data.tar.gz: 1f0f691322bfd2920435181514fd2c664eeb5f84ba1acc2958ffb84ce7f8517a669661f681f0e7785838ae467b901c0d5c7e7f566fa246c99c9fc16490998936

data/.rubocop-https---raw-githubusercontent-com-trailblazer-meta-master-rubocop-yml

@@ -1,4 +1,5 @@
 AllCops:
+  TargetRubyVersion: 2.5.0
   DisplayCopNames: true
 Layout/CaseIndentation:
   IndentOneStep: true
@@ -99,3 +100,16 @@ Metrics/AbcSize:
   Max: 25
 Style/LambdaCall:
   Enabled: false
+Style/Semicolon:
+  Enabled: false
+Naming/UncommunicativeMethodParamName:
+  Enabled: false
+Style/ClassAndModuleChildren:
+  Enabled: false
+Layout/LeadingCommentSpace:
+  Exclude:
+    - 'test/docs/**/*'
+Layout/AlignHash:
+  EnforcedHashRocketStyle: table
+Style/FrozenStringLiteralComment:
+  Enabled: false

data/.rubocop.yml

@@ -1,29 +1,12 @@
 inherit_from:
   - https://raw.githubusercontent.com/trailblazer/meta/master/rubocop.yml
 
-Style/ClassCheck:
-  Exclude:
-    - 'lib/trailblazer/rails/cell.rb'
-
-Metrics/AbcSize:
-  Exclude:
-    - 'lib/trailblazer/rails/controller.rb'
-
 Bundler/DuplicatedGem:
   Enabled: false
 
 Style/Send:
   Enabled: false
 
-Style/StringLiterals:
-  Enabled: false
-
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-Style/ClassAndModuleChildren:
-  Enabled: false
-
 # required when rubocop is run via travis
 AllCops:
   Exclude:

data/.travis.yml

@@ -15,8 +15,8 @@ matrix:
     gemfile: test/rails5.1/Gemfile
 
   - rvm: 2.5.1
-    env: TEST_SUITE=rails5.2
     gemfile: test/rails5.2/Gemfile
+    script: cd test/rails5.2 && bundle install && bundle exec rake test && cd ../.. && bundle install && bundle exec rake rubocop
 
-script: cd test/$TEST_SUITE && bundle install && bundle exec rake test && cd ../.. && bundle install && bundle exec rake rubocop
+script: cd test/$TEST_SUITE && bundle install && bundle exec rake test
 

data/CHANGES.md

@@ -1,3 +1,8 @@
+# 2.1.7
+
+* Bug: Deprecation warning for use_loader always called (fixed)
+* Run rubocop in travis only for ruby 2.5
+
 # 2.1.6
 
 * Dependency for `railties` >= 4.0.0

data/Gemfile

@@ -1,25 +1,25 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in trailblazer-rails.gemspec
 gemspec
 
-case ENV['GEMS_SOURCE']
-  when 'local'
+case ENV["GEMS_SOURCE"]
+  when "local"
     gem "cells-erb", path: "../cells-erb"
     gem "cells-rails", path: "../cells-rails"
     gem "reform-rails", path: "../reform-rails"
     gem "trailblazer", path: "../trailblazer"
     gem "trailblazer-cells", path: "../trailblazer-cells"
     gem "trailblazer-loader", path: "../trailblazer-loader"
-  when 'github'
+  when "github"
     gem "cells-erb", github: "trailblazer/cells-erb"
     gem "cells-rails", github: "trailblazer/cells-rails"
     gem "reform-rails", github: "trailblazer/reform-rails"
     gem "trailblazer", github: "trailblazer/trailblazer"
     gem "trailblazer-cells", github: "trailblazer/trailblazer-cells"
     gem "trailblazer-loader", github: "trailblazer/trailblazer-loader"
-  when 'custom'
-    eval_gemfile('GemfileCustom')
+  when "custom"
+    eval_gemfile("GemfileCustom")
   else # use rubygems releases
     gem "cells-erb"
     gem "cells-rails"

data/Rakefile

@@ -5,12 +5,12 @@ require "rubocop/rake_task"
 Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
-  t.test_files = FileList['test/**/*_test.rb']
+  t.test_files = FileList["test/**/*_test.rb"]
 end
 
 RuboCop::RakeTask.new(:rubocop)
 
-desc 'Remove temporary files'
+desc "Remove temporary files"
 task :clean do
   `rm -rf *.gem doc pkg coverage test-reports`
   %x(rm -f `find . -name '*.rbc'`)
@@ -21,5 +21,5 @@ task :gem do
   `gem build trailblazer-rails.gemspec`
 end
 
-desc 'Running Tests'
+desc "Running Tests"
 task default: %i[clean test]

data/lib/trailblazer/rails/cell.rb

@@ -3,7 +3,7 @@ module Trailblazer::Rails::Controller::Cell
 
   module Render
     def render(cell = nil, options = {}, *, &block)
-      return super unless cell.kind_of?(::Cell::ViewModel)
+      return super unless cell.kind_of?(::Cell::ViewModel) # rubocop:disable Style/ClassCheck
 
       render_cell(cell, options)
     end

data/lib/trailblazer/rails/railtie.rb

@@ -7,9 +7,8 @@ module Trailblazer
   class Railtie < ::Rails::Railtie
     config.trailblazer = ActiveSupport::OrderedOptions.new
     ## Accept also an Array of controllers
-    config.trailblazer.application_controller ||= 'ActionController::Base'
+    config.trailblazer.application_controller ||= "ActionController::Base"
     config.trailblazer.enable_loader ||= true
-    config.trailblazer.use_loader ||= true # TODO: remove with next release
     config.trailblazer.enable_tracing ||= false
 
     include Loader
@@ -21,7 +20,7 @@ module Trailblazer
       # Rails 5.0.0.rc1 says:
       # DEPRECATION WARNING: to_prepare is deprecated and will be removed from Rails 5.1
       # (use ActiveSupport::Reloader.to_prepare instead)
-      if Gem.loaded_specs['activesupport'].version >= Gem::Version.new('5')
+      if Gem.loaded_specs["activesupport"].version >= Gem::Version.new("5")
         ActiveSupport::Reloader
       else
         ActionDispatch::Reloader

data/lib/trailblazer/rails/railtie/loader.rb

@@ -40,10 +40,10 @@ module Trailblazer
           # the trb autoloading has to be run after initializers have been loaded, so we can tweak inclusion of features in
           # initializers.
 
-          # TODO: remove me in the next version!
+          # TODO: remove me in v2.2.0
           if config.trailblazer.use_loader.to_s.present?
             warn "DEPRECATION WARNING [trailblazer-rails]: please use config.trailblazer.enable_loader" \
-                 " to enable/disable the loader. config.trailblazer.use_loader will be removed from version > 2.1.6"
+                 " to enable/disable the loader, config.trailblazer.use_loader will be removed from version 2.2.0"
           end
 
           if config.trailblazer.enable_loader || config.trailblazer.use_loader

data/lib/trailblazer/rails/version.rb

@@ -1,5 +1,5 @@
 module Trailblazer
   module Rails
-    VERSION = "2.1.6".freeze
+    VERSION = "2.1.7".freeze
   end
 end

data/trailblazer-rails.gemspec

@@ -1,6 +1,6 @@
-lib = File.expand_path('lib', __dir__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'trailblazer/rails/version'
+require "trailblazer/rails/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "trailblazer-rails"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-rails
 version: !ruby/object:Gem::Version
-  version: 2.1.6
+  version: 2.1.7
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-04 00:00:00.000000000 Z
+date: 2018-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties