trailblazer-operation 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7d1a238c8c4bb3a49a8adad7d2ffc709f1f4766d
-  data.tar.gz: d3495a92e3fc1519b7e847ccd8f1ad2ff84d41a7
+  metadata.gz: 2f371c58b3c8fcd88c0c12a5e764be7a807c83c2
+  data.tar.gz: 67e41d4d0b7e0480a5948b45a2b53b4f56170ba9
 SHA512:
-  metadata.gz: 2f922d3d9a2ebbe3abdc6eb919cf6c99dbd66ffa990f041ba9a1aea6de1a2c56c5f1c436388978c434017213d6eb370059a03846613a3704a1617615d2168435
-  data.tar.gz: 60eabb5de8f611edc69a9c81003dc78a29c4734ba316e4cdcc6497ba7075ff4c7d1a732dca8660af1c9a327e582bb4c27ccc494820f5495c1b2b93a5fe8022a8
+  metadata.gz: '00591cd8d45d48b909d03042e486ac14496c0156455ec89222e7a68b059e12c4398b38e6a6265e4e971f4735d9cd2e4f675d2a73749a2baf3fca9bc42680841d'
+  data.tar.gz: f4aefde8d80cd7f822fbccf3ef9e513650db0f5caafc21cda3041e9fe6a9d220ea43eae000390933cf2d9546e04e5fc7d90dd41f5e72ae6d664c67701fb938ab

data/CHANGES.md

@@ -14,6 +14,10 @@ lots of work on the DSL specific parts.
 
 params:, rest: ..
 
+## 0.1.3
+
+* New taskWrap API for `activity` 0.3.2.
+
 ## 0.1.2
 
 * Add @mensfeld's "Macaroni" step style for a keyword-only signature for steps.

data/Gemfile

@@ -20,5 +20,5 @@ gem "trailblazer-developer", git: "https://github.com/trailblazer/trailblazer-de
 
 # gem "declarative", path: "../declarative"
 
-# gem "trailblazer-activity", path: "../circuit"
+gem "trailblazer-activity", path: "../trailblazer-circuit"
 # gem "trailblazer-activity", git: "https://github.com/trailblazer/trailblazer-activity"

data/lib/trailblazer/operation/railway/macaroni.rb

@@ -17,5 +17,7 @@ module Trailblazer
         end
       end
     end
+
+    KwSignature = Macaroni
   end
 end

data/lib/trailblazer/operation/variable_mapping.rb

@@ -45,11 +45,11 @@ class Trailblazer::Activity
         @strategy = strategy
       end
 
-      # Runs the user filter and replaces the ctx in `wrap_ctx[:result_args]` with the filtered one.
+      # Runs the user filter and replaces the ctx in `wrap_ctx[:return_args]` with the filtered one.
       def call( (wrap_ctx, original_args), **circuit_options )
         (original_ctx, original_flow_options), original_circuit_options = original_args
 
-        returned_ctx, _ = wrap_ctx[:result_args] # this is the Context returned from `call`ing the task.
+        returned_ctx, _ = wrap_ctx[:return_args] # this is the Context returned from `call`ing the task.
 
         # returned_ctx is the Context object from the nested operation. In <=2.1, this might be a completely different one
         # than "ours" we created in Input. We now need to compile a list of all added values. This is time-intensive and should
@@ -63,7 +63,7 @@ class Trailblazer::Activity
 
         new_ctx = @strategy.( original_ctx, output ) # here, we compute the "new" options {Context}.
 
-        wrap_ctx = wrap_ctx.merge( result_args: [new_ctx, original_flow_options] )
+        wrap_ctx = wrap_ctx.merge( return_args: [new_ctx, original_flow_options] )
 
         # and then pass on the "new" context.
         return Trailblazer::Activity::Right, [ wrap_ctx, original_args ]

data/lib/trailblazer/operation/version.rb

@@ -1,5 +1,5 @@
 module Trailblazer
   class Operation
-    VERSION = "0.1.2"
+    VERSION = "0.1.3"
   end
 end

data/lib/trailblazer/operation.rb

@@ -23,6 +23,8 @@ require "trailblazer/operation/railway/normalizer"
 require "trailblazer/operation/task_wrap"
 require "trailblazer/operation/trace"
 
+require "trailblazer/operation/railway/macaroni"
+
 module Trailblazer
   # The Trailblazer-style operation.
   # Note that you don't have to use our "opinionated" version with result object, skills, etc.

data/test/docs/macaroni_test.rb

@@ -1,26 +1,33 @@
 require "test_helper"
 
-require "trailblazer/operation/railway/macaroni"
-
 class MacaroniTaskBuilderTest < Minitest::Spec
-  module Memo; end
+  Memo = Struct.new(:title) do
+    def save
+      self.title = title[:title].reverse
+    end
+  end
 
+  #:create
   class Memo::Create < Trailblazer::Operation
-    Normalizer = Railway::Normalizer.new( task_builder: Railway::Macaroni )
+    #~ign
+    Normalizer = Railway::Normalizer.new( task_builder: Railway::KwSignature )
 
     step :create_model, normalizer: Normalizer
     step :save,         normalizer: Normalizer
-
-    def create_model(params:, options:, **)
-      options[:model] = params[:title]
+    #~ign end
+    #~methods
+    def create_model( params:, options:, ** )
+      options[:model] = Memo.new( title: params[:title] )
     end
 
-    def save(model:, **)
-      model.reverse!
+    def save( model:, ** )
+      model.save
     end
+    #~methods end
   end
+  #:create end
 
   it "allows optional macaroni call style" do
-    Memo::Create.( params: { title: "Wow!" } ).inspect(:model).must_equal %{<Result:true ["!woW"] >}
+    Memo::Create.( params: { title: "Wow!" } ).inspect(:model).must_equal %{<Result:true [#<struct MacaroniTaskBuilderTest::Memo title=\"!woW\">] >}
   end
 end

data/test/docs/wiring_test.rb

@@ -419,3 +419,55 @@ class WiringsDocRecoverTest < Minitest::Spec
     [ result.success?, result[:s3], result[:azure], result[:b2], result[:problem] ].must_equal [ false, false, false, false, "All uploads failed." ]
   end
 end
+
+class WiringsDocCustomConnectionTest < Minitest::Spec
+  Memo = Class.new(WiringDocsTest::Memo)
+
+  #:target-id
+  class Memo::Upload < Trailblazer::Operation
+    step :new?, Output(:failure) => "index"
+    step :upload
+    step :validate
+    fail :validation_error
+    step :index, id: "index"
+    #~target-id-methods
+    def new?(options, is_new:, **)
+      options[:new?] = is_new
+    end
+
+    def upload(options, **)
+      options[:upload] = true
+    end
+
+    def validate(options, validate:true, **)
+      options[:validate] = validate
+    end
+
+    def validation_error(options, **)
+      options[:validation_error] = true
+    end
+
+    def index(options, **)
+      options[:index] = true
+    end
+    #~target-id-methods end
+  end
+  #:target-id end
+
+  let(:my_image) { "beautiful landscape" }
+
+  it "works with new image" do
+    result = Memo::Upload.( image: my_image, is_new: true )
+    result.inspect(:new?, :upload, :validate, :validation_error, :index).must_equal %{<Result:true [true, true, true, nil, true] >}
+  end
+
+  it "skips everything but index for existing image" do
+    result = Memo::Upload.( image: my_image, is_new: false )
+    result.inspect(:new?, :upload, :validate, :validation_error, :index).must_equal %{<Result:true [false, nil, nil, nil, true] >}
+  end
+
+  it "fails in validation" do
+    result = Memo::Upload.( image: my_image, is_new: true, validate: false )
+    result.inspect(:new?, :upload, :validate, :validation_error, :index).must_equal %{<Result:false [true, true, false, true, nil] >}
+  end
+end

data/trailblazer-operation.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "trailblazer-activity", ">= 0.3.1", "< 0.4.0"
+  spec.add_dependency "trailblazer-activity", ">= 0.3.2", "< 0.4.0"
   spec.add_dependency "trailblazer-context", ">= 0.1.1", "< 0.3.0"
 
   spec.add_development_dependency "bundler"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-operation
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-19 00:00:00.000000000 Z
+date: 2017-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: trailblazer-activity
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.3.1
+        version: 0.3.2
     - - "<"
       - !ruby/object:Gem::Version
         version: 0.4.0
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.3.1
+        version: 0.3.2
     - - "<"
       - !ruby/object:Gem::Version
         version: 0.4.0
@@ -171,7 +171,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Trailblazer's operation object with railway flow and integrated error handling.