trailblazer-operation 0.0.11 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fa4ab9036f38cd68c0237c2498b0a37445c52d8a
-  data.tar.gz: c8a30650151fb381614dce92b2babfc40c952b07
+  metadata.gz: ea04dd0790a33b1d8ed216bc6c38b2051c8879dd
+  data.tar.gz: 5950c507d31e4ae46c90ef9b1b22789bdcb5c87b
 SHA512:
-  metadata.gz: e4547a6ac0d1c5cde8319ed1e00f99dde8cacf8801affb7ea0ab892f86fc087ac481416f48528ae8caab3b6e8c8a48701655e4ae22ef7bc0d5d2f2fd589da71f
-  data.tar.gz: 97148b9ef2c060f48bd23172e8b88d46cbb8dee2954a2935a6458a48155325bb04691a16c189838e46c26d1d3456696ed23dc25590baecd33816ec8e91cc0508
+  metadata.gz: 9a0b2ec25620b01f1f3ddef0ef93bae31de3b7df540d7c6048252ab8d3d1ed294ba9744cf751fdeeffdd1771a8cefd05aba100b3f15a1f1b9750e094ef0602dc
+  data.tar.gz: bc2d57beb613557e4594dba1734424cb39fa4d49e88247fa9d9d800ca1a7c6d7e3f30157a5a2360f9355adad9214f8af63deebde0a04caec53dc13abfc60e63a

data/.travis.yml

@@ -9,7 +9,7 @@ matrix:
     #   gemfile: "test/gemfiles/Gemfile.ruby-2.0"
     - rvm: 2.1
       gemfile: Gemfile
-    - rvm: 2.2.3
+    - rvm: 2.2.4
       gemfile: Gemfile
     - rvm: 2.3.1
       gemfile: Gemfile

data/CHANGES.md

@@ -1,3 +1,16 @@
+## 0.0.12
+
+* Allow passing tmp options into `KW::Option` that will be merged with `options` and then transformed into kw args, but only locally for the step scope (or wherever you do `Option.()`). The API:
+
+    ```ruby
+    Option::KW.(proc).(input, options, some: "more", ...)
+    ```
+  Note that `KW::Option` could be massively sped up with simple optimizations.
+
+## 0.0.11
+
+* Use `Forwardable` instead of `Uber::Delegates`.
+
 ## 0.0.10
 
 * `Flow` is now `Railway`.

data/lib/trailblazer/operation/option.rb

@@ -35,19 +35,19 @@ class Trailblazer::Operation
 
     # Call the option with keyword arguments. Ruby <= 2.0.
     class KW < Option
-      def self.call_proc(proc, input, options)
+      def self.call_proc(proc, input, options, tmp_options={})
         return proc.(options) if proc.arity == 1
-        proc.(options, **options)
+        proc.(options, **options.to_hash(tmp_options))
       end
 
-      def self.call_method(proc, input, options)
+      def self.call_method(proc, input, options, tmp_options={})
         return input.send(proc, options) if input.method(proc).arity == 1 # TODO: remove this
-        input.send(proc, options, **options)
+        input.send(proc, options, **options.to_hash(tmp_options))
       end
 
-      def self.call_callable(callable, input, options)
+      def self.call_callable(callable, input, options, tmp_options={})
         return callable.(options) if callable.method(:call).arity == 1
-        callable.(options, **options)
+        callable.(options, **options.to_hash(tmp_options))
       end
     end
   end

data/lib/trailblazer/operation/version.rb

@@ -1,5 +1,5 @@
 module Trailblazer
   class Operation
-    VERSION = "0.0.11"
+    VERSION = "0.0.12"
   end
 end

data/lib/trailblazer/skill.rb

@@ -32,15 +32,16 @@ module Trailblazer
 
     # Called when Ruby transforms options into kw args, via **options.
     # TODO: this method has massive potential for speed improvements.
-    def to_hash
+    # The `tmp_options` argument is experimental. It allows adding temporary options
+    # to the kw args.
+    #:private:
+    def to_hash(tmp_options={})
       {}.tap do |h|
-        arr = to_runtime_data << to_mutable_data
-
+        arr = to_runtime_data << to_mutable_data << tmp_options
 
         arr.each { |hsh|
-         hsh.each { |k, v| h[k.to_sym] = v }
+          hsh.each { |k, v| h[k.to_sym] = v }
         }
-
       end
     end
 

data/test/2.0.0-pipetree_test.rb

@@ -18,6 +18,22 @@ class KWBugsTest < Minitest::Spec
   it { Merchant::New.( {}, { "yo"=> nil   } ) }
 end
 
+class KWOptionsTest < Minitest::Spec
+  X = Trailblazer::Operation::Option::KW.( ->(options, **) { options["x"] = true } )
+  Y = Trailblazer::Operation::Option::KW.( ->(options, params:nil, **) { options["y"] = params } )
+  Z = Trailblazer::Operation::Option::KW.( ->(options, params:nil, z:nil, **) { options["kw_z"] = z } )
+  A = Trailblazer::Operation::Option::KW.( ->(options, params:nil, z:nil, **) { options["options_z"] = options["z"] } )
+
+  class Create < Trailblazer::Operation
+    step [ ->(input, options) { X.(input, options, z: "Z!") }, name: "X" ]
+    step [ ->(input, options) { Y.(input, options, z: "Z!") }, name: "Y" ]
+    step [ ->(input, options) { Z.(input, options, z: "Z!") }, name: "Z" ]
+    step [ ->(input, options) { A.(input, options, z: "Z!") }, name: "A" ]
+  end
+
+  it { Create.({ params: "yo" }, "z" => 1).inspect("x", "y", "kw_z", "options_z").must_equal %{<Result:true [true, {:params=>\"yo\"}, "Z!", 1] >} }
+end
+
 
 class Ruby200PipetreeTest < Minitest::Spec
   class Create < Trailblazer::Operation

data/test/2.1.0-pipetree_test.rb

@@ -18,6 +18,22 @@ class KWBugsTest < Minitest::Spec
   it { Merchant::New.( {}, { "yo"=> nil   } ) }
 end
 
+class KWOptionsTest < Minitest::Spec
+  X = Trailblazer::Operation::Option::KW.( ->(options, **) { options["x"] = true } )
+  Y = Trailblazer::Operation::Option::KW.( ->(options, params:, **) { options["y"] = params } )
+  Z = Trailblazer::Operation::Option::KW.( ->(options, params:, z:, **) { options["kw_z"] = z } )
+  A = Trailblazer::Operation::Option::KW.( ->(options, params:, z:, **) { options["options_z"] = options["z"] } )
+
+  class Create < Trailblazer::Operation
+    step [ ->(input, options) { X.(input, options, z: "Z!") }, name: "X" ]
+    step [ ->(input, options) { Y.(input, options, z: "Z!") }, name: "Y" ]
+    step [ ->(input, options) { Z.(input, options, z: "Z!") }, name: "Z" ]
+    step [ ->(input, options) { A.(input, options, z: "Z!") }, name: "A" ]
+  end
+
+  it { Create.({ params: "yo" }, "z" => 1).inspect("x", "y", "kw_z", "options_z").must_equal %{<Result:true [true, {:params=>\"yo\"}, "Z!", 1] >} }
+end
+
 
 class Ruby200PipetreeTest < Minitest::Spec
   class Create < Trailblazer::Operation

data/test/skill_test.rb

@@ -46,12 +46,3 @@ class SkillTest < Minitest::Spec
     end
   end
 end
-# resolve: prefer @instance_attrs over competences
-#   or instace_atrt is competences
-
-# dependencies = { current_user: Runtime::User..., container: BLA }
-# dependencies[:current_user]
-# dependencies["user.create.contract"] # delegates to container, somehow.
-
-# Create.(params, dependencies) # not sure if op should build this runtime dependencies hash or if it comes from outside.
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-operation
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-20 00:00:00.000000000 Z
+date: 2017-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: uber