trailblazer-finder 0.1.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60587025c9bddf5a856868fa908615064b1b5a683c187d9606670e00ceb999f4
-  data.tar.gz: d110b70e65eef74d6cba432740c4df30b2449cd338c9a933e1c82a2b3bb4e9ef
+  metadata.gz: dc3cc06785eeaa846359a0577ece8ba7d42a93ac122d732607b6f01ca535b782
+  data.tar.gz: a55de72ba22507d8a22854fb94998df91b08e29b9260161e3ac9177db5048c72
 SHA512:
-  metadata.gz: 9ab8dc1682c4a9968af5a442a27ff1be21a98b78c87776cbd477e809ade202bc28732d0bb00fbc6857f107c8a3cb296dd99ffd192557b7de04ba35c24f08ccb1
-  data.tar.gz: 5f5b69d3715e35f3350509fd8b32613e7b39c219049c3411bd95cda17a8f0ad2675dce7ee51dc412bfdbe159a7fb87885c18accbc3847efae2c6ed41009cae5e
+  metadata.gz: 62888964119288ea47b1c4a2beaf88a51fb6c5185bf1866e4f2362f4461b6f4e616a4ebc38641fce019e70f6fe44d9d6170a0642dd0ec92cac68829866a48c58
+  data.tar.gz: dd1d405a36b76e271115bf69d36b26285cbc96dd18fe1be5a03ce05a5a0a95468c175eb160e65e36e74a97f1137147c8ba2d057b66b8242f2d15866811d324bf

data/.gitignore

@@ -17,3 +17,6 @@ test/tmp
 test/version_tmp
 tmp
 bitbucket-pipelines.yml
+.byebug_history
+.idea/
+.tool-versions

data/.rubocop-https---raw-githubusercontent-com-trailblazer-meta-master-rubocop-yml

@@ -0,0 +1,101 @@
+AllCops:
+  DisplayCopNames: true
+Layout/CaseIndentation:
+  IndentOneStep: true
+Layout/FirstArrayElementLineBreak:
+  Enabled: true
+Layout/FirstHashElementLineBreak:
+  Enabled: true
+Layout/FirstMethodArgumentLineBreak:
+  Enabled: true
+Layout/FirstMethodParameterLineBreak:
+  Enabled: true
+Layout/MultilineAssignmentLayout:
+  Enabled: true
+  EnforcedStyle: same_line
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+Metrics/LineLength:
+  Max: 130
+Metrics/ParameterLists:
+  Max: 5
+Naming/VariableNumber:
+  EnforcedStyle: snake_case
+Style/AndOr:
+  EnforcedStyle: conditionals
+Style/AutoResourceCleanup:
+  Enabled: true
+Style/CollectionMethods:
+  Enabled: true
+Style/Documentation:
+  Enabled: false
+Style/EmptyLiteral:
+  Enabled: false
+Style/EmptyMethod:
+  EnforcedStyle: expanded
+Style/FormatStringToken:
+  EnforcedStyle: template
+Style/ImplicitRuntimeError:
+  Enabled: true
+Style/MethodCalledOnDoEndBlock:
+  Enabled: true
+Style/MethodDefParentheses:
+  EnforcedStyle: require_parentheses
+Style/MissingElse:
+  Enabled: true
+  EnforcedStyle: case
+Style/NumericLiterals:
+  Enabled: false
+Style/OptionHash:
+  Enabled: true
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    "%w": "[]"
+    "%W": "[]"
+    "%i": "[]"
+    "%I": "[]"
+    "%r": "()"
+Style/ReturnNil:
+  Enabled: true
+Style/SafeNavigation:
+  Enabled: false
+Style/Send:
+  Enabled: true
+Style/SignalException:
+  EnforcedStyle: semantic
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+Style/StringLiteralsInInterpolation:
+  EnforcedStyle: double_quotes
+Style/StringMethods:
+  Enabled: true
+Style/SymbolArray:
+  Enabled: true
+# this allows in rspec to have expect { } with multiple lines
+Style/BlockDelimiters:
+  EnforcedStyle: braces_for_chaining
+Layout/EndOfLine:
+  Enabled: false
+# don't need these checks in test folders
+Metrics/ModuleLength:
+  Exclude:
+    - "spec/**/*"
+    - "test/**/*"
+Metrics/BlockLength:
+  Exclude:
+    - "spec/**/*"
+    - "test/**/*"
+    - "*.gemspec" # definitely not in the gemspec
+Metrics/MethodLength:
+  Max: 20
+Lint/UnreachableCode:
+  Description: 'Unreachable code.'
+  Enabled: false
+Lint/Void:
+  Enabled: false
+Layout/AlignHash:
+  EnforcedLastArgumentHashStyle: ignore_implicit
+Metrics/AbcSize:
+  Max: 25
+Style/LambdaCall:
+  Enabled: false

data/.rubocop.yml

@@ -1,45 +1,5 @@
 require: rubocop-rspec
 
-inherit_from: .rubocop_todo.yml
-
-AllCops:
-  Exclude:
-    - Rakefile
-    - coverage
-    - test-reports
-    - bitbucket-pipelines.yml
-    - trailblazer-finder.gemspec
-    - spec/trailblazer/finder/base_spec.rb
-    - lib/trailblazer/operation/finder.rb
-
-# Disables "Line is too long"
-LineLength:
-  Enabled: false
-
-# Disables Module has too many lines
-ModuleLength:
-  Enabled: false
-
-# Disables "Missing top-level class documentation comment"
-Documentation:
-  Enabled: false
-
-# Disables "Use each_with_object instead of inject"
-Style/EachWithObject:
-  Enabled: false
-
-# Disables "Prefer reduce over inject."
-Style/CollectionMethods:
-  Enabled: false
-
-# Disables "Block has too many lines."
-Metrics/BlockLength:
-  Enabled: false
-
-# Disables "Example has too many lines."
-RSpec/ExampleLength:
-  Enabled: false
-
-# Disables "Too many expectations."
-RSpec/MultipleExpectations:
-  Enabled: false
+inherit_from:
+  - https://raw.githubusercontent.com/trailblazer/meta/master/rubocop.yml
+  - .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -1,232 +1,78 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-03-17 16:23:14 +0100 using RuboCop version 0.53.0.
+# on 2018-08-23 00:10:15 +0200 using RuboCop version 0.58.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 1
-# Cop supports --auto-correct.
-Layout/CommentIndentation:
-  Exclude:
-    - 'spec/trailblazer/finder/adapters/sequel/predicates_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/EmptyLines:
-  Exclude:
-    - 'spec/trailblazer/operation/finder_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, no_empty_lines
-Layout/EmptyLinesAroundBlockBody:
-  Exclude:
-    - 'spec/trailblazer/finder/adapters/active_record/sorting_spec.rb'
-    - 'spec/trailblazer/finder/features/sorting_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
-Layout/EmptyLinesAroundModuleBody:
-  Exclude:
-    - 'lib/trailblazer/finder/adapters/sequel/predicates.rb'
+Metrics/AbcSize:
+  Max: 31
 
 # Offense count: 2
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: native, lf, crlf
-Layout/EndOfLine:
-  Exclude:
-    - 'lib/trailblazer/finder/adapters/data_mapper/predicates.rb'
-    - 'spec/trailblazer/finder/adapters/data_mapper/predicates_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: normal, rails
-Layout/IndentationConsistency:
-  Exclude:
-    - 'spec/trailblazer/finder/adapters/sequel/predicates_spec.rb'
+Metrics/CyclomaticComplexity:
+  Max: 7
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: Width, IgnoredPatterns.
-Layout/IndentationWidth:
-  Exclude:
-    - 'spec/trailblazer/finder/adapters/sequel/predicates_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/SpaceAroundKeyword:
-  Exclude:
-    - 'spec/trailblazer/finder/features/predicates_spec.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
-Layout/SpaceAroundOperators:
-  Exclude:
-    - 'spec/trailblazer/finder/features/predicates_spec.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceBeforeBlockBraces:
-  Exclude:
-    - 'lib/trailblazer/finder/adapters/sequel/predicates.rb'
-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideBlockBraces:
-  Exclude:
-    - 'lib/trailblazer/finder/adapters/sequel/predicates.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-Layout/SpaceInsideParens:
-  Exclude:
-    - 'lib/trailblazer/finder/utils/splitter.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Layout/TrailingWhitespace:
-  Exclude:
-    - 'lib/trailblazer/finder/filter.rb'
-    - 'spec/trailblazer/finder/adapters/active_record/base_spec.rb'
+# Offense count: 13
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 283
 
 # Offense count: 1
-Lint/DuplicateMethods:
-  Exclude:
-    - 'lib/trailblazer/finder/utils/splitter.rb'
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 6
 
 # Offense count: 1
-Lint/NestedMethodDefinition:
-  Exclude:
-    - 'spec/trailblazer/finder/adapters/sequel/base_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'lib/trailblazer/finder/adapters/sequel/predicates.rb'
-
-# Offense count: 3
-Metrics/AbcSize:
-  Max: 17
-
-# Offense count: 9
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 51
-
-# Offense count: 8
 RSpec/DescribeClass:
   Exclude:
-    - 'spec/trailblazer/finder/adapters/active_record/sorting_spec.rb'
-    - 'spec/trailblazer/finder/adapters/data_mapper/sorting_spec.rb'
-    - 'spec/trailblazer/finder/adapters/sequel/predicates_spec.rb'
-    - 'spec/trailblazer/finder/adapters/sequel/sorting_spec.rb'
     - 'spec/trailblazer/operation/finder_spec.rb'
-    - 'spec/trailblazer/operation/paging_spec.rb'
-    - 'spec/trailblazer/operation/predicates_spec.rb'
-    - 'spec/trailblazer/operation/sorting_spec.rb'
 
-# Offense count: 50
-# Configuration parameters: CustomTransform, IgnoredWords.
-RSpec/ExampleWording:
+# Offense count: 78
+# Configuration parameters: Max.
+RSpec/ExampleLength:
   Exclude:
-    - 'spec/trailblazer/finder/adapters/active_record/predicates_spec.rb'
-    - 'spec/trailblazer/finder/adapters/data_mapper/predicates_spec.rb'
-    - 'spec/trailblazer/finder/adapters/sequel/predicates_spec.rb'
-    - 'spec/trailblazer/finder/features/predicates_spec.rb'
-    - 'spec/trailblazer/operation/predicates_spec.rb'
+    - 'spec/trailblazer/finder/adapters/active_record_spec.rb'
+    - 'spec/trailblazer/finder/adapters/basic_spec.rb'
+    - 'spec/trailblazer/finder/adapters/kaminari_spec.rb'
+    - 'spec/trailblazer/finder/adapters/sequel_spec.rb'
+    - 'spec/trailblazer/finder/adapters/will_paginate_spec.rb'
+    - 'spec/trailblazer/finder/base_spec.rb'
+    - 'spec/trailblazer/finder/dsl_spec.rb'
+    - 'spec/trailblazer/finder/utils/string_spec.rb'
+
+# Offense count: 62
+# Configuration parameters: AggregateFailuresByDefault.
+RSpec/MultipleExpectations:
+  Max: 7
 
 # Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: prefer_alias, prefer_alias_method
-Style/Alias:
+RSpec/RepeatedDescription:
   Exclude:
-    - 'lib/trailblazer/finder/utils/splitter.rb'
+    - 'spec/trailblazer/finder/adapters/basic_spec.rb'
 
-# Offense count: 18
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Exclude:
     - 'spec/trailblazer/operation/finder_spec.rb'
-    - 'spec/trailblazer/operation/paging_spec.rb'
-    - 'spec/trailblazer/operation/predicates_spec.rb'
-    - 'spec/trailblazer/operation/sorting_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: compact, expanded
-Style/EmptyMethod:
-  Exclude:
-    - 'spec/trailblazer/finder/adapters/sequel/sorting_spec.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
-Style/IfUnlessModifier:
-  Exclude:
-    - 'lib/trailblazer/finder/utils/deep_locate.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: IncludeSemanticChanges.
-Style/NonNilCheck:
+# Configuration parameters: SuspiciousParamNames.
+# SuspiciousParamNames: options, opts, args, params, parameters
+Style/OptionHash:
   Exclude:
-    - 'lib/trailblazer/finder/predicates.rb'
+    - 'lib/trailblazer/finder/dsl.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/ParallelAssignment:
-  Exclude:
-    - 'lib/trailblazer/finder/utils/splitter.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/PerlBackrefs:
-  Exclude:
-    - 'lib/trailblazer/finder/utils/splitter.rb'
-
-# Offense count: 191
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
+# Offense count: 3
+Style/Send:
   Exclude:
-    - 'lib/trailblazer/finder/adapters/sequel/predicates.rb'
-    - 'spec/trailblazer/finder/adapters/active_record/predicates_spec.rb'
-    - 'spec/trailblazer/finder/adapters/active_record/sorting_spec.rb'
-    - 'spec/trailblazer/finder/adapters/data_mapper/predicates_spec.rb'
-    - 'spec/trailblazer/finder/adapters/data_mapper/sorting_spec.rb'
-    - 'spec/trailblazer/finder/adapters/sequel/predicates_spec.rb'
-    - 'spec/trailblazer/finder/features/predicates_spec.rb'
-    - 'spec/trailblazer/operation/predicates_spec.rb'
+    - 'lib/trailblazer/finder/adapters/sequel/sorting.rb'
+    - 'lib/trailblazer/operation/finder.rb'
 
-# Offense count: 24
-# Cop supports --auto-correct.
-# Configuration parameters: WordRegex.
-# SupportedStyles: percent, brackets
-Style/WordArray:
-  EnforcedStyle: percent
-  MinSize: 9
-
-# Offense count: 191
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 172
+RSpec/DescribedClass:
+  SkipBlocks: true

data/.travis.yml

@@ -1,13 +1,10 @@
 language: ruby
+cache: bundler
 before_install:
   - gem install bundler
 matrix:
   include:
-    - rvm: 2.2
-      gemfile: Gemfile
-    - rvm: 2.3.1
-      gemfile: Gemfile
-    - rvm: 2.4.1
-      gemfile: Gemfile
-    - rvm: 2.5.0
-      gemfile: Gemfile
+    - rvm: 2.3.8
+    - rvm: 2.4.6
+    - rvm: 2.5.5
+    - rvm: 2.6.3