trailblazer-activity 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dab847dcaff55b44bfa62dad2a7f8e662458bc082e941dccf1e8f189b87eb6fa
-  data.tar.gz: f8c1782081b72b024f5fdc06e49d040825979c3cd825cd2a242270fc100d65c3
+  metadata.gz: 92e2284135d0c4f569c3b6de38647a5f4dfae359b90a6461539d67fe2a8d58fc
+  data.tar.gz: d71820d9da38a2099713bb5fd5005b4680f01c1181e4f6bb919cd84a4ec80443
 SHA512:
-  metadata.gz: acd50922b312667f892d6b73d0c39fdb5cfc136f5421af01fdbb0383e065845e332518b02d068a3279b72cc5cbec1e2f6d22c0a9cbaf77abe25af8669b31a0f9
-  data.tar.gz: e493008be86cff07f981fb6ab6542b14749f17dc91c542bde511f7cfabe14b8b8b0c1eb91dccc6b714a24d66567846b03fe2dbc6898bd598b48b0dd2d16c5192
+  metadata.gz: c13c41f9631224f688190808efea928dda6b6cfac0d9fa7c53edc0e77d998b3d9b27ff0f9753394f0403dc2cb0783f2731cfd4b5993cce63ba71518c83006459
+  data.tar.gz: 6c2c4ead668c87454a1129254d88cd9a9558336896e7796441f391223ca6e40b5ba4cdb8fae52c4bcc4c0d3fd8a17bfe1f48c1832f88e44a3bfaa0b05e55a21c

data/CHANGES.md

@@ -1,3 +1,9 @@
+# 0.5.1
+
+* Include all end events without outgoing connections into `Activity.outputs`. In earlier versions, we were filtering out end events without incoming connections, which reduces the number of outputs, but might not represent the desired interface of an activity.
+* Add `_end` to `Railway` and `FastTrack`.
+* Move `Builder::FastTrack::PassFast` and `:::FailFast` to `Activity::FastTrack` since those are signals and unrelated to builders.
+
 # 0.5.0
 
 * Rename `Nested()` to `Subprocess` and move the original one to the `operation` gem.

data/lib/trailblazer/activity/dsl/magnetic/builder/fast_track.rb

@@ -41,8 +41,8 @@ module Trailblazer
 
             # add fast track outputs if :fast_track
             plus_poles = plus_poles.reverse_merge(
-              Activity.Output(FailFast, :fail_fast) => :fail_fast,
-              Activity.Output(PassFast, :pass_fast) => :pass_fast
+              Activity.Output(Activity::FastTrack::FailFast, :fail_fast) => :fail_fast,
+              Activity.Output(Activity::FastTrack::PassFast, :pass_fast) => :pass_fast
             ) if options[:fast_track]
 
             [
@@ -55,7 +55,7 @@ module Trailblazer
         class FailPolarization < Railway::StepPolarization
           def call(magnetic_to, plus_poles, options)
             plus_poles = plus_poles.reconnect( :failure => :fail_fast, :success => :fail_fast ) if options[:fail_fast]
-            plus_poles = plus_poles.reverse_merge( Activity.Output(FailFast, :fail_fast) => :fail_fast, Activity.Output(PassFast, :pass_fast) => :pass_fast ) if options[:fast_track]
+            plus_poles = plus_poles.reverse_merge( Activity.Output(Activity::FastTrack::FailFast, :fail_fast) => :fail_fast, Activity.Output(Activity::FastTrack::PassFast, :pass_fast) => :pass_fast ) if options[:fast_track]
 
             [
               magnetic_to,
@@ -67,7 +67,7 @@ module Trailblazer
         class PassPolarization < Railway::StepPolarization
           def call(magnetic_to, plus_poles, options)
             plus_poles = plus_poles.reconnect( :success => :pass_fast, :failure => :pass_fast ) if options[:pass_fast]
-            plus_poles = plus_poles.reverse_merge( Activity.Output(FailFast, :fail_fast) => :fail_fast, Activity.Output(PassFast, :pass_fast) => :pass_fast ) if options[:fast_track]
+            plus_poles = plus_poles.reverse_merge( Activity.Output(Activity::FastTrack::FailFast, :fail_fast) => :fail_fast, Activity.Output(Activity::FastTrack::PassFast, :pass_fast) => :pass_fast ) if options[:fast_track]
 
             [
               magnetic_to,
@@ -112,10 +112,6 @@ module Trailblazer
 
           path_adds + ends
         end
-
-        # Direction signals.
-        FailFast = Class.new(Activity::Signal)
-        PassFast = Class.new(Activity::Signal)
       end
     end
   end

data/lib/trailblazer/activity/dsl/magnetic/finalizer.rb

@@ -37,14 +37,10 @@ module Trailblazer
           return Circuit.new(circuit_hash, end_events), end_events
         end
 
-        # Filters out unconnected ends, e.g. the standard end in nested tracks that weren't used.
+        # Find all end events that don't have outgoing connections.
         def self.end_events_for(circuit_hash)
-          tasks_with_incoming_edge = circuit_hash.values.collect { |connections| connections.values }.flatten(1)
-
           ary = circuit_hash.collect do |task, connections|
-            task.kind_of?(Activity::End) &&
-              connections.empty? &&
-              tasks_with_incoming_edge.include?(task) ? task : nil
+            task.kind_of?(Activity::End) && connections.empty? ? task : nil
           end
 
           ary.compact

data/lib/trailblazer/activity/dsl/strategy/fast_track.rb

@@ -11,9 +11,14 @@ class Trailblazer::Activity < Module
         extend:          [
           DSL.def_dsl(:step, Magnetic::Builder::FastTrack, :StepPolarizations),
           DSL.def_dsl(:fail, Magnetic::Builder::FastTrack, :FailPolarizations),
-          DSL.def_dsl(:pass, Magnetic::Builder::FastTrack, :PassPolarizations)
+          DSL.def_dsl(:pass, Magnetic::Builder::FastTrack, :PassPolarizations),
+          DSL.def_dsl(:_end, Magnetic::Builder::Path,      :EndEventPolarizations), # TODO: TEST ME
         ],
       )
     end
+
+    # Signals
+    FailFast = Class.new(Signal)
+    PassFast = Class.new(Signal)
   end
 end

data/lib/trailblazer/activity/dsl/strategy/railway.rb

@@ -13,7 +13,8 @@ module Trailblazer
           extend:          [
             DSL.def_dsl(:step, Magnetic::Builder::Railway, :StepPolarizations),
             DSL.def_dsl(:fail, Magnetic::Builder::Railway, :FailPolarizations),
-            DSL.def_dsl(:pass, Magnetic::Builder::Railway, :PassPolarizations)
+            DSL.def_dsl(:pass, Magnetic::Builder::Railway, :PassPolarizations),
+            DSL.def_dsl(:_end, Magnetic::Builder::Path,    :EndEventPolarizations), # TODO: TEST ME
           ],
         )
       end

data/lib/trailblazer/activity/version.rb

@@ -1,5 +1,5 @@
 module Trailblazer
   class Activity < Module
-    VERSION = "0.5.0"
+    VERSION = "0.5.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: trailblazer-activity
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-03-01 00:00:00.000000000 Z
+date: 2018-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hirb