traffic_mansion 0.0.15 → 0.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8dabb7b8252e7bb3a3377316678e3b85b480b3dc
-  data.tar.gz: cb16034a271c1e02ba0a4d3040be03f75e0b2d40
+  metadata.gz: 8a4e05cf8d2d6d40c3e987b8d11a38a95e3eb1a1
+  data.tar.gz: c3982ed383e534acf243439a2e16bce2bce8d670
 SHA512:
-  metadata.gz: 2c3b8fa03098c2cb4e40673d8c9f2865fb9aa5304f2ea0778979dac386d27c8240a3ce59bd99e8053bce87cd2ec0f8273ee140c995bb7f792dd18ffd02e56e09
-  data.tar.gz: e04ce7edd4845f6ac7c14df8a91bbeb059e808121ab2506550a05c71d199a278d75e293abb50b4126bed22eb472a16b1f9042ecd3668a706f0eb0d85fd2a19fa
+  metadata.gz: 8943f9f2c4901ae0d748dbf76869db31151151f3caa59a2144e7c1e9c7f94e62be70ac78c259ac067a6b24115d40d285aef63b11ecb15d2ba51f314b68cfff15
+  data.tar.gz: 1e202381df9c51c6e3618f0f4d5eb4c9f0afbdc414098f9a6599f76bc43b560bb23e34944e1fca317e468695d2902ebc538ab4d3f83a16fd220d13dbcf8f7f96

data/lib/traffic_mansion/queue.rb

@@ -9,6 +9,7 @@ module TrafficMansion
     field :parent_event_id, :type => String
     field :user_id,         :type => String
     field :data,            :type => Hash
+    field :last_error,      :type => String
     field :result,          :type => Hash
     field :processed,       :type => Boolean, :default => false
 
@@ -110,30 +111,43 @@ module TrafficMansion
         self.parent_event_id = parent_event.id
         save!
       else
-        raise "Could not find a parent event!"
+        error = "Could not find a parent event!"
+        update_error error
+        raise error
       end
     end
 
     def update_from_parent
       parent_event = TrafficMansion::Queue.find_by_id parent_event_id
-      if parent_event && parent_event.processed
+      if !parent_event
+        error = "Could not find a parent event!"
+        raise error
+      end
+      if parent_event.processed
         self.data["visit_id"] = parent_event.data["visit_id"].present? ? parent_event.data["visit_id"] : parent_event.result["visit_id"]
         save!
       else
-        raise "Parent was not processed yet!"
+        error = "Parent was not processed yet!"
+        update_error error
+        raise error
       end
     end
 
     def track
       tracker = TrafficMansion::Tracker.new data
       res = tracker.send type, data
+      self.set :result, res.get_response
       if res.success?
-        self.result = res.get_response
-        self.processed = true
-        save!
+        self.set :processed, true
       else
-        raise "Tracking failed with result: #{res.get_error}"
+        error = "Tracking failed with result: #{res.get_error}"
+        update_error error
+        raise error
       end
     end
+
+    def update_error error
+      self.set :last_error, error.to_s
+    end
   end
 end

data/lib/traffic_mansion/version.rb

@@ -1,3 +1,3 @@
 module TrafficMansion
-  VERSION = "0.0.15"
+  VERSION = "0.0.16"
 end

data/spec/queue_spec.rb

@@ -276,7 +276,7 @@ describe TrafficMansion::Queue do
       end
 
       context "when the repsonse is not success" do
-        let(:result) { mock("TMResult", :success? => false, :get_error => "error text") }
+        let(:result) { mock("TMResult", :success? => false, :get_error => "error text", :get_response => nil) }
 
         before :each do
           TrafficMansion::Tracker.any_instance.stub(:send => result)
@@ -344,7 +344,7 @@ describe TrafficMansion::Queue do
     end
 
     context "when the repsonse is not success" do
-      let(:result) { mock("TMResult", :success? => false, :get_error => "error text") }
+      let(:result) { mock("TMResult", :success? => false, :get_error => "error text", :get_response => nil) }
 
       before :each do
         TrafficMansion::Tracker.any_instance.stub(:send => result)
@@ -360,4 +360,49 @@ describe TrafficMansion::Queue do
       end
     end
   end
+
+  describe :track do
+    let!(:event)   { TrafficMansion::Queue.add "visit"}
+    let(:response) { {:code => "1"} }
+    let(:result)   { mock("TMResult", :success? => true, :get_error => "error text", :get_response => response) }
+
+    before :each do
+      TrafficMansion::Tracker.any_instance.stub(:send => result)
+    end
+    
+    it "saves the TM result" do
+      event.track
+      event.result.should be response
+    end
+
+    context "when the result is success" do
+      let(:result)   { mock("TMResult", :success? => true, :get_error => "error text", :get_response => response) }
+
+      before :each do
+        TrafficMansion::Tracker.any_instance.stub(:send => result)
+      end
+
+      it "sets the event as processed" do
+        event.track
+        event.processed.should be true
+      end
+    end
+
+    context "when the result is not success" do
+      let(:result)   { mock("TMResult", :success? => false, :get_error => "error text", :get_response => response) }
+
+      before :each do
+        TrafficMansion::Tracker.any_instance.stub(:send => result)
+      end
+
+      it "sets the event as not processed" do
+        lambda{ event.track }
+        event.processed.should be false
+      end
+
+      it "raises an error" do
+        lambda{ event.track }.should raise_error("Tracking failed with result: error text")
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: traffic_mansion
 version: !ruby/object:Gem::Version
-  version: 0.0.15
+  version: 0.0.16
 platform: ruby
 authors:
 - AgileWings
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-01 00:00:00.000000000 Z
+date: 2013-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler