toodledo 1.3.4 → 1.3.5

data/History.txt

@@ -1,3 +1,7 @@
+== 1.3.5 / 2010-10-15
+
+* Patches for raising a better error when no internet connection, recovering from state where no internet + token expired.
+
 == 1.3.4 / 2010-10-08
 
 * More patches for reestablishing connection, based off file modification time as well as :tokenexpires

data/lib/toodledo.rb

@@ -5,7 +5,7 @@
 module Toodledo
 
   # Required for gem  
-  VERSION = '1.3.4'
+  VERSION = '1.3.5'
   
   # Returns the configuration object.
   def self.get_config()

data/lib/toodledo/session.rb

@@ -221,6 +221,9 @@ module Toodledo
       
       # make the call
       response = http.request_get(url.request_uri, HEADERS)
+      unless response
+        raise Toodledo::ServerError.new("No HTTP response found from request #{url.path}");
+      end
       body = response.body
 
       # body = url.read
@@ -233,18 +236,25 @@ module Toodledo
       end
 
       root_node = doc.root
+      retry_error = nil
       if (root_node.name == 'error')
         error_text = root_node.text        
-        if (error_text == 'Invalid ID number')
+        case error_text
+        when 'Invalid ID number' then
           raise Toodledo::ItemNotFoundError.new(error_text)
-        elsif (error_text == 'key did not validate')        
-          raise Toodledo::InvalidKeyError.new(error_text)
-          # May want to get uncached token here as a recovery mechanism?
+        when 'key did not validate', 'No Key Specified' then 
+          retry_error = true    
         else
           raise Toodledo::ServerError.new(error_text)
         end
       end
-
+      
+      if (retry_error)
+        logger.debug("call(#{method}): invalid key, reconnecting") if logger
+        reconnect(@base_url, @proxy);
+        root_node = call(method, params);
+      end
+      
       return root_node
     end
 

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 3
-  - 4
-  version: 1.3.4
+  - 5
+  version: 1.3.5
 platform: ruby
 authors: 
 - Will Sargent
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-08 00:00:00 -07:00
+date: 2010-10-15 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency