tomato_power 0.0.8 → 0.0.9

data/README.md

@@ -22,6 +22,7 @@ Create a `TomatoPower::Client`.
   
     >> client = TomatoPower.new <your_rotten_tomatoes_api_key>
 
+_note_: You can also set ENV["ROTTEN_TOMATOES_API_KEY"] and omit passing your API key to the client.
 
 ## Examples
 

data/lib/tomato_power/api/api.rb

@@ -3,38 +3,23 @@ require 'open-uri'
 
 module TomatoPower
   # API class to interface with Client 
-  #
   class API
 
     def initialize api_key
       @api_key = api_key
+      API.define_tomato_methods(*TOMATO_METHODS.keys)
     end
 
     #Defines methods that are in TOMATO_METHODS 
     #
-    #@param method [Symbol] method to be created. 
+    #@param methods [Array] methods to be created. 
     #@param options [Hash] options for function call.
     #@note TOMATO_METHODS is a hash containing all of the Rotten Tomatoes API calls.
-    def method_missing method, options={}
-      if TOMATO_METHODS.key?(method)
-        self.class.send(:define_method, method) do |options={}|
-            fetch(TOMATO_METHODS[method][:url], @api_key, options) if options_valid? method, options
+    def self.define_tomato_methods(*methods)
+      methods.each do |method|
+        define_method(method) do |options={}|
+          fetch(TOMATO_METHODS[method][:url], @api_key, options) if options_valid? method, options
         end
-      else
-        super
-      end
-      self.send method, options
-    end
-
-    # Whether or not this class responds to a function.
-    #
-    # @param method method in question.
-    # @return [true, false]
-    def respond_to? method
-      if TOMATO_METHODS.key? method
-        true
-      else
-        super
       end
     end
 

data/lib/tomato_power/client.rb

@@ -6,8 +6,6 @@ module TomatoPower
     # Main entry point for end users.
     # Client handles interactions from the user and delegates API calls to the 
     # API class.
-    #
-    # Certain functions are not delegated due to usability design deicisons.
     extend Forwardable
 
     def initialize 

data/lib/tomato_power/movie/movie.rb

@@ -7,8 +7,6 @@ module TomatoPower
       :studio, :directors
 
     def initialize movie={}
-      @api = TomatoPower::api
-
       @info = movie 
       @id = movie["id"] 
       @title = movie["title"]
@@ -23,6 +21,9 @@ module TomatoPower
       @links = movie["links"]
       @directors = movie["abridged_directors"]
       @studio = movie["studio"]
+
+      @api = TomatoPower::api
+      Movie.define_movie_methods(*MOVIE_METHOD_ALIAS.keys)
     end
 
     # Aliased API methods for a better interface. 
@@ -31,7 +32,6 @@ module TomatoPower
       :clips => :movie_clips,
       :reviews => :movie_reviews,
       :similar => :movie_similar,
-      :alias => :movie_alias
     }
 
     # Poster for a movie
@@ -47,23 +47,18 @@ module TomatoPower
       @actors ||= TomatoPower::Parser::parse_cast @abridged_cast
     end
 
-    def method_missing method, options={}
-      if MOVIE_METHOD_ALIAS.keys.include?(method)
-        self.class.send(:define_method, method) do |options={}|
+    #Defines methods that are in MOVIE_METHOD_ALIAS. Straight up delegation is not used
+    #because @id needs to be inserted into options before calling the method. 
+    #
+    #@param methods [Array] methods to be created. 
+    #@param options [Hash] options for function call.
+    #@note TOMATO_METHODS is a hash containing all of the Rotten Tomatoes API calls.
+    def self.define_movie_methods(*methods)
+      methods.each do |method|
+        define_method(method) do |options={}|
           options[:movie_id] = @id
           @api.send(MOVIE_METHOD_ALIAS[method], options)
         end
-      else
-        super
-      end
-      self.send method, options
-    end
-
-    def respond_to? method
-      if MOVIE_METHOD_ALIAS.key? method
-        true
-      else
-        super
       end
     end
   end

data/lib/tomato_power/version.rb

@@ -1,3 +1,3 @@
 module TomatoPower
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/spec/unit_specs/movie/movie_spec.rb

@@ -20,7 +20,7 @@ module TomatoPower
       it { should respond_to(:synopsis)}
       it { should respond_to(:alternate_ids)}
       it { should respond_to(:links)}
-      it { should respond_to(:abridged_directors)}
+      it { should respond_to(:directors)}
       it { should respond_to(:studio)}
     end
 

data/tomato_power.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |gem|
   gem.summary       = %q{Easily access Rotten Tomatoes API methods}
   gem.homepage      = "https://github.com/seankay/tomato_power"
   
-  gem.add_dependency "active_support"
+  gem.add_dependency 'active_support','>= 3.2.12'
 
   gem.add_development_dependency "rspec"
   gem.add_development_dependency "pry"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tomato_power
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-22 00:00:00.000000000 Z
+date: 2013-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_support
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.2.12
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.2.12
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement