todoist-ruby 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eae81f26048e5304824cb26dbb794166ecffcb90
-  data.tar.gz: 9a3c4c2bdd624e0c5f9c1b387a7014b4b1138ac1
+  metadata.gz: d36fbf13110d44679219837d5b8e7fa0b9f0f079
+  data.tar.gz: 7b6ed748aaadf0b41a5387ce597201eb5c1187fd
 SHA512:
-  metadata.gz: f3fd6042062b81c40304c84608acd333c17309e7a2cac47d09203741147a5d8037a66209b40a583915d83826bfe44baeb2061ea8de11736d051018048a9dcc91
-  data.tar.gz: 6ab12386bcaff94b62512deca61d10088482bb8317987d29f83f4a97ca0877c71539ab17caf74233410712596fad8e5ea86b6b2e36d88be437a5b9c24daf13af
+  metadata.gz: 12ddbea8f9a2663df0322e42bf804799b8fec78b0914f7171b3cb0e99c884d91793e9f5579ca2de8140c83fa0e87574cc8e2740cf451db47445ff4069dec0b27
+  data.tar.gz: 8d26cf0c27ad96dc3195d07ef04dbde27330903f729098253b823f27cf55317a1da5c744701096866875d8c23e4002605c2a3e0d67a53f80899474dd20fdc166

data/README.md

@@ -190,6 +190,11 @@ rake spec:clean["misc_items"]
 
 Once tests pass cleanly, subsquent runs that do not change the network requests run quickly since no network calls are made and in fact ```rake``` can be run with no issues.
 
+## Version History
+
+* 0.1.2: Renamed method ```Todoist::Util::ParseHelper.make_objects_as_array``` to ```Todoist::Util::ParseHelper.make_objects_as_hash``` to reflect the fact that it was actually returning hashes.  Added the aforementioned deleted method to return arrays and finally altered ```Todoist::Misc::Completed``` to return objects as arrays instead of hashes due to the fact that recurring completed items were being de-duped unintentionally and data was being lost as a result.
+* 0.1.1: Initial release.
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/h6y3/todoist-ruby. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.

data/lib/todoist/misc/activity.rb

@@ -44,7 +44,7 @@ module Todoist
           end
             
           result = NetworkHelper.getResponse(Config::TODOIST_ACTIVITY_GET_COMMAND, params)
-          ParseHelper.make_objects_as_array(result)
+          ParseHelper.make_objects_as_hash(result)
         end
     end
   end

data/lib/todoist/misc/backups.rb

@@ -6,7 +6,7 @@ module Todoist
         # Returns the backups for a user.
         def get()
           result = NetworkHelper.getResponse(Config::TODOIST_BACKUPS_GET_COMMAND, {})
-          ParseHelper.make_objects_as_array(result)
+          ParseHelper.make_objects_as_hash(result)
         end
     end
   end

data/lib/todoist/misc/items.rb

@@ -46,7 +46,7 @@ module Todoist
           result = NetworkHelper.getResponse(Config::TODOIST_ITEMS_GET_COMMAND, params)
           item = ParseHelper.make_object(result["item"])
           project = ParseHelper.make_object(result["project"])
-          notes = result["notes"] ? ParseHelper.make_objects_as_array(result["notes"]) : nil
+          notes = result["notes"] ? ParseHelper.make_objects_as_hash(result["notes"]) : nil
           return {"item" => item, "project" => project, "notes" => notes}
         end
         

data/lib/todoist/misc/projects.rb

@@ -6,7 +6,7 @@ module Todoist
         # Get archived projects.  Returns projects as documented here.
         def get_archived_projects()
           result = NetworkHelper.getResponse(Config::TODOIST_PROJECTS_GET_ARCHIVED_COMMAND)
-          return ParseHelper.make_objects_as_array(result)
+          return ParseHelper.make_objects_as_hash(result)
         end
         
         # Gets project information including all notes.
@@ -15,7 +15,7 @@ module Todoist
           result = NetworkHelper.getResponse(Config::TODOIST_PROJECTS_GET_COMMAND, {project_id: project.id, all_data: true})
           
           project = result["project"] ? ParseHelper.make_object(result["project"]) : nil
-          notes = result["notes"] ? ParseHelper.make_objects_as_array(result["notes"]) : nil
+          notes = result["notes"] ? ParseHelper.make_objects_as_hash(result["notes"]) : nil
           return {"project" => project, "notes" => notes}
         end
         
@@ -23,7 +23,7 @@ module Todoist
         def get_project_data(project)
           result = NetworkHelper.getResponse(Config::TODOIST_PROJECTS_GET_DATA_COMMAND, {project_id: project.id})
           project = result["project"] ? ParseHelper.make_object(result["project"]) : nil
-          items = result["items"] ? ParseHelper.make_objects_as_array(result["items"]) : nil
+          items = result["items"] ? ParseHelper.make_objects_as_hash(result["items"]) : nil
           return {"project" => project, "items" => items}
         end
     end

data/lib/todoist/misc/query.rb

@@ -14,7 +14,7 @@ module Todoist
         def queries(queries)
           result = NetworkHelper.getResponse(Config::TODOIST_QUERY_COMMAND, 
             queries: queries.to_json)
-          return ParseHelper.make_objects_as_array(result, "query")
+          return ParseHelper.make_objects_as_hash(result, "query")
         end
         
         # Given a query, return result.  See return structure in comments above.

data/lib/todoist/util/parse_helper.rb

@@ -32,23 +32,42 @@ module Todoist
         datetime.strftime("%Y-%m-%dT%H:%M")
       end
 
-      def self.make_objects_as_array(objects_as_hashes, key = "id")
-        objects = {}
+      def self.make_objects_as_array(object_datas, key = "id")
+        objects_as_array = []
         
-        objects_as_hashes.each do |object_data|
+        object_datas.each do |object_data|
             begin
               object = make_object(object_data)
-              objects[object.send(key)] = object
+              objects_as_array << object
             rescue
               # Occasionally the API returns arrays of arrays of hashes
               if object_data.kind_of? Array
                 
                 object = make_object(object_data[1])
-                objects[object.send(key)] = object
+                objects_as_array << object
               end
             end
         end
-        return objects
+        return objects_as_array
+      end
+
+      def self.make_objects_as_hash(object_datas, key = "id")
+        objects_as_hash = {}
+        
+        object_datas.each do |object_data|
+            begin
+              object = make_object(object_data)
+              objects_as_hash[object.send(key)] = object
+            rescue
+              # Occasionally the API returns arrays of arrays of hashes
+              if object_data.kind_of? Array
+                
+                object = make_object(object_data[1])
+                objects_as_hash[object.send(key)] = object
+              end
+            end
+        end
+        return objects_as_hash
       end
       
       def self.make_object(object_as_hash)

data/lib/todoist/version.rb

@@ -1,3 +1,3 @@
 module Todoist
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: todoist-ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Han Yuan
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-05-19 00:00:00.000000000 Z
+date: 2017-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -224,4 +224,3 @@ signing_key:
 specification_version: 4
 summary: This gem provides access to the latest Todoist API.
 test_files: []
-has_rdoc: