tod 2.2.0 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b81b1887eee62d6f7a98bf6281f16da3cffd47206925beca789a94b91c3e7c2
-  data.tar.gz: 662b50760caef5be2bf7e41b1b59ced86ece56b8d46b10aa6fe7cd24e33cb869
+  metadata.gz: 8986b140f4dcc736d253b188cd5f9a46a72110f38887cd6e8ff93ecee823c438
+  data.tar.gz: 95d31c83abc1264946bf2ce6aa6ba6fac45dcaeca1362b76a22d54eab27f402f
 SHA512:
-  metadata.gz: 8b97d86a5945a3f274b3674b11bd4f09add9ca409e4512ddba81c107acc8e5bc339896fa7b94a5da7d9e61bf8d579e7c866b0473dfc86ef3e6cd2b63c0174964
-  data.tar.gz: f539df0792da43d8a45244e9ba978732d59c02ffc36406047725c7209a44e1958926647b05bdb9c7d51a5d1417d6f2f396246e9aeba63bb17b017b87756a9195
+  metadata.gz: 2d1c3b50deb1df502928666b38e113fb7d58b4a25c140119bac8155ad3ff3add0689cffba810b7bdd6ab1461493838873a839ac259895630210e47679ae9ef89
+  data.tar.gz: 98a76ddcb2b8c866f602efe1def27c236b88ffcc6bbb12812580794113dc964d5b6df1bd95b0f055a48e9e95ca4b69ccf3dea93b20f866ca72be7932596e1aaf

data/.travis.yml

@@ -1,13 +1,3 @@
 language: ruby
 rvm:
-  - 2.3.3
-  - 2.2.6
-gemfile:
-  - gemfiles/4.0.gemfile
-  - gemfiles/4.1.gemfile
-  - gemfiles/4.2.gemfile
-  - gemfiles/5.0.gemfile
-matrix:
-  include:
-    - rvm: 2.5.1
-      gemfile: gemfiles/5.2.gemfile
+  - 2.6.5

data/CHANGELOG.md

@@ -1,7 +1,12 @@
+# 3.0.0 (March 6, 2021)
+
+* Support and require Rails 6
+
 # 2.2.0 (October 10, 2018)
 
 * Add string formatting compatible with Rails (Tate Johnson)
 * Add ability to use ActiveRecord's attribute API (Brent Wheeldon)
+* Add method for use in Rails database quoting (Ben Jackson)
 
 # 2.1.1 (April 14, 2017)
 

data/Gemfile.lock

@@ -1,48 +1,46 @@
 PATH
   remote: .
   specs:
-    tod (2.2.0)
+    tod (3.0.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (5.2.0)
-      activesupport (= 5.2.0)
-    activerecord (5.2.0)
-      activemodel (= 5.2.0)
-      activesupport (= 5.2.0)
-      arel (>= 9.0)
-    activesupport (5.2.0)
+    activemodel (6.1.3)
+      activesupport (= 6.1.3)
+    activerecord (6.1.3)
+      activemodel (= 6.1.3)
+      activesupport (= 6.1.3)
+    activesupport (6.1.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    arel (9.0.0)
-    byebug (10.0.2)
-    coderay (1.1.2)
-    concurrent-ruby (1.0.5)
-    i18n (1.0.1)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    byebug (11.1.3)
+    coderay (1.1.3)
+    concurrent-ruby (1.1.8)
+    i18n (1.8.9)
       concurrent-ruby (~> 1.0)
-    method_source (0.9.0)
-    minitest (5.11.3)
-    pry (0.11.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.6.0)
-      byebug (~> 10.0)
-      pry (~> 0.10)
-    rake (12.3.1)
-    sqlite3 (1.3.13)
-    thread_safe (0.3.6)
-    tzinfo (1.2.5)
-      thread_safe (~> 0.1)
+    method_source (1.0.0)
+    minitest (5.14.4)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
+      byebug (~> 11.0)
+      pry (~> 0.13.0)
+    rake (13.0.3)
+    sqlite3 (1.4.2)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  activerecord (>= 3.0.0)
-  arel
+  activerecord (>= 6.0.0)
   minitest
   pry-byebug
   rake
@@ -51,4 +49,4 @@ DEPENDENCIES
   tzinfo
 
 BUNDLED WITH
-   1.16.3
+   2.0.2

data/README.markdown

@@ -226,32 +226,21 @@ produce an object with the correct time and time zone, pass in an
     tod.on time, Time.find_zone!("US/Mountain")          # => Mon, 24 Sep 2018 08:30:00 MDT -06:00
     Date.tomorrow.at tod, Time.find_zone!("US/Mountain") # => Tue, 25 Sep 2018 08:30:00 MDT -06:00
 
-ActiveRecord Serializable Attribute Support
+ActiveRecord Attribute Support
 =======================
-Tod::TimeOfDay implements a custom serialization contract for ActiveRecord serialize which allows to store Tod::TimeOfDay directly
+Tod::TimeOfDay can be used as an ActiveRecord attribute to store Tod::TimeOfDay directly
 in a column of the time type.
 
 Example:
 
 ```ruby
 class Order < ActiveRecord::Base
-  serialize :time, Tod::TimeOfDay
+  attribute :time, :time_only
 end
 order = Order.create(time: Tod::TimeOfDay.new(9,30))
 order.time                                      # => 09:30:00
 ```
 
-By default Rails 5.1 treats database `time` values as if time zones are
-meaningful. Tod::TimeOfDay cannot correctly save and restore values when Rails
-automatically shifts values based on time zone and the normal `serialize`
-interface is not able to override this behavior. To correctly serialize
-Tod::TimeOfDay values with Rails 5.1 time zone handling must be disabled for
-database `time` types. This can be done with the following config:
-
-```
-config.active_record.time_zone_aware_types = [:datetime]
-```
-
 MongoDB Support
 ===============
 
@@ -294,10 +283,10 @@ Compatibility
 
 [![Build Status](https://travis-ci.org/jackc/tod.png)](https://travis-ci.org/jackc/tod)
 
-Tod is compatible with Ruby 1.9.3, 2.0.0, 2.1.8, and 2.2.0. It is tested against Rails 3.2, 4.0, 4.1, 4.2, 5.0.
+Tod is tested against Ruby 2.6.x and  Rails 6.x.
 
 
 License
 =======
 
-Copyright (c) 2010-2015 Jack Christensen, released under the MIT license
+Copyright (c) 2010-2021 Jack Christensen, released under the MIT license

data/lib/tod/railtie.rb

@@ -1,8 +1,11 @@
+require "active_model/type"
+require "active_record/type"
 require "tod/time_of_day_type"
 
 module Tod
   class Railtie < Rails::Railtie
-    initializer "tod.register_active_record_type" do
+    initializer "tod.register_active_model_type" do
+      ActiveModel::Type.register(:time_only, Tod::TimeOfDayType)
       ActiveRecord::Type.register(:time_only, Tod::TimeOfDayType)
     end
   end

data/lib/tod/shift.rb

@@ -33,20 +33,40 @@ module Tod
 
     # Returns true if ranges overlap, false otherwise.
     def overlaps?(other)
-      max_seconds = TimeOfDay::NUM_SECONDS_IN_DAY
-
-      # Standard case, when Shifts are on the same day
-      a, b = [self, other].map(&:range).sort_by(&:first)
-      op = a.exclude_end? ? :> : :>=
-      return true if a.last.send(op, b.first)
-
-      # Special cases, when Shifts span to the next day
-      return false if (a.last < max_seconds) && (b.last < max_seconds)
-
-      a = Range.new(a.first, a.last - max_seconds, a.exclude_end?) if a.last > max_seconds
-      b = Range.new(b.first, b.last - max_seconds, b.exclude_end?) if b.last > max_seconds
-      a, b = [a, b].sort_by(&:last)
-      b.last.send(op, a.last) && a.last.send(op, b.first)
+      a, b = [self, other].map(&:range)
+      #
+      #  Although a Shift which passes through midnight is stored
+      #  internally as lasting more than TimeOfDay::NUM_SECONDS_IN_DAY
+      #  seconds from midnight, that's not how it is meant to be
+      #  handled.  Rather, it consists of two chunks:
+      #
+      #    range.first => Midnight
+      #    Midnight => range.last
+      #
+      #  The second one is *before* the first.  None of it is more than
+      #  TimeOfDay::NUM_SECONDS_IN_DAY after midnight.  We thus need to shift
+      #  each of our ranges to cover all overlapping possibilities.
+      #
+      one_day = TimeOfDay::NUM_SECONDS_IN_DAY
+      ashifted =
+        Range.new(a.first + one_day, a.last + one_day, a.exclude_end?)
+      bshifted =
+        Range.new(b.first + one_day, b.last + one_day, b.exclude_end?)
+      #
+      #  For exclusive ranges we need:
+      #
+      #  a.ending > b.beginning && b.ending > a.beginning
+      #
+      #  and for inclusive we need:
+      #
+      #  a.ending >= b.beginning && b.ending >= a.beginning
+      #
+      aop = a.exclude_end? ? :> : :>=
+      bop = b.exclude_end? ? :> : :>=
+      #
+      (a.last.send(aop, b.first) && b.last.send(bop, a.first)) ||
+      (ashifted.last.send(aop, b.first) && b.last.send(bop, ashifted.first)) ||
+      (a.last.send(aop, bshifted.first) && bshifted.last.send(bop, a.first))
     end
 
     def contains?(shift)

data/lib/tod/time_of_day.rb

@@ -34,8 +34,8 @@ module Tod
     /x
 
     WORDS = {
-      "noon" => "12pm",
-      "midnight" => "12am"
+      "noon" => "12pm".freeze,
+      "midnight" => "12am".freeze
     }
 
     NUM_SECONDS_IN_DAY = 86400
@@ -43,9 +43,9 @@ module Tod
     NUM_SECONDS_IN_MINUTE = 60
 
     FORMATS = {
-      short: "%-l:%M %P",
-      medium: "%-l:%M:%S %P",
-      time: "%H:%M"
+      short: "%-l:%M %P".freeze,
+      medium: "%-l:%M:%S %P".freeze,
+      time: "%H:%M".freeze
     }
 
     def initialize(h, m=0, s=0)
@@ -89,7 +89,7 @@ module Tod
     def strftime(format_string)
       # Special case 2400 because strftime will load TimeOfDay into Time which
       # will convert 24 to 0
-      format_string.gsub!(/%H|%k/, '24') if @hour == 24
+      format_string = format_string.gsub(/%H|%k/, '24') if @hour == 24
       Time.local(2000,1,1, @hour, @minute, @second).strftime(format_string)
     end
 
@@ -106,6 +106,10 @@ module Tod
     end
     alias_method :to_s, :to_formatted_s
 
+    def value_for_database
+      to_s
+    end
+
     # Return a new TimeOfDay num_seconds greater than self. It will wrap around
     # at midnight.
     def +(num_seconds)
@@ -200,25 +204,5 @@ module Tod
     def self.time_zone
       (Time.respond_to?(:zone) && Time.zone) || Time
     end
-
-    def self.dump(time_of_day)
-      time_of_day =
-        if time_of_day.is_a? Hash
-           # rails multiparam attribute
-           # get hour, minute and second and construct new TimeOfDay object
-          ::Tod::TimeOfDay.new(time_of_day[4], time_of_day[5], time_of_day[6])
-        else
-          # return nil, if input is not parsable
-          Tod::TimeOfDay(time_of_day){}
-        end
-      time_of_day.to_s if time_of_day
-    end
-
-    def self.load(time)
-      if time && !time.to_s.empty?
-        return ::Tod::TimeOfDay.new(24) if time.respond_to?(:day) && time.day == 2 && time.hour == 0 && time.min == 0 && time.sec == 0
-        ::Tod::TimeOfDay(time)
-      end
-    end
   end
 end

data/lib/tod/time_of_day_type.rb

@@ -1,11 +1,18 @@
 module Tod
-  class TimeOfDayType < ActiveRecord::Type::Value
+  class TimeOfDayType < ActiveModel::Type::Value
     def cast(value)
-      TimeOfDay.load(value)
+      if value.is_a? Hash
+          # rails multiparam attribute
+          # get hour, minute and second and construct new TimeOfDay object
+        ::Tod::TimeOfDay.new(value[4], value[5], value[6])
+      else
+        # return nil, if input is not parsable
+        Tod::TimeOfDay(value){}
+      end
     end
 
     def serialize(value)
-      TimeOfDay.dump(value)
+      value.to_s if value.present?
     end
   end
 end

data/lib/tod/version.rb

@@ -1,3 +1,3 @@
 module Tod
-  VERSION = "2.2.0"
+  VERSION = "3.0.0"
 end

data/test/test_helper.rb

@@ -4,7 +4,6 @@ require 'bundler/setup'
 require 'active_support/time'
 require 'tod'
 require 'tod/core_extensions'
-require 'tod/arel_extensions'
 require 'minitest/autorun'
 require 'pry'
 

data/test/tod/shift_test.rb

@@ -99,6 +99,49 @@ describe "Shift" do
       shift2 = Tod::Shift.new(Tod::TimeOfDay.new(5), Tod::TimeOfDay.new(12), true)
       refute shift1.overlaps?(shift2)
     end
+
+    it "copes correctly with mixed shifts" do
+      shift1 = Tod::Shift.new(Tod::TimeOfDay.new(1), Tod::TimeOfDay.new(5))
+      shift2 = Tod::Shift.new(Tod::TimeOfDay.new(5), Tod::TimeOfDay.new(12), true)
+      assert shift1.overlaps?(shift2)
+      assert shift2.overlaps?(shift1)
+      shift1 = Tod::Shift.new(Tod::TimeOfDay.new(1), Tod::TimeOfDay.new(5), true)
+      shift2 = Tod::Shift.new(Tod::TimeOfDay.new(5), Tod::TimeOfDay.new(12))
+      refute shift1.overlaps?(shift2)
+      refute shift2.overlaps?(shift1)
+    end
+
+    it "copes correctly with zero length inclusive end shifts" do
+      shift1 = Tod::Shift.new(Tod::TimeOfDay.new(9), Tod::TimeOfDay.new(17))
+      shift2 = Tod::Shift.new(Tod::TimeOfDay.new(10), Tod::TimeOfDay.new(10))
+      shift3 = Tod::Shift.new(Tod::TimeOfDay.new(9), Tod::TimeOfDay.new(9))
+      shift4 = Tod::Shift.new(Tod::TimeOfDay.new(17), Tod::TimeOfDay.new(17))
+      assert shift1.overlaps?(shift2)
+      assert shift2.overlaps?(shift1)
+
+      assert shift1.overlaps?(shift3)
+      assert shift3.overlaps?(shift1)
+
+      assert shift1.overlaps?(shift4)
+      assert shift4.overlaps?(shift1)
+
+    end
+
+    it "copes correctly with zero length exclusive end shifts" do
+      shift1 = Tod::Shift.new(Tod::TimeOfDay.new(9), Tod::TimeOfDay.new(17), true)
+      shift2 = Tod::Shift.new(Tod::TimeOfDay.new(10), Tod::TimeOfDay.new(10), true)
+      shift3 = Tod::Shift.new(Tod::TimeOfDay.new(9), Tod::TimeOfDay.new(9), true)
+      shift4 = Tod::Shift.new(Tod::TimeOfDay.new(17), Tod::TimeOfDay.new(17), true)
+      assert shift1.overlaps?(shift2)
+      assert shift2.overlaps?(shift1)
+
+      refute shift1.overlaps?(shift3)
+      refute shift3.overlaps?(shift1)
+
+      refute shift1.overlaps?(shift4)
+      refute shift4.overlaps?(shift1)
+
+    end
   end
 
   describe "contains?" do

data/test/tod/time_of_day_attribute_test.rb

@@ -0,0 +1,74 @@
+require_relative '../test_helper'
+require File.expand_path(File.join(File.dirname(__FILE__),'..','support/active_record'))
+
+require 'tod/time_of_day_type'
+
+ActiveModel::Type.register(:time_only, Tod::TimeOfDayType)
+ActiveRecord::Type.register(:time_only, Tod::TimeOfDayType)
+
+class Order < ActiveRecord::Base
+  attribute :time, :time_only
+end
+
+describe "TimeOfDay with ActiveRecord Attribute" do
+  it "sets time of day" do
+    Order.create!(time: Tod::TimeOfDay.new(9, 30))
+  end
+
+  it "sets nil as value" do
+    Order.create!(time: nil)
+  end
+
+  it "works with multiparam time arguments" do
+    order = Order.create!({"time(4i)" => "8", "time(5i)" => "6", "time(6i)" => "5"})
+    assert_equal Tod::TimeOfDay.new(8,6,5), order.time
+  end
+
+  it "should not raise Exception on access of unparsable values" do
+    order = Order.new(time: 'unparsable')
+    order.time
+    assert order.valid?
+  end
+
+  it "should dump unparsable values to nil" do
+    assert_nil Order.new(time: '').time
+    assert_nil Order.new(time: 'unparsable').time
+    assert_nil Order.new(time: nil).time
+  end
+
+  it "loads set Tod::TimeOfDay" do
+    time_of_day = Tod::TimeOfDay.new(9, 30)
+    order = Order.create!(time: time_of_day)
+    order.reload
+    assert_equal order.time, time_of_day
+  end
+
+  it "loads set Time" do
+    time_of_day = Time.new(2015, 10, 21, 16, 29, 0, "-07:00")
+    order = Order.create!(time: time_of_day)
+    order.reload
+    assert_equal order.time, Tod::TimeOfDay.new(16, 29)
+  end
+
+  it "returns nil if time is not set" do
+    order = Order.create!(time: nil)
+    order.reload
+    assert_nil order.time
+  end
+
+  it "dump 24:00:00 and get it back" do
+    time_of_day = Tod::TimeOfDay.new(24, 0, 0)
+    order = Order.create!(time: time_of_day)
+    order.reload
+    assert_equal Tod::TimeOfDay.new(24), order.time
+  end
+
+  describe "Order.where" do
+    it "handles TimeOfDay as a parameter" do
+      tod = Tod::TimeOfDay.new(11, 11)
+      expected = Order.create!(time: tod)
+      actual = Order.where(time: tod).first
+      assert_equal expected, actual
+    end
+  end
+end

data/test/tod/time_of_day_test.rb

@@ -176,6 +176,13 @@ describe "TimeOfDay" do
     end
   end
 
+  describe "value_for_database" do
+    it "returns a formatted value for database query serialization" do
+      t = Tod::TimeOfDay.new(12,15,05)
+      assert_equal "12:15:05", t.value_for_database
+    end
+  end
+
   describe "to_s" do
     it "is aliased to to_formatted_s" do
       t = Tod::TimeOfDay.new(8,15,30)

data/tod.gemspec

@@ -16,10 +16,9 @@ Gem::Specification.new do |s|
   s.add_development_dependency "minitest"
   s.add_development_dependency "tzinfo"
   s.add_development_dependency "rake"
-  s.add_development_dependency "activerecord", ">= 3.0.0"
+  s.add_development_dependency "activerecord", ">= 6.0.0"
   s.add_development_dependency "sqlite3"
   s.add_development_dependency "pry-byebug"
-  s.add_development_dependency "arel"
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tod
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 3.0.0
 platform: ruby
 authors:
 - Jack Christensen
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-10-10 00:00:00.000000000 Z
+date: 2021-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 6.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 6.0.0
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -94,20 +94,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: arel
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Supplies TimeOfDay and Shift class that includes parsing, strftime, comparison,
   and arithmetic.
 email:
@@ -124,13 +110,7 @@ files:
 - MIT-LICENSE
 - README.markdown
 - Rakefile
-- gemfiles/4.0.gemfile
-- gemfiles/4.1.gemfile
-- gemfiles/4.2.gemfile
-- gemfiles/5.0.gemfile
-- gemfiles/5.2.gemfile
 - lib/tod.rb
-- lib/tod/arel_extensions.rb
 - lib/tod/conversions.rb
 - lib/tod/core_extensions.rb
 - lib/tod/date_extensions.rb
@@ -146,7 +126,7 @@ files:
 - test/tod/conversion_test.rb
 - test/tod/date_test.rb
 - test/tod/shift_test.rb
-- test/tod/time_of_day_serializable_attribute_test.rb
+- test/tod/time_of_day_attribute_test.rb
 - test/tod/time_of_day_test.rb
 - test/tod/time_of_day_time_zone_with_active_support_test.rb
 - test/tod/time_test.rb
@@ -155,7 +135,7 @@ homepage: https://github.com/JackC/tod
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -170,9 +150,17 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.0.6
+signing_key:
 specification_version: 4
 summary: Supplies TimeOfDay and Shift class
-test_files: []
+test_files:
+- test/support/active_record.rb
+- test/test_helper.rb
+- test/tod/conversion_test.rb
+- test/tod/date_test.rb
+- test/tod/shift_test.rb
+- test/tod/time_of_day_attribute_test.rb
+- test/tod/time_of_day_test.rb
+- test/tod/time_of_day_time_zone_with_active_support_test.rb
+- test/tod/time_test.rb

data/gemfiles/4.0.gemfile

@@ -1,5 +0,0 @@
-source "https://rubygems.org"
-
-gem "activerecord", "4.0.0"
-
-gemspec :path=>"../"

data/gemfiles/4.1.gemfile

@@ -1,5 +0,0 @@
-source "https://rubygems.org"
-
-gem "activerecord", "~> 4.1.8"
-
-gemspec :path=>"../"

data/gemfiles/4.2.gemfile

@@ -1,5 +0,0 @@
-source "https://rubygems.org"
-
-gem "activerecord", "~> 4.2.0"
-
-gemspec :path=>"../"

data/gemfiles/5.0.gemfile

@@ -1,5 +0,0 @@
-source "https://rubygems.org"
-
-gem 'activerecord', '~> 5.0.0.1'
-
-gemspec :path=>"../"

data/gemfiles/5.2.gemfile

@@ -1,5 +0,0 @@
-source "https://rubygems.org"
-
-gem 'activerecord', '~> 5.2.1'
-
-gemspec :path=>"../"

data/lib/tod/arel_extensions.rb

@@ -1,25 +0,0 @@
-require 'arel'
-
-module Tod
-  module ArelDepthFirstExtensions
-    def self.included(base)
-      base.send :alias_method, :visit_Tod_TimeOfDay, :terminal
-    end
-  end
-
-  module ArelDotExtensions
-    def self.included(base)
-      base.send :alias_method, :visit_Tod_TimeOfDay, :visit_String
-    end
-  end
-
-  module ArelToSqlExtensions
-    def visit_Tod_TimeOfDay(o, collector=nil)
-      quote Tod::TimeOfDay.dump(o)
-    end
-  end
-end
-
-Arel::Visitors::DepthFirst.send :include, Tod::ArelDepthFirstExtensions
-Arel::Visitors::Dot.send :include, Tod::ArelDotExtensions
-Arel::Visitors::ToSql.send :include, Tod::ArelToSqlExtensions

data/test/tod/time_of_day_serializable_attribute_test.rb

@@ -1,73 +0,0 @@
-require_relative '../test_helper'
-require File.expand_path(File.join(File.dirname(__FILE__),'..','support/active_record'))
-
-class Order < ActiveRecord::Base
-  serialize :time, Tod::TimeOfDay
-end
-
-describe "TimeOfDay with ActiveRecord Serializable Attribute" do
-  describe ".dump" do
-    it "sets time of day" do
-      Order.create!(time: Tod::TimeOfDay.new(9, 30))
-    end
-
-    it "sets nil as value" do
-      Order.create!(time: nil)
-    end
-
-    it "works with multiparam time arguments" do
-      order = Order.create!({"time(4i)" => "8", "time(5i)" => "6", "time(6i)" => "5"})
-      assert_equal Tod::TimeOfDay.new(8,6,5), order.time
-    end
-
-    it "should not raise Exception on access of unparsable values" do
-      order = Order.new(time: 'unparsable')
-      order.time
-      assert order.valid?
-    end
-
-    it "should dump unparsable values to nil" do
-      assert_nil Tod::TimeOfDay.dump('')
-      assert_nil Tod::TimeOfDay.dump('unparsable')
-      assert_nil Tod::TimeOfDay.dump(nil)
-    end
-  end
-
-  describe ".load" do
-    it "loads set Tod::TimeOfDay" do
-      time_of_day = Tod::TimeOfDay.new(9, 30)
-      order = Order.create!(time: time_of_day)
-      order.reload
-      assert_equal order.time, time_of_day
-    end
-
-    it "loads set Time" do
-      time_of_day = Time.new(2015, 10, 21, 16, 29, 0, "-07:00")
-      order = Order.create!(time: time_of_day)
-      order.reload
-      assert_equal order.time, Tod::TimeOfDay.new(16, 29)
-    end
-
-    it "returns nil if time is not set" do
-      order = Order.create!(time: nil)
-      order.reload
-      assert_nil order.time
-    end
-
-    it "dump 24:00:00 and get it back" do
-      time_of_day = Tod::TimeOfDay.new(24, 0, 0)
-      order = Order.create!(time: time_of_day)
-      order.reload
-      assert_equal Tod::TimeOfDay.new(24), order.time
-    end
-  end
-
-  describe "Order.where" do
-    it "handles TimeOfDay as a parameter" do
-      tod = Tod::TimeOfDay.new(11, 11)
-      expected = Order.create!(time: tod)
-      actual = Order.where(time: tod).first
-      assert_equal expected, actual
-    end
-  end
-end