tkh_mailing_list 0.10.2 → 0.10.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b5a07a6988a466c208dd6b462bfebfb7aedaa4a
-  data.tar.gz: b90dde936c41b4fdf2a36cb5e558698173e2be24
+  metadata.gz: 9bce2ea0d41e83f9b53c8d4b9a3b9a9c7dda0b8b
+  data.tar.gz: ee57b96e0e0a1e3709f2b706ae570a7a7cb1bd11
 SHA512:
-  metadata.gz: 17f8e03f0e9706e00ef363b5260c8c355cb89d0d8163ec08050fefa9c9c09e4a1cc4eb774b5af7ae540ef2175d5e11f313054796726266c48f276d8bb6e252da
-  data.tar.gz: a8bea57a1b7ed011177efd05e7c51e4b9d872980d412593bfb59997f14c784d882a2bf98d40f7f15a878d1d072580bd9fe869ec8d5fc7f37a899b87dd54d6ce4
+  metadata.gz: e68e2a0a3b33591cb408aaa26952046f150cfeefaafc55120f6209a5d0150f1bd9189c2410415aa7fe48a08c9463eef554a468384aa353b5e9036f91e27904dc
+  data.tar.gz: 1cc652572aa327c2001ed0f4c02db5036dc910d19d0c279e28736388558cd91f3d34995b07e56fab8e26772064e76f4b19de31ae133961778c7e6c169f1c15d2

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 
 
+## 0.10.3
+
+* Added rel-nofollow to public profile links.
+* Removed http and https from profile link anchors.
+* Debugged and improved public profile view and links.
+
+
 ## 0.10.2
 
 * Imported manually the jcrop files so host application does not need to install any gems.

data/app/helpers/members_helper.rb

@@ -0,0 +1,11 @@
+module  MembersHelper
+
+  def abridged_url(str)
+    if str.present?
+      uri = URI(str)
+      "#{uri.host}#{uri.path}#{uri.query}#{uri.fragment}"
+    else # string is blank
+      ''
+    end
+  end
+end

data/app/views/members/show.html.erb

@@ -2,26 +2,26 @@
 <% content_for :meta_description, "Public profile for #{@member.name}" %>
 
 <div id="profile-title">
-  <% if student.other_name.present? %>
+  <% if @member.other_name.present? %>
     <h1>
-      <%= student.other_name %><br />
-      <span class="secondary-name"><%= student.name %></span>
+      <%= @member.other_name %><br />
+      <span class="secondary-name"><%= @member.name %></span>
     </h1>
   <% else %>
-    <h1><%= student.name %></h1>
+    <h1><%= @member.name %></h1>
   <% end %>
   <% if Profile.find(@member.id).portrait.present? %>
-    <p id="profile-portrait"><%= image_tag Profile.find(@member.id).portrait_url(:small), title: student.name, alt: student.name, id: 'profile-portrait' %></p>
+    <p id="profile-portrait"><%= image_tag Profile.find(@member.id).portrait_url(:small), title: @member.name, alt: @member.name, id: 'profile-portrait' %></p>
   <% end %>
 </div>
 
 <table id="profile-attributes">
   <tbody>
-    <tr><td class="key">website</td><td class="value"><%= link_to student.website_url, student.website_url %></td></tr>
-    <tr><td class="key">facebook</td><td class="value"><%= link_to student.facebook_url, student.facebook_url %></td></tr>
-    <tr><td class="key">twitter</td><td class="value"><%= link_to student.twitter_handle, "https://twitter.com/#{student.twitter_handle}" %></td></tr>
-    <tr><td class="key">google+</td><td class="value"><%= link_to student.google_plus_url, student.google_plus_url %></td></tr>
-    <%= render 'profiles/custom_public_profile_attributes' %>
+    <tr><td class="key">website</td><td class="value"><%= link_to abridged_url(@member.website_url), @member.website_url, rel: 'nofollow' %></td></tr>
+    <tr><td class="key">facebook</td><td class="value"><%= link_to abridged_url(@member.facebook_url), @member.facebook_url, rel: 'nofollow' %></td></tr>
+    <tr><td class="key">twitter</td><td class="value"><%= @member.twitter_handle.present? ? link_to( @member.twitter_handle, "https://twitter.com/#{@member.twitter_handle}", rel: 'nofollow' ) : '' %></td></tr>
+    <tr><td class="key">google+</td><td class="value"><%= link_to abridged_url(@member.google_plus_url), @member.google_plus_url, rel: 'nofollow' %></td></tr>
+    <%= render 'profiles/custom_public_profile_attributes', member: @member %>
   </tbody>
 </table>
 

data/app/views/profiles/show.html.erb

@@ -35,10 +35,10 @@
     <tr><td class="key">first name</td><td class="value"><%= @profile.first_name %></td></tr>
     <tr><td class="key">last name</td><td class="value"><%= @profile.last_name %></td></tr>
     <tr><td class="key"><%= render 'shared/other_name_label' %></td><td class="value"><%= @profile.other_name %></td></tr>
-    <tr><td class="key">website</td><td class="value"><%= link_to student.website_url, student.website_url %></td></tr>
-    <tr><td class="key">facebook</td><td class="value"><%= link_to student.facebook_url, student.facebook_url %></td></tr>
-    <tr><td class="key">twitter</td><td class="value"><%= link_to student.twitter_handle, "https://twitter.com/#{student.twitter_handle}" %></td></tr>
-    <tr><td class="key">google+</td><td class="value"><%= link_to student.google_plus_url, student.google_plus_url %></td></tr>
+    <tr><td class="key">website</td><td class="value"><%= link_to "#{URI(student.website_url).host}#{URI(student.website_url).path}#{URI(student.website_url).query}#{URI(student.website_url).fragment}", student.website_url, rel: 'nofollow' %></td></tr>
+    <tr><td class="key">facebook</td><td class="value"><%= link_to "#{URI(student.facebook_url).host}#{URI(student.facebook_url).path}#{URI(student.facebook_url).query}#{URI(student.facebook_url).fragment}", student.facebook_url, rel: 'nofollow' %></td></tr>
+    <tr><td class="key">twitter</td><td class="value"><%= link_to student.twitter_handle, "https://twitter.com/#{student.twitter_handle}", rel: 'nofollow' %></td></tr>
+    <tr><td class="key">google+</td><td class="value"><%= link_to "#{URI(student.google_plus_url).host}#{URI(student.google_plus_url).path}#{URI(student.google_plus_url).query}#{URI(student.google_plus_url).fragment}", student.google_plus_url, rel: 'nofollow' %></td></tr>
     <%= render 'custom_public_profile_attributes' %>
 
   </tbody>

data/lib/tkh_mailing_list/version.rb

@@ -1,3 +1,3 @@
 module TkhMailingList
-  VERSION = "0.10.2"
+  VERSION = "0.10.3"
 end

data/tkh_mailing_list.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Swami Atma"]
   spec.email         = ["swami@TenThousandHours.eu"]
   spec.description   = %q{A mailing list module to work with tkh_authentication gem}
-  spec.summary       = %q{This gem inherits from the tkh_authentication gem and allow administrators to manage user records}
+  spec.summary       = %q{This gem inherits from the tkh_authentication gem and allows administrators to manage user records}
   spec.homepage      = "https://github.com/allesklar/tkh_mailing_list"
   spec.license       = "MIT"
 
@@ -18,8 +18,6 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  # spec.add_dependency   'jcrop-rails-v2'
-
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tkh_mailing_list
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 0.10.3
 platform: ruby
 authors:
 - Swami Atma
@@ -59,6 +59,7 @@ files:
 - app/controllers/details_controller.rb
 - app/controllers/members_controller.rb
 - app/controllers/profiles_controller.rb
+- app/helpers/members_helper.rb
 - app/models/detail.rb
 - app/models/member.rb
 - app/models/profile.rb
@@ -120,6 +121,6 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: This gem inherits from the tkh_authentication gem and allow administrators
+summary: This gem inherits from the tkh_authentication gem and allows administrators
   to manage user records
 test_files: []