tkh_content 0.10.6 → 0.10.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0d951dd93ce0701b8f607b73cafe41969914202c
-  data.tar.gz: de8a4b6e98b7d0da145ede1686ed8efa57352b24
+  metadata.gz: 55391869340e129ff0ab0c1c0da3d4edf682240d
+  data.tar.gz: bab8e99e206689e2fe6ab863a6cef46ed72c1b25
 SHA512:
-  metadata.gz: 4c911b617d4d1667d68cd0ab6e4f6cb41dc02c3b757fc44178a964ba2d80dbf5b520d1ce355bee6021092489685789387f4cc3ad3ada99910307db89cc79540e
-  data.tar.gz: 0020551ba14ddb59c5bc356e1a0794b2a1ad7e9e9f09c5ab2c951675e60d511bc9f5f4048810796c016ef60cd87f379d5a3b106ac05a75e8e75c6953f1c006d2
+  metadata.gz: 1a241b5f3496fe18c4b585119059ad05d3127ed3111fc8c708c3593e5a404fd71a514f59cf976cf11c5a583bc4273752575dd6a71e671bbf0068aa49ced55958
+  data.tar.gz: bb2fc414805a838d3971055efd899ac0028bbbb76873fd46f0fddae1731db487a4f2660d3f49e60aba41eb2ba077c99c1e8abec89302fdbda6171e5a8d063e98

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 
 
+## 0.10.7
+
+* Debugged blog#by_tag method and view when there were no posts for a specific tag. Can happen with a non-translated bi-lingual post.
+
+
 ## 0.10.6
 
 * Added translation for comments admin digest list.

data/app/controllers/blog_controller.rb

@@ -9,11 +9,17 @@ class BlogController < ApplicationController
   end
 
   def by_tag
+    # this is necessary to deal with instances when no posts are present for that tag
+    @tag_name = params[:id]
     # this little hack is necessary because globalize won't let me access the tag directly by name
-    tag_id = Tag::Translation.find_by( locale: I18n.locale.to_s, name: params[:id] ).tag_id
-    @tag = Tag.find(tag_id)
-    @posts = @tag.pages.published.order('published_at desc').paginate(:page => params[:page], :per_page => 20)
-    render :layout => 'blog'
+    tag = Tag::Translation.find_by( locale: I18n.locale.to_s, name: @tag_name )
+    if tag.present?
+      @tag = Tag.find(tag.tag_id)
+      @posts = @tag.pages.published.order('published_at desc').paginate(:page => params[:page], :per_page => 20)
+      render :layout => 'blog'
+    else
+      @posts = nil
+    end
   end
 
 end

data/app/views/blog/by_tag.html.erb

@@ -1,24 +1,24 @@
 <% content_for :meta_title, Setting.first.try(:company_name) %>
-<% content_for :meta_description, "Blog posts with the '#{@tag.name}' tag." %>
+<% content_for :meta_description, "Blog posts with the '#{@tag_name}' tag." %>
 <% content_for :canonical_link, link_to('', blog_path, rel: 'canonical') %>
 
 <div class="panel panel-info">
   <div class="panel-heading">
-    <h3 class="panel-title"><%= "#{@tag.name} (#{@tag.taggings.count})" %></h3>
+    <h3 class="panel-title"><%= "#{@tag_name} (#{@tag.present? ? @tag.taggings.count : '0'})" %></h3>
   </div>
   <div class="panel-body">
-    Liste des articles avec cette étiquette
+    <%= @posts.nil? ? t('tags.no_posts_to_show') : t('tags.list_of_posts') %>
   </div>
 </div>
 
-<%= will_paginate @posts, inner_window: 2 %>
-
-<% for post in @posts %>
-  <%= render '/pages/individual_blog_post_in_list', post: post %>
+<% unless @posts.nil? %>
+  <%= will_paginate @posts, inner_window: 2 %>
+  <% for post in @posts %>
+    <%= render '/pages/individual_blog_post_in_list', post: post %>
+  <% end %>
+  <%= will_paginate @posts, inner_window: 2 %>
 <% end %>
 
-<%= will_paginate @posts, inner_window: 2 %>
-
 <%= render 'all_tags_list' %>
 <%= render( 'admin_context_menu', page: @page) %>
 <%# partial in tkh_menus gem or has to be added in host app %>

data/lib/generators/tkh_content/create_or_update_locales/templates/de.yml

@@ -66,6 +66,9 @@ de:
     hint:
       name: 'Lower case only. Multiple words should be joined by a dash (-) and NOT spaces'
 
+    list_of_posts: List of blog posts with this tag
+    no_posts_to_show: There are no posts with this tag
+
 
   comments:
     digest_intro: 'List of non-moderated comments from users:'

data/lib/generators/tkh_content/create_or_update_locales/templates/en.yml

@@ -66,6 +66,9 @@ en:
     hint:
       name: 'Lower case only. Multiple words should be joined by a dash (-) and NOT spaces'
 
+    list_of_posts: List of blog posts with this tag
+    no_posts_to_show: There are no posts with this tag
+
   comments:
     digest_intro: 'List of non-moderated comments from users:'
     login_needed: 'You need to be logged in to leave a comment'

data/lib/generators/tkh_content/create_or_update_locales/templates/es.yml

@@ -66,6 +66,9 @@ es:
     hint:
       name: 'Lower case only. Multiple words should be joined by a dash (-) and NOT spaces'
 
+    list_of_posts: List of blog posts with this tag
+    no_posts_to_show: There are no posts with this tag
+
   comments:
     digest_intro: 'List of non-moderated comments from users:'
     login_needed: 'You need to be logged in to leave a comment'

data/lib/generators/tkh_content/create_or_update_locales/templates/fr.yml

@@ -66,6 +66,9 @@ fr:
     hint:
       name: 'Pas de majuscules, que des minuscules. Entre les mots multiples, utilisez un tiret ( - ), pas avec un espace.'
 
+    list_of_posts: Liste des articles avec cette étiquette
+    no_posts_to_show: Il n'y a pas d'articles avec cette étiquette
+
 
   comments:
     digest_intro: 'Liste des commentaires en attente de revue :'

data/lib/tkh_content/version.rb

@@ -1,3 +1,3 @@
 module TkhContent
-  VERSION = "0.10.6"
+  VERSION = "0.10.7"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tkh_content
 version: !ruby/object:Gem::Version
-  version: 0.10.6
+  version: 0.10.7
 platform: ruby
 authors:
 - Swami Atma
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-19 00:00:00.000000000 Z
+date: 2015-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -278,7 +278,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.4
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Rails engine running pages and blog posts.