titler 0.4.4 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 51c3b8c39cea79ca4a980b8e94d9340b767c2eba
-  data.tar.gz: 120347193ab92790dbce2ef753961a0c71f20ced
+  metadata.gz: 7640ad0f1e74af13977c990d48e0a415e9da53cb
+  data.tar.gz: 7f0252467cf3b2fdb2b5ea59890bcae8498e30ce
 SHA512:
-  metadata.gz: b805ae7d3553b134a6965eb7671fab6c489c38d1c3b5d3f924ccc7181d6361a1869fdfd029dcdcf48a5246147647ac3b7524897cd1f1e4c9d69193c9a45936d7
-  data.tar.gz: d497dcba674cb65fb0ee88e4b432872ef0801f97c9e93120d0dca686dbab0cc93b6f40e137194c8f0709ff4aab50d16613c7d1d2b8c35fb11980403613bb67d2
+  metadata.gz: 05a2ba2169caa18b33702128119b92d28223a355bad6a8cab97482a797488476c4060b86fbe099e2ce59b4167044eb1282e4bd8755c67d7cb1c102e50d825adb
+  data.tar.gz: d4436a7b16d2e63d37dd77cbbd190d4ea11fba23f73175029292657c6685befd72b047b69afb74185be0f89ce5bef5d96722052c4a29736b42ed8bb5ecf3e598

data/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2017 Robert Travis Pierce
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/app/helpers/titler/titler_helper.rb

@@ -20,7 +20,7 @@ module Titler
         @i18n = i18n
         @title_as_set = title_as_set
         @context = context
-        @configuration = Configuration.new
+        @configuration = Titler.configuration
       end
 
       def to_s

data/lib/titler/version.rb

@@ -1,3 +1,3 @@
 module Titler
-  VERSION = '0.4.4'
+  VERSION = '1.0.0'
 end

data/spec/configure_spec.rb

@@ -1,12 +1,28 @@
 require 'spec_helper'
 require 'titler'
 
+class ManagerController; end
+
 module Titler
   describe Configuration do
 
     context 'with configuration block' do
-      it 'returns the use_env_prefix' do
-        expect(Titler.configuration.use_env_prefix).to be true
+      it 'uses the options in the configuration block instead of defaults' do
+        Titler.configure do |config|
+          config.admin_controller = ManagerController
+          config.admin_name = 'Manager'
+          config.app_name_position = 'prepend'
+          config.delimiter = ' | '
+          config.use_app_tagline = false
+          config.use_env_prefix = false
+        end
+
+        expect(Titler.configuration.admin_controller).to eq ManagerController
+        expect(Titler.configuration.admin_name).to eq 'Manager'
+        expect(Titler.configuration.app_name_position).to eq 'prepend'
+        expect(Titler.configuration.delimiter).to eq ' | '
+        expect(Titler.configuration.use_app_tagline).to eq false
+        expect(Titler.configuration.use_env_prefix).to eq false
       end
     end
 

data/spec/helpers/titler_helper_spec.rb

@@ -95,6 +95,19 @@ describe Titler::TitlerHelper do
 
 # Configuration Values Context ----------------------------------------------------
   context 'when titler configuration values exist' do
+    it 'uses the options in the configuration block instead of defaults' do
+      controller = MockController.new
+      stub_rails(controller, 'production', nil)
+      load_translations({})
+
+      Titler.configure do |config|
+        config.delimiter = ' | '
+      end
+
+      expect(titler_helper.titler).to include('|')
+
+      Titler.reset
+    end
   end
 
   def stub_rails(controller, env_str, content_for)
@@ -116,8 +129,6 @@ describe Titler::TitlerHelper do
     I18n.backend.store_translations(:en, { titler: titles })
   end
 
-  # TODO: Can this be right? I'm using what is essentially a private method from inside titler to
-  # set up tests for titler. Just for the sake of saving some lines of code.
   def env_prefix
     Rails.env.production? ? '' : "(#{Rails.env[0,1].upcase}) "
   end
@@ -170,13 +181,4 @@ describe Titler::TitlerHelper do
   def titler_helper
     @titler_helper ||= Class.new { include Titler::TitlerHelper }.new
   end
-
-  # def helper
-  #   Helper.new
-  # end
-  #
-  # class Helper
-  #   include Singleton
-  #   include ActionView::Helpers::CaptureHelper
-  # end
 end

data/titler.gemspec

@@ -6,7 +6,7 @@ require 'titler/version'
 Gem::Specification.new do |spec|
   spec.name          = "titler"
   spec.version       = Titler::VERSION
-  spec.authors       = ["Robert Travis Pierce"]
+  spec.authors       = ["Robert Travis Pierce", "Jonathan Allured"]
   spec.email         = ["robert@roberttravispierce.com"]
 
   spec.summary       = %q{Titler is a ruby gem that automaticaly gives you useful and consistent page titles for your Rails application.}

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: titler
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 1.0.0
 platform: ruby
 authors:
 - Robert Travis Pierce
+- Jonathan Allured
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-10 00:00:00.000000000 Z
+date: 2017-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -236,6 +237,7 @@ files:
 - ".ruby-version"
 - ".travis.yml"
 - Gemfile
+- LICENSE
 - README.md
 - Rakefile
 - app/helpers/titler/titler_helper.rb