title 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6c795ba3f15ebae717a82a25f1972ab853e73419
-  data.tar.gz: 2f62923f88cd8dc69abb7859de3c006e8f605876
+  metadata.gz: 03f9667e1be4fe850bb8d230b5a564eca382c5e5
+  data.tar.gz: 6151b9dd9a956ef25ffd803f5d65613480c72148
 SHA512:
-  metadata.gz: b6a8492f732db46220af427baeb074b136bde549699e860e17f3ec544195dcc260af77141638c63a79602a5082280def5c7c09d29b1d4f490de2d56506450211
-  data.tar.gz: 39b3e5a49237c4e5f8d07c4fef6f734b010cb56d74aecbb9ed153e945f23fc66e5ed1c0c1d9960e95891b82ef7049eb7a7f5b2fd69f38649c03a1927c3a1583e
+  metadata.gz: 22c49852733852b6a395f569f65965db25d04607784eee8f2788c5eeab2a3a58f21eac4b016413165f6cebb03a2461a7b31b3c81d07ce173f0722456831b80c2
+  data.tar.gz: f23398d952d9941c116badc046e8a6003b71837637039b32de85abdabca4dc7dc62a90f963865b5772191a4e259d20b63b0147345a6d22006acd28a5f9b28010

data/CONTRIBUTING.md

@@ -0,0 +1,39 @@
+# Contributing
+
+We love pull requests. Here's a quick guide:
+
+1. Fork the repo.
+2. Run the tests. We only take pull requests with passing tests, and it's great
+   to know that you have a clean slate: `bundle && rake`
+3. Add a test for your change. Only refactoring and documentation changes
+   require no new tests. If you are adding functionality or fixing a bug, we need
+   a test!
+4. Make the test pass.
+5. Make sure your changes adhere to the [thoughtbot Style
+   Guide](https://github.com/thoughtbot/guides/tree/master/style)
+6. Push to your fork and submit a pull request.
+7. At this point you're waiting on us. We like to at least comment on, if not
+   accept, pull requests within three business days (and, typically, one business
+   day). [We may suggest some changes or improvements or
+   alternatives](https://github.com/thoughtbot/guides/tree/master/code-review).
+
+## Increase your chances of getting merged
+
+Some things that will increase the chance that your pull request is accepted,
+taken straight from the Ruby on Rails guide:
+
+* Use Rails idioms and helpers
+* Include tests that fail without your code, and pass with it
+* Update the documentation: that surrounding your change, examples elsewhere,
+  guides, and whatever else is affected by your contribution
+* Syntax:
+    * Two spaces, no tabs.
+    * No trailing whitespace. Blank lines should not have any space.
+    * Make sure your [source files end with newline
+      characters](http://stackoverflow.com/questions/729692/why-should-files-end-with-a-newline#answer-729725).
+    * Prefer `&&`/`||`  over `and`/`or`.
+    * `MyClass.my_method(my_arg)` not `my_method( my_arg )` or
+      `my_method my_arg`.
+    * `a = b` and not `a=b`.
+    * Follow the conventions you see used in the source already.
+* And in case we didn't emphasize it enough: *We love tests!*

data/README.md

@@ -30,3 +30,13 @@ def to_s
   name
 end
 ```
+
+## Acknowledgement
+
+Though the idea of translating titles was arrived at seperately, [Brandon
+Keepers] wrote [Abusing Rails I18N to Set Page Titles] which outlines an
+extremely similar approach, and from whence came the idea of using the view
+context to get local assigns to be used in interpolation.
+
+[Brandon Keepers]: https://github.com/bkeepers
+[Abusing Rails I18N to Set Page Titles]: http://opensoul.org/blog/archives/2012/11/05/abusing-rails-i18n-to-set-page-titles/

data/lib/title.rb

@@ -1,7 +1,7 @@
 require 'title/version'
 require 'rails/engine'
 require 'title/engine'
-require 'title/helpers/title_helper'
+require 'helpers/title/title_helper'
 
 module Title
   # Your code goes here...

data/lib/title/version.rb

@@ -1,3 +1,3 @@
 module Title
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/helpers/title_helper_spec.rb

@@ -1,5 +1,4 @@
 require 'rubygems'
-require 'pry'
 require 'title'
 
 describe Title::TitleHelper do

data/title.gemspec

@@ -23,5 +23,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec'
 
   spec.add_dependency 'rails', '>= 3.1'
-  spec.add_dependency 'I18n'
+  spec.add_dependency 'i18n'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: title
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Caleb Thompson
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
-  name: I18n
+  name: i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -88,11 +88,12 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- app/title/helpers/title_helper.rb
+- app/helpers/title/title_helper.rb
 - lib/title.rb
 - lib/title/engine.rb
 - lib/title/version.rb