tinybucket 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 24e3536cf6f81ae670df0d854aca916d60ab010d
-  data.tar.gz: 2d59c8468bb0a79a5a6ce76d1a7858817fbcc7f7
+  metadata.gz: df8de5bb4a23d41681373aca721509d6ed520902
+  data.tar.gz: a0e0d3fc7485d3f065ae93aef7b92d7b32f31b8b
 SHA512:
-  metadata.gz: 1217df53d313c34644437182696fcb2741813c40af241057bbab8c925491b6a3a44a7c1d9eeea534d64306ab0834b80c01de2ab649c465dd8ec85cc577c72a55
-  data.tar.gz: 6badf2bcc2aabb16604f3cea9274723c704dddee46af91050534032fdae72f31f12e127f5fde5d8225f5d43dfc1c1187cb856313ba7a66aee0ca0071a826e77e
+  metadata.gz: 5456f3c17cbe2ee7fde00fc7609059da637326575cebe64ec717ea8dde55130205d6a3c1a73e5bd8a7d9f7f830f79c4a4362f934b5901ca5362e00335cdeb33b
+  data.tar.gz: fc4c4969316d1294247c251d02a8e06219095f3701a77f46b5013a028515160ea80806025565fc39317a0b0e251485de781edaf7a154ec28eda880617212b080

data/README.md

@@ -34,6 +34,23 @@ Or install it yourself as:
 
 NOTE: `x` mark means `Already implemented.`.
 
+### Configure
+
+#### Configure logger
+
+This gem use built-in null_logger in default.
+
+If you want to set your logger, configure like this.
+
+```
+logger = Logger.new($stdout)
+logger.level = Logger::WARN
+
+Tinybucket.configure do |config|
+  config.logger = logger
+end
+```
+
 ### init
 
 ```

data/lib/tinybucket/config.rb

@@ -0,0 +1,6 @@
+module Tinybucket
+  class Config
+    include ActiveSupport::Configurable
+    config_accessor :logger
+  end
+end

data/lib/tinybucket/model/base.rb

@@ -17,9 +17,9 @@ module Tinybucket
       end
 
       def attributes=(hash)
-        hash.each do |key, value|
+        hash.each_pair do |key, value|
           if acceptable_attribute?(key)
-            send("#{key}=", value)
+            send("#{key}=".intern, value)
           else
             # rubocop:disable Metrics/LineLength
             logger.warn("Ignored '#{key}' attribute (value: #{value}). [#{self.class}]")
@@ -28,7 +28,11 @@ module Tinybucket
         end
       end
 
-      alias_method :attributes, :acceptable_attributes
+      def attributes
+        acceptable_attributes.map do |key|
+          { key => send(key.intern) }
+        end.reduce(&:merge)
+      end
 
       protected
 

data/lib/tinybucket/null_logger.rb

@@ -0,0 +1,35 @@
+module Tinybucket
+  class NullLogger
+    attr_accessor :level
+
+    def fatal(_progname = nil, &_block); end
+
+    def fatal?
+      false
+    end
+
+    def error(_progname = nil, &_block); end
+
+    def error?
+      false
+    end
+
+    def warn(_progname = nil, &_block); end
+
+    def warn?
+      false
+    end
+
+    def info(_progname = nil, &_block); end
+
+    def info?
+      false
+    end
+
+    def debug(_progname = nil, &_block); end
+
+    def debug?
+      false
+    end
+  end
+end

data/lib/tinybucket/version.rb

@@ -1,3 +1,3 @@
 module Tinybucket
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

data/lib/tinybucket.rb

@@ -15,6 +15,8 @@ require 'active_model'
 
 require 'logger'
 
+require 'tinybucket/config'
+require 'tinybucket/null_logger'
 require 'tinybucket/api'
 require 'tinybucket/api_factory'
 require 'tinybucket/api/helper'
@@ -52,12 +54,16 @@ module Tinybucket
       @api_client = Tinybucket::Client.new(options, &block)
     end
 
+    def configure
+      yield(config)
+    end
+
+    def config
+      @config ||= Tinybucket::Config.new
+    end
+
     def logger
-      @logger ||= begin
-                    logger = Logger.new($stdout)
-                    logger.level = Logger::DEBUG
-                    logger
-                  end
+      config.logger || Tinybucket::NullLogger.new
     end
   end
 end

data/spec/lib/tinybucket/null_logger_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+RSpec.describe Tinybucket::NullLogger do
+  subject { Tinybucket::NullLogger.new }
+
+  describe '#level' do
+    it { expect(subject).to respond_to(:level) }
+  end
+
+  describe '#level=' do
+    it { expect(subject).to respond_to(:level=) }
+  end
+
+  describe '#fatal' do
+    it { expect(subject).to respond_to(:fatal) }
+  end
+
+  describe '#fatal?' do
+    it { expect(subject.fatal?).to be_falsey }
+  end
+
+  describe '#error' do
+    it { expect(subject).to respond_to(:error) }
+  end
+
+  describe '#error?' do
+    it { expect(subject.error?).to be_falsey }
+  end
+
+  describe '#warn' do
+    it { expect(subject).to respond_to(:warn) }
+  end
+
+  describe '#warn?' do
+    it { expect(subject.warn?).to be_falsey }
+  end
+
+  describe '#info' do
+    it { expect(subject).to respond_to(:info) }
+  end
+
+  describe '#info?' do
+    it { expect(subject.info?).to be_falsey }
+  end
+
+  describe '#debug' do
+    it { expect(subject).to respond_to(:debug) }
+  end
+
+  describe '#debug?' do
+    it { expect(subject.debug?).to be_falsey }
+  end
+end

data/spec/lib/tinybucket_spec.rb

@@ -29,4 +29,28 @@ RSpec.describe Tinybucket do
       it_behaves_like 'return client which configured with options'
     end
   end
+
+  describe 'config' do
+    subject { Tinybucket.config }
+    it { expect(subject).to be_an_instance_of(Tinybucket::Config) }
+  end
+
+  describe 'configure' do
+    subject(:config) { Tinybucket.config }
+    let(:logger) { Logger.new($stdout) }
+
+    it 'can configurable logger' do
+      expect(config.logger).to be_nil
+
+      expect do
+        Tinybucket.configure do |config|
+          config.logger = logger
+        end
+      end.not_to raise_error
+
+      expect(config.logger).to eq(logger)
+    end
+
+    after { Tinybucket.configure { |config| config.logger = nil } }
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tinybucket
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - hirakiuc
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-06 00:00:00.000000000 Z
+date: 2015-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -255,6 +255,7 @@ files:
 - lib/tinybucket/api/user_api.rb
 - lib/tinybucket/api_factory.rb
 - lib/tinybucket/client.rb
+- lib/tinybucket/config.rb
 - lib/tinybucket/connection.rb
 - lib/tinybucket/constants.rb
 - lib/tinybucket/error.rb
@@ -275,6 +276,7 @@ files:
 - lib/tinybucket/model/pull_request.rb
 - lib/tinybucket/model/repository.rb
 - lib/tinybucket/model/team.rb
+- lib/tinybucket/null_logger.rb
 - lib/tinybucket/parser.rb
 - lib/tinybucket/parser/base_parser.rb
 - lib/tinybucket/parser/branch_restriction_parser.rb
@@ -355,6 +357,7 @@ files:
 - spec/lib/tinybucket/model/pull_request_spec.rb
 - spec/lib/tinybucket/model/repository_spec.rb
 - spec/lib/tinybucket/model/team_spec.rb
+- spec/lib/tinybucket/null_logger_spec.rb
 - spec/lib/tinybucket_spec.rb
 - spec/spec_helper.rb
 - spec/support/api_response_macros.rb
@@ -381,7 +384,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: ruby wrapper for the Bitbucket REST API (v2) with oauth
@@ -446,6 +449,7 @@ test_files:
 - spec/lib/tinybucket/model/pull_request_spec.rb
 - spec/lib/tinybucket/model/repository_spec.rb
 - spec/lib/tinybucket/model/team_spec.rb
+- spec/lib/tinybucket/null_logger_spec.rb
 - spec/lib/tinybucket_spec.rb
 - spec/spec_helper.rb
 - spec/support/api_response_macros.rb