tiny_sweeper 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7f01b1523f85b42ff7dab6b0a3f5f45f7fc0fef1
-  data.tar.gz: 44f3c34cd71b6b9ca16aaa8ff6f972bc49f3d4cf
+  metadata.gz: d882388d33abc912ce5a2053ca3875fa522de795
+  data.tar.gz: 9ba763bf797822519587ff6dd9083bb09ec8bac1
 SHA512:
-  metadata.gz: f69edb529e29a9496b7d72bb5fa91fe9932ddd7600e337b1056798625633313a9af87cc4eef7abe20a6eafd8e267f12c360572bb807850a779f4ccf77f7e6507
-  data.tar.gz: 7fa70945f24ed1f00d7365efaf7f2e1aef4eeacbc7c16ec0e3ff64916876beae8f5a62d9735f95428f787ff3efd3d32fe90d5d0fcf5f0702f6f671fa7b8ad6ac
+  metadata.gz: 7801be0bb60028f792f690d3027851a3d686070b2b57bce51dab5802171680ac5e75783621a537ff4ba0f526887a7369c4f49479b60db5efa4783e0b3a7e23d6
+  data.tar.gz: 1085c3a1a2f13dc85ccd99f6e667fb1c31c6c55ca9878f4967c886b843bfa9b061bfd03e0ec0105c7d4e9deaa6a01a41de011d70acf9a5eab5f651a8a1cae2ec

data/.travis.yml

@@ -3,4 +3,3 @@ rvm:
   - 2.2
   - 2.1
   - 2.0
-  - 1.9

data/README.md

@@ -11,10 +11,10 @@ It's a handy way to clean attributes on your Rails models, though it's independe
 
 ```ruby
 class Sundae
-  attr_accessor :topping
+  attr_accessor :ice_cream, :topping
 
   include TinySweeper
-  sweep(:topping) { |topping| topping.strip.downcase }
+  sweep(:ice_cream, :topping) { |flavor| flavor.strip.downcase }
 end
 ```
 
@@ -22,8 +22,10 @@ Now your Sundae toppings will be tidied up:
 
 ```ruby
 dessert = Sundae.new
+dessert.ice_cream = '   CHOCOlate  '
 dessert.topping = ' ButTTERscotCH   '
-dessert.topping #=> 'butterscotch'. Tidy!
+dessert.ice_cream #=> 'chocolate'. Tidy!
+dessert.topping   #=> 'butterscotch'. Tidy!
 ```
 
 TinySweeper will not bother you about your nil values; they're your job to handle.
@@ -32,7 +34,7 @@ TinySweeper will not bother you about your nil values; they're your job to handl
 Sundae.new.topping = nil  # No topping? TinySweeper won't sweep it.
 ```
 
-If you have an object with lots of attributes that need cleaning, you can do that, too:
+If you have an object with lots of attributes that need cleaning (because, say, they were loaded from the database), you can do that, too:
 
 ```ruby
 dessert.sweep_up!
@@ -44,8 +46,6 @@ Sundae.sweep_up!(dessert)
 
 Just spit-balling here...
 
-It'd be nice to define sweep-ups for multiple fields.
-
 If you often sweep up fields in the same way - say, squishing and nilifying blanks - it'd be nice to bundle that up in some way, so you don't have to repeat yourself. Something like this might be nice:
 
 ```ruby
@@ -72,7 +72,14 @@ end
 
 #### Other Ways to Sweep
 
-Rails models are clearly the natural use-case for this. So it would make sense to have an easy way to auto-clean up models in a table. We'll see.
+Rails models are clearly the natural use-case for this. So it would make sense to have an easy way to auto-clean up models in a table. We'll see. Right now, this works (though it's slow):
+
+```ruby
+MyModel.find_each do |m|
+  m.sweep_up!
+  m.save
+end
+```
 
 ## How Does It Work?
 
@@ -80,11 +87,7 @@ You include the `TinySweeper` module in your class, and define some sweep-up rul
 
 "Why not use `after_create` or `before_save` or `before_validate` callbacks?"
 
-That's one approach, and it's used by [nilify_blanks](https://github.com/rubiety/nilify_blanks), so it's clearly workable.
-
-But it means your data isn't cleaned until the callback runs; TinySweeper cleans your data as soon as it arrives.
-
-Also, it requires rails, so you can't use it outside of rails.
+That's one approach, and it's used by [nilify_blanks](https://github.com/rubiety/nilify_blanks), so it's clearly workable. But it means your data isn't cleaned until the callback runs; TinySweeper cleans your data as soon as it arrives. Also, it requires rails, so you can't use it outside of rails.
 
 ## Install It
 

data/lib/tiny_sweeper.rb

@@ -1,14 +1,16 @@
 module TinySweeper
   module ClassMethods
-    def sweep(field_name, &sweeper)
-      stop_if_we_have_seen_this_before!(field_name)
-
-      overrides_module.module_eval do
-        define_method("#{field_name}=") do |value|
-          if value
-            super(sweeper.call(value))
-          else
-            super(value)
+    def sweep(*field_names, &sweeper)
+      Array(field_names).each do |field_name|
+        stop_if_we_have_seen_this_before!(field_name)
+
+        overrides_module.module_eval do
+          define_method("#{field_name}=") do |value|
+            if value
+              super(sweeper.call(value))
+            else
+              super(value)
+            end
           end
         end
       end
@@ -51,4 +53,4 @@ module TinySweeper
 end
 
 # Do it on all fields, by default? Or be explicit?
-# TODO: add EagerSweeper, which loops over attributes
+# TODO: add EagerSweeper, which loops over attributes. But how would it sweep?

data/lib/tiny_sweeper/version.rb

@@ -1,3 +1,3 @@
 module TinySweeper
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/tiny_sweeper_spec.rb

@@ -68,6 +68,7 @@ describe 'cleaning fields' do
   end
 
   it "will let you sweep an inherited method" do
+    # This just falls out of the design, but it's nice to note.
     class BaseClass
       attr_accessor :name
     end
@@ -82,3 +83,27 @@ describe 'cleaning fields' do
     expect(child.name).to eq('Monty')
   end
 end
+
+describe 'sweeping many fields at once, in the same way' do
+  class Address
+    attr_accessor :address1, :address2, :city, :state, :zip
+    include TinySweeper
+    sweep :address1, :address2, :city, :state, :zip, &:strip
+  end
+
+  it 'can do it' do
+    address = Address.new
+
+    address.address1 = ' 12 Elm St '
+    address.address2 = ' Apt B '
+    address.city     = ' New Haven '
+    address.state    = ' CT '
+    address.zip      = ' 06510 '
+
+    expect(address.address1).to eq('12 Elm St')
+    expect(address.address2).to eq('Apt B')
+    expect(address.city    ).to eq('New Haven')
+    expect(address.state   ).to eq('CT')
+    expect(address.zip     ).to eq('06510')
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tiny_sweeper
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Dan Bernier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-07 00:00:00.000000000 Z
+date: 2015-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler