tiny_sweeper 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bab53d4f83febe0e94f9f5c97f632b1c7a4f6074
-  data.tar.gz: 6cb5b37b25afdbaa6599567434aae424bc52a9f1
+  metadata.gz: 57a9592ee6e0610b57e326c16b4acc66c4e84735
+  data.tar.gz: 8ac28a68c9d45d9926aeffce712aae4ac03a3f00
 SHA512:
-  metadata.gz: a575f5ff0cba1a49c8a46af5b15159749cf53b2313cfeee4ff5bd793f020bba9eb00a6405d443a1181ab149e4725afd67457e61f93b7e34df8369dc64fda84e8
-  data.tar.gz: 20bd0f5be58572b3931aa4ddda86503a4e477d7960a37e5ae149c158a225172afeb037a985bf12fce857d61939a428416b77361860cb36997dab5d546056046c
+  metadata.gz: ab8711abf77ee6cdf3ab60b1cdefc4b1ef918b4632f0ffa165c67236aa2776a029ad095c5ae789f533ec71b06c55074879492befb7fe269905ec27914b2ab9a3
+  data.tar.gz: 5106e0f3a1107d974f5ab4e240d94e948eccbc6010cebd1764135e22578289598076d1d59d95775f9cfd212850a6e8ed7d1f01713bbbac1537c3de2d7e49ef30

data/README.md

@@ -70,11 +70,7 @@ Rails models are clearly the natural use-case for this. So it would make sense t
 
 ## How Does It Work?
 
-You include the `TinySweeper` module in your class, and define some sweep-up rules on your class' attributes. It overrides your method, and defines a new method that cleans its input according to the sweep-up rule, and then calls the original method with the clean value.
-
-"Isn't it better to generate a module for the new methods, and call `super`?"
-
-Sure, but if you do that, the module's method is called *after* the original one. We want to clean the input *before* it gets to your method.
+You include the `TinySweeper` module in your class, and define some sweep-up rules on your class' attributes. It prepends an anonymous module to your class, adds to it a method with the same name that cleans its input according to the sweep-up rule, and then passes the cleaned value to `super`.
 
 "Why not use `after_create` or `before_save` or `before_validate` callbacks?"
 

data/lib/tiny_sweeper/version.rb

@@ -1,3 +1,3 @@
 module TinySweeper
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/tiny_sweeper.rb

@@ -1,16 +1,14 @@
 module TinySweeper
   module ClassMethods
     def sweep(field_name, &sweeper)
-      stop_if_attribute_does_not_exist!(field_name)
       stop_if_we_have_seen_this_before!(field_name)
 
       writer_method_name = writer_method_name(field_name)
 
-      alias_method "original #{writer_method_name}", writer_method_name
-
-      define_method(writer_method_name) do |value|
-        clean_value = sweeper.call(value)
-        send("original #{writer_method_name}", clean_value)
+      overrides_module.module_eval do
+        define_method(writer_method_name) do |value|
+          super(sweeper.call(value))
+        end
       end
     end
 
@@ -22,10 +20,12 @@ module TinySweeper
 
     private
 
-    def stop_if_attribute_does_not_exist!(field_name)
-      unless instance_methods(true).include?(writer_method_name(field_name))
-        raise "There is no method named #{field_name.inspect} to sweep up!"
-      end
+    def overrides_module
+      @overrides_module ||= begin
+                              mod = Module.new
+                              prepend mod
+                              mod
+                            end
     end
 
     def stop_if_we_have_seen_this_before!(field_name)

data/spec/tiny_sweeper_spec.rb

@@ -10,13 +10,6 @@ describe 'cleaning fields' do
     sweep(:name) { |n| n.upcase }
   end
 
-  it 'leaves some unfortunate method names, maybe?' do
-    contract = Contract.new
-    original_writers = contract.methods.grep(/^original /).sort
-    expect(original_writers).to eq([:"original name=", :"original notes="])
-    # NB: we're not saying this is GOOD, we're just noting it.
-  end
-
   it 'strips notes' do
     contract = Contract.new
     contract.notes = ' needs stripping '
@@ -64,14 +57,6 @@ describe 'cleaning fields' do
     }.to raise_error
   end
 
-  it "will bark if you sweep a method that doesn't exist" do
-    some_class = Class.new
-    some_class.send(:include, TinySweeper)
-    expect {
-      some_class.send(:sweep, :attribute, &:whatever)
-    }.to raise_error("There is no method named :attribute to sweep up!")
-  end
-
   it "will let you sweep an inherited method" do
     class BaseClass
       attr_accessor :name

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tiny_sweeper
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Dan Bernier