tina4ruby 3.13.96 → 3.13.97

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 03c4fdd796ea815b87db64ddfcdbfb640ab0c581b5b224b691994cacde2e6a0c
-  data.tar.gz: 504966fa78530e347b4306b54ce3e353e950bf66af96ec13412a9100a371d108
+  metadata.gz: cc06b125fb780e5f4703244636215011a65c6ee220081fcd02b4f73fa37db06c
+  data.tar.gz: a4ebef28a619dff925c104eb3e93c0632cf9cf47c9f84d15aff0c1658345eae0
 SHA512:
-  metadata.gz: ff853a253a55c4cb93649f0f6b23d15c707a5f6e207acc36cfbf31560cd5c01d1937f696c633b6f86cde279caf7f9fdc8498a2d0a0da6cb1b7144a4dcabaad7d
-  data.tar.gz: 57f7c58bee9776ffc0cd28010380842064b987188f8b16bf291fb91fc820ffb23186c6bee73b363ffb4eaf20d67d9372330b7afbe979f4697543d991bf5a73c8
+  metadata.gz: e3e081993e4da7a7ba4fd6fdd487ed06428bb5ccc7cd212dcee1e50ff309cfe30c342f14b4d17c4208067a558f089bc5300d4f6ee219967497dd43a17baa357a
+  data.tar.gz: 5a6123804aef171532d90d81230e6f45d6fd47a92c4820afe8416670372de57cd6afa1f66e05d493a57446ef4a0c4711ad3dd3281a2e369df99f551bc161df2f

data/lib/tina4/queue_backends/rabbitmq_backend.rb

@@ -210,18 +210,36 @@ module Tina4
         true
       end
 
-      # Remove messages by status. "dead" empties the dead-letter queue;
-      # anything else empties the main queue. Returns the count removed.
-      def purge(topic, status)
-        name = dead_status?(status) ? "#{topic}.dead_letter" : topic
-        queue = get_queue(name)
-        count = queue.message_count
-        queue.purge
-        count
+      # Not performable on RabbitMQ - raises naming the backend and the operation.
+      #
+      # purge(status) removes jobs SELECTED BY STATUS. RabbitMQ cannot address
+      # messages by status: basic.get pops the head of the queue and the only
+      # bulk operation is queue.purge, which empties the WHOLE live queue
+      # regardless of status. This used to drain that queue on any non-dead
+      # status, destroying every pending job - the destructive no-op ADR-0022
+      # invariant 6 forbids. Refusing by name is the honest answer.
+      def purge(_topic, _status)
+        raise NotImplementedError,
+              "The rabbitmq queue backend cannot perform purge(): RabbitMQ " \
+              "cannot address messages by status (basic.get pops the head of " \
+              "the queue), so a status-addressed purge would have to drain the " \
+              "entire live queue and destroy pending work. Use the file or " \
+              "mongodb backend."
       end
 
-      def clear(topic)
-        purge(topic, "pending")
+      # Not performable on RabbitMQ - raises naming the backend and the operation.
+      #
+      # clear() empties the queue. RabbitMQ cannot address messages by status,
+      # so the only thing it could do is queue.purge the WHOLE live queue. This
+      # used to do exactly that and return 0, silently destroying every pending
+      # job. Draining a live broker on a status-addressed clear is data loss.
+      def clear(_topic)
+        raise NotImplementedError,
+              "The rabbitmq queue backend cannot perform clear(): RabbitMQ " \
+              "cannot address messages by status (basic.get pops the head of " \
+              "the queue), so a status-addressed clear would have to drain the " \
+              "entire live queue and destroy pending work. Use the file or " \
+              "mongodb backend."
       end
 
       def size(topic)
@@ -251,10 +269,6 @@ module Tina4
         @queues[topic] ||= @channel.queue(topic, durable: true)
       end
 
-      def dead_status?(status)
-        %w[dead dead_letter deadletter failed].include?(status.to_s.downcase)
-      end
-
       # Pop every message off <topic>.dead_letter and put it straight back.
       # A READ must not consume: dead_letters() is called by dashboards and
       # health checks, and a read that emptied the queue would destroy the very

data/lib/tina4/session.rb

@@ -178,8 +178,12 @@ module Tina4
     # Persist the session if dirty. On a backend write failure the error is
     # logged and false is returned — the @modified (dirty) flag is RETAINED so
     # a later save can retry. Returns true on a successful (or no-op) write.
+    #
+    # A cleared id (@id nil, e.g. after #destroy) is a no-op: there is nothing
+    # to persist, and a write would re-create the just-destroyed record. Mirrors
+    # the Python master's `if self._session_id and self._dirty`.
     def save
-      return true unless @modified
+      return true unless @id && @modified
       if safe_write(@id, @data, @ttl)
         @modified = false
         true
@@ -188,11 +192,16 @@ module Tina4
       end
     end
 
-    # Destroy the current session. Should be called right after login or any
-    # privilege change to defend against session fixation (see #regenerate).
+    # Destroy the current session. ENDS the session: the stored record is
+    # removed and the id is CLEARED (@id = nil), so a later set()+save() with no
+    # new #start has no id to persist under and cannot RESURRECT the just-
+    # destroyed record. Mirrors the Python master (nulls _session_id) and Node
+    # (nulls sessionId). A fresh session needs a new #start, which mints a new id.
     def destroy
-      safe_destroy(@id)
+      safe_destroy(@id) if @id
+      @id = nil
       @data = {}
+      @modified = false
     end
 
     # Get a session value with optional default.

data/lib/tina4/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Tina4
-  VERSION = "3.13.96"
+  VERSION = "3.13.97"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tina4ruby
 version: !ruby/object:Gem::Version
-  version: 3.13.96
+  version: 3.13.97
 platform: ruby
 authors:
 - Tina4 Team