tina4ruby 3.13.83 → 3.13.84

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 047daf112e32975b3a932f37b8cc266495c67744228dad532831ecfc918d76d1
-  data.tar.gz: 06a13610c6f4dca323533afda0170fe9ab8b80c8181bd21ee3cc9743314704c3
+  metadata.gz: a44456ebacba7cc7b8a9b8ffe8a973411c13f8055e3297a9bfb1cbb370d4397b
+  data.tar.gz: 1fce4c668f1439fd7c057a4b94e804670d7ce4672a0641f0a325e343e44bba3b
 SHA512:
-  metadata.gz: 9836d9caa0a14bcdebaca2effb98265c76a326c21e4d67a50daa6a22f2eef134fce9cf31ab068a60da688b2daa6fc0717a0244d58b1f17116a501a2f8ab91685
-  data.tar.gz: d6fae651771e754bf8a3bb5fd9a73aee386765bf0574abb285a1eccea1fefe294e96d1e15913b3b413f380d2c239881b2cb70431956a67bb3282d132068c97f2
+  metadata.gz: 9d18d9143115b94beb1f6a4c4e067702f3127c2f05b24dc29a0c9efe04419622d2bb3c8bf94a19c61d1dad38f75ba2cc76d3d15fd530e51ee22198990584173d
+  data.tar.gz: 506e937dc17782c347efc91af039b21ea9e73e76fd92457bc8eab345ab27a7f6bc454eafca2d999a930053494926450f5d615eb871463577f2b5983d127f5f6c

data/CHANGELOG.md

@@ -12,13 +12,6 @@ UNRELEASED work. When a version ships, its notes go to the release notes above.
 
 ## Unreleased
 
-### Added
-
-- **MQTT 3.1.1 client** (`Tina4::Mqtt` / `Tina4::MqttMessage`), zero-dependency (stdlib `socket` +
-  lazily-required `openssl`), verified against a real broker with no mocks. publish/subscribe/consume,
-  QoS 0/1, retained, Last Will, per-client TLS, QoS 2 refused loudly. Ruby ships all 97 shared
-  features plus its native ERB engine, for **98 built-in features**.
-
 ### Changed
 
 - Internal: the SQL dialect-translation file is renamed
@@ -30,26 +23,31 @@ UNRELEASED work. When a version ships, its notes go to the release notes above.
 
 ### Fixed
 
-- **Security: the bundled Swagger UI static assets now honour the swagger gate.** `/swagger`,
-  `/swagger/`, `/swagger/index.html` and `/swagger/oauth2-redirect.html` were served from the
-  framework's own public directory BEFORE route matching (with directory-index resolution turning
-  `/swagger` into `swagger/index.html`), so a production server with `TINA4_SWAGGER_ENABLED=false`
-  still served the whole UI while `/swagger/openapi.json` correctly 404'd. Static serving now checks
-  the gate before it resolves an index. Bite-verified lock-in test. (python#97)
-- **The startup banner advertises only a surface that answers.** The `Swagger:` and `Dashboard:`
-  rows printed unconditionally, so a production log claimed a dev surface was exposed and a
-  developer following the link hit a 404. Each row is now built by one pure helper of
-  (port, swagger_enabled, dev_admin_enabled), unit tested rather than inferred from stdout.
-  (python#99)
-- **MQTT TLS tests verify the CA before trusting it.** A stale CA file in the shared temp directory
-  made six TLS tests FAIL instead of skip, in all four frameworks, pointing at correct TLS code.
-  The suites now confirm the CA actually validates the broker certificate before treating the TLS
-  environment as present. (python#98)
-- **The gemspec declares `logger` and `base64`.** Ruby 4 dropped both from the default gems.
-  `tina4ruby` requires `logger` and nothing in its transitive closure provided it, so a fresh
-  install on Ruby 4 could fail at require time. `base64` is satisfied through `jwt` today and is
-  declared directly so a change there cannot break us.
-
+- **`tina4 deploy docker` produced images that could not start.** Of the eight
+  Dockerfile generators in the stack (four templates in the `tina4` CLI plus one
+  in each framework's own CLI), exactly one was correct. Python named
+  `python -m tina4_python.cli`, a package with no `__main__.py`, so the container
+  died on startup; PHP ran `php index.php <addr>`, but `App::run(?host, port)`
+  never reads argv so the address was dropped and production never engaged;
+  Node named a path that exists only inside the tina4-nodejs monorepo and
+  depended on tsx, which `npm ci --omit=dev` strips. Every generator now names a
+  published entry point and requests production. Verified by scaffolding,
+  generating, building and running a container for all four languages.
+- **`serve` no longer kills PID 1.** The port-reclaim step read `lsof -ti`
+  without validating it. Where lsof prints a different shape, a non-numeric field
+  coerced to 0 or 1 -- and signalling PID 0 hits every process in the caller's
+  own process group. In a container the server IS PID 1, so it killed itself
+  (Node logged "Killed existing process on port 7148 (PID: 1 ...)" then exited
+  143; PHP logged the same attempt and survived by luck). Reclaiming is now
+  skipped inside a container, only all-digit PIDs are accepted, and PID 0, PID 1
+  and the current process are never signalled.
+- **The Ruby image builds.** The builder stage was `ruby:3.3-slim`, which has no
+  compiler, so `bundle install` failed with `Gem::Ext::BuildError` on the first
+  native extension (date, json, nio4r, sqlite3 are all in the default set). The
+  builder is now the full `ruby:3.3` image and the slim runtime installs
+  `libsqlite3-0`. Bundler's `deployment true` is gone: it demands a lockfile
+  matching the image's bundler exactly, so a lockfile from a newer bundler on a
+  developer machine hard-failed the build.
 
 ## Earlier history (pre-3.x)
 

data/lib/tina4/cli.rb

@@ -340,18 +340,81 @@ module Tina4
     end
 
     # Kill any process listening on the given port. Returns true if killed.
+    # True when this process is running inside a container.
+    #
+    # Reclaiming a port makes sense on a dev machine, where a previous
+    # `tina4 serve` may still hold it. Inside a container the server IS the
+    # container, so there is no stale sibling to reclaim from -- and trying is
+    # actively dangerous (see #kill_process_on_port).
+    def in_container?
+      return true if File.exist?("/.dockerenv") || File.exist?("/run/.containerenv")
+
+      blob = File.read("/proc/1/cgroup")
+      blob.include?("docker") || blob.include?("containerd") || blob.include?("kubepods")
+    rescue SystemCallError
+      false
+    end
+
+    # Kill any process listening on `port`. Returns true if anything was killed.
+    #
+    # Every PID is validated before use. `pid.to_i` on a non-numeric field
+    # yields 0, and Process.kill("TERM", 0) signals EVERY process in the
+    # caller's own process group -- the server kills itself. That is exactly
+    # what happened in a container: "Killed existing process on port 7148
+    # (PID: 1 ...)" followed by exit 143.
+    #
+    # So: skip entirely in a container, accept only all-digit PIDs, and never
+    # signal 0 (our process group), 1 (init), or ourselves.
+    # The PIDs from `lsof -ti` output that are safe to signal.
+    #
+    # Pure so the safety rule can be tested directly. An unvalidated parse is a
+    # footgun with real teeth: where lsof prints a different shape than -ti
+    # implies, a non-numeric field becomes 0, and signalling PID 0 hits EVERY
+    # process in the caller's own process group -- the server kills itself.
+    #
+    # Accept only all-digit tokens; never PID 0 (our group), PID 1 (init),
+    # ourselves, or our own process group.
+    def selectable_pids(lsof_output, me, my_group = nil)
+      pids = []
+      lsof_output.split(/\s+/).each do |token|
+        next unless token.match?(/\A\d+\z/)   # never coerce junk into a PID
+
+        pid = token.to_i
+        next if pid <= 1 || pid == me           # 0 = our group, 1 = init, me = suicide
+        next if !my_group.nil? && pid == my_group
+
+        pids << pid unless pids.include?(pid)
+      end
+      pids
+    end
+
     def kill_process_on_port(port)
+      return false if in_container?
+
       result = `lsof -ti :#{port} 2>/dev/null`.strip
       return false if result.empty?
 
-      pids = result.split("\n")
-      pids.each do |pid|
-        Process.kill("TERM", pid.to_i)
-      rescue Errno::ESRCH, Errno::EPERM
-        # Process already gone or no permission
+      me = Process.pid
+      my_group = begin
+        Process.getpgrp
+      rescue StandardError
+        nil
+      end
+
+      killed = []
+      selectable_pids(result, me, my_group).each do |pid|
+        begin
+          Process.kill("TERM", pid)
+          killed << pid.to_s
+        rescue Errno::ESRCH, Errno::EPERM
+          # Process already gone or no permission
+        end
       end
+
+      return false if killed.empty?
+
       sleep 0.5
-      puts "  Killed existing process on port #{port} (PID: #{pids.join(', ')})"
+      puts "  Killed existing process on port #{port} (PID: #{killed.join(', ')})"
       true
     rescue Errno::ENOENT
       false
@@ -3136,7 +3199,7 @@ module Tina4
           ENV SWAGGER_DESCRIPTION="Auto-generated API documentation"
 
           # Start the server on all interfaces
-          CMD ["bundle", "exec", "tina4ruby", "start", "-p", "7147", "-h", "0.0.0.0"]
+          CMD ["bundle", "exec", "tina4ruby", "start", "-p", "7147", "-h", "0.0.0.0", "--production"]
         DOCKERFILE
       end
 

data/lib/tina4/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Tina4
-  VERSION = "3.13.83"
+  VERSION = "3.13.84"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tina4ruby
 version: !ruby/object:Gem::Version
-  version: 3.13.83
+  version: 3.13.84
 platform: ruby
 authors:
 - Tina4 Team