tina4ruby 3.13.158 → 3.13.159

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9821daa34797e73cbeb2363f1df52e61a22a17eb2b7e44412483c72a02176866
-  data.tar.gz: 4eb81de452060f402677cecb522bd11417c968c50940a39cfbf7f9cd42b5700a
+  metadata.gz: c8eaa3629bc154d2dfc5419385857a0f9c3a8ede768af9363664c80448be9e19
+  data.tar.gz: aefe567a6fb3cf128750add20e11dc7683325a14b978708c57010ac5d4062bbe
 SHA512:
-  metadata.gz: b3350a878be47194f468507e910d6975c347eb717d101aeb7d78c4cec836156ab3ee06c234ec63b1c7a84cb8b8e5fcc3d11f226d688813360f7102fe55a61abb
-  data.tar.gz: f065e3b6de1441f44bd6104f6b9eb2e46c5c5fb856043ec9e86abf7b6a738305130259cf6697239d54a9cd390a97ca77775466e0476c8272d863d672acafb15b
+  metadata.gz: 2041d862f935b2a6611323856b8cfc7ed376009f1a0d7a52583f9ada47eeb4da1298e01c8ef6b48f17bbc71bd2d2c13bf4ae712d1004ba80636c772e18ab358f
+  data.tar.gz: 1d4d7726c126abab28b2f6261b1f5961249e8a2a8ca77e579941379c7943705d91094b0e2caf7701193a1f633ce7ccdd59a5287b1e1bc111ee438c70d3301cda

data/CHANGELOG.md

@@ -6,6 +6,21 @@ number means the same thing everywhere.
 **The authoritative release notes for every shipped version live in the documentation:**
 https://tina4.com/ruby/36-releases
 
+## 3.13.159 - 2026-11-06
+
+### Fixed
+- `generate route/service/queue/websocket/listener` co-emitted a spec that asserted the
+  stub still raised `NotImplementedError`, so filling the handler in correctly turned the
+  project's own suite red. The generated spec now asserts the handler is wired and stays
+  green both as the scaffold stub and once implemented (#270).
+- `tina4ruby migrate` applied a freshly scaffolded comment-only migration and recorded it
+  passed, so the real SQL written later under the same filename never ran. The runner now
+  keeps a migration pending while it still bears a `tina4:edit` marker and has no
+  executable SQL; a scaffolded `CREATE TABLE` is real DDL and still applies (#288).
+- `migrate:create create_*_view` scaffolded a runnable `CREATE TABLE <name>_view`, so
+  `migrate` built a table and never the view. A `*_view` name now scaffolds commented
+  `CREATE VIEW` guidance that is kept pending until written (#297).
+
 ## 3.13.158 - 2026-11-05
 
 ### Added

data/lib/tina4/cli.rb

@@ -2446,10 +2446,23 @@ module Tina4
       fields = fields_override&.any? ? fields_override : parse_fields(flags["fields"])
       is_create = name.start_with?("create_") || !fields_override.nil?
 
+      # A `create_*_view` name is a VIEW, not a table. Emitting a runnable
+      # `CREATE TABLE <name>_view` made migrate build a table and never the
+      # view, silently (#297). A view needs a SELECT, so scaffold it as
+      # commented guidance with tina4:edit markers and no executable SQL, so
+      # startup auto-migrate keeps it pending until it is written (#288).
+      is_view = is_create && fields_override.nil? && table.end_with?("_view")
+
       filename = "#{timestamp}_#{name}.sql"
       path = File.join(dir, filename)
 
-      if is_create
+      if is_view
+        up_sql = "-- tina4:edit  write the CREATE VIEW statement, then remove the\n" \
+                 "-- tina4:edit lines. For example:\n" \
+                 "-- CREATE VIEW #{table} AS\n" \
+                 "--     SELECT id, /* columns */ FROM source_table WHERE /* ... */;"
+        down_sql = "DROP VIEW IF EXISTS #{table};"
+      elsif is_create
         col_lines = ["    id INTEGER PRIMARY KEY AUTOINCREMENT"]
         fields.each do |fname, ftype|
           info = FIELD_TYPE_MAP[ftype] || FIELD_TYPE_MAP["string"]
@@ -2500,9 +2513,10 @@ module Tina4
       File.write(down_path, down_content)
       puts "  Created #{down_path}"
 
-      # Co-emit a real apply-UP/DOWN spec — only for CREATE migrations, whose UP
-      # SQL is real DDL to assert against (a placeholder ALTER has nothing yet).
-      emit_migration_test(name, table, filename, down_filename) if emit_test && is_create
+      # Co-emit a real apply-UP/DOWN spec — only for CREATE TABLE migrations,
+      # whose UP SQL is real DDL to assert against (a placeholder ALTER, or a
+      # VIEW stub that still needs its SELECT, has nothing concrete yet).
+      emit_migration_test(name, table, filename, down_filename) if emit_test && is_create && !is_view
     end
 
     # ── Generator: middleware ────────────────────────────────────────────
@@ -3492,10 +3506,11 @@ module Tina4
         # Routing spec for #{route} — no mocks, real Router.
         #
         # Generated with src/routes/#{route}.rb by `tina4ruby generate route
-        # #{route}` (no --model). The handlers are AI-FILL stubs that raise until
-        # you implement them, so this tests what IS live on generation: all five
-        # routes register on the REAL Router, and the list handler fails loud until
-        # filled. Fill a handler, then assert its real response here.
+        # #{route}` (no --model). The handlers start as AI-FILL stubs that raise
+        # until you implement them. This tests what is live on generation: all
+        # five routes register on the REAL Router, and the list handler is wired
+        # and callable. It stays GREEN whether the stub still raises OR you have
+        # filled it in — implementing the handler never turns this spec red.
         require "spec_helper"
 
         RSpec.describe "#{klass} routing (real Router)" do
@@ -3510,9 +3525,20 @@ module Tina4
             expect(paths).to include(["DELETE", "/api/#{route}/{id:int}"])
           end
 
-          it "the list handler is a live stub (raises until filled)" do
+          it "the list handler is wired (green as a stub AND when filled)" do
+            # It starts as a loud AI-FILL stub (raises NotImplementedError); once
+            # you implement it this spec STILL passes — it asserts wiring, never
+            # that the stub is unfinished, so doing the work never turns red.
             route, = Tina4::Router.match("GET", "/api/#{route}")
-            expect { route.handler.call(nil, nil) }.to raise_error(NotImplementedError)
+            expect(route.handler).to respond_to(:call)
+            request = Tina4::Request.new("REQUEST_METHOD" => "GET",
+                                         "PATH_INFO" => "/api/#{route}", "QUERY_STRING" => "")
+            begin
+              result = route.handler.call(request, Tina4::Response.new)
+            rescue NotImplementedError
+              next # still the scaffold stub — expected until filled in
+            end
+            expect(result).not_to be_nil # filled in: must hand back a response
           end
         end
       RUBY
@@ -3581,8 +3607,15 @@ module Tina4
             expect(Tina4::ServiceRunner.list.any? { |s| s[:name] == "#{snake}" }).to be true
           end
 
-          it "the task is a live stub (raises until filled)" do
-            expect { #{snake}_task(nil) }.to raise_error(NotImplementedError)
+          it "the task is wired (green as a stub AND when filled)" do
+            # Starts as a loud AI-FILL stub (raises NotImplementedError); once
+            # implemented this spec STILL passes, so doing the work never turns red.
+            expect(defined?(#{snake}_task)).to be_truthy
+            begin
+              #{snake}_task(nil)
+            rescue NotImplementedError
+              next # still the scaffold stub — expected until filled in
+            end
           end
         end
       RUBY
@@ -3619,8 +3652,15 @@ module Tina4
             expect(svc[:options][:daemon]).to be true
           end
 
-          it "handle_#{slug} is a live stub (raises until filled)" do
-            expect { handle_#{slug}({}) }.to raise_error(NotImplementedError)
+          it "handle_#{slug} is wired (green as a stub AND when filled)" do
+            # Starts as a loud AI-FILL stub (raises NotImplementedError); once
+            # implemented this spec STILL passes, so doing the work never turns red.
+            expect(defined?(handle_#{slug})).to be_truthy
+            begin
+              handle_#{slug}({})
+            rescue NotImplementedError
+              next # still the scaffold stub — expected until filled in
+            end
           end
         end
       RUBY
@@ -3727,8 +3767,15 @@ module Tina4
             expect(ws_route.handler.call(nil, :close, nil)).to be_nil
           end
 
-          it "the :message branch is a live stub (raises until filled)" do
-            expect { ws_route.handler.call(nil, :message, "hi") }.to raise_error(NotImplementedError)
+          it "the :message branch is wired (green as a stub AND when filled)" do
+            # Starts as a loud AI-FILL stub (raises NotImplementedError); once
+            # implemented this spec STILL passes, so doing the work never turns red.
+            expect(ws_route.handler).to respond_to(:call)
+            begin
+              ws_route.handler.call(nil, :message, "hi")
+            rescue NotImplementedError
+              next # still the scaffold stub — expected until filled in
+            end
           end
         end
       RUBY
@@ -3759,8 +3806,16 @@ module Tina4
             expect(Tina4::Events.listeners("#{event}").length).to be >= 1
           end
 
-          it "emitting reaches the listener (strict re-raises the stub)" do
-            expect { Tina4::Events.emit("#{event}", { "id" => 1 }, strict: true) }.to raise_error(NotImplementedError)
+          it "emitting reaches the listener (green as a stub AND when filled)" do
+            # Starts as a loud AI-FILL stub (strict emit re-raises
+            # NotImplementedError); once implemented this spec STILL passes, so
+            # doing the work never turns red.
+            expect(Tina4::Events.listeners("#{event}").length).to be >= 1
+            begin
+              Tina4::Events.emit("#{event}", { "id" => 1 }, strict: true)
+            rescue NotImplementedError
+              next # still the scaffold stub — expected until filled in
+            end
           end
         end
       RUBY

data/lib/tina4/migration.rb

@@ -199,6 +199,23 @@ module Tina4
       batch = next_batch_number
       results = []
       pending.each do |file|
+        # An empty, unedited scaffold migration — one that still bears a
+        # tina4:edit marker AND has no executable statement (the comment-only
+        # ALTER stub from a non-create migrate:create, or the view stub) — is
+        # unfinished. Applying it (and recording it passed) runs nothing and
+        # leaves the real SQL, written later under the same filename, never
+        # applied, with migrate reporting nothing pending (#288, #297). Keep it
+        # pending until written. A scaffolded CREATE TABLE carries the same hint
+        # but IS real DDL, so it applies — generate-model -> migrate is untouched.
+        if unapplied_scaffold?(file)
+          Tina4::Log.warning(
+            "Migration #{File.basename(file)} is still an unedited scaffold " \
+            "(a 'tina4:edit' placeholder with no SQL yet) — skipped and kept " \
+            "pending. Write the migration and remove the tina4:edit line(s), " \
+            "then run migrate again."
+          )
+          next
+        end
         result = run_migration(file, batch)
         results << result
         # Stop on failure
@@ -207,6 +224,24 @@ module Tina4
       results
     end
 
+    # True if a migration file is still the unedited scaffold placeholder: it
+    # bears a tina4:edit marker AND (for a .sql file) has no executable
+    # statement. A .rb scaffold qualifies on the marker alone.
+    def unapplied_scaffold?(file)
+      raw = File.read(file)
+      return false unless raw =~ %r{(?:#|//|--|/\*|\{#)\s*tina4:edit\b}i
+      return true if file.end_with?(".rb")
+      !executable_sql?(raw)
+    rescue SystemCallError
+      false
+    end
+
+    # True if any executable statement remains once SQL comments are stripped.
+    def executable_sql?(sql)
+      body = sql.gsub(%r{/\*.*?\*/}m, "").gsub(/--[^\n]*/, "")
+      !body.gsub(/[;\s]/, "").empty?
+    end
+
     # A stable signed-64-bit key for PostgreSQL's pg_advisory_lock, derived from
     # the lock name so it cannot collide with an application's own advisory-lock
     # keys. It is a constant (not user input), so inlining it in the SQL is

data/lib/tina4/version.rb

@@ -7,5 +7,5 @@
 
 
 module Tina4
-  VERSION = "3.13.158"
+  VERSION = "3.13.159"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tina4ruby
 version: !ruby/object:Gem::Version
-  version: 3.13.158
+  version: 3.13.159
 platform: ruby
 authors:
 - Tina4 Team
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-11-05 00:00:00.000000000 Z
+date: 2026-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3