timezone 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a86053f82b0d4454425aeab0810919007923ee4
-  data.tar.gz: b20264b2d51d7be0d65f05b534e1a835c74951e0
+  metadata.gz: 0d9109a87342399c39d7e3a860024d18248e8d11
+  data.tar.gz: 730bd61717c5a2de743a34e0cfc7c358f44be7d6
 SHA512:
-  metadata.gz: 1653863e3d830cc2a9ea9a8d7220c97ddded649c893de1ce1f9b9f65b77d25ab82cfe139b4511e73498fb18e643c060cdb4888a463cc0204ff00ade64b9c039a
-  data.tar.gz: aca52242ce0b87377d03a733f6a25b8b0b645b641d2a27cf7c2ce7d3bfbfae19ea1b12b0dd2468bb9ec653adbb4449c6f6d8e225626b28774fcdbc9de87639f8
+  metadata.gz: 27cebff1881253bb79164c1259233891bd3589e54c771799c4d56affd25b383b7f2b1fa0acd4302f5ae4beb01aebfc6db37542ffdf250c40806a3ed8c9feb274
+  data.tar.gz: 3186874343a8b9294b16848c3e7d1c80adc12d6bb14d4a6f5b2f8704b7a0750a377511473ba62a1048b7abbe9d5329b3ca23ac86964791a65ca918f1cb7f8937

data/CHANGES.markdown

@@ -1,5 +1,10 @@
 # master (unreleased)
 
+# 1.2.0
+
+* Added `::Timezone::Zone#abbr` method. (panthomakos)
+* Handle GeoNames error code 15 - "no result found". (panthomakos)
+
 # 1.1.1
 
 * Updated with `tzdata-2016f-1`. (panthomakos)

data/README.markdown

@@ -38,6 +38,9 @@ Simple querying of time, in any timezone, is accomplished by first retrieving a
     timezone.time_with_offset(Time.utc(2010, 1, 1, 0, 0, 0))
     => 2009-12-31 16:00:00 -0800
 
+    timezone.abbr(Time.new(2016, 9, 4, 1, 0, 0))
+    => "PDT"
+
 NOTE: time is always returned in the UTC timezone when using the `utc_to_local` function, but it accurately reflects the actual time in the specified timezone. The reason for this is that this function also takes into account daylight savings time and historical changes in timezone, which can alter the offset. If you want a time with the appropriate offset at the given time, then use the `time_with_offset` function as shown above.
 
 You can use the timezone object to convert local times into the best UTC

data/lib/timezone/lookup/geonames.rb

@@ -7,6 +7,12 @@ module Timezone
   module Lookup
     # @!visibility private
     class Geonames < ::Timezone::Lookup::Basic
+      # Status code used by GeoNames to indicate that the lookup succeeded, but
+      # there is no timezone information for the given <lat, lng>. This can
+      # happen if the <lat, lng> resolves to a point in the middle of the ocean,
+      # for example.
+      NO_TIMEZONE_INFORMATION = 15
+
       def initialize(config)
         if config.username.nil?
           raise(::Timezone::Error::InvalidConfig, 'missing username'.freeze)
@@ -30,6 +36,8 @@ module Timezone
 
         return unless data['status']
 
+        return if NO_TIMEZONE_INFORMATION == data['status']['value']
+
         raise(Timezone::Error::GeoNames, data['status']['message'])
       rescue => e
         raise(Timezone::Error::GeoNames, e.message)

data/lib/timezone/version.rb

@@ -1,3 +1,3 @@
 module Timezone
-  VERSION = '1.1.1'.freeze
+  VERSION = '1.2.0'.freeze
 end

data/lib/timezone/zone.rb

@@ -123,6 +123,16 @@ module Timezone
       Time.new(utc.year, utc.month, utc.day, utc.hour, utc.min, utc.sec, offset)
     end
 
+    # The timezone abbreviation, at the given time.
+    #
+    # @param time [#to_time] the source time
+    # @return [String] the timezone abbreviation, at the given time
+    def abbr(time)
+      time = sanitize(time)
+
+      rule_for_utc(time)[NAME_BIT]
+    end
+
     # If, at the given time, the timezone was observing Daylight Savings.
     #
     # @param time [#to_time] the source time

data/test/mocks/no_result_found.json

@@ -0,0 +1 @@
+{"status":{"message":"no timezone information found for lat/lng", "value":15}}

data/test/timezone/lookup/test_geonames.rb

@@ -100,6 +100,13 @@ class TestGeonames < ::Minitest::Test
     assert_exception(mine, 'invalid lat/lng')
   end
 
+  def test_no_result_found
+    mine = lookup
+    mine.client.body = File.open(mock_path + '/no_result_found.json').read
+
+    assert_nil(mine.lookup(10, 10))
+  end
+
   def test_invalid_parameter
     mine = lookup
     mine.client.body = File.open(mock_path + '/invalid_parameter.json').read

data/test/timezone/test_zone.rb

@@ -30,6 +30,11 @@ class TestZone < ::Minitest::Test
     assert_equal 'Europe/Paris', paris.name
   end
 
+  def test_abbr
+    assert_equal 'PDT', la.abbr(Time.new(2011, 6, 05))
+    assert_equal 'PST', la.abbr(Time.new(2011, 11, 20))
+  end
+
   def test_valid?
     assert la.valid?
     assert paris.valid?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: timezone
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Pan Thomakos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-16 00:00:00.000000000 Z
+date: 2016-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -702,6 +702,7 @@ files:
 - test/mocks/lat_lon_coords_atlantic.txt
 - test/mocks/lat_lon_coords_norfolk.txt
 - test/mocks/lat_lon_coords_wrong_offset.txt
+- test/mocks/no_result_found.json
 - test/test_timezone.rb
 - test/timezone/lookup/test_basic.rb
 - test/timezone/lookup/test_geonames.rb
@@ -738,7 +739,7 @@ rubyforge_project: timezone
 rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
-summary: timezone-1.1.1
+summary: timezone-1.2.0
 test_files:
 - test/data/Helsinki_rules_without_timestamps.json
 - test/data/asia
@@ -753,6 +754,7 @@ test_files:
 - test/mocks/lat_lon_coords_atlantic.txt
 - test/mocks/lat_lon_coords_norfolk.txt
 - test/mocks/lat_lon_coords_wrong_offset.txt
+- test/mocks/no_result_found.json
 - test/test_timezone.rb
 - test/timezone/lookup/test_basic.rb
 - test/timezone/lookup/test_geonames.rb