timet 1.5.4 → 1.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d3673e96ff9410f3b77d1ecdd59b74cbfe794bd50b9f6fad75701200c911742
-  data.tar.gz: d405e584648c18a4119b7f4c242923b74e28e433779ad3929ff22da3e569bba1
+  metadata.gz: bc6553610acca8f30eb067accd9a8ff09756ea7c0fdb231dac896210018e0db1
+  data.tar.gz: 41e673fa16e1a7ea7d7c7c3f75a7131c7add0fa4ea297ae3044ca9ddbbd1b4f3
 SHA512:
-  metadata.gz: 63267d2db22ceabb15c2ca4e8114a25854bf71446799992de552ce91f6ff7d8487fb7204f1ea76df8be77dcfa71ac89d21f26084c87fb17831469406920f1862
-  data.tar.gz: 2f7d784e8f9b3385d37c90a04fce2b4ea869c5fb3b1e62be613e835b898a2b6f4f8742dbb38785295e695309c7b6b6f6b3fe804a8e5afb7f03655510612ce05d
+  metadata.gz: '01793d4487cd53b78a2d35721a3e6d91ff29a8c98976e9e861bfc599e49dfbf89939bec66da4fd986f8b8f99c4cf2001ac859274859185aaf4a89f9f56bae7a3'
+  data.tar.gz: c0f27b5b4656c07a16e861544daf610b94d397a5b245e89d65850c23e24f1a5318042b6871430cd2c0341c0bdb3f27b4163781bbf024680157cd68889202459c

data/.rubocop.yml

@@ -8,10 +8,13 @@ AllCops:
 Metrics/MethodLength:
   Max: 12
 
-require: rubocop-rspec
+plugins: rubocop-rspec
 
 RSpec/ExampleLength:
-  Max: 10 
+  Max: 15 
 
 Metrics/CyclomaticComplexity:
   Max: 8
+
+RSpec/MultipleMemoizedHelpers:
+  Max: 15

data/CHANGELOG.md

@@ -1,8 +1,33 @@
-## [Unreleased]
+## [1.5.5] - 2025-02-26
+
+**Improvements:**
+
+- Refactored `DatabaseSyncer` specs to improve clarity, maintainability, and reduce redundancy.
+  - Removed `#process_existing_item` as its logic was redundant.
+  - Improved `#remote_wins?` tests with `let` blocks and better descriptions.
+  - Split multi-expectation tests into smaller, focused tests.
+  - Improved test descriptions for accuracy and clarity.
+  - Reorganized tests into more logical `describe` blocks.
+  - Moved S3 download tests to the `Timet::S3Supabase` `describe` block.
+  - Improved CSV export tests with extracted common data, centralized database setup, and a helper method.
+  - Improved message expectations in `#export_report` using `class_spy` and `have_received`.
+  - Improved test readability in `ApplicationHelper` with `let` blocks and separate `it` blocks.
+  - Refactored `DatabaseSyncer` specs with `let` blocks, focused examples, and explicit `expect` assertions.
+  - Prefer `have_received` for setting message expectations.
+  - Improved granularity in specs with smaller, focused examples and shared test data.
+- Updated gem dependencies to latest versions.
+- Overall code cleanup and improved test structure.
+- Update the way rubocop plugins are defined in the config.
+- Removed unnecessary comments.
+
+**Bug Fixes:**
+
+- Fixed a bug in the time field update logic in `validation_edit_helper`, specifically regarding the end time.
 
 ## [1.5.4] - 2025-02-11
 
 **Improvements:**
+
 - Added `.env` file creation in CI workflow for testing environment variables.
 - Updated Code Climate coverage reporting to use `simplecov-lcov` for LCOV format compatibility.
 - Refactored validation error message tests in `ValidationEditHelper` for clarity and maintainability.
@@ -16,6 +41,7 @@
 - Improved error handling and added tests for `S3Supabase`.
 
 **Bug Fixes:**
+
 - Fixed environment variable validation in `S3Supabase` to handle `nil` values.
 - Resolved issues with database synchronization logic in `DatabaseSyncer`.
 - Fixed test setup and cleanup in `S3Supabase` and `DatabaseSyncer` specs.

data/lib/timet/validation_edit_helper.rb

@@ -92,9 +92,9 @@ module Timet
     def update_time_field(item, field, new_time)
       field_index = Timet::Application::FIELD_INDEX[field]
       timestamp = item[field_index]
-      current_time = Time.at(timestamp || TimeHelper.current_timestamp).to_s.split
-      current_time[1] = new_time
-      DateTime.strptime(current_time.join(' '), '%Y-%m-%d %H:%M:%S %z').to_time
+      edit_time = Time.at(timestamp || item[1]).to_s.split
+      edit_time[1] = new_time
+      DateTime.strptime(edit_time.join(' '), '%Y-%m-%d %H:%M:%S %z').to_time
     end
 
     # Validates if a new time value is valid for a specific time field (start or end).

data/lib/timet/version.rb

@@ -6,6 +6,6 @@ module Timet
   # @return [String] The version number in the format 'major.minor.patch'.
   #
   # @example Get the version of the Timet application
-  #   Timet::VERSION # => '1.5.4'
-  VERSION = '1.5.4'
+  #   Timet::VERSION # => '1.5.5'
+  VERSION = '1.5.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: timet
 version: !ruby/object:Gem::Version
-  version: 1.5.4
+  version: 1.5.5
 platform: ruby
 authors:
 - Frank Vielma
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-02-11 00:00:00.000000000 Z
+date: 2025-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor