timecode 0.1.8 → 0.1.9

data/History.txt

@@ -1,3 +1,7 @@
+=== 0.1.9 / 2009-02-23
+
+* Do not be biased when rounding out frames on from_seconds
+
 === 0.1.8 / 2009-01-31
 
 * Bail out with empty or whitespace strings passed to Timecode.parse

data/SPECS.txt

@@ -1,11 +1,18 @@
 
-== Timecode.new() should
+== Timecode.new should
 * instantiate from int
 * always coerce FPS to float
 * create a zero TC with no arguments
 * accept full string SMPTE timecode as well
 
-== Timecode.at() should
+== Timecode.validate_atoms! should
+* disallow more than 99 hrs
+* disallow more than 59 minutes
+* disallow more than 59 seconds
+* disallow more frames than what the framerate permits
+* pass validation with usable values
+
+== Timecode.at should
 * disallow more than 99 hrs
 * disallow more than 59 minutes
 * disallow more than 59 seconds
@@ -30,6 +37,11 @@
 == A Timecode of zero should
 * properly respond to zero?
 
+== Timecode#to_seconds should
+* return a float
+* return the value in seconds
+* properly roundtrip a value via Timecode.from_seconds
+
 == An existing Timecode on inspection should
 * properly present himself via inspect
 * properly print itself
@@ -64,8 +76,7 @@
 
 == Timecode.parse should
 * handle complete SMPTE timecode
-* handle complete SMPTE timecode via new
-* refuse to handle timecode that is out of range for the framerate
+* handle timecode with fractional seconds
 * parse a row of numbers as parts of a timecode starting from the right
 * parse a number with f suffix as frames
 * parse a number with s suffix as seconds
@@ -78,6 +89,7 @@
 * parse timecode with fractional second instead of frames
 * raise when trying to parse DF timecode
 * raise on improper format
+* raise on empty argument
 
 == Timecode.soft_parse should
 * parse the timecode
@@ -87,4 +99,4 @@
 * parse from a 4x4bits packed 32bit unsigned int
 * properly convert itself back to 4x4 bits 32bit unsigned int
 
-60 specifications (101 requirements), 0 failures
+68 specifications (112 requirements), 0 failures

data/lib/timecode.rb

@@ -12,7 +12,7 @@
 #     :mapping => [%w(source_tc_frames total), %w(tape_fps fps)]
 
 class Timecode
-  VERSION = '0.1.8'
+  VERSION = '0.1.9'
 
   include Comparable
   
@@ -80,9 +80,6 @@ class Timecode
       # Drop frame goodbye
       if (input =~ DF_TC_RE)
         raise Error, "We do not support drop-frame TC"
-      # No empty values
-      elsif (input =~ /A(\s+)Z/)
-        raise CannotParse, "Empty timecode"
       # 00:00:00:00
       elsif (input =~ COMPLETE_TC_RE)
         atoms_and_fps = input.scan(COMPLETE_TC_RE).to_a.flatten.map{|e| Integer(e)} + [with_fps]
@@ -157,7 +154,7 @@ class Timecode
     # create a timecode from the number of seconds. This is how current time is supplied by
     # QuickTime and other systems which have non-frame-based timescales
     def from_seconds(seconds_float, the_fps = DEFAULT_FPS)
-      total_frames = (seconds_float.to_f * the_fps.to_f).ceil
+      total_frames = (seconds_float.to_f * the_fps.to_f).to_i
       new(total_frames, the_fps)
     end
   

data/test/test_timecode.rb

@@ -44,8 +44,8 @@ context "Timecode.validate_atoms! should" do
   end
   
   specify "disallow more frames than what the framerate permits" do
-    lambda{ Timecode.validate_atoms!(1,0,60,25, 25) }.should.raise(Timecode::RangeError)
-    lambda{ Timecode.validate_atoms!(1,0,60,32, 30) }.should.raise(Timecode::RangeError)
+    lambda{ Timecode.validate_atoms!(1,0,45,25, 25) }.should.raise(Timecode::RangeError)
+    lambda{ Timecode.validate_atoms!(1,0,45,32, 30) }.should.raise(Timecode::RangeError)
   end
   
   specify "pass validation with usable values" do
@@ -166,6 +166,13 @@ context "Timecode#to_seconds should" do
     secs = 126.3
     Timecode.new(fps * secs, fps).to_seconds.should.be.close 126.3, 0.1
   end
+  
+  specify "properly roundtrip a value via Timecode.from_seconds" do
+    secs_in = 19.76
+    from_secs = Timecode.from_seconds(19.76, 25.0)
+    from_secs.total.should.equal 494
+    from_secs.to_seconds.should.be.close(secs_in, 0.001)
+  end
 end
 
 context "An existing Timecode on inspection should" do
@@ -271,7 +278,7 @@ context "A Timecode used with fractional number of seconds" do
 
     fraction = 7.16
     tc = Timecode.from_seconds(fraction, 12.5)
-    tc.to_s.should.equal "00:00:07:02"
+    tc.to_s.should.equal "00:00:07:01"
   end
 
 end
@@ -310,6 +317,11 @@ context "Timecode.parse should" do
     Timecode.parse(simple_tc).to_s.should.equal(simple_tc)
   end
   
+  specify "handle timecode with fractional seconds" do
+    tc = Timecode.parse("10:10:10.2", 25)
+    tc.to_s.should.equal "10:10:10:05"
+  end
+  
   specify "parse a row of numbers as parts of a timecode starting from the right" do
     Timecode.parse("10").should.equal Timecode.new(10)
     Timecode.parse("210").should.equal Timecode.new(60)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: timecode
 version: !ruby/object:Gem::Version 
-  version: 0.1.8
+  version: 0.1.9
 platform: ruby
 authors: 
 - Julik
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-02-04 00:00:00 +01:00
+date: 2009-02-23 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency