time_jawn 1.2.1 → 1.2.2

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    OGI5Yzg3MTkzOWQ3NjE3YjliYzg1NWY5ODY0NDNjNDMxOWU2OTJhZg==
-  data.tar.gz: !binary |-
-    YmUxNDQ0NGE0MzZlN2RhMzU3NjJhZTMxM2MxNDExNzhiZDc2OWNkNA==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    NWY2MjhkMTc0N2Y4ODFkMDY5YTMyYTRiYTViYjE3YmViMWQ4YmQyYTdhZTg3
-    ZmU3OTA4ZTNjNjk4ZGM4MTVmZmZjOGM0MDBiMmFhZTU1NWUwYzU1MDBkMjFk
-    MDM3NzhiYTJiOTg0OWU2MTAyMTBiNDgyNWNkYTc2YmY2Y2JhYjY=
-  data.tar.gz: !binary |-
-    ZTc3OWUxOGQzZDQ0ODAzMjgyMWE5MTM3NzYwZTk3YzU4Zjc3ZGYyYjBkNmUy
-    MjJmOTYyZWQwOGI4ODk4ODkzN2YxZGM2YzRjMjgwYzhmODk3YTZkMTkzNmVh
-    NTZiNjg1NjM1ZTIyMWQ5ZjdiMjc2N2I4YTc5OWYwMTM5MGYwNmM=
+SHA1:
+  metadata.gz: a6a4e6f180be9199ca277acb30b77eb1c669e5d2
+  data.tar.gz: 7d4358869e51cdc0c2beabca8d190b88b0d413e3
+SHA512:
+  metadata.gz: 267b4c81102f5f0802a19fd994588328e9dd58c5ea7f01f3b070cc36c33a0e885d3da624c6bad842a816dc47d64a2af0627ad2e404cd15faeddd6dd0425fb53e
+  data.tar.gz: cad1e579ac4eacce73346c287be8d4d95bd3dfec0ec173b5852311ac46ec71038eaecb423f5d5e8183a64fd6b0de4e7d97c5a415e630c04e4328af9482070f22

data/lib/time_jawn/time_jawn.rb

@@ -2,11 +2,14 @@
 # in a attribute name time_zone or has been delegating one to somewhere else.
 module TimeJawn
   require 'time_jawn/time_jawn_private_class_methods'
+
+  DATE_FORMAT = '%a, %d %b %Y %H:%M:%S'
+
   # Automatically runs and adds ClassMethods to ActiveRecord::Base
   def self.included(base)
     base.send :extend, ClassMethods
   end
-  
+
   # Defines methods that will attached to all ActiveRecord classes.
   module ClassMethods
     include TimeJawnPrivateClassMethods
@@ -15,11 +18,10 @@ module TimeJawn
     # It is typically included in a model's rb file so that instances of that class gain the InstanceMethods at each instantiation.
     #     class Event<ActiveRecord::Base
     #       has_time_zone
-    #     end 
+    #     end
     # Optionally you may pass the name of your time zone attribute in as a symbol.
     #     class Event<ActiveRecord::Base
     #       has_time_zone    :this_is_my_time_zone
-    #     end 
     def has_time_zone(time_zone_attribute_name=:time_zone, options_hash={})
       _set_instance_variables(time_zone_attribute_name, options_hash)
       send :include, InstanceMethods
@@ -31,28 +33,28 @@ module TimeJawn
     # This method generates a series of methods on instances by calling the _generate_to_local and
     #  _generate_to_local_with_assignment that are private on teh parent class. The methods that are created are called
     # local_#{attribue} and local_#{attribute}= the attribute portion their names are completed by enumerating
-    # the datetime_attributes of the class. Twice as many methods as there are DateTime attributes will 
+    # the datetime_attributes of the class. Twice as many methods as there are DateTime attributes will
     # be created.
-    # 
+    #
     #    :created_at, and :updated_at
-    #     
+    #
     #     local_created_at
     #     local_updated_at
     #     local_created_at=
     #     local_updated_at=
-    # 
+    #
     # The local_#{attribue} methods will take the value stored in the attribute indicated by the methods name
     # and apply a time zone conversion to it. This is useful for displaying the local time (according to the object).
-    # 
+    #
     # local_#{attribute}= methods are assignment shortcuts. They behave a little differently than you would expect.
-    # They do not take a local time and convert it into utc (or whatever, ActiveSupport will handle that for us), 
-    # what these assigment methods do is take any sort of string that looks like a time, or any sort of time or datetime 
-    # object lop off whatever timezone is being fed in and glue the instances local timezone on the end before applying 
-    # it to the appropriate attribute. This is convenient for some one in one time zone setting a value for an instance 
+    # They do not take a local time and convert it into utc (or whatever, ActiveSupport will handle that for us),
+    # what these assigment methods do is take any sort of string that looks like a time, or any sort of time or datetime
+    # object lop off whatever timezone is being fed in and glue the instances local timezone on the end before applying
+    # it to the appropriate attribute. This is convenient for some one in one time zone setting a value for an instance
     # that represents a different time zone. For example:
     #
-    #     I am in Philadelphia (EST), my application is set to UTC, and I want to set the time on an Alarm instance that 
-    #     goes off in San Francisco (PST). I want that time to be 6PM. In Philadlephia I choose 6PM (local), the applications assumes I 
+    #     I am in Philadelphia (EST), my application is set to UTC, and I want to set the time on an Alarm instance that
+    #     goes off in San Francisco (PST). I want that time to be 6PM. In Philadlephia I choose 6PM (local), the applications assumes I
     #     meant 6PM UTC (2PM EST and 11AM PST). That is not what I intended, I intended on 6PM PST, and now my Alarm is all wrong.
     #     The assignment methods turn 6PM (set in EST, and processed in UTC) into 6PM PST (or 9PM EST, 1AM UTC) the expected time. The
     #     Alarm goes off as expected!*
@@ -76,19 +78,19 @@ module TimeJawn
       ActiveSupport::Deprecation.warn "_to_local will be made private in a future version."
       time.in_time_zone(self.send(self.class.time_zone_attribute_name))
     end
-    
+
     # Given a string that looks like a time. It will convert that string into a time object that matches the time but with
     # the instances time zone appended.
     def _add_zone(time_string)
       ActiveSupport::Deprecation.warn "_add_zone will be made private in a future version."
       Time.zone = self.send(self.class.time_zone_attribute_name)
-      Time.zone.parse(Time.parse(time_string).strftime('%a, %d %b %Y %H:%M:%S'))
+      Time.zone.parse(Time.parse(time_string).strftime(DATE_FORMAT))
     end
 
     # Returns a string representation of a time object suitable for consumption by add_zone.
     def _change_zone(time)
       ActiveSupport::Deprecation.warn "_change_zone will be made private in a future version."
-      _add_zone(time.strftime('%a, %d %b %Y %H:%M:%S'))
+      _add_zone(time.strftime(DATE_FORMAT))
     end
   end
 end

data/lib/time_jawn/time_jawn_private_class_methods.rb

@@ -1,4 +1,4 @@
-# Defines private methods necessary for TimeJawn to work. 
+# Defines private methods necessary for TimeJawn to work.
 module TimeJawnPrivateClassMethods
   # Locates all of an ActiveRecord class' DateTime Attributes and returns them as an array of symbols.
   def _datetime_attributes
@@ -9,7 +9,7 @@ module TimeJawnPrivateClassMethods
     klass.columns.each do |column|
        datetime_attributes << column.name.to_sym if column.type == :datetime
     end
-    return datetime_attributes
+    datetime_attributes
   end
 
   private
@@ -56,10 +56,6 @@ module TimeJawnPrivateClassMethods
 
   # returns all of the date_time attributes for a class unless it is specified in the class.
   def _class_date_attributes_or_arguments
-    if @time_jawn_date_time_attributes
-      @time_jawn_date_time_attributes
-    else
-      _datetime_attributes
-    end
+    @time_jawn_date_time_attributes || _datetime_attributes
   end
 end

data/spec/time_jawn_spec.rb

@@ -9,7 +9,7 @@ describe Happening do
   context 'class method' do
     describe "datetime_attributes" do
       it "returns an array of all datetime objects for the class" do
-        expect(Happening._datetime_attributes).to eq [:start_time, :created_at, :updated_at] 
+        expect(Happening._datetime_attributes).to eq [:start_time, :created_at, :updated_at]
       end
     end
     describe "has_time_zone" do
@@ -22,9 +22,9 @@ describe Happening do
         expect(Happening.instance_methods.include? :local_updated_at=).to eq false
       end
       it "has instance methods once called " do
-        
+
         Happening.has_time_zone
-        
+
         expect(Happening.instance_methods.include? :local_start_time).to eq true
         expect(Happening.instance_methods.include? :local_created_at).to eq true
         expect(Happening.instance_methods.include? :local_updated_at).to eq true
@@ -126,7 +126,7 @@ describe Happening do
     describe "local_start_time=(time_or_string)" do
       it "sets start_time on the instance to a time_with_zone object only modifying the time zone" do
         expect(@happening1.start_time).to eq 'Mon, 01 Apr 2013 00:01:00 UTC +00:00'
-        
+
         @happening1.local_start_time = Time.parse("Thu, 29 Aug 2013 02:40:12 HST -10:00")
         expect(@happening1.start_time).to eq Time.parse("2013-08-29 02:40:12 -0400")
 
@@ -148,7 +148,7 @@ describe Happening do
     describe "local_updated_at=(time_or_string)" do
       it "sets updated_at on the instance to a time_with_zone object only modifying the time zone" do
         expect(@happening1.updated_at).to eq 'Tue, 01 Jan 2013 00:01:00 +0000'
-        
+
         @happening1.local_updated_at = Time.parse("Thu, 29 Aug 2013 02:40:12 HST -10:00")
         expect(@happening1.updated_at).to eq Time.parse("2013-08-29 02:40:12 -0400")
 
@@ -170,7 +170,7 @@ describe Happening do
     describe "local_created_at=(time_or_string)" do
       it "sets created_at on the instance to a time_with_zone object only modifying the time zone" do
         expect(@happening1.created_at).to eq ' Tue, 01 Jan 2013 00:01:00 +0000'
-        
+
         @happening1.local_created_at = Time.parse("Thu, 29 Aug 2013 02:40:12 HST -10:00")
         expect(@happening1.created_at).to eq Time.parse("2013-08-29 02:40:12 -0400")
 
@@ -215,7 +215,7 @@ describe Occurrence do
   before do
     @occurrence1 = Occurrence.find_by_name('Eastern Time (US & Canada)')
   end
-  
+
   context "Ocurrence instance attribute accessor" do
     describe "time_zone_attribute_name" do
       it 'should respond with the time_zone attribute name as defined in the class.' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: time_jawn
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Mark Platt
@@ -14,76 +14,76 @@ dependencies:
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: TimeJawn makes class instances time zone aware. It doesn't care one iota
   about system, application or database time as far as I can tell. It has some expectations
   and adds some useful methods.
-email: mplatt@tammantech.com
+email: mark@mrkplt.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -92,7 +92,7 @@ files:
 - lib/time_jawn/time_jawn.rb
 - lib/time_jawn/time_jawn_private_class_methods.rb
 - spec/time_jawn_spec.rb
-homepage: http://tammantech.com
+homepage: https://github.com/mrkplt/time_jawn
 licenses:
 - MIT
 metadata: {}
@@ -102,17 +102,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.7
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: TimeJawn makes time zone aware class instances.