timber 2.5.0 → 2.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb90a5dcdaf6811bfa761744ebcb1df521aca6e3
-  data.tar.gz: 92784b6843f7acc7649aa1ff62434c907d7e71ae
+  metadata.gz: a87f39b30172987e5484e2cc7a7b8141df304872
+  data.tar.gz: cbc461a99678fd533074bf6b8e9fdf91d4003bab
 SHA512:
-  metadata.gz: de2fba5e95d5e0ddf11bb753cd7be7986f9ed836c63793583d076280f30312113f40b48f32718654b57394515afea77867d692a625e7cab2a8f6ee19e88c89e8
-  data.tar.gz: e62cd797becc6aa3bbc8ae37b6b44a42ef5d1d27bc8b0ea7c9510078511b04b5e8cebd12c6a8f6c3bbcd4fc2eba4bf553b4ef4df3923558cae91af2fa71fa7a0
+  metadata.gz: d5af9920a09c610cc4fcdfb22c38db8b99e25f1b4232ed3c70350ec63965facef2ccd3f580e4b72cb08a8c795bcf8038a5ddc3ce22ea1c26968dc54f2453fe20
+  data.tar.gz: 693d57eba475629b40c9bbbf639ebc6f87af2298eea376b9cc881a76ea224eeb75b0b9d08377a3ebde2d05854ce1d1c006c32679072cd5a721b7c80fc41e1848

data/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [2.5.1] - 2017-10-27
+
+### Fixed
+
+  - Ensure the new `content_length` field for HTTP request and response events are an integer.
+
 ## [2.5.0] - 2017-10-27
 
 ### Changed
@@ -97,7 +103,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
     instead of applying back pressure.
 
 
-[Unreleased]: https://github.com/timberio/timber-ruby/compare/v2.5.0...HEAD
+[Unreleased]: https://github.com/timberio/timber-ruby/compare/v2.5.1...HEAD
+[2.5.1]: https://github.com/timberio/timber-ruby/compare/v2.5.0...v2.5.1
 [2.5.0]: https://github.com/timberio/timber-ruby/compare/v2.4.0...v2.5.0
 [2.4.0]: https://github.com/timberio/timber-ruby/compare/v2.3.4...v2.4.0
 [2.3.4]: https://github.com/timberio/timber-ruby/compare/v2.3.3...v2.3.4

data/lib/timber/events/http_request.rb

@@ -14,7 +14,7 @@ module Timber
 
       def initialize(attributes)
         @body = attributes[:body] && Util::HTTPEvent.normalize_body(attributes[:body])
-        @content_length = attributes[:content_length]
+        @content_length = Timber::Util::Object.try(attributes[:content_length], :to_i)
         @headers = Util::HTTPEvent.normalize_headers(attributes[:headers])
         @host = attributes[:host]
         @method = Util::HTTPEvent.normalize_method(attributes[:method]) || raise(ArgumentError.new(":method is required"))

data/lib/timber/events/http_response.rb

@@ -13,7 +13,7 @@ module Timber
 
       def initialize(attributes)
         @body = attributes[:body] && Util::HTTPEvent.normalize_body(attributes[:body])
-        @content_length = attributes[:content_length]
+        @content_length = Timber::Util::Object.try(attributes[:content_length], :to_i)
         @headers = Util::HTTPEvent.normalize_headers(attributes[:headers])
         @http_context = attributes[:http_context]
         @request_id = attributes[:request_id]

data/lib/timber/version.rb

@@ -1,3 +1,3 @@
 module Timber
-  VERSION = "2.5.0"
+  VERSION = "2.5.1"
 end

data/spec/timber/events/http_request_spec.rb

@@ -4,6 +4,11 @@ require "spec_helper"
 
 describe Timber::Events::HTTPRequest, :rails_23 => true do
   describe ".initialize" do
+    it "should coerce content_length into an integer" do
+      event = described_class.new(:method => 'GET', :content_length => "123")
+      expect(event.content_length).to eq(123)
+    end
+
     context "with a header filters" do
       around(:each) do |example|
         old_http_header_filters = Timber::Config.instance.http_header_filters

data/spec/timber/events/http_response_spec.rb

@@ -0,0 +1,12 @@
+# encoding: UTF-8
+
+require "spec_helper"
+
+describe Timber::Events::HTTPResponse, :rails_23 => true do
+  describe ".initialize" do
+    it "should coerce content_length into an integer" do
+      event = described_class.new(:content_length => "123", :status => 200, :time_ms => 1)
+      expect(event.content_length).to eq(123)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: timber
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.5.1
 platform: ruby
 authors:
 - Timber Technologies, Inc.
@@ -278,6 +278,7 @@ files:
 - spec/timber/events/custom_spec.rb
 - spec/timber/events/error_spec.rb
 - spec/timber/events/http_request_spec.rb
+- spec/timber/events/http_response_spec.rb
 - spec/timber/events_spec.rb
 - spec/timber/integrations/action_controller/log_subscriber_spec.rb
 - spec/timber/integrations/action_dispatch/debug_exceptions_spec.rb
@@ -347,6 +348,7 @@ test_files:
 - spec/timber/events/custom_spec.rb
 - spec/timber/events/error_spec.rb
 - spec/timber/events/http_request_spec.rb
+- spec/timber/events/http_response_spec.rb
 - spec/timber/events_spec.rb
 - spec/timber/integrations/action_controller/log_subscriber_spec.rb
 - spec/timber/integrations/action_dispatch/debug_exceptions_spec.rb