tikkie-api 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 10c4a5614f612f5644d20fc71952d57c7104086e8a2ab377183fea972a9f21fd
-  data.tar.gz: 66e49070354bc7fff4dd78ca1da2b37e404e47ba324502ecf22b7a68f4644a9a
+  metadata.gz: 2c74647a459da497c8470c60da1f984fe8e51b127b9109795ea953ba1fe84fe9
+  data.tar.gz: e32193a47ad9c1a16baa9be79c783c4463bc940d6bbbd2dbeb9bc89ce4d43065
 SHA512:
-  metadata.gz: e0c1ff2ba7627421270620a60a8510d8958261e0239f3650fc7f6e82242d846bf712051b65d3c5c7ede981b91b46fbb8b970e85f5a4d6a870becc18eed77db84
-  data.tar.gz: b5ca9fed8e11d329c76f3d90ea877f77b3c376e9b7b04897868fb21adc2b007fd00b0681276713f81b81d15948d2311adf12b309059c9be98a27012fa2583400
+  metadata.gz: 2b5cc9ea35734bf58fd93e640df6ef514f819b06484dc4628a148124f49b872d449e0e63f619862673aab8c31f067b2a5cc147bf6ac9f22b92c50c4c93799aa3
+  data.tar.gz: 7b155ca26948a100d6e595a329b703049365c85e408b30bcd4fe0426cf1cde0ff8abb145c106311a8ba768814dd7eee0742ace64de6ee019a8840a078ff92b75

data/.rubocop.yml

@@ -1,8 +1,11 @@
+require: rubocop-rspec
+
 AllCops:
   TargetRubyVersion: 2.3
   DisplayCopNames: true
   DisplayStyleGuide: true
 
+
 Metrics/AbcSize:
   Max: 21
 
@@ -19,6 +22,20 @@ Metrics/LineLength:
 Metrics/MethodLength:
   Enabled: false
 
+
+RSpec/DescribedClass:
+  EnforcedStyle: explicit
+
+RSpec/ExampleLength:
+  Max: 8
+
+RSpec/MultipleExpectations:
+  Max: 4
+
+RSpec/NamedSubject:
+  Enabled: false
+
+
 Style/Documentation:
   Exclude:
     - 'spec/**/*'

data/Gemfile

@@ -7,4 +7,5 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 # Specify your gem's dependencies in tikkie-api.gemspec
 gemspec
 
-gem 'rubocop', '~> 0.63.1'
+gem 'rubocop', '~> 0.65.0'
+gem 'rubocop-rspec', '~> 1.32.0'

data/Gemfile.lock

@@ -1,51 +1,55 @@
 PATH
   remote: .
   specs:
-    tikkie-api (0.2.0)
+    tikkie-api (0.2.1)
       jwt (>= 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.2)
+    addressable (2.6.0)
       public_suffix (>= 2.0.2, < 4.0)
     ast (2.4.0)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
-    hashdiff (0.3.7)
+    hashdiff (0.3.8)
     jaro_winkler (1.5.2)
     jwt (2.1.0)
-    parallel (1.13.0)
+    parallel (1.14.0)
     parser (2.6.0.0)
       ast (~> 2.4.0)
     powerpack (0.1.2)
-    public_suffix (3.0.1)
+    psych (3.1.0)
+    public_suffix (3.0.3)
     rainbow (3.0.0)
     rake (10.5.0)
-    rspec (3.7.0)
-      rspec-core (~> 3.7.0)
-      rspec-expectations (~> 3.7.0)
-      rspec-mocks (~> 3.7.0)
-    rspec-core (3.7.1)
-      rspec-support (~> 3.7.0)
-    rspec-expectations (3.7.0)
+    rspec (3.8.0)
+      rspec-core (~> 3.8.0)
+      rspec-expectations (~> 3.8.0)
+      rspec-mocks (~> 3.8.0)
+    rspec-core (3.8.0)
+      rspec-support (~> 3.8.0)
+    rspec-expectations (3.8.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-mocks (3.7.0)
+      rspec-support (~> 3.8.0)
+    rspec-mocks (3.8.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-support (3.7.0)
-    rubocop (0.63.1)
+      rspec-support (~> 3.8.0)
+    rspec-support (3.8.0)
+    rubocop (0.65.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.5, != 2.5.1.1)
       powerpack (~> 0.1)
+      psych (>= 3.1.0)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.4.0)
+    rubocop-rspec (1.32.0)
+      rubocop (>= 0.60.0)
     ruby-progressbar (1.10.0)
-    safe_yaml (1.0.4)
+    safe_yaml (1.0.5)
     timecop (0.9.1)
     unicode-display_width (1.4.1)
     webmock (2.3.2)
@@ -60,7 +64,8 @@ DEPENDENCIES
   bundler (~> 1.16)
   rake (~> 10.0)
   rspec (~> 3.0)
-  rubocop (~> 0.63.1)
+  rubocop (~> 0.65.0)
+  rubocop-rspec (~> 1.32.0)
   tikkie-api!
   timecop (~> 0.9)
   webmock (~> 2.3)

data/README.md

@@ -24,11 +24,16 @@ Or install it yourself as:
 
 ## Usage
 
-### Initialization
+### Preparation
+
+This library uses a JSON Web Token (JWT) as authentication method. You need to create a public/private key pair to sign the tokens.
+See the [developer documentation from ABN AMRO](https://developer.abnamro.com/get-started#authentication) to get started.
 
-First create a Tikkie configuration and specify your API key and the path to your private RSA key. See also the [developer documentation from ABN AMRO](https://developer.abnamro.com/get-started) to get started.
+Make sure you have created an App in the developers portal with the Tikkie API product enabled. This App contains a Consumer Key (this is your API key), which you will need next.
+
+### Initialization
 
-Use the configuration to initialize a Tikkie client:
+First create a Tikkie configuration and specify the API key of your App and the path to your private RSA key. Then use the configuration to initialize a Tikkie client:
 
 ```ruby
 require 'tikkie/api'
@@ -98,12 +103,16 @@ payment_requests = client.payment_requests.list("platform_token", "user_token")
 The payments requests response is paginated. You can use the method `more_elements?` to determine if there's more data to retrieve. In the next request, set the `offset` parameter to the new offset using the method `next_offset` from the previous response. For example:
 
 ```ruby
-response = client.payment_requests.list("platform_token", "user_token")
-payment_requests = response.to_a
+options = {}
+
+loop do
+  payment_requests = client.payment_requests.list("platform_token", "user_token", options)
+
+  # Do something with payment requests
+
+  break unless payment_requests.more_elements?
 
-while response.more_elements?
-  response = client.payment_requests.list("platform_token", "user_token", offset: response.next_offset)
-  payment_requests << response.to_a
+  options[:offset] = payment_requests.next_offset
 end
 ```
 

data/lib/tikkie/api/responses/base.rb

@@ -12,7 +12,7 @@ module Tikkie
         def initialize(response)
           if response.respond_to?(:body)
             @response = response
-            @data = JSON.parse(response.body, symbolize_names: true)
+            @data = parse_body(response.body)
           else
             @data = response
           end
@@ -23,7 +23,7 @@ module Tikkie
         end
 
         def success?
-          response_code == 200 || response_code == 201
+          (response_code == 200 || response_code == 201) && !@invalid
         end
 
         def error?
@@ -47,6 +47,20 @@ module Tikkie
             errors
           end
         end
+
+        private
+
+        def parse_body(body)
+          body = body.respond_to?(:read) ? body.read : body
+
+          JSON.parse(body, symbolize_names: true)
+        rescue JSON::ParserError => ex
+          @invalid = true
+
+          {
+            message: "Unable to parse JSON: #{ex.message}"
+          }
+        end
       end
     end
   end

data/lib/tikkie/api/version.rb

@@ -2,6 +2,6 @@
 
 module Tikkie
   module Api
-    VERSION = "0.2.0"
+    VERSION = "0.2.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tikkie-api
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Kentaa BV
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-02-11 00:00:00.000000000 Z
+date: 2019-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jwt