ticketevolution-ruby 0.7.4 → 0.7.5

data/README.markdown

@@ -267,7 +267,7 @@ Click on the links next to each endpoint for more detail.
     @venue = @connection.venues.show(id)
 
 
-######ticketevolution-ruby v0.7.4
+######ticketevolution-ruby v0.7.5
 
 License
 -------

data/lib/ticket_evolution/core/base.rb

@@ -1,7 +1,15 @@
 module TicketEvolution
   class Base
     def method_missing(method, *args)
-      "TicketEvolution::#{method.to_s.camelize.to_sym}".constantize.new({:parent => self}) rescue super
+      begin
+        "#{self.class.name}::#{method.to_s.camelize.to_sym}".constantize.new({:parent => self})
+      rescue
+        begin
+          "TicketEvolution::#{method.to_s.camelize.to_sym}".constantize.new({:parent => self})
+        rescue
+          super
+        end
+      end
     end
   end
 end

data/lib/ticket_evolution/core/builder.rb

@@ -2,10 +2,12 @@ module TicketEvolution
   class Builder < OpenStruct
     include SingularClass
 
-    def initialize(*stuff)
-      super
-      @table.each do |k, v|
-        send("#{k}=", process_datum(v))
+    def initialize(hash={})
+      attrs = hash.clone
+      @table = attrs['id'].present? ? {:id => attrs.delete('id')} : {}
+      attrs.each do |k, v|
+        @table[k.to_sym] = process_datum(v, k)
+        new_ostruct_member(k)
       end
     end
 
@@ -28,7 +30,7 @@ module TicketEvolution
 
     private
 
-    def process_datum(v)
+    def process_datum(v, k=nil)
       case v.class.to_s.to_sym
       when :Hash
         Datum.new(v)
@@ -53,11 +55,11 @@ module TicketEvolution
 
     def method_missing(meth, *args)
       if args.size == 1
-        super(meth, process_datum(args.first))
+        super(meth, process_datum(args.first, meth))
       elsif args.size == 0
         super(meth)
       else
-        super(meth, process_datum(args))
+        super(meth, process_datum(args, meth))
       end
     end
 

data/lib/ticket_evolution/core/endpoint.rb

@@ -7,10 +7,7 @@ module TicketEvolution
       raise EndpointConfigurationError, "#{self.class.to_s} instances require a hash as their first parameter" unless options.is_a? Hash
       raise EndpointConfigurationError, "The options hash must include a parent key / value pair" unless options[:parent].present?
       raise EndpointConfigurationError, "#{self.class.to_s} instances require a parent which inherits from TicketEvolution::Base" unless options[:parent].kind_of? TicketEvolution::Base
-      options.each do |k, v|
-        self.singleton_class.send(:attr_accessor, k)
-        send("#{k}=", v)
-      end
+      @options = options.with_indifferent_access
       raise EndpointConfigurationError, "The parent passed in the options hash must be a TicketEvolution::Connection object or have one in it's parent chain" unless has_connection?
     end
 
@@ -18,14 +15,14 @@ module TicketEvolution
       [].tap do |parts|
         parts << parent.base_path if parent.kind_of? TicketEvolution::Endpoint
         parts << "/"+endpoint_name
-        parts << "/#{self.id}" if self.respond_to?("id=") and self.id.present?
+        parts << "/#{self.id}" if self.id.present?
       end.join
     end
 
     def connection
       if self.parent.is_a? TicketEvolution::Connection
         self.parent
-      elsif self.parent.respond_to? :parent
+      elsif self.parent.kind_of? TicketEvolution::Endpoint
         self.parent.connection
       else
         nil
@@ -40,12 +37,22 @@ module TicketEvolution
       self.class.name.demodulize.underscore
     end
 
+    def method_missing(method, *args)
+      name = method.to_s
+      @options.keys.include?(name) ? @options[name] : super
+    end
+
+    # Ruby 1.8.7 / REE compatibility
+    def id
+      @options[:id]
+    end
+
     private
 
     def ensure_id
       raise TicketEvolution::MethodUnavailableError.new \
         "#{self.class.to_s}##{caller.first.split('`').last.split("'").first} can only be called if there is an id present on this #{self.class.to_s} instance" \
-        unless self.respond_to?("id=") and self.id.present?
+        unless self.id.present?
     end
   end
 end

data/lib/ticket_evolution/core/endpoint/request_handler.rb

@@ -57,6 +57,10 @@ module TicketEvolution
           resp.server_message = (CODES[resp.response_code] || ['Unknown Error']).last
         end
       end
+
+      def collection_handler(response)
+        TicketEvolution::Collection.build_from_response(response, self.class.name.demodulize.underscore, singular_class)
+      end
     end
   end
 end

data/lib/ticket_evolution/core/model.rb

@@ -43,7 +43,7 @@ module TicketEvolution
 
     private
 
-    def process_datum(v)
+    def process_datum(v, k=nil)
       if v.is_a? Hash and v['url'].present?
         name = class_name_from_url(v['url'])
         datum_exists?(name) ? singular_class(class_name_from_url(name)).new(v.merge({:connection => @connection})) : Datum.new(v)

data/lib/ticket_evolution/core/model/parental_behavior.rb

@@ -1,24 +1,38 @@
 module TicketEvolution
+  module EndpointBehavior
+    def endpoint=(e); @endpoint = e; end
+    def method_missing(method, *args); @endpoint.send(method, *args); end
+  end
+
   class Model
     module ParentalBehavior
-      def new_ostruct_member(name)
-        ostruct_method = super
+      def process_datum(v, k = nil)
+        v = super
+        if k and v.is_a? Array and v.singleton_class.ancestors.first == Array
+          endpoint = "#{self.plural_class_name}::#{k.to_s.chomp('=').camelize}".constantize.new({
+            :parent => self.plural_class.new({
+              :id => self.id,
+              :parent => @connection
+            })
+          })
+          v.extend(TicketEvolution::EndpointBehavior)
+          v.endpoint = endpoint
+        end
+      ensure
+        return v
+      end
 
-        named_endpoint = "#{self.plural_class_name}::#{name.to_s.camelize}".constantize
-        class << self; self; end.class_eval do
-          define_method(name) do
-            obj = @table[name.to_sym]
-            unless obj.nil?
-              def obj.endpoint=(e); @endpoint = e; end
-              def obj.method_missing(method, *args); @endpoint.send(method, *args); end
-              obj.endpoint = named_endpoint.new(:parent => self.plural_class.new(:id => self.id, :parent => @connection))
-            end
-            obj
+      def new_ostruct_member(name)
+        name = name.to_sym
+        unless self.respond_to?(name)
+          class << self; self; end.class_eval do
+            define_method(name) { @table[name.to_sym] }
+            define_method("#{name}=") { |x| modifiable[name] = process_datum(x, name) }
           end
         end
-        ostruct_method
+        name
       rescue NameError => e
-        ostruct_method
+        super
       end
     end
   end

data/lib/ticket_evolution/modules/deleted.rb

@@ -2,13 +2,9 @@ module TicketEvolution
   module Modules
     module Deleted
       def deleted(params = nil, &handler)
-        handler ||= method(:build_for_deleted)
+        handler ||= method(:collection_handler)
         request(:GET, '/deleted', params, &handler)
       end
-
-      def build_for_deleted(response)
-        TicketEvolution::Collection.build_from_response(response, self.class.name.demodulize.underscore, singular_class)
-      end
     end
   end
 end

data/lib/ticket_evolution/modules/list.rb

@@ -2,15 +2,11 @@ module TicketEvolution
   module Modules
     module List
       def list(params = nil, &handler)
-        handler ||= method(:build_for_list)
+        handler ||= method(:collection_handler)
         request(:GET, nil, params, &handler)
       end
 
       alias :all :list
-
-      def build_for_list(response)
-        TicketEvolution::Collection.build_from_response(response, self.class.name.demodulize.underscore, singular_class)
-      end
     end
   end
 end

data/lib/ticket_evolution/modules/search.rb

@@ -2,13 +2,9 @@ module TicketEvolution
   module Modules
     module Search
       def search(params = nil, &handler)
-        handler ||= method(:build_for_search)
+        handler ||= method(:collection_handler)
         request(:GET, '/search', params, &handler)
       end
-
-      def build_for_search(response)
-        TicketEvolution::Collection.build_from_response(response, self.class.name.demodulize.underscore, singular_class)
-      end
     end
   end
 end

data/lib/ticket_evolution/version.rb

@@ -1,3 +1,3 @@
 module TicketEvolution
-  VERSION = '0.7.4'
+  VERSION = '0.7.5'
 end

data/spec/fixtures/net/endpoints/clients/list.yml

@@ -0,0 +1,48 @@
+---
+- !ruby/struct:VCR::HTTPInteraction
+  request: !ruby/struct:VCR::Request
+    method: :get
+    uri: https://api.sandbox.ticketevolution.com:443/clients?per_page=1
+    body: !!null 
+    headers:
+      x-signature:
+      - CVHhWgZb27YMNhFegxDYpGpJJ0dN4Cjf7w4am0cYSmM=
+      x-token:
+      - b2b5a7a33b1a78896ed1b53d81c5c9cc
+      accept:
+      - application/vnd.ticketevolution.api+json; version=8
+      accept-encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+  response: !ruby/struct:VCR::Response
+    status: !ruby/struct:VCR::ResponseStatus
+      code: 200
+      message: OK
+    headers:
+      content-type:
+      - application/vnd.ticketevolution.api+json; version=8; charset=utf-8
+      transfer-encoding:
+      - chunked
+      connection:
+      - keep-alive
+      status:
+      - '200'
+      x-powered-by:
+      - Phusion Passenger (mod_rails/mod_rack) 3.0.11
+      x-ua-compatible:
+      - IE=Edge,chrome=1
+      etag:
+      - ! '"46f6caa87384ce7e4bcee3406b641e9d"'
+      cache-control:
+      - max-age=0, private, must-revalidate
+      x-runtime:
+      - '0.153706'
+      strict-transport-security:
+      - max-age=31536000
+      server:
+      - nginx/1.0.11 + Phusion Passenger 3.0.11 (mod_rails/mod_rack)
+    body: ! '{"current_page":1,"per_page":1,"total_entries":119,"clients":[{"email_addresses":[{"label":null,"address":"tyrique@brown.info","id":"309"}],"addresses":[{"label":"Work","longitude":null,"extended_address":null,"street_address":"555
+      Evergreen Terrace","locality":"Springfield","region":"MG","country_code":"US","name":null,"latitude":null,"postal_code":"58008-0000","id":"170858"}],"office":{"url":"/offices/6","brokerage":{"abbreviation":"Ticket
+      Evolution","url":"/brokerages/61","name":"Ticket Evolution","id":"61"},"name":"Main
+      Office","id":"6"},"url":"/clients/3","updated_at":"2012-03-20T18:06:05Z","company":null,"phone_numbers":[{"number":"(301)555-1234","label":null,"extension":"999","country_code":null,"id":"333"}],"tags":["best
+      seller","promotion","vip"],"name":"Main Office","id":"3"}]}'
+    http_version: '1.1'

data/spec/lib/ticket_evolution/client_spec.rb

@@ -19,6 +19,18 @@ describe TicketEvolution::Client do
   it_behaves_like "a ticket_evolution model"
   it_behaves_like "a parental model"
 
+  describe "a retrieved instance" do
+    use_vcr_cassette "endpoints/clients/list", :record => :new_episodes, :match_requests_on => [:method, :uri, :body]
+
+    let(:client) { connection.clients.list(:per_page => 1) }
+
+    it "should be capable of being marshaled" do
+      expect {
+        Marshal.dump(client)
+      }.to_not raise_error
+    end
+  end
+
   context "#update_attributes" do
     let(:client) { connection.clients.create(:name => "foo") }
     let(:initial_client_id) { client.id }

data/spec/lib/ticket_evolution/clients_spec.rb

@@ -34,4 +34,13 @@ describe TicketEvolution::Clients do
       end
     end
   end
+
+  describe "chained endpoints" do
+    context "when the parent endpoint has an id" do
+      it "should check for chained endpoints in the method_missing stack" do
+        endpoint = klass.new(:parent => connection, :id => 1).samples
+        endpoint.should be_a TicketEvolution::Clients::Samples
+      end
+    end
+  end
 end

data/spec/lib/ticket_evolution/core/builder_spec.rb

@@ -21,14 +21,17 @@ describe TicketEvolution::Builder do
     end
 
     it "should assign each key value pair as attributes" do
+      instance
       params.keys.each do |key|
         instance.send(key).should == params[key]
       end
     end
 
     it "should call #process_datum for each attribute assigned" do
-      params.values.each do |v|
-        klass.any_instance.should_receive(:process_datum).with(v)
+      attrs = params.clone
+      attrs.delete('id')
+      attrs.each do |k, v|
+        klass.any_instance.should_receive(:process_datum).with(v, k)
       end
       instance
     end
@@ -79,9 +82,9 @@ describe TicketEvolution::Builder do
 
     describe "with args" do
       it "should invoke #process_datum with the information received" do
-        instance.should_receive(:process_datum).with(:ing)
+        instance.should_receive(:process_datum).with(:ing, :test=)
         instance.test = :ing
-        instance.should_receive(:process_datum).with([1,2])
+        instance.should_receive(:process_datum).with([1,2], :array=)
         instance.array = [1,2]
       end
     end

data/spec/lib/ticket_evolution/core/connection_spec.rb

@@ -122,7 +122,7 @@ describe TicketEvolution::Connection do
     end
 
     context "with logger object is set" do
-      use_vcr_cassette "core/connection", :record => :all
+      use_vcr_cassette "core/connection", :record => :new_episodes
 
       let(:target) { StringIO.new }
       let(:logger) { Logger.new(target) }

data/spec/shared_examples/endpoints/class.rb

@@ -16,13 +16,13 @@ shared_examples_for "a ticket_evolution endpoint class" do
           :test => :one,
           :testing => "two",
           :number => 3,
-          :hash => {}
+          :hsh => {}
         })
         instance.parent.should == connection
         instance.test.should == :one
         instance.testing.should == "two"
         instance.number.should == 3
-        instance.hash.should == {}
+        instance.hsh.should == {}
       end
 
       context "with a parent k/v pair" do
@@ -37,8 +37,16 @@ shared_examples_for "a ticket_evolution endpoint class" do
 
         context "that does inherit from TicketEvolution::Base" do
           context "and is a TicketEvolution::Connection object" do
+            let(:instance) { klass.new({:parent => connection}) }
+
             it "should not raise" do
-              expect { klass.new({:parent => connection}) }.to_not raise_error
+              expect { instance }.to_not raise_error
+            end
+
+            it "should be capable of being marshaled" do
+              expect {
+                Marshal.dump(instance)
+              }.to_not raise_error
             end
           end
 

data/spec/shared_examples/endpoints/deleted.rb

@@ -35,18 +35,18 @@ shared_examples_for "a deleted endpoint" do
     end
   end
 
-  context "#build_for_deleted" do
+  context "default response handler" do
     let(:response) { Fake.list_response }
 
     it "invokes Collection#build_from_response" do
       TicketEvolution::Collection.
         should_receive(:build_from_response).
         with(response, klass.name.demodulize.underscore, instance.singular_class)
-      instance.build_for_deleted(response)
+      instance.collection_handler(response)
     end
 
     it "returns a collection" do
-      instance.build_for_deleted(response).should be_a TicketEvolution::Collection
+      instance.collection_handler(response).should be_a TicketEvolution::Collection
     end
   end
 end

data/spec/shared_examples/endpoints/list.rb

@@ -35,18 +35,18 @@ shared_examples_for "a list endpoint" do
     end
   end
 
-  context "#build_for_list" do
+  context "default response handler" do
     let(:response) { Fake.list_response }
 
     it "invokes Collection#build_from_response" do
       TicketEvolution::Collection.
         should_receive(:build_from_response).
         with(response, klass.name.demodulize.underscore, instance.singular_class)
-      instance.build_for_list(response)
+      instance.collection_handler(response)
     end
 
     it "returns a collection" do
-      instance.build_for_list(response).should be_a TicketEvolution::Collection
+      instance.collection_handler(response).should be_a TicketEvolution::Collection
     end
   end
 end

data/spec/shared_examples/endpoints/search.rb

@@ -35,18 +35,18 @@ shared_examples_for "a search endpoint" do
     end
   end
 
-  context "#build_for_search" do
+  context "default response handler" do
     let(:response) { Fake.list_response }
 
     it "invokes Collection#build_from_response" do
       TicketEvolution::Collection.
         should_receive(:build_from_response).
         with(response, klass.name.demodulize.underscore, instance.singular_class)
-      instance.build_for_search(response)
+      instance.collection_handler(response)
     end
 
     it "returns a collection" do
-      instance.build_for_search(response).should be_a TicketEvolution::Collection
+      instance.collection_handler(response).should be_a TicketEvolution::Collection
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ticketevolution-ruby
 version: !ruby/object:Gem::Version
-  version: 0.7.4
+  version: 0.7.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-28 00:00:00.000000000Z
+date: 2012-04-03 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70187908360220 !ruby/object:Gem::Requirement
+  requirement: &70114881071020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *70187908360220
+  version_requirements: *70114881071020
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &70187908358760 !ruby/object:Gem::Requirement
+  requirement: &70114881069720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 0.7.3
   type: :runtime
   prerelease: false
-  version_requirements: *70187908358760
+  version_requirements: *70114881069720
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &70187908355960 !ruby/object:Gem::Requirement
+  requirement: &70114881066980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: 0.7.7
   type: :runtime
   prerelease: false
-  version_requirements: *70187908355960
+  version_requirements: *70114881066980
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &70187908354740 !ruby/object:Gem::Requirement
+  requirement: &70114881065660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: 0.0.4
   type: :runtime
   prerelease: false
-  version_requirements: *70187908354740
+  version_requirements: *70114881065660
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70187908353580 !ruby/object:Gem::Requirement
+  requirement: &70114881064320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: 1.4.3
   type: :runtime
   prerelease: false
-  version_requirements: *70187908353580
+  version_requirements: *70114881064320
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70187908352260 !ruby/object:Gem::Requirement
+  requirement: &70114881062980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: 2.7.1
   type: :development
   prerelease: false
-  version_requirements: *70187908352260
+  version_requirements: *70114881062980
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &70187908350880 !ruby/object:Gem::Requirement
+  requirement: &70114881061620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - <
@@ -87,10 +87,10 @@ dependencies:
         version: '2'
   type: :development
   prerelease: false
-  version_requirements: *70187908350880
+  version_requirements: *70114881061620
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70187908350240 !ruby/object:Gem::Requirement
+  requirement: &70114881061000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -101,10 +101,10 @@ dependencies:
         version: 1.8.0
   type: :development
   prerelease: false
-  version_requirements: *70187908350240
+  version_requirements: *70114881061000
 - !ruby/object:Gem::Dependency
   name: awesome_print
-  requirement: &70187908349240 !ruby/object:Gem::Requirement
+  requirement: &70114881060120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -112,10 +112,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70187908349240
+  version_requirements: *70114881060120
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70187908348260 !ruby/object:Gem::Requirement
+  requirement: &70114881059000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -123,7 +123,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70187908348260
+  version_requirements: *70114881059000
 description: Provides Ruby wrappers for the Ticket Evolution API (http://developer.ticketevolution.com).
   Ticket Evolution is the industry leader in software for the Ticket Broker industry.
 email:
@@ -227,6 +227,7 @@ files:
 - spec/fixtures/net/endpoints/categories.yml
 - spec/fixtures/net/endpoints/clients.yml
 - spec/fixtures/net/endpoints/clients/create.yml
+- spec/fixtures/net/endpoints/clients/list.yml
 - spec/fixtures/net/endpoints/clients/update_fail.yml
 - spec/fixtures/net/endpoints/clients/update_success.yml
 - spec/fixtures/net/endpoints/company/destroy_error.yml
@@ -322,7 +323,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 937722356540209047
+      hash: -2909427560002696490
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -343,6 +344,7 @@ test_files:
 - spec/fixtures/net/endpoints/categories.yml
 - spec/fixtures/net/endpoints/clients.yml
 - spec/fixtures/net/endpoints/clients/create.yml
+- spec/fixtures/net/endpoints/clients/list.yml
 - spec/fixtures/net/endpoints/clients/update_fail.yml
 - spec/fixtures/net/endpoints/clients/update_success.yml
 - spec/fixtures/net/endpoints/company/destroy_error.yml