thunderer 0.9.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f06c6d86a7fb9ab91ccc695100d1bb38522a09e1
-  data.tar.gz: ed2ecd2a1364b28d2fa8a7352fc108766c2020e1
+  metadata.gz: 67917833bd7bdb8962664293c6659eabda202252
+  data.tar.gz: 6aba43d84bda05ded6eec74460b310fbcac968d4
 SHA512:
-  metadata.gz: a0eedfda8684dd26ce682ab4746c48c8dfdf5238b1d841dfb1ef933d3c82112bb851285c5b57200c9d33ee678c230ff12094eb53622da9ca80abf27976090317
-  data.tar.gz: 41b061f20bce2aad21520d7661a8fd8ff3a64d44781a84c80515cd36bf981d213596143a8661547091c5a4895e0c734379691a34ab2f7dbd2a33704e4a0ee07f
+  metadata.gz: 95cd9c98d64d08426cf6ec9b7bbc3d37948a4f4417ef4d936afcca591fffdff5b63d4eaeeafb78010b2097efebcabaaec4fe131dd6c2f81fcd00a118950c2bcf
+  data.tar.gz: 3ab00dba836fbb7dc3eead43756f15ef0fa935c7d6e613987598b07316bb52ab7bc33e3f2578c7baa0a96aadd38f17cde4a355383f3b1891c947fb77275f41d2

data/.travis.yml

@@ -3,7 +3,7 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
+  - 2.1.2
 addons:
   code_climate:
-    repo_token:
-      secure: kQfmRpllfvpVjss75SRQKDJ70j72doORRsr8EQyY3cJsoAnwfu8E25/JZ+ZoG25AS+Z6dNYpSH0unrsqzbaSGucFfnQD0TiGINJhs36svHhtrP+JDSxwE38PyKu3tX07TMDxfZ0ig8OfuEuB3RB+E/1/1fy4RrrDn+ZIQN0dIHs=
+    repo_token: c277309738ed74f1285b9724c26528315c67b45850f09892970bad596fc15882

data/Gemfile

@@ -13,4 +13,5 @@ end
 group :test do
   gem 'rspec'
   gem 'codeclimate-test-reporter', require: nil
+  gem 'timecop'
 end

data/README.md

@@ -1,6 +1,7 @@
 [![Build Status](https://travis-ci.org/chubarovNick/thunderer.svg?branch=master)](https://travis-ci.org/chubarovNick/thunderer)
-[![Code Climate](https://codeclimate.com/github/chubarovNick/thunderer.png)](https://codeclimate.com/github/chubarovNick/thunderer)
+[![Code Climate](https://codeclimate.com/github/chubarovNick/thunderer/badges/gpa.svg)](https://codeclimate.com/github/chubarovNick/thunderer)
 [![Dependency Status](https://gemnasium.com/chubarovNick/thunderer.svg)](https://gemnasium.com/chubarovNick/thunderer)
+[![Test Coverage](https://codeclimate.com/github/chubarovNick/thunderer/badges/coverage.svg)](https://codeclimate.com/github/chubarovNick/thunderer)
 # Thunderer
 
 Thunderer is gem for publishing messages through [Faye](http://faye.jcoglan.com/). It allows you to easily provide real-time updates through an open socket without tying

data/Rakefile

@@ -7,6 +7,6 @@ RSpec::Core::RakeTask.new do |t|
   t.verbose = false
 end
 
-task default: :spec
+task default: [:spec, "jasmine:ci"]
 require 'jasmine'
 load 'jasmine/tasks/jasmine.rake'

data/lib/thunderer/engine.rb

@@ -4,8 +4,8 @@ require 'thunderer/controller_additions'
 module Thunderer
   class Engine < ::Rails::Engine
 
-    initializer "thunderer.config" do
-      path = Rails.root.join("config/thunderer.yml")
+    initializer 'thunderer.config' do
+      path = Rails.root.join('config/thunderer.yml')
       Thunderer.load_config(path, Rails.env) if path.exist?
     end
 
@@ -14,7 +14,7 @@ module Thunderer
           Gem.loaded_specs['faye'].full_gem_path, 'lib')
     end
 
-    initializer "thunderer.view_helpers" do
+    initializer 'thunderer.view_helpers' do
       ActionView::Base.send :include, ViewHelpers
     end
 

data/lib/thunderer/faye_extension.rb

@@ -5,9 +5,9 @@ module Thunderer
     # Callback to handle incoming Faye messages. This authenticates both
     # subscribe and publish calls.
     def incoming(message, callback)
-      if message["channel"] == "/meta/subscribe"
+      if message['channel'] == '/meta/subscribe'
         authenticate_subscribe(message)
-      elsif message["channel"] !~ %r{^/meta/}
+      elsif message['channel'] !~ %r{^/meta/}
         authenticate_publish(message)
       end
       callback.call(message)
@@ -17,23 +17,23 @@ module Thunderer
 
     # Ensure the subscription signature is correct and that it has not expired.
     def authenticate_subscribe(message)
-      subscription = Thunderer.subscription(:channel => message["subscription"], :timestamp => message["ext"]["thunderer_timestamp"])
-      if message["ext"]["thunderer_signature"] != subscription[:signature]
-        message["error"] = "Incorrect signature."
-      elsif Thunderer.signature_expired? message["ext"]["thunderer_timestamp"].to_i
-        message["error"] = "Signature has expired."
+      subscription = Thunderer.subscription(:channel => message['subscription'], :timestamp => message['ext']['thunderer_timestamp'])
+      if message['ext']['thunderer_signature'] != subscription[:signature]
+        message['error'] = 'Incorrect signature.'
+      elsif Thunderer.signature_expired? message['ext']['thunderer_timestamp'].to_i
+        message['error'] = 'Signature has expired.'
       end
     end
 
     # Ensures the secret token is correct before publishing.
     def authenticate_publish(message)
       if Thunderer.config[:secret_token].nil?
-        raise Error, "No secret_token config set, ensure thunderer.yml is loaded properly."
-      elsif message["ext"]["thunderer_secret_token"] != Thunderer.config[:secret_token]
+        raise Error, 'No secret_token config set, ensure thunderer.yml is loaded properly.'
+      elsif message['ext']['thunderer_secret_token'] != Thunderer.config[:secret_token]
 
-        message["error"] = "Incorrect token."
+        message['error'] = 'Incorrect token.'
       else
-        message["ext"]["thunderer_secret_token"] = nil
+        message['ext']['thunderer_secret_token'] = nil
       end
     end
   end

data/lib/thunderer/messanger.rb

@@ -16,12 +16,12 @@ module Thunderer
         @config['use_ssl'] = uri.scheme == 'https'
       end
 
-      def post message
+      def post( message )
         raise ConfigurationError if not_configured?
 
         form = build_form
         form.set_form_data(:message => message.to_json)
-        protocol.start {|h| h.request(form)}
+        protocol.start { |h| h.request(form) }
       end
 
       private

data/lib/thunderer/version.rb

@@ -1,3 +1,3 @@
 module Thunderer
-  VERSION = '0.9.1'
+  VERSION = '1.0.0'
 end

data/lib/thunderer/view_helpers.rb

@@ -14,7 +14,7 @@ module Thunderer
     # options.
     def subscribe_to(channel)
       subscription = Thunderer.subscription(:channel => channel)
-      content_tag "script", :type => "text/javascript" do
+      content_tag 'script', :type => 'text/javascript' do
         raw("Thunderer.sign(#{subscription.to_json});")
       end
     end

data/lib/thunderer.rb

@@ -1,10 +1,10 @@
-require "thunderer/version"
+require 'thunderer/version'
 require 'thunderer/parser'
 require 'thunderer/messanger'
 require 'thunderer/faye_extension'
-require "digest/sha1"
+require 'digest/sha1'
 require 'yaml'
-require "thunderer/engine" if defined? Rails
+require 'thunderer/engine' if defined? Rails
 
 module Thunderer
   class Error < StandardError; end
@@ -22,7 +22,7 @@ module Thunderer
       config_yaml = YAML.load_file(filename)[environment]
       raise ArgumentError, "The #{environment} environment dose not exist" unless config_yaml
       config_yaml.each { |k,v| config[k.to_sym] = v }
-      Thunderer::Messanger.configure(config[:server])
+      Thunderer::Messanger.configure( config[:local_server_url] || config[:server])
       @messanger = Thunderer::Messanger
 
     end
@@ -32,7 +32,7 @@ module Thunderer
     end
 
     def publish_message(message)
-      raise Error, "No server specified, ensure private_pub.yml was loaded properly." unless config[:server]
+      raise Error, 'No server specified, ensure thunderer.yml was loaded properly.' unless config[:server]
       url = URI.parse(config[:server])
       messanger.post(message)
     end

data/spec/fixtures/dummy_classes.yml

@@ -0,0 +1,6 @@
+dummy:
+  name      : Joe
+  id        : 1
+  created_at: 1999-02-19 08:00
+  updated_at: 1999-02-19 08:00
+

data/spec/fixtures/schema.rb

@@ -0,0 +1,9 @@
+ActiveRecord::Schema.define do
+
+  create_table "dummy_classes", :force => true do |t|
+    t.string "name"
+    t.datetime "created_at", :null => false
+    t.datetime "updated_at", :null => false
+  end
+
+end

data/spec/fixtures/thunderer_local_server.yml

@@ -0,0 +1,10 @@
+development:
+  server: http://dev.local:9292/faye
+  secret_token: DEVELOPMENT_SECRET_TOKEN
+  signature_expiration: 600
+production:
+  server: http://example.com/faye
+  local_server_url: http://localhost:3000
+  secret_token: PRODUCTION_SECRET_TOKEN
+  signature_expiration: 600
+

data/spec/javascripts/thunderer_spec.js

@@ -1,7 +1,16 @@
 describe('Thunderer', function () {
   var doc;
   beforeEach(function () {
-    Faye = {};
+    Faye = {
+      Client: function () {
+        return {
+          addExtension: function () {
+          }
+        }
+
+      }
+
+    };
     doc = {};
   });
 
@@ -110,8 +119,11 @@ describe('Thunderer', function () {
   });
 
   it("adds fayeCallback when client and server aren't available", function() {
-    Thunderer.faye("callback");
-    expect(Thunderer.fayeCallbacks[0]).toEqual("callback");
+    Thunderer.faye(function () {
+      return 'callback';
+    });
+    expect(Thunderer.fayeCallbacks[0]).toEqual(jasmine.any(Function));
+    expect(Thunderer.fayeCallbacks[0]()).toEqual('callback')
   });
 
 

data/spec/spec_helper.rb

@@ -10,20 +10,34 @@ require 'bundler/setup'
 require 'support/matchers/have_filter'
 require 'json'
 require 'faye'
+require 'active_record'
 require 'support/controller_macros'
+require 'active_record/fixtures'
 Bundler.setup
 
 require 'thunderer'
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
+  FIXTURES_PATH = File.join(File.dirname(__FILE__), 'fixtures')
+
+
+  ActiveRecord::Base.establish_connection(
+      adapter: 'sqlite3',
+      database: ':memory:'
+  )
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
-
+  config.raise_errors_for_deprecations!
   config.include ControllerMacros
 
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
+  dep = defined?(ActiveSupport::Dependencies) ? ActiveSupport::Dependencies : ::Dependencies
+  dep.autoload_paths.unshift FIXTURES_PATH
+
+  ActiveRecord::Base.quietly do
+    ActiveRecord::Migration.verbose = false
+    load File.join(FIXTURES_PATH, 'schema.rb')
+  end
+
+  ActiveRecord::Fixtures.create_fixtures(FIXTURES_PATH, ActiveRecord::Base.connection.tables)
+
   config.order = 'random'
 end

data/spec/thunderer/controller_aditions_spec.rb

@@ -17,32 +17,35 @@ describe Thunderer::ControllerAdditions do
   let(:controller_class) { MyController }
 
   describe '#thunderer_channels' do
+    let(:config_file_path) { 'spec/fixtures/thunderer.yml' }
+    let(:environment) { 'production' }
+    before { Thunderer.load_config(config_file_path, environment) }
 
-      it 'should affect channels class variable' do
-        controller_class.thunderer_channels('hello')
-        expect(controller_class.channels).to include('hello')
-      end
-
-      it 'should affect interpolation_object of class' do
-        controller_class.thunderer_channels(object: 'hello')
-        expect(controller_class.interpolation_object).to include('hello')
-      end
+    it 'should affect channels class variable' do
+      controller_class.thunderer_channels('hello')
+      expect(controller_class.channels).to include('hello')
+    end
 
-      it 'should setup before filter for setting headers' do
-        expect(controller_class).to have_filters(:before, :add_channels_header)
-      end
+    it 'should affect interpolation_object of class' do
+      controller_class.thunderer_channels(object: 'hello')
+      expect(controller_class.interpolation_object).to include('hello')
+    end
 
-      context 'for instance of controller' do
-        subject(:controller) { controller_class.new }
+    it 'should setup before filter for setting headers' do
+      expect(controller_class).to have_filters(:before, :add_channels_header)
+    end
 
-        # it 'should add special header for index response' do
-        #   controller_class.thunderer_channels('hello')
-        #   allow(controller).to receive(:headers)
-        #   controller.send(:add_channels_header)
-        # end
+    context 'for instance of controller' do
+      subject(:controller) { controller_class.new }
 
+      it 'should add special header for index response' do
+        controller_class.thunderer_channels('hello')
+        allow(controller).to receive(:headers) { {} }
+        controller.send(:add_channels_header)
       end
 
+    end
+
   end
 
 end

data/spec/thunderer/messanger_spec.rb

@@ -13,17 +13,41 @@ describe Thunderer::Messanger do
     expect(messanger.config['use_ssl']).to eq(nil)
   end
 
-  context 'with default config' do
+  describe '#post' do
+    subject { messanger.post(message) }
+
+    context 'with default config' do
+      let(:message) { double(:message) }
+
+      specify do
+        expect { subject }.to raise_error Thunderer::Messanger::ConfigurationError
+      end
 
-    it 'should raise error when you try post message' do
-      message = double(:message)
-      expect {
-        messanger.post(message)
-      }.to raise_error Thunderer::Messanger::ConfigurationError
     end
 
+    context 'with correct config' do
+      before { Thunderer::Messanger.configure('http://localhost:3000') }
+      let(:http_form) { double(:form) }
+      let(:http) { double(:http) }
+      let(:message) { 'Hello world' }
+      before { allow(Net::HTTP::Post).to receive(:new).with('/').and_return(http_form) }
+      before { allow(Net::HTTP).to receive(:new).with('localhost', 3000).and_return(http) }
+      before { allow(http).to receive(:use_ssl=) }
+
+
+      specify do
+        expect(http_form).to receive(:set_form_data).with(message: message.to_json)
+        expect(http).to receive(:start).and_yield(http)
+        expect(http).to receive(:request).with(http_form).and_return(:result)
+        expect(subject).to eq(:result)
+      end
+
+    end
+
+
   end
 
+
   describe '#configure' do
 
     it 'parse url and set configuration' do

data/spec/thunderer/parser_spec.rb

@@ -11,22 +11,22 @@ describe Thunderer::Parser do
     context 'when channel have no interpolation' do
       let(:channel) { 'without interpolation string' }
 
-      it { should == channel }
+      it { is_expected.to  eq(channel) }
     end
 
     context 'when channel have one interpolation sequence' do
       let(:channel) { '/hello/:first' }
 
-      it { should include('1') }
+      it { is_expected.to include('1') }
 
     end
 
     context 'when channel have two interpolations' do
       let(:channel) { '/hello/:first/world/:second' }
 
-      it { should include('1') }
+      it { is_expected.to include('1') }
 
-      it { should include('2') }
+      it { is_expected.to include('2') }
     end
 
 

data/spec/thunderer/publish_changes_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+require 'thunderer/publish_changes'
+
+class DummyClass < ActiveRecord::Base
+  include Thunderer::PublishChanges
+end
+
+describe Thunderer::PublishChanges do
+  let(:dummy_class) { DummyClass }
+  let(:dummy) { DummyClass.new }
+
+  context 'when notify_client_to_channels with only channel' do
+    before do
+      dummy_class.notify_client_to_channels('/channel')
+    end
+
+    context 'channels' do
+      subject { dummy_class.channels }
+
+      it { is_expected.to eq(['/channel']) }
+
+    end
+
+    context 'callback' do
+      before { expect(Thunderer).to receive(:publish_to).with('/channel', dummy) }
+      subject { dummy.save }
+
+      it { is_expected.to eq(true) }
+
+    end
+
+  end
+
+  context 'when notify_client_to_channels message_root' do
+    before do
+      dummy_class.notify_client_to_channels('/channel', message_root: 'root')
+    end
+
+    context 'channels' do
+      subject { dummy_class.channels }
+
+      it { is_expected.to eq(['/channel']) }
+
+    end
+
+    context 'callback' do
+      before { expect(Thunderer).to receive(:publish_to).with('/channel', Hash['root', dummy]) }
+      subject { dummy.save }
+
+      it { is_expected.to eq(true) }
+
+    end
+  end
+
+  context 'when notify_client_to_channels block' do
+    let(:dummy) { DummyClass.find(1)}
+    before do
+      dummy_class.notify_client_to_channels '/channel' do |object|
+        {id: object.id}
+      end
+    end
+
+    context 'channels' do
+      subject { dummy_class.channels }
+
+      it { is_expected.to eq(['/channel']) }
+
+    end
+
+    context 'callback' do
+      before { expect(Thunderer).to receive(:publish_to).with('/channel', {id: dummy.id}) }
+      subject { dummy.save }
+
+      it { is_expected.to eq(true) }
+
+    end
+  end
+
+end

data/spec/thunderer_spec.rb

@@ -2,107 +2,183 @@ require 'spec_helper'
 
 describe Thunderer do
   before { Thunderer.reset_config }
+  let(:config_file_path) { 'spec/fixtures/thunderer.yml' }
+  let(:environment) { 'production' }
+  let(:load_config) { Thunderer.load_config(config_file_path, environment) }
 
-  it "defaults server to nil" do
-    Thunderer.config[:server].should be_nil
-  end
+  describe 'default state' do
+    describe '#config' do
+      subject { Thunderer.config }
 
-  it "defaults signature_expiration to nil" do
-    Thunderer.config[:signature_expiration].should be_nil
-  end
+      it { is_expected.to eq({}) }
 
-  it "defaults subscription timestamp to current time in milliseconds" do
-    time = Time.now
-    Time.stub(:now).and_return(time)
-    Thunderer.subscription[:timestamp].should eq((time.to_f * 1000).round)
+    end
   end
 
-  it "loads a simple configuration file via load_config" do
-    Thunderer.load_config("spec/fixtures/thunderer.yml", "production")
-    Thunderer.config[:server].should eq("http://example.com/faye")
-    Thunderer.config[:secret_token].should eq("PRODUCTION_SECRET_TOKEN")
-    Thunderer.config[:signature_expiration].should eq(600)
-  end
+  describe '#load_config' do
 
-  it 'also configure Thunderer::Messanger when load config' do
-    Thunderer.load_config("spec/fixtures/thunderer.yml", "production")
-    # expect(Thunderer.messanger).to be_kind_of(Thunderer::Messanger)
-    expect(Thunderer.messanger.config).not_to be_nil
-  end
+    subject { Thunderer.config }
 
-  it "raises an exception if an invalid environment is passed to load_config" do
-    expect {
-      Thunderer.load_config("spec/fixtures/thunderer.yml", :test)
-    }.to raise_error ArgumentError
-  end
+    context 'when config environment was exists' do
+      before { load_config }
 
+      it { is_expected.to include(:server => 'http://example.com/faye') }
 
-  it "includes channel, server, and custom time in subscription" do
-    Thunderer.config[:server] = "server"
-    subscription = Thunderer.subscription(:timestamp => 123, :channel => "hello")
-    subscription[:timestamp].should eq(123)
-    subscription[:channel].should eq("hello")
-    subscription[:server].should eq("server")
-  end
+      it { is_expected.to include(:secret_token => 'PRODUCTION_SECRET_TOKEN') }
 
-  it "does a sha1 digest of channel, timestamp, and secret token" do
-    Thunderer.config[:secret_token] = "token"
-    subscription = Thunderer.subscription(:timestamp => 123, :channel => "channel")
-    subscription[:signature].should eq(Digest::SHA1.hexdigest("tokenchannel123"))
-  end
+      it { is_expected.to include(:signature_expiration => 600) }
+    end
 
-  it "formats a message hash given a channel and a hash" do
-    Thunderer.config[:secret_token] = "token"
-    Thunderer.message("chan", :foo => "bar").should eq(
-      :ext => {:thunderer_secret_token => "token"},
-      :channel => "chan",
-      :data => {
-        :channel => "chan",
-        :data => {:foo => "bar"}
-      }
-    )
-  end
+    context 'when config environment was not exists' do
+      let(:environment) { 'test' }
+
+      specify do
+        expect {
+          load_config
+        }.to raise_error ArgumentError
+      end
+
+    end
+
+    describe 'Thunderer::Messanger configuration' do
+      subject { Thunderer::Messanger.config }
+
+      it { is_expected.not_to eq({}) }
+
+      context 'when config have local_server_url' do
+        let(:config_file_path) { 'spec/fixtures/thunderer_local_server.yml' }
+        let(:environment) { 'production' }
 
-  it "publish message as json to server using Net::HTTP" do
-    message = 'foo'
-    Thunderer.load_config("spec/fixtures/thunderer.yml", "production")
+        before { load_config }
+
+        it { is_expected.to include('uri'=>URI.parse('http://localhost:3000')) }
+
+      end
+
+    end
 
-    expect(Thunderer::Messanger).to receive(:post)
-    Thunderer.publish_message(message)
   end
 
-  
-  it "raises an exception if no server is specified when calling publish_message" do
-    lambda {
-      Thunderer.publish_message("foo")
-    }.should raise_error(Thunderer::Error)
+  describe '#subscription' do
+    before { load_config }
+    let!(:time_mock) { Time.now }
+    before { allow(Time).to receive(:now) { time_mock } }
+    before { Thunderer.config[:server] = 'server' }
+    subject { Thunderer.subscription }
+
+    it { is_expected.to include(:timestamp => (time_mock.to_f * 1000).round) }
+
+    context 'when #subscription pass params' do
+      subject { Thunderer.subscription(:timestamp => 123, :channel => 'hello') }
+
+      it { is_expected.to include(:timestamp => 123) }
+      it { is_expected.to include(:channel => 'hello') }
+      it { is_expected.to include(:server => 'server') }
+    end
+
+    describe 'signature' do
+      before { Thunderer.config[:secret_token] = 'token' }
+      subject { Thunderer.subscription(:timestamp => 123, :channel => 'channel') }
+
+      it { is_expected.to include(:signature => Digest::SHA1.hexdigest('tokenchannel123')) }
+
+    end
+
+
   end
 
-  it "publish_to passes message to publish_message call" do
-    Thunderer.should_receive(:message).with("chan", "foo").and_return("message")
-    Thunderer.should_receive(:publish_message).with("message").and_return(:result)
-    Thunderer.publish_to("chan", "foo").should eq(:result)
+  describe '#message' do
+
+    describe 'formatting' do
+      let(:secret_token) { 'token' }
+      before { Thunderer.config[:secret_token] = secret_token }
+
+      subject { Thunderer.message('chan', :foo => 'bar') }
+
+      it do
+        expect(subject).to eq(:ext => {:thunderer_secret_token => 'token'},
+                              :channel => 'chan',
+                              :data => {
+                                  :channel => 'chan',
+                                  :data => {:foo => 'bar'}
+                              })
+      end
+
+    end
+
   end
 
-  it "has a Faye rack app instance" do
-    Thunderer.faye_app.should be_kind_of(Faye::RackAdapter)
+  describe '#publish_message' do
+    let(:message) { 'foo' }
+    subject { Thunderer.publish_message(message) }
+
+    context 'when config are loaded' do
+      before { load_config }
+
+      specify do
+        expect(Thunderer::Messanger).to receive(:post)
+        subject
+      end
+    end
+
+    context 'when config are not loaded' do
+      specify do
+        expect { subject }.to raise_error(Thunderer::Error)
+      end
+    end
+
+
   end
 
-  it "says signature has expired when time passed in is greater than expiration" do
-    Thunderer.config[:signature_expiration] = 30*60
-    time = Thunderer.subscription[:timestamp] - 31*60*1000
-    Thunderer.signature_expired?(time).should be_true
+  describe '#publish_to' do
+    let(:message) { 'foo' }
+    let(:channel) { 'channel' }
+    subject { Thunderer.publish_to(channel, message) }
+    before do
+      allow(Thunderer).to receive(:message).with( channel, message) { 'message' }
+      allow(Thunderer).to receive(:publish_message).with('message') { :result }
+    end
+
+    it { is_expected.to eq(:result)}
+
+
   end
 
-  it "says signature has not expired when time passed in is less than expiration" do
-    Thunderer.config[:signature_expiration] = 30*60
-    time = Thunderer.subscription[:timestamp] - 29*60*1000
-    Thunderer.signature_expired?(time).should be_false
+  describe '#faye_app' do
+    subject { Thunderer.faye_app }
+
+    it { is_expected.to be_kind_of(Faye::RackAdapter) }
+
   end
 
-  it "says signature has not expired when expiration is nil" do
-    Thunderer.config[:signature_expiration] = nil
-    Thunderer.signature_expired?(0).should be_false
+
+  describe 'signature_expired?' do
+    let(:expiration) { 30*60 }
+    before { Thunderer.config[:signature_expiration] = expiration }
+    subject { Thunderer.signature_expired?(time) }
+
+    context 'when time greater than expiration ' do
+      let(:time) { Thunderer.subscription[:timestamp] - 31*60*1000 }
+
+      it { is_expected.to eq(true) }
+
+    end
+
+    context 'when time less than expiration' do
+      let(:time) { Thunderer.subscription[:timestamp] - 29*60*1000 }
+
+      it { is_expected.to eq(false) }
+
+    end
+
+    context 'when expiration is nil' do
+      let(:expiration) { nil }
+      let(:time) { 0 }
+
+      it { is_expected.to eq(nil) }
+
+    end
+
   end
 
 end

data/thunderer.gemspec

@@ -17,8 +17,9 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'activesupport'
   spec.add_development_dependency 'rails'
-  spec.add_development_dependency 'rspec', '~> 2.14.1'
+  spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'jasmine'
+  spec.add_development_dependency 'sqlite3'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: thunderer
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Nick Chubarov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-02 00:00:00.000000000 Z
+date: 2014-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faye
@@ -56,16 +56,16 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: jasmine
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -137,7 +151,10 @@ files:
 - lib/thunderer/publish_changes.rb
 - lib/thunderer/version.rb
 - lib/thunderer/view_helpers.rb
+- spec/fixtures/dummy_classes.yml
+- spec/fixtures/schema.rb
 - spec/fixtures/thunderer.yml
+- spec/fixtures/thunderer_local_server.yml
 - spec/javascripts/helpers/.gitkeep
 - spec/javascripts/helpers/jasmine_examples/SpecHelper.js
 - spec/javascripts/support/jasmine.yml
@@ -179,7 +196,10 @@ signing_key:
 specification_version: 4
 summary: pub/sub messaging in Rails application
 test_files:
+- spec/fixtures/dummy_classes.yml
+- spec/fixtures/schema.rb
 - spec/fixtures/thunderer.yml
+- spec/fixtures/thunderer_local_server.yml
 - spec/javascripts/helpers/.gitkeep
 - spec/javascripts/helpers/jasmine_examples/SpecHelper.js
 - spec/javascripts/support/jasmine.yml
@@ -195,3 +215,4 @@ test_files:
 - spec/thunderer/parser_spec.rb
 - spec/thunderer/publish_changes_spec.rb
 - spec/thunderer_spec.rb
+has_rdoc: