thumbs_up 0.6.1 → 0.6.2

data/lib/acts_as_voteable.rb

@@ -24,7 +24,7 @@ module ThumbsUp
       # You can also have the upvotes and downvotes returned separately in the same query:
       # Post.plusminus_tally(:separate_updown => true)
       def plusminus_tally(params = {})
-        t = self.joins("LEFT OUTER JOIN #{Vote.table_name} ON #{self.table_name}.id = #{Vote.table_name}.voteable_id")
+        t = self.joins("LEFT OUTER JOIN #{Vote.table_name} ON #{self.table_name}.id = #{Vote.table_name}.voteable_id AND #{Vote.table_name}.voteable_type = '#{self.name}'")
         t = t.order("plusminus_tally DESC")
         t = t.group("#{self.table_name}.id")
         t = t.select("#{self.table_name}.*")

data/lib/thumbs_up/version.rb

@@ -1,3 +1,3 @@
 module ThumbsUp
-	VERSION = '0.6.1'
+	VERSION = '0.6.2'
 end

data/test/test_helper.rb

@@ -75,6 +75,12 @@ ActiveRecord::Schema.define do
     t.string  :name
     t.string  :description
   end
+
+  create_table :other_items, :force => true do |t|
+    t.integer :user_id
+    t.string  :name
+    t.string  :description
+  end
 end
 
 require 'thumbs_up'
@@ -100,6 +106,11 @@ class Item < ActiveRecord::Base
   belongs_to :user
 end
 
+class OtherItem < ActiveRecord::Base
+  acts_as_voteable
+  belongs_to :user
+end
+
 class User < ActiveRecord::Base
   acts_as_voter
   has_many :items

data/test/thumbs_up_test.rb

@@ -354,4 +354,17 @@ class TestThumbsUp < Test::Unit::TestCase
     assert_equal 4, users[0].karma
     assert_equal 0, users[1].karma
   end
+
+  def test_plusminus_tally_scopes_by_voteable_type
+    user = User.create(:name => 'david')
+    item = Item.create(:name => 'XBOX', :description => 'XBOX console')
+    another_item = OtherItem.create(:name => 'Playstation', :description => 'Playstation console')
+
+    user.vote_for(item)
+    user.vote_for(another_item)
+
+    assert_equal 1, Item.plusminus_tally.sum(&:plusminus_tally).to_i
+    assert_equal 1, OtherItem.plusminus_tally.sum(&:plusminus_tally).to_i
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: thumbs_up
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
   prerelease: 
 platform: ruby
 authors:
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-30 00:00:00.000000000 Z
+date: 2012-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -166,7 +166,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2774307803948239525
+      hash: 173536367113367291
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -175,10 +175,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2774307803948239525
+      hash: 173536367113367291
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Voting for ActiveRecord with multiple vote sources and karma calculation.