thumblemonks-sso_what 0.2.0 → 0.2.1

data/lib/thumblemonks/base_domain_cookie.rb

@@ -0,0 +1,27 @@
+module ThumbleMonks
+  module SsoWhat
+    module BaseDomainCookie
+      def self.included(klass)
+        klass.alias_method_chain :set_cookie, :domain_override
+      end
+
+      def set_cookie_with_domain_override(key, value)
+        value = {:value => value} unless value.is_a?(Hash)
+        domain_requested, host = value[:domain], request.host
+        unless domain_requested || host_has_no_tld?(host)
+          domain_requested = host.gsub(/^(.*\.)?([a-z0-9-]+\.[a-z]+)$/i, '\2')
+          value[:domain] = ".#{domain_requested}"
+        end
+        set_cookie_without_domain_override(key, value)
+      end
+
+    private
+
+      def host_has_no_tld?(host)
+        host =~ /^[a-z0-9-]+$/i
+      end
+    end # DomainOverride
+  end # SsoWhat
+end # ThumbleMonks
+
+Rack::Response.instance_eval { include ThumbleMonks::SsoWhat::BaseDomainCookie }

data/lib/thumblemonks/base_domain_session.rb

@@ -0,0 +1,19 @@
+module Centro
+  module SsoWhat
+    module BaseDomainSession
+      def self.included(klass)
+        klass.alias_method_chain :call, :domain_override
+      end
+    
+      def call_with_domain_override(env)
+        if @default_options[:base_domain]
+          base_host = env["HTTP_HOST"].scan(/[0-9a-z-]+\.[0-9a-z-]+(?=:|$)/i).first
+          @default_options[:domain] = base_host ? ".#{base_host}" : base_host
+        end
+        call_without_domain_override(env)
+      end
+    end # MultiDomainSession
+  end # AbstractStore
+end # Centro
+
+ActionController::Session::AbstractStore.instance_eval { include Centro::SsoWhat::BaseDomainSession }

data/sso_what.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name     = "sso_what"
-  s.version  = "0.2.0"
+  s.version  = "0.2.1"
   s.date     = "2009-03-05"
   s.summary  = "Rails extension to help with cookies in a system with sub-domains"
   s.email    = %w[gus@gusg.us gabriel.gironda@gmail.com]
@@ -23,15 +23,15 @@ Gem::Specification.new do |s|
     MIT-LICENSE
     README.markdown
     Rakefile
-    lib/centro/base_host.rb
     lib/sso_what.rb
-    lib/thumblemonks/subdomain_cookie_jar.rb
+    lib/thumblemonks/base_domain_cookie.rb
+    lib/thumblemonks/base_domain_session.rb
     sso_what.gemspec
   ]
   
   s.test_files = %w[
-    test/base_host_test.rb
-    test/subdomain_cookie_jar_test.rb
+    test/base_domain_cookie_test.rb
+    test/base_domain_session_test.rb
     test/test_helper.rb
   ]
 

data/test/base_domain_cookie_test.rb

@@ -0,0 +1,50 @@
+require File.join(File.dirname(__FILE__), 'test_helper')
+
+class BaseDomainCookieTest < Test::Unit::TestCase
+  def setup
+    # @response = OpenStruct.new(:headers => { "Set-Cookie" => [] })
+    # @controller = OpenStruct.new(:request => @request, :response => @response)
+    @test_request = OpenStruct.new
+    @response = Rack::Response.new
+    @response.stubs(:request).returns(@test_request)
+  end
+
+  context "if domain is provided" do
+    should "not do anyhing" do
+      @response.set_cookie("fanta", {:value => "wanna fanta", :domain => 'foo.bar'})
+      assert_equal 'domain=foo.bar', domain_for_the_first_cookie_found
+    end
+  end
+
+  context "if domain is not provided" do
+    context "and value is a string" do
+      should "set the domain to request.host but with subdomain support" do
+        @test_request.expects(:host).returns('foo-bar.baz')
+        @response.set_cookie("fanta", "wanna fanta")
+        assert_equal 'domain=.foo-bar.baz', domain_for_the_first_cookie_found
+      end
+    end
+
+    should "set the domain to request.host but with subdomain support" do
+      @test_request.expects(:host).returns('foo-bar.baz')
+      @response.set_cookie("fanta", {:value => "wanna fanta"})
+      assert_equal 'domain=.foo-bar.baz', domain_for_the_first_cookie_found
+    end
+
+    should "remove subdomains" do
+      @test_request.expects(:host).returns('thomas.f00.bar')
+      @response.set_cookie("fanta", {:value => "wanna fanta"})
+      assert_equal 'domain=.f00.bar', domain_for_the_first_cookie_found
+    end
+
+    should "do nothing for one word hosts" do
+      @test_request.expects(:host).returns('localhost')
+      @response.set_cookie("fanta", {:value => "wanna fanta"})
+      assert_nil domain_for_the_first_cookie_found
+    end
+  end
+
+  def domain_for_the_first_cookie_found
+    @response["Set-Cookie"].scan(/domain=[a-z0-9.-]+/i).first
+  end
+end

data/test/base_domain_session_test.rb

@@ -0,0 +1,60 @@
+require File.join(File.dirname(__FILE__), 'test_helper')
+
+class BaseDomainSessionTest < Test::Unit::TestCase
+  # Macros
+
+  def self.store_with_multi_domain(multi_domain_option, &block)
+    context "session store with multi-domain set to #{multi_domain_option.inspect}" do
+      setup do
+        @response = [nil, {"Set-Cookie" => nil}] # second element is the header
+        @app = stub(:call => @response)
+        options = {:base_domain => multi_domain_option, :expire_after => 3600}
+        @store = TestSessionStore.new(@app, options)
+      end
+      yield if block_given?
+    end
+  end
+
+  def self.should_expect_cookie_domain_for_http_host(http_host, cookie_domain)
+    should "return #{cookie_domain} for #{http_host}" do
+      env = {"HTTP_HOST" => http_host}
+      @store.call(env)
+      expected = cookie_domain.nil? ? nil : "domain=#{cookie_domain}"
+      assert_equal expected, domain_for_the_first_cookie_found
+    end
+  end
+
+  def domain_for_the_first_cookie_found
+    set_cookie = @response[1]["Set-Cookie"]
+    set_cookie && set_cookie.scan(/domain=[a-z0-9.-]+/i).first
+  end
+
+  # Tests
+
+  store_with_multi_domain(true) do
+    should_expect_cookie_domain_for_http_host "foohost", nil
+    should_expect_cookie_domain_for_http_host "foohost.bar", ".foohost.bar"
+    should_expect_cookie_domain_for_http_host "gah.foohost.bar", ".foohost.bar"
+    should_expect_cookie_domain_for_http_host "publisher.gah.foohost.bar", ".foohost.bar"
+    should_expect_cookie_domain_for_http_host "gah.foohost.bar:3000", ".foohost.bar"
+  end
+  
+  store_with_multi_domain(false) do
+    should_expect_cookie_domain_for_http_host "gah.foohost.bar", nil
+  end
+
+  store_with_multi_domain(nil) do
+    should_expect_cookie_domain_for_http_host "gah.foohost.bar", nil
+  end
+
+end
+
+class TestSessionStore < ActionController::Session::AbstractStore
+  def get_session(env, sid)
+    [sid, {:foo => "bar"}]
+  end
+
+  def set_session(env, sid, session_data)
+    true
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: thumblemonks-sso_what
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors: 
 - Justin Knowlden
@@ -29,9 +29,9 @@ files:
 - MIT-LICENSE
 - README.markdown
 - Rakefile
-- lib/centro/base_host.rb
 - lib/sso_what.rb
-- lib/thumblemonks/subdomain_cookie_jar.rb
+- lib/thumblemonks/base_domain_cookie.rb
+- lib/thumblemonks/base_domain_session.rb
 - sso_what.gemspec
 has_rdoc: true
 homepage: http://github.com/thumblemonks/sso_what
@@ -65,6 +65,6 @@ signing_key:
 specification_version: 2
 summary: Rails extension to help with cookies in a system with sub-domains
 test_files: 
-- test/base_host_test.rb
-- test/subdomain_cookie_jar_test.rb
+- test/base_domain_cookie_test.rb
+- test/base_domain_session_test.rb
 - test/test_helper.rb