thrifter 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4d4d2c07c4f438c528cbee2fb79eaaad32d492e0
-  data.tar.gz: 04118a2ca3fdc79444b6454ab63897344ab09ae2
+  metadata.gz: f749536c8bf5a2560c17986f6ef8a38828aedc22
+  data.tar.gz: 3a1e08e6e213162ac77ceffb70c329bfa7ce0756
 SHA512:
-  metadata.gz: 57afa5cab7442e4af1bb49cc35b856ebadc9dd94fe83cb36daf069042ad8ac93e368793b376410e1da3539adbd87cbf3db0a809b957279a9e6c7b9971db9b0e7
-  data.tar.gz: d99656e443fbf32b2a16fc805d211d92549b06e69b58480961c6f823775ed2071a0afb6ea755f8d3b505b911ccc2e36f56881b7495737d786e4a7d392e2f35a0
+  metadata.gz: 6429f24abd079c31a99e0701dbe051d9f63716776175028a56c9a65526486fc606cdcc8e107ccffcad77ae9cc75c2c52c84dbe2f24fb611f77cd5cb105f48686
+  data.tar.gz: 4344478d6dc7553594d54b89f274ad4854e196e01c20d36fc219fbc356113068282fa6e113611ced192e6add67b693b85706f5535cfa82b70ddaf377e0193a21

data/lib/thrifter/extensions/queueing.rb

@@ -12,27 +12,37 @@ module Thrifter
       # other structure. This is why the method has so many arguments.
       # Sidekik-thrift_arguments will correctly pick up any complex
       # type in the splat and handle serialization/deserialization
-      def perform(klass, rpc_name, *rpc_args)
+      def perform(klass, method_name, *args)
         client = klass.constantize.new
-        client.send rpc_name, *rpc_args
+        client.send method_name, *args
       end
     end
 
-    class Proxy
-      def initialize(klass, rpcs)
-        rpcs.each do |name|
-          define_singleton_method name do |*args|
-            job_args = [ klass.to_s, name ].concat(args)
-            Job.perform_async(*job_args)
-          end
+    class Proxy < BasicObject
+      def initialize(target)
+        @target = target
+      end
+
+      def method_missing(name, *args, &block)
+        if target.respond_to? name
+          job_args = [ target.class.to_s, name ].concat(args)
+          Job.perform_async(*job_args)
+        else
+          super
         end
       end
+
+      private
+
+      def target
+        @target
+      end
     end
 
     def queued
-      Proxy.new(self.class, rpcs).tap do |proxy|
-        yield proxy if block_given?
-      end
+      proxy = Proxy.new self
+      yield proxy if block_given?
+      proxy
     end
   end
 end

data/lib/thrifter/extensions/retriable.rb

@@ -16,21 +16,19 @@ module Thrifter
       Errno::ETIMEDOUT
     ]
 
-    class Proxy
+    class Proxy < BasicObject
       attr_reader :tries, :interval, :client
 
-      def initialize(client, tries, interval, rpcs)
+      def initialize(client, tries, interval)
         @client, @tries, @interval = client, tries, interval
-
-        rpcs.each do |name|
-          define_singleton_method name do |*args|
-            invoke_with_retry(name, *args)
-          end
-        end
       end
 
       private
 
+      def method_missing(name, *args)
+        invoke_with_retry(name, *args)
+      end
+
       def invoke_with_retry(name, *args)
         counter = 0
 
@@ -49,9 +47,9 @@ module Thrifter
     end
 
     def with_retry(tries: 5, interval: 0.01)
-      Proxy.new(self, tries, interval, rpcs).tap do |proxy|
-        yield proxy if block_given?
-      end
+      proxy = Proxy.new self, tries, interval
+      yield proxy if block_given?
+      proxy
     end
   end
 end

data/lib/thrifter/version.rb

@@ -1,3 +1,3 @@
 module Thrifter
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/test/extensions/queueing_test.rb

@@ -12,6 +12,10 @@ class QueuingTest < MiniTest::Unit::TestCase
     include Thrifter::Queueing
 
     self.config.uri = 'tcp://localhost:9090'
+
+    def custom_echo
+      echo TestMessage.new(message: 'custom')
+    end
   end
 
   def queue
@@ -26,7 +30,7 @@ class QueuingTest < MiniTest::Unit::TestCase
     queue.clear
   end
 
-  def test_sends_rpcs_with_sidekiq
+  def test_queues_methods_with_sidekiq
     client = QueuedClient.new
 
     message = TestMessage.new message: 'echo'
@@ -62,7 +66,7 @@ class QueuingTest < MiniTest::Unit::TestCase
     refute jobs.empty?, 'Nothing enqueued'
   end
 
-  def test_fails_if_given_rpc_name
+  def test_fails_if_given_unknown_method
     client = QueuedClient.new
     message = TestMessage.new message: 'echo'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: thrifter
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - ahawkins
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-01 00:00:00.000000000 Z
+date: 2015-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thrift