threedaymonk-l10nizer 0.0.5 → 0.0.6

data/lib/l10nizer/keygen.rb

@@ -27,7 +27,13 @@ module L10nizer
 
     def make_safe(string)
       return nil if string.nil?
-      safe = string.downcase.gsub(/[^a-z0-9]+/, "_").gsub(/^_|_$/, "")[0, 40]
+      safe = string.
+             downcase.
+             gsub(/&[a-z0-9]{1,20};/, ""). # entities
+             gsub(/<[^>]*>/, "").          # html
+             gsub(/[^a-z0-9]+/, "_").      # non alphanumeric
+             slice(0, 40).
+             gsub(/^_|_$/, "")             # leading/trailing _
       safe = "unknown" if safe.empty?
       safe
     end

data/lib/l10nizer/version.rb

@@ -2,7 +2,7 @@ module L10nizer #:nodoc:
   module VERSION #:nodoc:
     MAJOR = 0
     MINOR = 0
-    TINY  = 5
+    TINY  = 6
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/test/test_key_generator.rb

@@ -17,7 +17,7 @@ class KeyGeneratorTest < Test::Unit::TestCase
 
     should "truncate exceptionally long keys" do
       long  = "blah_" * 20
-      short = long[0, 40]
+      short = "blah_blah_blah_blah_blah_blah_blah_blah"
       assert_equal short, @keygen.call(long)
     end
 
@@ -31,9 +31,17 @@ class KeyGeneratorTest < Test::Unit::TestCase
       assert_equal "a_thing_2", @keygen.call("A Thing")
     end
 
-    should "generate_non_empty_keys_for_punctuation" do
+    should "generate non empty keys for punctuation" do
       assert_not_equal "", @keygen.call("<>!@#%#.,")
     end
+
+    should "skip entities in keys" do
+      assert_equal "foo_bar", @keygen.call("foo &apos; bar")
+    end
+
+    should "skip inline markup in keys" do
+      assert_equal "foo_bar", @keygen.call("foo <strong>bar</strong>")
+    end
   end
 
   context "with namespacing" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: threedaymonk-l10nizer
 version: !ruby/object:Gem::Version 
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors: 
 - Paul Battley