thread-parent 1.0.1 → 1.0.2

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 rvm:
+  - 2.0.0
   - 1.9.3
   - jruby-19mode
   

data/README.md

@@ -19,46 +19,46 @@ Or install it yourself as:
 
 ## Usage
 
-You can either create ThreadParent::Thread directly:
+Thread is extended to provide direct access to its 'parent', or the thread where the current
+thread was created.  It also provides a way to lookup through its ancestor chain for Thread-local variables.
 
 ```ruby
-require 'thread-parent'
+require 'thread_parent'
 
 Thread.current[:abc] = 'abc'
 
-ThreadParent::Thread.new do |thread|
+Thread.new do |thread|
   
-  thread.parent == Thread.main #= true
+  thread.parent == Thread.main #=> true
 
-  # Since the thread variable isn't set locally it will be found in its parent.
-  Thread.current[:abc] #= 'abc'
+  # Standard local variable lookup behaves as expected.
+  thread[:abc] #=> nil
 
-  # Local thread variable assignments work as expected.
-  Thread.current[:def] = 'def'
+  # Lookup through the ancestor chain is now supported.
+  thread.parents[:abc] #=> 'abc'
 
-  ThreadParent::Thread.new do
-    Thread.current[:def] #= 'def'
+  # Local thread variable assignments works as expected.
+  thread[:def] = 'def'
+  thread[:def] #=> 'def'
+  thread.parents[:def] #=> 'def' <- The calling thread is always checked first.
 
-    # The parent lookup will continue to the parent's parent until a variable is found.
-    Thread.current[:abc] #= 'abc'
-  end
-end
-```
+  # Short-hand references to the current thread's parents is also provided.
+  Thread.parents[:abc] #=> 'abc'
+  Thread.parent == Thread.main #=> true
 
-Or include the module to hijack references to Thread:
+  Thread.new do
+    Thread.parents[:def] #= 'def'
 
-```ruby
-require 'thread-parent'
-include ThreadParent
-
-Thread.new do
-  # This is really a ThreadParent::Thread
+    # The parent lookup will continue to the parent's parent until a variable is found.
+    Thread.parents[:abc] #= 'abc'
+  end
 end
 ```
 
 ## Code Status
 
 [![Build Status](https://api.travis-ci.org/mje113/thread-parent.png)](http://travis-ci.org/mje113/thread-parent)
+[![Code Climate](https://codeclimate.com/github/mje113/thread-parent.png)](https://codeclimate.com/github/mje113/thread-parent)
 
 ## Contributing
 

data/lib/thread_parent.rb

@@ -2,23 +2,45 @@ require 'thread_parent/version'
 require 'thread'
 
 module ThreadParent
-  class Thread < Thread
 
-    def initialize
-      @_parent = Thread.current
-      super
-    end
+  class Parents
 
-    def parent
-      @_parent
+    def initialize(child)
+      @child = child
     end
 
     def [](key)
-      if key?(key)
-        super
+      if @child.key?(key)
+        @child[key]
       else
-        parent[key]
+        @child.parent.parents[key]
       end
     end
   end
 end
+
+class Thread
+
+  alias_method :_initialize, :initialize
+
+  def initialize(*args, &block)
+    @_parent = Thread.current
+    _initialize(*args, &block)
+  end
+
+  def parent
+    @_parent
+  end
+
+  def parents
+    ThreadParent::Parents.new(self)
+  end
+
+  def self.parent
+    Thread.current.parent
+  end
+
+  def self.parents
+    ThreadParent::Parents.new(Thread.current)
+  end
+end

data/lib/thread_parent/version.rb

@@ -1,3 +1,3 @@
 module ThreadParent
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/test/test_thread_parent.rb

@@ -2,12 +2,15 @@ require 'helper'
 
 class TestThreadParent < MiniTest::Unit::TestCase
 
-  include ThreadParent
-
   def setup
     Thread.current[:a] = 'a'
   end
 
+  def test_is_a_thread_parent
+    thread = Thread.new { 'work' }
+    assert_kind_of Thread, thread
+  end
+
   def test_can_have_parent
     thread = Thread.new { 'work' }.join
     assert_equal Thread.current, thread.parent
@@ -15,13 +18,13 @@ class TestThreadParent < MiniTest::Unit::TestCase
 
   def test_can_find_thread_variable_in_parent
     thread = Thread.new { 'work' }.join
-    assert_equal 'a', thread[:a]
+    assert_equal 'a', thread.parents[:a]
   end
 
   def test_can_find_thread_variable_in_parents_parent
     Thread.new {
       Thread.new {
-        assert_equal 'a', Thread.current[:a]
+        assert_equal 'a', Thread.current.parents[:a]
       }.join
     }.join
   end
@@ -31,12 +34,12 @@ class TestThreadParent < MiniTest::Unit::TestCase
       Thread.current[:a] = 'b'
     }.join
 
-    assert_equal 'b', thread[:a]
+    assert_equal 'b', thread.parents[:a]
   end
 
   def test_wont_break_parent_threads_scope
     Thread.new { Thread.current[:a] = 'b' }.join
     thread = Thread.new { 'work' }.join
-    assert_equal('a', thread[:a])
+    assert_equal('a', thread.parents[:a])
   end
-end
+end

data/thread-parent.gemspec

@@ -16,4 +16,6 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
+
+  gem.add_development_dependency 'rake'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: thread-parent
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,8 +9,19 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-09 00:00:00.000000000 Z
-dependencies: []
+date: 2013-05-09 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: &70120867349120 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *70120867349120
 description: ThreadParent facilitates spawning threads that maintain a reference to
   the thread that created them. The primary goal is to allow thread local variable
   lookup through the ancestor chain.