thoughtbot-clearance 0.2.7 → 0.2.8

data/README.textile

@@ -50,9 +50,9 @@ This will create:
     test/unit/user_mailer_test.rb
     test/unit/user_test.rb
 
-For example: 
+Add the corresponding Clearance module for any file(s) you don't want to override. They are namespaced exactly like the directory structure of a Rails app: 
 
-    app/models/user.rb already exists. Add this line to it:
+    app/models/user.rb already exists.
     include Clearance::App::Models::User
 
 h2. Tests

data/Rakefile

@@ -18,11 +18,12 @@ spec = Gem::Specification.new do |s|
   s.email = "dcroak@thoughtbot.com"
   s.homepage = "http://github.com/thoughtbot/clearance"
   s.description = "Simple, complete Rails authentication scheme."
-  s.authors = ["thoughtbot, inc.", "Dan Croak", "Josh Nichols", "Mike Breen", "Mike Burns", "Jason Morrison"]
+  s.authors = ["thoughtbot, inc.", "Dan Croak", "Josh Nichols", "Jason Morrison", "Mike Burns", "Mike Breen"]
   s.files = FileList["[A-Z]*", "{generators,lib,test}/**/*"]
 end
  
 begin
+  require 'rubygems'
   require 'jeweler'
   Jeweler.gemspec = spec
 rescue LoadError 

data/TODO.textile

@@ -2,7 +2,6 @@
 
 # activation code instead of salt?
 # users#show doesn't exist, but confirmations create redirects there
-# sessions controller test is missing remember_me tests
 # mailers should not hardcode example.com as from address
 # should_have_form should be pulled into shoulda
 # generator should print out instructions to include modules existing files

data/lib/clearance/test/functional/sessions_controller_test.rb

@@ -24,36 +24,65 @@ module Clearance
 
               context "a POST to #create with good credentials" do
                 setup do
-                  post :create, :session => { :email => @user.email, :password => @user.password }
+                  post :create, :session => { :email => @user.email, 
+                    :password => @user.password }
                 end
 
                 should_set_the_flash_to /success/i
                 should_redirect_to '@controller.send(:url_after_create)'
-                #should_return_from_session(:user_id, '@user.id')
-                should "return the correct value from the session for key :user_id" do
-                  instantiate_variables_from_assigns do
-                    expected_value = @user.id
-                    assert_equal expected_value, session[:user_id], "Expected #{expected_value.inspect} but was #{session[:user_id]}"
-                  end
-                end
+                should_return_from_session :user_id, "@user.id"
               end
 
               context "a POST to #create with bad credentials" do
                 setup do
-                  post :create, :session => { :email => @user.email, :password => "bad value" }
+                  post :create, :session => { :email => @user.email, 
+                    :password => "bad value" }
                 end
 
                 should_set_the_flash_to /bad/i
                 should_render_template :new
-                #should_return_from_session(:user_id, 'nil')
-                should "return nil from the session for key :user_id" do
-                  instantiate_variables_from_assigns do
-                    assert_nil session[:user_id], "Expected nil but was #{session[:user_id]}"
-                  end
-                end
+                should_return_from_session :user_id, "nil"
               end
           
-              # TODO: two tests for remember me - success and failure
+              context "a POST to #create with good credentials and remember me" do
+                setup do
+                  post :create, :session => { :email => @user.email, 
+                    :password => @user.password, :remember_me => '1' }
+                end
+
+                should_set_the_flash_to /success/i
+                should_redirect_to '@controller.send(:url_after_create)'
+                should_return_from_session :user_id, "@user.id"
+                
+                should 'set the cookie' do
+                  assert ! cookies['auth_token'].empty?
+                end
+
+                should 'set the remember me token in users table' do
+                  assert_not_nil @user.reload.remember_token
+                  assert_not_nil @user.reload.remember_token_expires_at
+                end
+              end
+              
+              context "a POST to #create with bad credentials and remember me" do
+                setup do
+                  post :create, :session => { :email => @user.email, 
+                    :password => "bad value", :remember_me => '1' }
+                end
+
+                should_set_the_flash_to /bad/i
+                should_render_template :new
+                should_return_from_session :user_id, "nil"
+                
+                should 'not create the cookie' do
+                  assert_nil cookies['auth_token']
+                end
+
+                should 'not set the remember me token in users table' do
+                  assert_nil @user.reload.remember_token
+                  assert_nil @user.reload.remember_token_expires_at
+                end
+              end
             end
 
             public_context do

data/lib/clearance/version.rb

@@ -1,7 +1,7 @@
-class Clearance
+module Clearance
   module Version
     MAJOR = 0
     MINOR = 2
-    PATCH = 7
+    PATCH = 8
   end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification 
 name: thoughtbot-clearance
 version: !ruby/object:Gem::Version 
-  version: 0.2.7
+  version: 0.2.8
 platform: ruby
 authors: 
 - thoughtbot, inc.
 - Dan Croak
 - Josh Nichols
-- Mike Breen
-- Mike Burns
 - Jason Morrison
+- Mike Burns
+- Mike Breen
 autorequire: 
 bindir: bin
 cert_chain: []