thoughtbot-clearance 0.2.6 → 0.2.7

data/lib/clearance/test/functional/confirmations_controller_test.rb

@@ -0,0 +1,85 @@
+module Clearance
+  module Test
+    module Functional
+      module ConfirmationsControllerTest
+
+        def self.included(base)
+          base.class_eval do
+
+            context 'A GET to #new' do
+              context "with the User with the given id's salt" do
+                setup do
+                  @user = Factory :user
+                  get :new, :user_id => @user.id, :salt => @user.salt
+                end
+
+                should 'find the User record with the given id and salt' do
+                  assert_equal @user, assigns(:user)
+                end
+
+                should_respond_with :success
+                should_render_template :new
+              end
+
+              context "without the User with the given id's salt" do
+                setup do
+                  user = Factory :user
+                  salt = ''
+                  assert_not_equal salt, user.salt
+
+                  get :new, :user_id => user.id, :salt => ''
+                end
+
+                should_respond_with :not_found
+
+                should 'render nothing' do
+                  assert @response.body.blank?
+                end
+              end
+            end
+
+            context 'A POST to #create' do
+              context "with the User with the given id's salt" do
+                setup do
+                  @user = Factory :user
+                  assert ! @user.confirmed?
+
+                  post :create, :user_id => @user, :salt => @user.salt
+                  @user.reload
+                end
+
+                should 'confirm the User record with the given id' do
+                  assert @user.confirmed?
+                end
+
+                should 'log the User in' do
+                  assert_equal @user.id, session[:user_id]
+                end
+
+                should_redirect_to "user_path(@user)"
+              end
+
+              context "without the User with the given id's salt" do
+                setup do
+                  user = Factory :user
+                  salt = ''
+                  assert_not_equal salt, user.salt
+
+                  post :create, :user_id => user.id, :salt => salt
+                end
+
+                should_respond_with :not_found
+
+                should 'render nothing' do
+                  assert @response.body.blank?
+                end
+              end
+            end
+
+          end
+        end
+
+      end
+    end
+  end
+end

data/lib/clearance/test/functional/passwords_controller_test.rb

@@ -0,0 +1,192 @@
+module Clearance
+  module Test
+    module Functional
+      module PasswordsControllerTest
+
+        def self.included(base)
+          base.class_eval do
+
+            should_route :get, '/users/1/password/edit', :action => 'edit', :user_id => '1'
+
+            context 'with a user' do
+              setup { @user = Factory :user }
+
+              context 'A GET to #new' do
+                setup { get :new, :user_id => @user_id }
+
+                should_respond_with :success
+                should_render_template 'new'
+              end
+
+              context 'A POST to #create' do
+                context "with an existing user's email address" do
+                  setup do
+                    ActionMailer::Base.deliveries.clear
+
+                    post :create, :password => { :email => @user.email }
+                    @email = ActionMailer::Base.deliveries[0]
+                  end
+
+                  should 'send an email to the user to edit their password' do
+                    assert @email.subject =~ /request to change your password/i
+                  end
+
+                  should_redirect_to "new_session_path"
+                end
+
+                context 'with a non-existing email address' do
+                  setup do
+                    email = 'user1@example.com'
+                    assert ! User.exists?(['email = ?', email])
+                    ActionMailer::Base.deliveries.clear
+
+                    post :create, :password => { :email => email }
+                  end
+
+                  should 'not send a password reminder email' do
+                    assert ActionMailer::Base.deliveries.empty?
+                  end
+
+                  should 'set a :warning flash' do
+                    assert_not_nil flash.now[:warning]
+                  end
+
+                  should_render_template "new"
+                end
+              end
+
+              context 'A GET to #edit' do
+                context "with an existing user's id and password" do
+                  setup do
+                    get :edit, 
+                      :user_id => @user.id, 
+                      :password => @user.crypted_password, 
+                      :email => @user.email
+                  end
+
+                  should 'find the user with the given id and password' do
+                    assert_equal @user, assigns(:user)
+                  end
+
+                  should_respond_with :success
+                  should_render_template "edit"
+
+                  should "have a form for the user's email, password, and password confirm" do
+                    update_path = ERB::Util.h(user_password_path(@user,
+                          :password => @user.crypted_password,
+                          :email    => @user.email))
+
+                    assert_select 'form[action=?]', update_path do
+                      assert_select 'input[name=_method][value=?]', 'put'
+                      assert_select 'input[name=?]', 'user[password]'
+                      assert_select 'input[name=?]', 'user[password_confirmation]'
+                    end
+                  end
+                end
+
+                context "with an existing user's id but not password" do
+                  setup do
+                    get(:edit,
+                        :user_id => @user.id,
+                        :password => '')
+                  end
+
+                  should_respond_with :not_found
+
+                  should 'render an empty response' do
+                    assert @response.body.blank?
+                  end
+                end
+              end
+
+              context 'A PUT to #update' do
+                context "with an existing user's id but not password" do
+                  setup do
+                    put(:update,
+                        :user_id => @user.id,
+                        :password => '')
+                  end
+
+                  should "not update the user's password" do
+                    assert_not_equal @encrypted_new_password, @user.crypted_password
+                  end
+
+                  should 'not log the user in' do
+                    assert_nil session[:user_id]
+                  end
+
+                  should_respond_with :not_found
+
+                  should 'render an empty response' do
+                    assert @response.body.blank?
+                  end
+                end
+
+                context 'with a matching password and password confirmation' do
+                  setup do
+                    new_password = 'new_password'
+                    encryption_format = "--#{@user.salt}--#{new_password}--"
+                    @encrypted_new_password = Digest::SHA1.hexdigest encryption_format
+                    assert_not_equal @encrypted_new_password, @user.crypted_password
+
+                    put(:update,
+                        :user_id  => @user,
+                        :email    => @user.email,
+                        :password => @user.crypted_password,
+                        :user => {
+                          :password              => new_password,
+                          :password_confirmation => new_password
+                        })
+                    @user.reload
+                  end
+
+                  should "update the user's password" do
+                    assert_equal @encrypted_new_password, @user.crypted_password
+                  end
+
+                  should 'log the user in' do
+                    assert_equal session[:user_id], @user.id
+                  end
+
+                  should_redirect_to "user_path(@user)"
+                end
+
+                context 'with password but blank password confirmation' do
+                  setup do
+                    new_password = 'new_password'
+                    encryption_format = "--#{@user.salt}--#{new_password}--"
+                    @encrypted_new_password = Digest::SHA1.hexdigest encryption_format
+
+                    put(:update,
+                        :user_id => @user.id,
+                        :password => @user.crypted_password,
+                        :user => {
+                          :password => new_password,
+                          :password_confirmation => ''
+                        })
+                    @user.reload
+                  end
+
+                  should "not update the user's password" do
+                    assert_not_equal @encrypted_new_password, @user.crypted_password
+                  end
+
+                  should 'not log the user in' do
+                    assert_nil session[:user_id]
+                  end
+
+                  should_respond_with :not_found
+
+                  should 'render an empty response' do
+                    assert @response.body.blank?
+                  end
+                end
+              end
+            end
+          end
+        end
+
+      end
+    end
+  end
+end

data/lib/clearance/test/functional/sessions_controller_test.rb

@@ -0,0 +1,96 @@
+module Clearance
+  module Test
+    module Functional
+      module SessionsControllerTest
+    
+        def self.included(base)
+          base.class_eval do
+            context "Given a user" do
+              setup { @user = Factory :user }
+
+              should_filter_params :password
+
+              context "on GET to /sessions/new" do
+                setup { get :new }
+          
+                should_respond_with :success
+                should_render_template :new
+                should_not_set_the_flash
+                should_have_form :action => "session_path",
+                  :fields => { "session[email]" => :text,
+                    "session[password]" => :password,
+                    "session[remember_me]" => :checkbox }
+              end
+
+              context "a POST to #create with good credentials" do
+                setup do
+                  post :create, :session => { :email => @user.email, :password => @user.password }
+                end
+
+                should_set_the_flash_to /success/i
+                should_redirect_to '@controller.send(:url_after_create)'
+                #should_return_from_session(:user_id, '@user.id')
+                should "return the correct value from the session for key :user_id" do
+                  instantiate_variables_from_assigns do
+                    expected_value = @user.id
+                    assert_equal expected_value, session[:user_id], "Expected #{expected_value.inspect} but was #{session[:user_id]}"
+                  end
+                end
+              end
+
+              context "a POST to #create with bad credentials" do
+                setup do
+                  post :create, :session => { :email => @user.email, :password => "bad value" }
+                end
+
+                should_set_the_flash_to /bad/i
+                should_render_template :new
+                #should_return_from_session(:user_id, 'nil')
+                should "return nil from the session for key :user_id" do
+                  instantiate_variables_from_assigns do
+                    assert_nil session[:user_id], "Expected nil but was #{session[:user_id]}"
+                  end
+                end
+              end
+          
+              # TODO: two tests for remember me - success and failure
+            end
+
+            public_context do
+              context "logging out again" do
+                setup { delete :destroy }
+                should_redirect_to '@controller.send(:url_after_destroy)'
+              end
+            end
+
+            logged_in_user_context do
+              context "a DELETE to #destroy without a cookie" do
+                setup { delete :destroy }
+
+                should_set_the_flash_to(/logged out/i)
+                should_redirect_to '@controller.send(:url_after_destroy)'
+              end
+
+              context 'a DELETE to #destroy with a cookie' do
+                setup do
+                  cookies['auth_token'] = CGI::Cookie.new 'token', 'value'
+                  delete :destroy
+                end
+
+                should 'delete the cookie' do
+                  assert cookies['auth_token'].empty?
+                end
+
+                should 'delete the remember me token in users table' do
+                  assert_nil @user.reload.remember_token
+                  assert_nil @user.reload.remember_token_expires_at
+                end
+              end
+            end
+          end
+        end
+
+      end
+    end
+  end
+end

data/lib/clearance/test/functional/users_controller_test.rb

@@ -0,0 +1,64 @@
+module Clearance
+  module Test
+    module Functional
+      module UsersControllerTest
+
+        def self.included(base)
+          base.class_eval do
+            public_context do
+
+              context "on GET to /users/new" do
+                setup { get :new }
+                should_respond_with :success
+                should_render_template :new
+                should_not_set_the_flash
+                should_have_form :action => "users_path",
+                  :method => :post,
+                  :fields => { :email => :text,
+                    :password => :password,
+                    :password_confirmation => :password }
+
+                context "with params" do
+                  setup do
+                    @email = 'a@example.com'
+                    get :new, :user => {:email => @email}
+                  end
+
+                  should_assign_to :user
+                  should "set the @user's params" do
+                    assert_equal @email, assigns(:user).email
+                  end
+                end
+              end
+
+              context "on POST to /users" do
+                setup do
+                  post :create, :user => {
+                    :email => Factory.next(:email),
+                    :password => 'skerit',
+                    :password_confirmation => 'skerit'
+                  }
+                end
+            
+                should_set_the_flash_to /confirm/i
+                should_redirect_to "@controller.send(:url_after_create)"
+                should_assign_to :user
+                should_change 'User.count', :by => 1
+              end
+
+            end
+
+            logged_in_user_context do
+
+              should_deny_access_on "get :new"
+              should_deny_access_on "post :create, :user => {}" 
+              should_filter_params :password
+
+            end
+          end
+        end
+
+      end
+    end
+  end
+end

data/lib/clearance/test/unit/user_mailer_test.rb

@@ -0,0 +1,38 @@
+module Clearance
+  module Test
+    module Unit
+      module UserMailerTest
+  
+        def self.included(base)
+          base.class_eval do
+            context "A change password email" do
+              setup do
+                @user = Factory :user
+                @email = UserMailer.create_change_password @user
+              end
+
+              should "set its from address to 'donotreply@example.com'" do
+                assert_equal 'donotreply@example.com', @email.from[0]
+              end
+
+              should "contain a link to edit the user's password" do
+                host = ActionMailer::Base.default_url_options[:host]
+                regexp = %r{http://#{host}/users/#{@user.id}/password/edit\?email=#{@user.email.gsub("@", "%40")}&password=#{@user.crypted_password}}
+                assert_match regexp, @email.body
+              end
+
+              should "be sent to the user" do
+                assert_equal [@user.email], @email.to
+              end
+
+              should "have a subject of '[YOUR APP] Request to change your password'" do
+                assert_equal "[YOUR APP] Request to change your password", @email.subject
+              end
+            end
+          end
+        end
+
+      end
+    end  
+  end
+end

data/lib/clearance/test/unit/user_test.rb

@@ -0,0 +1,208 @@
+module Clearance
+  module Test
+    module Unit
+      module UserTest
+    
+        def self.included(base)
+          base.class_eval do
+            should_require_attributes :email, :password
+
+            should "require password validation on create" do
+              user = Factory.build(:user, :password => 'blah', :password_confirmation => 'boogidy')
+              assert !user.save
+              assert_match(/confirmation/i, user.errors.on(:password))
+            end
+
+            should "create a crypted_password on save" do
+              assert_not_nil Factory(:user, :crypted_password => nil).crypted_password
+            end
+
+            context 'updating a password' do
+              setup do
+                @user = Factory(:user)
+                assert_not_nil @user.crypted_password
+                @crypt = @user.crypted_password
+                assert_not_nil @user.salt
+                @salt = @user.salt
+                @user.password = 'a_new_password'
+                @user.password_confirmation = 'a_new_password'
+                assert @user.save
+              end
+
+              should 'update a crypted_password' do
+                @user.reload
+                assert @user.crypted_password != @crypt
+              end
+            end
+        
+            context 'A user' do
+              setup do
+                @salt = 'salt'
+                User.any_instance.stubs(:initialize_salt)
+                @user = Factory :user, :salt => @salt
+                @password = @user.password
+              end
+          
+              should "require password validation on update" do
+                @user.update_attributes(:password => "blah", :password_confirmation => "boogidy")
+                assert !@user.save
+                assert_match(/confirmation/i, @user.errors.on(:password))
+              end
+          
+              should_require_unique_attributes :email
+          
+              context 'authenticating a user' do
+                context 'with good credentials' do
+                  setup do
+                    @result = User.authenticate @user.email, @password
+                  end
+
+                  should 'return true' do
+                    assert @result
+                  end
+                end
+
+                context 'with bad credentials' do
+                  setup do
+                    @result = User.authenticate @user.email, 'horribly_wrong_password'
+                  end
+
+                  should 'return false' do
+                    assert !@result
+                  end
+                end
+              end
+          
+              context 'authenticated?' do
+                context 'with good credentials' do
+                  setup do
+                    @result = @user.authenticated? @password
+                  end
+
+                  should 'return true' do
+                    assert @result
+                  end
+                end
+
+                context 'with bad credentials' do
+                  setup do
+                    @result = @user.authenticated? 'horribly_wrong_password'
+                  end
+
+                  should 'return false' do
+                    assert !@result
+                  end
+                end
+              end
+
+              context 'encrypt' do
+                setup do
+                  @crypted  = @user.encrypt(@password)
+                  @expected = Digest::SHA1.hexdigest("--#{@salt}--#{@password}--")
+                end
+
+                should 'create a Hash using SHA1 encryption' do
+                  assert_equal @expected, @crypted
+                  assert_not_equal @password, @crypted
+                end
+              end
+
+              context 'remember_me!' do
+                setup do
+                  assert_nil @user.remember_token
+                  assert_nil @user.remember_token_expires_at
+                  @user.remember_me!
+                end
+
+                should 'set the remember token and expiration date' do
+                  assert_not_nil @user.remember_token
+                  assert_not_nil @user.remember_token_expires_at
+                end
+
+                should 'remember_token?' do
+                  assert @user.remember_token?
+                end
+
+                context 'forget_me!' do
+                  setup do
+                    @user.forget_me!
+                  end
+
+                  should 'unset the remember token and expiration date' do
+                    assert_nil @user.remember_token
+                    assert_nil @user.remember_token_expires_at
+                  end
+
+                  should 'not remember_token?' do
+                    assert ! @user.remember_token?
+                  end
+                end
+              end
+
+              context 'remember_token?' do
+                context 'when token expires in the future' do
+                  setup do
+                    @user.update_attribute :remember_token_expires_at, 2.weeks.from_now.utc
+                  end
+
+                  should 'be true' do
+                    assert @user.remember_token?
+                  end
+                end
+
+                context 'when token expired' do
+                  setup do
+                    @user.update_attribute :remember_token_expires_at, 2.weeks.ago.utc
+                  end
+
+                  should 'be false' do
+                    assert ! @user.remember_token?
+                  end
+                end
+              end
+
+              context "User.authenticate with a valid email and password" do
+                setup do
+                  @found_user = User.authenticate @user.email, @user.password
+                end
+
+                should "find that user" do
+                  assert_equal @user, @found_user
+                end
+              end
+
+              context "When sent authenticate with an invalid email and password" do
+                setup do
+                  @found_user = User.authenticate "not", "valid" 
+                end
+
+                should "find nothing" do
+                  assert_nil @found_user
+                end
+              end
+            end
+
+            context "A user" do
+              setup do
+                @user = Factory :user
+              end
+
+              context 'when sent #confirm!' do
+                setup do
+                  assert ! @user.confirmed?
+                  assert @user.confirm!
+                  @user.reload
+                end
+
+                should 'mark the User record as confirmed' do
+                  assert @user.confirmed?
+                end
+              end
+            end
+          end
+        end
+
+      end
+    end
+  end
+end

data/lib/clearance/version.rb

@@ -1,7 +1,7 @@
-module Clearance
+class Clearance
   module Version
     MAJOR = 0
     MINOR = 2
-    PATCH = 6
+    PATCH = 7
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: thoughtbot-clearance
 version: !ruby/object:Gem::Version 
-  version: 0.2.6
+  version: 0.2.7
 platform: ruby
 authors: 
 - thoughtbot, inc.
@@ -81,15 +81,15 @@ files:
 - lib/clearance/app/models/user.rb
 - lib/clearance/app/models/user_mailer.rb
 - lib/clearance/test
-- lib/clearance/test/functionals
-- lib/clearance/test/functionals/confirmations_controller_test.rb
-- lib/clearance/test/functionals/passwords_controller_test.rb
-- lib/clearance/test/functionals/sessions_controller_test.rb
-- lib/clearance/test/functionals/users_controller_test.rb
+- lib/clearance/test/functional
+- lib/clearance/test/functional/confirmations_controller_test.rb
+- lib/clearance/test/functional/passwords_controller_test.rb
+- lib/clearance/test/functional/sessions_controller_test.rb
+- lib/clearance/test/functional/users_controller_test.rb
 - lib/clearance/test/test_helper.rb
-- lib/clearance/test/units
-- lib/clearance/test/units/user_mailer_test.rb
-- lib/clearance/test/units/user_test.rb
+- lib/clearance/test/unit
+- lib/clearance/test/unit/user_mailer_test.rb
+- lib/clearance/test/unit/user_test.rb
 - lib/clearance/version.rb
 - lib/clearance.rb
 - test/rails_root
@@ -142,8 +142,10 @@ files:
 - test/rails_root/config/routes.rb
 - test/rails_root/db
 - test/rails_root/db/bootstrap
+- test/rails_root/db/development.sqlite3
 - test/rails_root/db/migrate
 - test/rails_root/db/migrate/001_create_users.rb
+- test/rails_root/db/schema.rb
 - test/rails_root/db/test.sqlite3
 - test/rails_root/doc
 - test/rails_root/doc/README_FOR_APP
@@ -198,6 +200,8 @@ files:
 - test/rails_root/script/server
 - test/rails_root/test
 - test/rails_root/test/factories.rb
+- test/rails_root/test/fixtures
+- test/rails_root/test/fixtures/mailer
 - test/rails_root/test/functional
 - test/rails_root/test/functional/confirmations_controller_test.rb
 - test/rails_root/test/functional/passwords_controller_test.rb
@@ -211,6 +215,11 @@ files:
 - test/rails_root/test/unit
 - test/rails_root/test/unit/user_mailer_test.rb
 - test/rails_root/test/unit/user_test.rb
+- test/rails_root/tmp
+- test/rails_root/tmp/cache
+- test/rails_root/tmp/pids
+- test/rails_root/tmp/sessions
+- test/rails_root/tmp/sockets
 - test/rails_root/vendor
 - test/rails_root/vendor/gems
 - test/rails_root/vendor/gems/mocha-0.9.1
@@ -532,39 +541,6 @@ files:
 - test/rails_root/vendor/plugins/factory_girl_on_rails/rails_generators/factory/templates/unit_test.rb
 - test/rails_root/vendor/plugins/factory_girl_on_rails/rails_generators/factory/USAGE
 - test/rails_root/vendor/plugins/factory_girl_on_rails/README
-- test/rails_root/vendor/plugins/shoulda
-- test/rails_root/vendor/plugins/shoulda/bin
-- test/rails_root/vendor/plugins/shoulda/lib
-- test/rails_root/vendor/plugins/shoulda/lib/shoulda
-- test/rails_root/vendor/plugins/shoulda/lib/shoulda/action_mailer
-- test/rails_root/vendor/plugins/shoulda/lib/shoulda/active_record
-- test/rails_root/vendor/plugins/shoulda/lib/shoulda/controller
-- test/rails_root/vendor/plugins/shoulda/lib/shoulda/controller/formats
-- test/rails_root/vendor/plugins/shoulda/tasks
-- test/rails_root/vendor/plugins/shoulda/test
-- test/rails_root/vendor/plugins/shoulda/test/fixtures
-- test/rails_root/vendor/plugins/shoulda/test/functional
-- test/rails_root/vendor/plugins/shoulda/test/other
-- test/rails_root/vendor/plugins/shoulda/test/rails_root
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/app
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/app/controllers
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/app/helpers
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/app/models
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/app/views
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/app/views/layouts
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/app/views/posts
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/app/views/users
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/config
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/config/environments
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/config/initializers
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/db
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/db/migrate
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/log
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/public
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/script
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/vendor
-- test/rails_root/vendor/plugins/shoulda/test/rails_root/vendor/plugins
-- test/rails_root/vendor/plugins/shoulda/test/unit
 has_rdoc: false
 homepage: http://github.com/thoughtbot/clearance
 post_install_message: