this_feature 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b061ce7c8ed9133983dfc5435b15e70159f92226ecbdd2e96f3796e8e1bc6962
-  data.tar.gz: 3edd88333694e493d2e3c93bca6d1266a5d17ac9539771e7f434ad2e6d062eb8
+  metadata.gz: ac249d0e2b607a1e24264851a2429160e9002634da26cb409f6d9b903e6a6157
+  data.tar.gz: 96464767635651ed17b057629e7bcdf2abd5dd6fc82fac20bfec75248d93fe55
 SHA512:
-  metadata.gz: b6ece19b22abae62d53094df235f29236a55970a3dd43f6b36818d8c5666181c7cf82326fd5b84c276095e484d39144e91bc186f8f88cb89efd2b0f4008fddd0
-  data.tar.gz: 1e2fd96239fb9c9f203475a95ed0c92ded460d35093ca97d69766ab72da8ed880868d135533cb034de867a1b2e85b04c5339eb1bf76ae357ec8a08df03143884
+  metadata.gz: f8725be53adf91f813519ac778a9e3558c5981d9a5908fc94578508b9f1baa2a607f9d47e4015159726dc18c4670b9f14f87ea844923936ce0f2bf7b114ef110
+  data.tar.gz: b3ced52a1340ddc0c8664d92300ca2c13154a75a5e7d1a5767e7fe4f6f1549bc8a8fcd107289252a5e6a25f915df5cf31a2b40f926ae791b608891afaf853b67

data/Gemfile

@@ -2,3 +2,4 @@ source "https://rubygems.org"
 
 gemspec name: "this_feature"
 gemspec name: "this_feature-adapters-flipper"
+gemspec name: "this_feature-adapters-split_io"

data/Gemfile.lock

@@ -1,10 +1,14 @@
 PATH
   remote: .
   specs:
-    this_feature (0.3.0)
-    this_feature-adapters-flipper (0.3.0)
+    this_feature (0.4.0)
+    this_feature-adapters-flipper (0.4.0)
       flipper (~> 0.16)
       flipper-active_record (~> 0.16)
+      this_feature
+    this_feature-adapters-split_io (0.4.0)
+      splitclient-rb
+      this_feature
 
 GEM
   remote: https://rubygems.org/
@@ -23,20 +27,30 @@ GEM
     byebug (11.1.2)
     coderay (1.1.2)
     concurrent-ruby (1.1.6)
+    connection_pool (2.2.3)
     database_cleaner (1.8.4)
     database_cleaner-active_record (1.8.0)
       activerecord
       database_cleaner (~> 1.8.0)
     diff-lcs (1.3)
+    faraday (1.0.1)
+      multipart-post (>= 1.2, < 3)
     flipper (0.18.0)
     flipper-active_record (0.18.0)
       activerecord (>= 5.0, < 7)
       flipper (~> 0.18.0)
     gem-release (2.1.1)
+    hitimes (1.3.1)
     i18n (1.8.5)
       concurrent-ruby (~> 1.0)
+    json (2.3.1)
+    jwt (2.2.2)
+    lru_redux (1.1.0)
     method_source (1.0.0)
     minitest (5.14.1)
+    multipart-post (2.1.1)
+    net-http-persistent (4.0.0)
+      connection_pool (~> 2.2)
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
@@ -44,6 +58,7 @@ GEM
       byebug (~> 11.0)
       pry (~> 0.13.0)
     rake (13.0.1)
+    redis (4.2.1)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -57,6 +72,18 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.2)
+    socketry (0.5.1)
+      hitimes (~> 1.2)
+    splitclient-rb (7.1.3)
+      concurrent-ruby (~> 1.0)
+      faraday (>= 0.8)
+      json (>= 1.8)
+      jwt (>= 2.2.1)
+      lru_redux
+      net-http-persistent (>= 2.9)
+      redis (>= 3.2)
+      socketry (~> 0.5.1)
+      thread_safe (>= 0.3)
     sqlite3 (1.4.2)
     thread_safe (0.3.6)
     tzinfo (1.2.7)
@@ -76,6 +103,7 @@ DEPENDENCIES
   sqlite3
   this_feature!
   this_feature-adapters-flipper!
+  this_feature-adapters-split_io!
 
 BUNDLED WITH
    2.1.4

data/README.md

@@ -19,42 +19,68 @@ bundle
 Or install it yourself as:
 
 ```sh
-gem install feature
+gem install this_feature
 ```
 
-## Usage
+## Configuration
+
+```ruby
+# config/initializers/this_feature.rb
+require 'this_feature'
 
-### Currently
+ThisFeature.configure do |config|
+  config.adapters = [ThisFeature::Adapters::Memory]
+  config.default_adapter = config.adapters.first
+end
+```
 
-Currently, the only available adapter is `Flipper`.
-We will update this document when more are added.
+**NOTE**: When searching for the presence of a flag, adapters are queried in order. The default adapter is the fallback adapter used when a flag isn't present in any of the adapters.
 
-To set it up, put this in an initializer file:
+
+### With Flipper
 
 ```ruby
-ThisFeature.set_adapters([ThisFeature::Adapters::FlipperAdapter])
+# config/initializers/this_feature.rb
+require 'this_feature/adapters/flipper'
+
+ThisFeature.configure do |config|
+  config.adapters = [ThisFeature::Adapters::Flipper]
+  config.default_adapter = config.adapters.first
+end
 ```
 
-This `set_adapters` will internally call the `.setup` method on the `FlipperAdapter`, which performs the Flipper initialization.
 
-Then you can call `ThisFeature.enabled?("flag name")`.
 
-It will iterate through the adapters until one of them returns `true`/`false`.
+## Usage
+
+### Flags
+```ruby
+ThisFeature.flag('flag_name').on? # check if flag is turned on
+ThisFeature.flag('flag_name').off? # check if flag is turned off
+ThisFeature.flag('flag_name').control? # see if the adapter is using the control
+ThisFeature.flag('flag_name').on! # turn on the flag
+ThisFeature.flag('flag_name').off! # turn off the flag
+```
 
-A context (`User` or `Org`) can be passed in the arguments to `enabled?` as well. `ThisFeature.enabled?(:flag_name, Current.user)`
+### Context
 
-### Planned
+You can also pass a context to the flag, many feature flagging systems support this.
 
-Create an initializer file in your Rails app:
+```ruby
+ThisFeature.flag('flag_name', context: current_user).on?
+```
 
-`/config/initializers/this_feature.rb`
+### Data
 
-And set your list of adapters, _ordered by priority_. For example:
+In case context is not sufficient, you can also pass a data hash.
 
 ```ruby
-ThisFeature.adapters = [SplitIO Flipper]
+ThisFeature.flag('flag_name', context: context, data: { org_id: 1 }).on?
 ```
 
+## TODO: Write documentation for the adapters (creating adapters, using memory adapter, using flipper adapter)
+
+
 ## Development
 
 The tests are a good reflection of the current development state.

data/lib/this_feature.rb

@@ -13,19 +13,19 @@ class ThisFeature
 
   def self.adapter_for(flag_name, context: nil, data: {})
     matching_adapter = adapters.find do |adapter|
-      adapter.present?(flag_name, context: context, data: data)
+      adapter.present?(flag_name)
     end
 
     matching_adapter || configuration.default_adapter
   end
 
-  # Configuration
-
   def self.configuration
     @configuration ||= Configuration.new
   end
 
   def self.configure
+    @configuration = Configuration.new
+
     yield(configuration)
 
     configuration.init
@@ -34,5 +34,4 @@ class ThisFeature
   def self.adapters
     configuration.adapters
   end
-
 end

data/lib/this_feature/adapters/base.rb

@@ -2,33 +2,25 @@ class ThisFeature
   module Adapters
     class Base
 
-      def self.setup
+      def setup
         raise UnimplementedError.new(self, __method__)
       end
 
-      def self.present?(flag_name)
+      def present?(flag_name)
         raise UnimplementedError.new(self, __method__)
       end
 
-      def self.on?(flag_name, context: nil, data: {})
+      def on?(flag_name, context: nil, data: {})
         raise UnimplementedError.new(self, __method__)
       end
 
-      def self.off?(flag_name, context: nil, data: {})
-        raise UnimplementedError.new(self, __method__)
-      end
-
-      def self.on!(flag_name, context: nil, data: {})
-        raise UnimplementedError.new(self, __method__)
-      end
-
-      def self.off!(flag_name, context: nil, data: {})
+      def off?(flag_name, context: nil, data: {})
         raise UnimplementedError.new(self, __method__)
       end
 
       # OPTIONAL method
       # check to see if a control is being used
-      def self.control?(flag_name, context: nil, data: {})
+      def control?(flag_name, context: nil, data: {})
         false
       end
     end

data/lib/this_feature/adapters/flipper.rb

@@ -4,31 +4,27 @@ require "flipper/adapters/active_record"
 class ThisFeature
   module Adapters
     class Flipper < Base
+      attr_reader :client
 
-      def self.setup(flipper = nil)
-        return @flipper = flipper unless flipper.nil?
-
-        @flipper = ::Flipper
+      def initialize(client: nil)
+        @client = client || default_flipper_adapter
+      end
 
-        ::Flipper.configure do |config|
-          config.default do
-            adapter = ::Flipper::Adapters::ActiveRecord.new
-            ::Flipper.new(adapter)
-          end
-        end
+      def present?(flag_name)
+        client[flag_name].exist?
       end
 
-      def self.present?(flag_name)
-        flipper[flag_name].exist?
+      def control?(flag_name, **kwargs)
+        !present?(flag_name)
       end
 
-      def self.on?(flag_name, context: nil, data: {})
+      def on?(flag_name, context: nil, data: {})
         return unless present?(flag_name)
 
-        flipper[flag_name].enabled?(*[context].compact)
+        client[flag_name].enabled?(*[context].compact)
       end
 
-      def self.off?(flag_name, context: nil, data: {})
+      def off?(flag_name, context: nil, data: {})
         on_result = on?(flag_name, context: context)
 
         return if on_result.nil?
@@ -36,16 +32,16 @@ class ThisFeature
         !on_result
       end
 
-      def self.on!(flag_name, context: nil, data: {})
-        flipper[flag_name].enable(*[context].compact)
-      end
+      private
 
-      def self.off!(flag_name, context: nil, data: {})
-        flipper[flag_name].disable(*[context].compact)
-      end
-
-      def self.flipper
-        @flipper
+      def default_flipper_adapter
+        ::Flipper.configure do |config|
+          config.default do
+            adapter = ::Flipper::Adapters::ActiveRecord.new
+            ::Flipper.new(adapter)
+          end
+        end
+        ::Flipper
       end
     end
   end

data/lib/this_feature/adapters/memory.rb

@@ -2,20 +2,19 @@ class ThisFeature
   module Adapters
     class Memory < Base
 
-      def self.setup(context_id_method: :id)
-        @context_id_method = context_id_method
+      def initialize(context_key_method: nil)
+        @context_key_method = context_key_method
       end
 
-      def self.clear
+      def clear
         storage.clear
       end
 
-      def self.present?(flag_name)
+      def present?(flag_name)
         !storage[flag_name].nil?
       end
 
-      def self.on?(flag_name, context: nil, data: {})
-        # binding.pry
+      def on?(flag_name, context: nil, data: {})
         return unless present?(flag_name)
 
         flag_data = storage[flag_name]
@@ -25,10 +24,10 @@ class ThisFeature
 
         flag_data[:contexts] ||= {}
 
-        !!flag_data[:contexts][context.send(@context_id_method)]
+        !!flag_data[:contexts][context_key(context)]
       end
 
-      def self.off?(flag_name, context: nil, data: {})
+      def off?(flag_name, context: nil, data: {})
         on_result = on?(flag_name, context: context)
 
         return if on_result.nil?
@@ -36,27 +35,37 @@ class ThisFeature
         !on_result
       end
 
-      def self.on!(flag_name, context: nil, data: {})
+      def on!(flag_name, context: nil, data: {})
         storage[flag_name] ||= {}
 
         return storage[flag_name][:global] = true if context.nil?
 
         storage[flag_name][:contexts] ||= {}
-        storage[flag_name][:contexts][context.send(@context_id_method)] = true
+        storage[flag_name][:contexts][context_key(context)] = true
       end
 
-      def self.off!(flag_name, context: nil, data: {})
+      def off!(flag_name, context: nil, data: {})
         storage[flag_name] ||= {}
 
         return storage[flag_name][:global] = false if context.nil?
 
         storage[flag_name][:contexts] ||= {}
-        storage[flag_name][:contexts][context.send(@context_id_method)] = false
+        storage[flag_name][:contexts][context_key(context)] = false
       end
 
-      def self.storage
+      def storage
         @storage ||= {}
       end
+
+      private
+
+      attr_reader :context_key_method
+
+      def context_key(context)
+        return context if context_key_method.nil?
+
+        context.send(context_key_method)
+      end
     end
   end
 end

data/lib/this_feature/adapters/split_io.rb

@@ -0,0 +1,52 @@
+require 'splitclient-rb'
+
+class ThisFeature
+  module Adapters
+    class SplitIo < Base
+      # used as treatment key when none is given, it's required by split
+      UNDEFINED_KEY = 'undefined_key'
+
+      def initialize(client: nil)
+        @client = client || default_split_client
+
+        @client.block_until_ready
+      end
+
+      def present?(flag_name)
+        !control?(flag_name)
+      end
+
+      def control?(flag_name, context: UNDEFINED_KEY, data: {})
+        treatment(flag_name, context: context, data: data).eql?('control_treatment')
+      end
+
+      def on?(flag_name, context: UNDEFINED_KEY, data: {})
+        treatment(flag_name, context: context, data: data).eql?('on')
+      end
+
+      def off?(flag_name, context: UNDEFINED_KEY, data: {})
+        treatment(flag_name, context: context, data: data).eql?('off')
+      end
+
+      private
+
+      attr_reader :client
+
+      def treatment(flag_name, context: UNDEFINED_KEY, data: {})
+        key = if context.nil?
+          UNDEFINED_KEY
+        elsif context.respond_to?(:to_s)
+          context.to_s
+        else
+          context
+        end
+
+        client.get_treatment(key, flag_name, data)
+      end
+
+      def default_split_client
+        SplitIoClient::SplitFactory.new(ENV.fetch('SPLIT_IO_AUTH_KEY')).client
+      end
+    end
+  end
+end

data/lib/this_feature/configuration.rb

@@ -5,13 +5,11 @@ class ThisFeature
 
     def init
       validate_adapters!
-
-      adapters.each(&:setup)
     end
 
     def validate_adapters!
       adapters.each do |adapter|
-        raise BadAdapterError.new(adapter) unless adapter < Adapters::Base
+        raise BadAdapterError.new(adapter) unless adapter.class < Adapters::Base
       end
     end
 

data/lib/this_feature/errors.rb

@@ -3,14 +3,14 @@ class ThisFeature
   class Error < StandardError; end
 
   class UnimplementedError < Error
-    def initialize(klass, fn_name)
-      super("class #{klass.name} doesnt implement method .#{fn_name}")
+    def initialize(adapter_instance, fn_name)
+      super("class #{adapter_instance.class.name} doesnt implement method .#{fn_name}")
     end
   end
 
   class BadAdapterError < Error
-    def initialize(adapter)
-      super("adapter #{adapter.name} doesn't inherit from ThisFeature::Adapters::Base")
+    def initialize(adapter_instance)
+      super("adapter #{adapter_instance.class.name} doesn't inherit from #{ThisFeature::Adapters::Base.name}")
     end
   end
 

data/lib/this_feature/flag.rb

@@ -20,13 +20,5 @@ class ThisFeature
     def control?
       adapter.control?(flag_name, context: context, data: data)
     end
-
-    def on!
-      adapter.on!(flag_name, context: context, data: data)
-    end
-
-    def off!
-      adapter.off!(flag_name, context: context, data: data)
-    end
   end
 end

data/lib/this_feature/version.rb

@@ -1,3 +1,3 @@
 class ThisFeature
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/this_feature-adapters-flipper.gemspec

@@ -18,6 +18,7 @@ Gem::Specification.new do |s|
   s.platform      = Gem::Platform::RUBY
   s.require_paths = ['lib']
 
+  s.add_runtime_dependency "this_feature"
   s.add_runtime_dependency "flipper", "~> 0.16"
   s.add_runtime_dependency "flipper-active_record", "~> 0.16"
 end

data/this_feature-adapters-split_io.gemspec

@@ -0,0 +1,23 @@
+# encoding: utf-8
+
+$:.unshift File.expand_path('../lib', __FILE__)
+
+require 'this_feature/version'
+
+Gem::Specification.new do |s|
+  s.name          = 'this_feature-adapters-split_io'
+  s.version       = ThisFeature::VERSION
+  s.authors       = ['Max Pleaner', 'Matt Fong']
+  s.email         = ['maxpleaner@gmail.com', 'matthewjf@gmail.com']
+  s.homepage      = 'http://hover.to'
+  s.licenses      = ['MIT']
+  s.summary       = '[summary]'
+  s.description   = '[description]'
+
+  s.files         = Dir.glob('{bin/*,lib/**/*,[A-Z]*}')
+  s.platform      = Gem::Platform::RUBY
+  s.require_paths = ['lib']
+
+  s.add_runtime_dependency "this_feature"
+  s.add_runtime_dependency "splitclient-rb"
+end

data/this_feature.gemspec

@@ -1,5 +1,7 @@
-lib = File.expand_path("lib", __dir__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+# encoding: utf-8
+
+$:.unshift File.expand_path('../lib', __FILE__)
+
 require "this_feature/version"
 
 Gem::Specification.new do |spec|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: this_feature
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Max Pleaner
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-08-26 00:00:00.000000000 Z
+date: 2020-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -132,18 +132,20 @@ files:
 - lib/this_feature/adapters/base.rb
 - lib/this_feature/adapters/flipper.rb
 - lib/this_feature/adapters/memory.rb
+- lib/this_feature/adapters/split_io.rb
 - lib/this_feature/configuration.rb
 - lib/this_feature/errors.rb
 - lib/this_feature/flag.rb
 - lib/this_feature/version.rb
 - this_feature-adapters-flipper.gemspec
+- this_feature-adapters-split_io.gemspec
 - this_feature.gemspec
 homepage: https://github.com/hoverinc/this_feature
 licenses: []
 metadata:
   homepage_uri: https://github.com/hoverinc/this_feature
   source_code_uri: https://github.com/hoverinc/this_feature
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -159,7 +161,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Feature flag control
 test_files: []