think_feel_do_dashboard 1.1.10 → 1.1.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 756096b8c05829aa2f884e5f5ab81834a30182cd
-  data.tar.gz: 2b043dfeb1edcef2f67d667847973f9ba97ea13d
+  metadata.gz: 4bf5728c5a9df450ae129c254a23c30f0ec281c2
+  data.tar.gz: d012a44b1f4557932ea6cbf9af80e5d3a1231bcb
 SHA512:
-  metadata.gz: b2bcbc0c9712fdcbce7764f240e017cda1f9afe4f3997eed5b9972da1888ff26af792abfd05d481511668750384e435dbdd2480754f8d67b9c5b0c297526405e
-  data.tar.gz: f8557e0f51915803abf6d4ee827daffbb46bb2aee866d16649dfaccf88a34c78b46328897d8cdbd53ec8dbda8a2d561cae570f442642a5d759074f32bba109ce
+  metadata.gz: f43672ab1ae2d80a6a8aa71573565c0770103ca0f90a6217fca39198d2535874bc3ec9c42a40d68bc00ddc4139bddd00dfa861aeb921ee89f209f7c1838e1d9e
+  data.tar.gz: 6a6bb8414e58b61c2233aef4d0559ffb9e28c0d5146b3d456eac0392395e192ed668b16de8a787f10a7793dc6e830566d9f330484d09ee253fcdcf77c915198c

data/app/controllers/think_feel_do_dashboard/moderators_controller.rb

@@ -4,7 +4,7 @@ module ThinkFeelDoDashboard
   # Allows Coaches/Clinicians to moderate.
   # That is, log in as a participant
   class ModeratorsController < ApplicationController
-    before_action :authenticate_user!, :set_group
+    before_action :set_group
 
     # POST /coach/groups/:group_id/moderates
     def create
@@ -17,6 +17,9 @@ module ThinkFeelDoDashboard
 
     def set_group
       @group = Group.find(params[:group_id])
+
+    rescue ActiveRecord::RecordNotFound => e
+      redirect_to root_path, alert: e.message
     end
   end
 end

data/app/controllers/think_feel_do_dashboard/social_networking/profile_questions_controller.rb

@@ -5,9 +5,8 @@ module ThinkFeelDoDashboard
     # Allows for the creation, updating, and deletion of social networking
     # profile questions
     class ProfileQuestionsController < ApplicationController
-      before_action :authenticate_user!
       before_action :set_profile_question, except: [:index, :new, :create]
-      before_action :set_group
+      before_action :set_group, :authorize_group_access!
 
       def index
         @profile_questions = ::SocialNetworking::ProfileQuestion
@@ -53,14 +52,23 @@ module ThinkFeelDoDashboard
 
       private
 
+      def authorize_group_access!
+        authorize! :moderate, @group
+      end
+
       def set_group
         @group = Group.find(params[:group_id])
-        authorize! :moderate, @group
+
+      rescue ActiveRecord::RecordNotFound => e
+        redirect_to root_path, alert: e.message
       end
 
       def set_profile_question
         @profile_question = ::SocialNetworking::ProfileQuestion
                             .find(params[:id])
+
+      rescue ActiveRecord::RecordNotFound => e
+        redirect_to root_path, alert: e.message
       end
 
       def profile_question_params

data/lib/think_feel_do_dashboard/version.rb

@@ -1,4 +1,4 @@
 # Version number of engine
 module ThinkFeelDoDashboard
-  VERSION = "1.1.10".freeze
+  VERSION = "1.1.11".freeze
 end

data/spec/controllers/think_feel_do_dashboard/moderators_controller_spec.rb

@@ -0,0 +1,53 @@
+require "rails_helper"
+
+module ThinkFeelDoDashboard
+  RSpec.describe ModeratorsController, type: :controller do
+    routes { Engine.routes }
+
+    describe "POST create" do
+      context "for authenticated users" do
+        let(:user) { instance_double(User, admin?: true) }
+
+        before do
+          sign_in_user user
+        end
+
+        describe "when Group is found" do
+          before do
+            expect(Group)
+              .to receive(:find) do
+                instance_double(
+                  Group,
+                  moderating_participant: user)
+              end
+            expect(controller).to receive(:sign_in).with(user)
+            allow(controller)
+              .to receive_message_chain("social_networking.social_networking_profile_path")
+              .and_return "hello_world"
+          end
+
+          it "should respond with a redirect to the moderator's profile page" do
+            post :create, group_id: 1
+
+            expect(response.status).to eq 302
+            expect(response.body).to match(/hello_world/)
+          end
+        end
+
+        describe "when Group is not found" do
+          it "should respond with a redirect" do
+            post :create, group_id: 1
+
+            expect(response.status).to eq 302
+          end
+        end
+      end
+
+      context "for unauthenticated users" do
+        before { post :create, group_id: 1 }
+
+        it_behaves_like "a rejected user action"
+      end
+    end
+  end
+end

data/spec/controllers/think_feel_do_dashboard/social_networking/profile_questions_controller_spec.rb

@@ -0,0 +1,63 @@
+require "rails_helper"
+
+module ThinkFeelDoDashboard
+  module SocialNetworking
+    RSpec.describe ProfileQuestionsController, type: :controller do
+      routes { Engine.routes }
+
+      describe "GET edit" do
+        context "for authenticated users" do
+          let(:group) { instance_double(Group) }
+          let(:user) { instance_double(User, admin?: true) }
+
+          before do
+            sign_in_user user
+          end
+
+          describe "when ProfileQuestion is found" do
+            before do
+              expect(::SocialNetworking::ProfileQuestion)
+                .to receive(:find) do
+                  double("ProfileQuestion")
+                end
+            end
+
+            describe "when Group is found" do
+              before do
+                expect(Group).to receive(:find) { group }
+              end
+
+              it "should respond with a redirect to the moderator's profile page" do
+                get :edit, group_id: 1, id: 1
+
+                expect(response.status).to eq 200
+              end
+            end
+
+            describe "when Group is not found" do
+              it "should respond with a redirect" do
+                get :edit, group_id: 1, id: 1
+
+                expect(response.status).to eq 302
+              end
+            end
+          end
+
+          describe "when ProfileQuestion is not found" do
+            it "should respond with a redirect" do
+              get :edit, group_id: 1, id: 1
+
+              expect(response.status).to eq 302
+            end
+          end
+        end
+
+        context "for unauthenticated users" do
+          before { get :edit, group_id: 1, id: 1 }
+
+          it_behaves_like "a rejected user action"
+        end
+      end
+    end
+  end
+end

data/spec/dummy/db/schema.rb

@@ -16,7 +16,7 @@ ActiveRecord::Schema.define(version: 20150410175659) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 
-  create_table "arms", force: true do |t|
+  create_table "arms", force: :cascade do |t|
     t.string   "title",                                 default: ""
     t.boolean  "is_social",                             default: false
     t.datetime "created_at"
@@ -25,14 +25,14 @@ ActiveRecord::Schema.define(version: 20150410175659) do
     t.boolean  "can_message_after_membership_complete", default: true,  null: false
   end
 
-  create_table "coach_assignments", force: true do |t|
+  create_table "coach_assignments", force: :cascade do |t|
     t.integer  "coach_id",       null: false
     t.integer  "participant_id", null: false
     t.datetime "created_at"
     t.datetime "updated_at"
   end
 
-  create_table "groups", force: true do |t|
+  create_table "groups", force: :cascade do |t|
     t.string   "title"
     t.datetime "created_at"
     t.datetime "updated_at"
@@ -40,7 +40,7 @@ ActiveRecord::Schema.define(version: 20150410175659) do
     t.integer  "moderator_id"
   end
 
-  create_table "memberships", force: true do |t|
+  create_table "memberships", force: :cascade do |t|
     t.integer  "group_id",                       null: false
     t.integer  "participant_id",                 null: false
     t.date     "end_date"
@@ -50,7 +50,7 @@ ActiveRecord::Schema.define(version: 20150410175659) do
     t.boolean  "is_complete",    default: false
   end
 
-  create_table "participants", force: true do |t|
+  create_table "participants", force: :cascade do |t|
     t.string   "email",                  default: "", null: false
     t.string   "phone_number"
     t.string   "study_id"
@@ -75,21 +75,21 @@ ActiveRecord::Schema.define(version: 20150410175659) do
   add_index "participants", ["reset_password_token"], name: "index_participants_on_reset_password_token", unique: true, using: :btree
   add_index "participants", ["study_id"], name: "index_participants_on_study_id", unique: true, using: :btree
 
-  create_table "slideshow_anchors", force: true do |t|
+  create_table "slideshow_anchors", force: :cascade do |t|
     t.integer  "bit_core_slideshow_id"
     t.string   "target_name"
     t.datetime "created_at"
     t.datetime "updated_at"
   end
 
-  create_table "social_networking_profile_questions", force: true do |t|
+  create_table "social_networking_profile_questions", force: :cascade do |t|
     t.integer  "group_id"
     t.text     "question_text"
     t.datetime "created_at"
     t.datetime "updated_at"
   end
 
-  create_table "social_networking_profiles", force: true do |t|
+  create_table "social_networking_profiles", force: :cascade do |t|
     t.integer  "participant_id"
     t.string   "icon_name"
     t.boolean  "active"
@@ -97,21 +97,21 @@ ActiveRecord::Schema.define(version: 20150410175659) do
     t.datetime "updated_at"
   end
 
-  create_table "social_networking_shared_items", force: true do |t|
+  create_table "social_networking_shared_items", force: :cascade do |t|
     t.integer  "participant_id"
     t.boolean  "is_public"
     t.datetime "created_at"
     t.datetime "updated_at"
   end
 
-  create_table "user_roles", force: true do |t|
+  create_table "user_roles", force: :cascade do |t|
     t.integer  "user_id"
     t.string   "role_class_name"
     t.datetime "created_at"
     t.datetime "updated_at"
   end
 
-  create_table "users", force: true do |t|
+  create_table "users", force: :cascade do |t|
     t.string   "email"
     t.datetime "created_at"
     t.datetime "updated_at"

data/spec/dummy/log/development.log

@@ -371970,3 +371970,9 @@ PG::DuplicateTable: ERROR:  relation "participants" already exists
    (0.3ms)  INSERT INTO "schema_migrations" (version) VALUES ('20141211143757')
    (0.3ms)  INSERT INTO "schema_migrations" (version) VALUES ('20141215203425')
    (0.3ms)  INSERT INTO "schema_migrations" (version) VALUES ('20150213215118')
+  ActiveRecord::SchemaMigration Load (3.0ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+Migrating to CreateParticipants (20141020185953)
+   (0.4ms)  BEGIN
+DEPRECATION WARNING: `#timestamps` was called without specifying an option for `null`. In Rails 5, this behavior will change to `null: false`. You should manually specify `null: true` to prevent the behavior of your existing migrations from changing. (called from block in change at /Users/usabilitymonitor/Desktop/Github/think_feel_do_dashboard/spec/dummy/db/migrate/20141020185953_create_participants.rb:8)
+   (21.6ms)  CREATE TABLE "participants" ("id" serial primary key, "email" character varying DEFAULT '' NOT NULL, "phone_number" character varying, "study_id" character varying, "created_at" timestamp, "updated_at" timestamp) 
+   (0.3ms)  ROLLBACK