thincloud-postmark 0.4.0 → 0.5.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 44dd270a169b3ce0412d96a3fdb2821e0736ed4b
+  data.tar.gz: c5a8fd4f393ab91c65127bd892b4e735e5d651c3
+SHA512:
+  metadata.gz: fc46af8bf170929ced2ef655a9f8fdfc24c1f3db18abddd54f67efebdcfe63f87aff8d8b6e032ed2990f4315ca5660bc2ac90fcc9a8be5ab48c0836dcc2b662d
+  data.tar.gz: 0c7cf9713623434a4e224a15470d5bde0cff63d9ca20cc1434494cae95eb8e63eef89c000ba3a5fc25d1ae8989120b0c04f35a199d89d38283d88cbee78d83be

data/.rubocop.yml

@@ -0,0 +1,17 @@
+AllCops:
+  Exclude:
+    - "test/dummy/**/*"
+
+Style/FileName:
+  Exclude:
+    - lib/thincloud-postmark.rb
+    - test/thincloud-postmark_test.rb
+
+LineLength:
+  Max: 80
+
+StringLiterals:
+  EnforcedStyle: double_quotes
+
+inherit_from: test/rubocop/enabled.yml
+inherit_from: test/rubocop/disabled.yml

data/.ruby-version

@@ -1 +1 @@
-1.9.3@thincloud-postmark
+2.1.2

data/.travis.yml

@@ -0,0 +1,18 @@
+language: ruby
+rvm:
+- 1.9.3
+- 2.0.0
+- 2.1.2
+bundler_args: "--without local"
+before_script:
+- bundle exec rake app:db:setup
+script:
+- bundle exec rake test
+- bundle exec rake cane
+- bundle exec rake rubocop
+notifications:
+  flowdock:
+    secure: hRaeI2fe3mbWP3BbIkurjuLLu7Lbq4ReE0Ee1i4h+drvv+pio6BItuTd7ujlhM80ZkRfpffTOZdk34fbZduf1WB+peWaYfO1f2kDPviap7wdnFRlSpJF/KaDS3/D70zA8RycSC1Oaam34cKoVg1Gmdwl0/EJAsRncfu3I+tYyiA=
+env:
+  global:
+    secure: w/lOREURd+nNeOdLPffnsVT9jwvrp/ougA8a/d2EZJ48pMp1d+5bL83ZwcUfVdDoNq8YEFu+fje8La4LmkdL1GUhnHGmznkVlPnPVMMZE5fenYiJIgkyhDe4EchBXUifT0iH4HjB4SsbaehzPy78H9ceD9qtG2zyCtDhzx0ic/A=

data/Gemfile

@@ -1,13 +1,11 @@
 source "https://rubygems.org"
 
+# Declare your gem's dependencies in thincloud-resque.gemspec.
+# Bundler will treat runtime dependencies like base dependencies, and
+# development dependencies will be added by default to the :development group.
 gemspec
 
-# jquery-rails is used by the dummy application
-gem "jquery-rails"
-
 group :test do
-  platforms :ruby do
-    gem "simplecov"
-    gem "sqlite3"
-  end
+  gem "codeclimate-test-reporter", require: false
+  gem "simplecov"
 end

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012 New Leaders
+Copyright (c) 2012-2014 New Leaders
 
 MIT License
 

data/README.md

@@ -1,4 +1,10 @@
-# Thincloud::Postmark
+# thincloud-postmark
+
+[![Gem Version](https://badge.fury.io/rb/thincloud-postmark.svg)](http://badge.fury.io/rb/thincloud-postmark)
+[![Dependency Status](https://gemnasium.com/newleaders/thincloud-postmark.svg)](https://gemnasium.com/newleaders/thincloud-postmark)
+[![Build Status](https://travis-ci.org/newleaders/thincloud-postmark.svg?branch=master)](https://travis-ci.org/newleaders/thincloud-postmark)
+[![Code Climate](https://codeclimate.com/github/newleaders/thincloud-postmark.png)](https://codeclimate.com/github/newleaders/thincloud-postmark)
+[![Test Coverage](https://codeclimate.com/github/newleaders/thincloud-postmark/coverage.png)](https://codeclimate.com/github/newleaders/thincloud-postmark)
 
 ## Description
 
@@ -18,13 +24,15 @@ This gem requires Rails 3.2+ and has been tested on the following versions:
 This gem has been tested against the following Ruby versions:
 
 * 1.9.3
+* 2.0.0
+* 2.1.2
 
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
-``` ruby
+```ruby
 gem "thincloud-postmark"
 ```
 
@@ -72,12 +80,12 @@ config.action_mailer.default_url_options = { host: "mydomain.com" }
 
 Several of the options will use environment variables when found.
 
-```
-api_key         -> ENV["POSTMARK_API_KEY"]
-secure          -> ENV["POSTMARK_SECURE"]
-interceptor_to  -> ENV["THINCLOUD_INTERCEPTOR_TO"]
-interceptor_cc  -> ENV["THINCLOUD_INTERCEPTOR_CC"]
-interceptor_bcc -> ENV["THINCLOUD_INTERCEPTOR_BCC"]
+```ruby
+api_key          # ENV["POSTMARK_API_KEY"]
+secure           # ENV["POSTMARK_SECURE"]
+interceptor_to   # ENV["THINCLOUD_INTERCEPTOR_TO"]
+interceptor_cc   # ENV["THINCLOUD_INTERCEPTOR_CC"]
+interceptor_bcc  # ENV["THINCLOUD_INTERCEPTOR_BCC"]
 ```
 
 #### Configuration Block
@@ -171,6 +179,6 @@ Mail.register_interceptor(MailInterceptor) unless Rails.env.production?
 
 ## License
 
-* Freely distributable and licensed under the [MIT license](http://newleaders.mit-license.org/2012/license.html).
-* Copyright (c) 2012 New Leaders ([opensource@newleaders.com](opensource@newleaders.com))
+* Freely distributable and licensed under the [MIT license](http://newleaders.mit-license.org/2012-2014/license.html).
+* Copyright (c) 2012-2014 New Leaders ([opensource@newleaders.com](opensource@newleaders.com))
 * [https://newleaders.com](https://newleaders.com)

data/Rakefile

@@ -1,8 +1,9 @@
-#!/usr/bin/env rake
-
 require "bundler/gem_tasks"
 require "rake/testtask"
 
+task default: [:test, :cane, :rubocop]
+
+desc "Run minitest suite"
 Rake::TestTask.new(:test) do |t|
   t.libs << "lib"
   t.libs << "test"
@@ -10,4 +11,16 @@ Rake::TestTask.new(:test) do |t|
   t.verbose = false
 end
 
-task default: :test
+require "cane/rake_task"
+desc "Run cane to check quality metrics"
+Cane::RakeTask.new(:cane) do |cane|
+  cane.abc_max = 8
+  cane.style_measure = 80
+end
+
+require "rubocop/rake_task"
+RuboCop::RakeTask.new
+
+# dummy rails app
+APP_RAKEFILE = File.expand_path("../test/dummy/Rakefile", __FILE__)
+load "rails/tasks/engine.rake"

data/lib/thincloud/postmark/configuration.rb

@@ -1,4 +1,5 @@
 module Thincloud
+  # Public: Postmark configuration namespace for Thincloud applications
   module Postmark
     class << self
       attr_accessor :configuration
@@ -20,20 +21,16 @@ module Thincloud
       attr_accessor :interceptor_environments
 
       def initialize
-        api_key         = ENV["POSTMARK_API_KEY"] || "POSTMARK_API_TEST"
-        secure          = ENV["POSTMARK_SECURE"] || true
-        interceptor_to  = ENV["THINCLOUD_INTERCEPTOR_TO"]
-        interceptor_cc  = ENV["THINCLOUD_INTERCEPTOR_CC"]
-        interceptor_bcc = ENV["THINCLOUD_INTERCEPTOR_BCC"]
-
-        @environments    = []
-        @api_key         ||= api_key
-        @interceptor_to  ||= interceptor_to
-        @interceptor_cc  ||= interceptor_cc
-        @interceptor_bcc ||= interceptor_bcc
+        @api_key ||= ENV.fetch("POSTMARK_API_KEY", "POSTMARK_API_TEST")
 
+        @interceptor_to  ||= ENV["THINCLOUD_INTERCEPTOR_TO"]
+        @interceptor_cc  ||= ENV["THINCLOUD_INTERCEPTOR_CC"]
+        @interceptor_bcc ||= ENV["THINCLOUD_INTERCEPTOR_BCC"]
+
+        @environments = []
         @interceptor_environments = []
-        self.secure = secure
+
+        self.secure = ENV.fetch("POSTMARK_SECURE", true)
       end
 
       def secure=(s)

data/lib/thincloud/postmark/engine.rb

@@ -1,8 +1,9 @@
+require "mail"
+
 module Thincloud
   module Postmark
     # Public: Thincloud Postmark Engine
     class Engine < ::Rails::Engine
-
       # convenience method for engine options / configuration
       def configuration
         Thincloud::Postmark.configuration
@@ -44,7 +45,6 @@ module Thincloud
           end
         end
       end
-
     end
   end
-end
+end

data/lib/thincloud/postmark/interceptor.rb

@@ -9,12 +9,12 @@ module Thincloud
       end
 
       def self.delivering_email(message)
-        message.subject = "#{message.to} #{message.subject}"
-        message.to      = self.to
-        message.cc      = self.cc
-        message.bcc     = self.bcc
+        message.subject = "[#{message.to}] #{message.subject}"
+        message.to      = to
+        message.cc      = cc
+        message.bcc     = bcc
         message
       end
     end
   end
-end
+end

data/lib/thincloud/postmark/version.rb

@@ -1,5 +1,6 @@
 module Thincloud
+  # Public: Postmark namespace for Thincloud applications
   module Postmark
-    VERSION = "0.4.0"
+    VERSION = "0.5.0"
   end
 end

data/lib/thincloud-postmark.rb

@@ -6,6 +6,7 @@ require "thincloud/postmark/engine"
 require "thincloud/postmark/version"
 
 module Thincloud
+  # Public: Postmark namespace for Thincloud applications
   module Postmark
   end
 end

data/test/configuration_test.rb

@@ -1,41 +1,45 @@
 require "minitest_helper"
 
 describe Thincloud::Postmark::Configuration do
-  let(:config) { Thincloud::Postmark::Configuration.new }
+  subject do
+    Thincloud::Postmark::Configuration.new
+  end
 
-  it { config.must_be_kind_of Thincloud::Postmark::Configuration }
-  it { config.must_respond_to :environments }
-  it { config.must_respond_to :environments= }
-  it { config.must_respond_to :api_key }
-  it { config.must_respond_to :api_key= }
-  it { config.must_respond_to :secure }
-  it { config.must_respond_to :secure= }
-  it { config.must_respond_to :interceptor_environments }
-  it { config.must_respond_to :interceptor_to }
-  it { config.must_respond_to :interceptor_to= }
-  it { config.must_respond_to :interceptor_bcc }
-  it { config.must_respond_to :interceptor_bcc= }
+  specify { subject.must_be_kind_of Thincloud::Postmark::Configuration }
+  specify { subject.must_respond_to :environments }
+  specify { subject.must_respond_to :environments= }
+  specify { subject.must_respond_to :api_key }
+  specify { subject.must_respond_to :api_key= }
+  specify { subject.must_respond_to :secure }
+  specify { subject.must_respond_to :secure= }
+  specify { subject.must_respond_to :interceptor_environments }
+  specify { subject.must_respond_to :interceptor_to }
+  specify { subject.must_respond_to :interceptor_to= }
+  specify { subject.must_respond_to :interceptor_bcc }
+  specify { subject.must_respond_to :interceptor_bcc= }
 
   describe "defaults" do
-    it { config.environments.must_equal [] }
-    it { config.api_key.must_equal "POSTMARK_API_TEST" }
-    it { config.secure.must_equal true }
-    it { ::Postmark.secure.must_equal true }
-    it { config.interceptor_environments.must_equal [] }
-    it { config.interceptor_to.must_be_nil }
-    it { config.interceptor_cc.must_be_nil }
-    it { config.interceptor_bcc.must_be_nil }
+    specify { subject.environments.must_equal [] }
+    specify { subject.api_key.must_equal "POSTMARK_API_TEST" }
+    specify { subject.secure.must_equal true }
+    specify { ::Postmark.secure.must_equal true }
+    specify { subject.interceptor_environments.must_equal [] }
+    specify { subject.interceptor_to.must_be_nil }
+    specify { subject.interceptor_cc.must_be_nil }
+    specify { subject.interceptor_bcc.must_be_nil }
   end
 
   describe "changes Postmark secure setting" do
     before do
       @original_setting = ::Postmark.secure
-      config.secure = false
+      subject.secure = false
     end
 
-    after { ::Postmark.secure = @original_setting }
+    after do
+      ::Postmark.secure = @original_setting
+    end
 
-    it { config.secure.must_equal false }
-    it { ::Postmark.secure.must_equal false }
+    specify { subject.secure.must_equal false }
+    specify { ::Postmark.secure.must_equal false }
   end
 end

data/test/dummy/db/schema.rb

@@ -0,0 +1,16 @@
+# encoding: UTF-8
+# This file is auto-generated from the current state of the database. Instead
+# of editing this file, please use the migrations feature of Active Record to
+# incrementally modify your database, and then regenerate this schema definition.
+#
+# Note that this schema.rb definition is the authoritative source for your
+# database schema. If you need to create the application database on another
+# system, you should be using db:schema:load, not running all the migrations
+# from scratch. The latter is a flawed and unsustainable approach (the more migrations
+# you'll amass, the slower it'll run and the greater likelihood for issues).
+#
+# It's strongly recommended to check this file into your version control system.
+
+ActiveRecord::Schema.define(:version => 0) do
+
+end

data/test/integration/configuration_test.rb

@@ -1,11 +1,13 @@
 require "minitest_helper"
 
 describe Dummy::Application.config do
-  let(:config) { Dummy::Application.config.thincloud.postmark }
+  let(:config) do
+    Dummy::Application.config.thincloud.postmark
+  end
 
   # defaults
-  it { config.must_be_kind_of Thincloud::Postmark::Configuration }
-  it { config.api_key.must_equal "INITIALIZER" }
+  specify { config.must_be_kind_of Thincloud::Postmark::Configuration }
+  specify { config.api_key.must_equal "INITIALIZER" }
 
   describe "with configure block" do
     before do
@@ -14,7 +16,7 @@ describe Dummy::Application.config do
       end
     end
 
-    it { config.api_key.must_equal "abc123" }
+    specify { config.api_key.must_equal "abc123" }
   end
 
   describe "changes Postmark secure setting" do
@@ -26,25 +28,22 @@ describe Dummy::Application.config do
       end
     end
 
-    after { config.secure = @original_setting }
-
-    it { config.secure.must_equal false }
-    it { ::Postmark.secure.must_equal false }
-  end
-
-  describe "updates Rails application configuration" do
-    let(:app_config) { Dummy::Application.config.action_mailer }
-    let(:settings) { { api_key: "INITIALIZER" } }
+    after do
+      config.secure = @original_setting
+    end
 
-    it { app_config.delivery_method.must_equal :postmark }
-    it { app_config.postmark_settings.must_equal settings }
+    specify { config.secure.must_equal false }
+    specify { ::Postmark.secure.must_equal false }
   end
 
-  describe "updates ActionMailer configuration" do
-    let(:base_config) { ActionMailer::Base }
-    let(:settings) { { api_key: "INITIALIZER" } }
+  describe "configuration updates" do
+    let(:settings) do
+      { api_key: "INITIALIZER" }
+    end
 
-    it { base_config.delivery_method.must_equal :postmark }
-    it { base_config.postmark_settings.must_equal settings }
+    [Dummy::Application.config.action_mailer, ActionMailer::Base].each do |conf|
+      specify { conf.delivery_method.must_equal :postmark }
+      specify { conf.postmark_settings.must_equal settings }
+    end
   end
 end

data/test/integration/interceptor_test.rb

@@ -1,13 +1,18 @@
 require "minitest_helper"
 
 describe Thincloud::Postmark::Interceptor do
-  let(:interceptor) { Thincloud::Postmark::Interceptor }
-  let(:interceptors) { ::Mail.class_variable_get(:@@delivery_interceptors) }
+  let(:interceptor) do
+    Thincloud::Postmark::Interceptor
+  end
+
+  let(:interceptors) do
+    ::Mail.class_variable_get(:@@delivery_interceptors)
+  end
 
   describe "after Rails config" do
-    it { interceptors.must_include Thincloud::Postmark::Interceptor }
-    it { interceptor.to.must_equal "marshmellowman@staypuft.com" }
-    it { interceptor.cc.must_be_nil }
-    it { interceptor.bcc.must_be_nil }
+    specify { interceptors.must_include Thincloud::Postmark::Interceptor }
+    specify { interceptor.to.must_equal "marshmellowman@staypuft.com" }
+    specify { interceptor.cc.must_be_nil }
+    specify { interceptor.bcc.must_be_nil }
   end
 end

data/test/interceptor_test.rb

@@ -1,49 +1,41 @@
 require "minitest_helper"
 
 describe Thincloud::Postmark::Interceptor do
-  let(:mail) { OpenStruct.new(to: "rpeck@epa.gov", subject: "Subject") }
-  let(:interceptor) { Thincloud::Postmark::Interceptor }
+  let(:mail) do
+    OpenStruct.new(to: "rpeck@epa.gov", subject: "Subject")
+  end
+
+  subject do
+    Thincloud::Postmark::Interceptor
+  end
 
-  it { interceptor.must_respond_to(:to) }
-  it { interceptor.must_respond_to(:to=) }
-  it { interceptor.must_respond_to(:cc) }
-  it { interceptor.must_respond_to(:cc=) }
-  it { interceptor.must_respond_to(:bcc) }
-  it { interceptor.must_respond_to(:bcc=) }
-  it { interceptor.must_respond_to(:delivering_email) }
+  specify { subject.must_respond_to(:to) }
+  specify { subject.must_respond_to(:to=) }
+  specify { subject.must_respond_to(:cc) }
+  specify { subject.must_respond_to(:cc=) }
+  specify { subject.must_respond_to(:bcc) }
+  specify { subject.must_respond_to(:bcc=) }
+  specify { subject.must_respond_to(:delivering_email) }
 
   describe "munges the subject" do
     before do
-      @msg = interceptor.delivering_email(mail)
+      @msg = subject.delivering_email(mail)
     end
 
-    it { @msg.subject.must_equal "rpeck@epa.gov Subject" }
+    specify { @msg.subject.must_equal "[rpeck@epa.gov] Subject" }
   end
 
   describe "sets email `to`" do
     before do
-      interceptor.to = "egon@ghostbusters.com"
-      @msg = interceptor.delivering_email(mail)
-    end
-
-    it { @msg.to.must_equal "egon@ghostbusters.com" }
-  end
-
-  describe "sets email `cc`" do
-    before do
-      interceptor.cc = "venkman@ghostbusters.com"
-      @msg = interceptor.delivering_email(mail)
-    end
+      subject.to = "egon@ghostbusters.com"
+      subject.cc = "venkman@ghostbusters.com"
+      subject.bcc = "stantz@ghostbusters.com"
 
-    it { @msg.cc.must_equal "venkman@ghostbusters.com" }
-  end
-
-  describe "sets email `bcc`" do
-    before do
-      interceptor.bcc = "stantz@ghostbusters.com"
-      @msg = interceptor.delivering_email(mail)
+      @msg = subject.delivering_email(mail)
     end
 
-    it { @msg.bcc.must_equal "stantz@ghostbusters.com" }
+    specify { @msg.to.must_equal "egon@ghostbusters.com" }
+    specify { @msg.cc.must_equal "venkman@ghostbusters.com" }
+    specify { @msg.bcc.must_equal "stantz@ghostbusters.com" }
   end
-end
+end

data/test/minitest_helper.rb

@@ -1,13 +1,10 @@
-if RUBY_ENGINE == "ruby"
-  begin
-    require "simplecov"
-    SimpleCov.add_filter "test"
-    SimpleCov.add_filter "config"
-    SimpleCov.command_name "MiniTest"
-    SimpleCov.start
-  rescue LoadError
-    warn "unable to load SimpleCov"
-  end
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
+
+require "simplecov"
+SimpleCov.start do
+  add_filter { |src| src.filename =~ /bundle|test|config|vendor/ }
+  command_name "Minitest"
 end
 
 ENV["RAILS_ENV"] = "test"
@@ -15,11 +12,4 @@ ENV["RAILS_ENV"] = "test"
 require File.expand_path("../dummy/config/environment",  __FILE__)
 
 require "minitest/autorun"
-require "minitest/rails"
 require "minitest/pride"
-require "minitest-rails-shoulda"
-
-Rails.backtrace_cleaner.remove_silencers!
-
-# Load support files
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }

data/test/rubocop/disabled.yml

@@ -0,0 +1,25 @@
+Encoding:
+  Description: 'Use UTF-8 as the source file encoding.'
+  Enabled: false
+
+SymbolArray:
+  Description: 'Use %i or %I for arrays of symbols.'
+  Enabled: false
+
+##################### Rails ##################################
+
+DefaultScope:
+  Description: 'Checks if the argument passed to default_scope is a block.'
+  Enabled: false
+
+HasAndBelongsToMany:
+  Description: 'Prefer has_many :through to has_and_belongs_to_many.'
+  Enabled: false
+
+Output:
+  Description: 'Checks for calls to puts, print, etc.'
+  Enabled: false
+
+Validation:
+  Description: 'Use sexy validations.'
+  Enabled: false