thetvdb_api 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 82c9a99fb9fa13974c7f00e23f00c164433b0022
-  data.tar.gz: 8409f71bc88aea05716703d69449d90e290e8fab
+  metadata.gz: f3740260dd6af0b5e4b3c7c93b7fbdc511a14efd
+  data.tar.gz: 8fb1c91dd7536b7b67a502388dd79c1b285620bd
 SHA512:
-  metadata.gz: 4cecac72881ed8dfb87e3da1a1f04caae7e9ef30e21833a0264080a67debac86fff469aa59017129c05169b402a27877f9ecec4aa323557d59aa7f74ba0deefb
-  data.tar.gz: e458d7169560328f73889af865d7731bd9c4d75308c01d6a61e09a1190fdd0c222823c53aab35881bceeca6c5b51324a96d9d0cabbfc5248178ef85e5ee87d18
+  metadata.gz: 771075d0e3a430cfc18635cc1a4568f2311b2dfb603e1a146f7c0ddc73bc4c885a763f27c0fa2b687d4858e2e408eac8e55b458a6c654d8902202a4d494ff67f
+  data.tar.gz: 9e7d3a5d4a120130d6d2e4d970621c8c6bb02809c361b0af41a75a05a51abdf69342c4debdfd68e25523125b68f37a8a5b4318501cee5e4867b03e0d3b9284d1

data/.travis.yml

@@ -3,4 +3,5 @@ script: 'bundle exec rspec spec/functionals'
 rvm:
   - 1.9.3
   - 2.0.0
-  - 2.1.0
+  - 2.1.5
+  - 2.2.0

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+## 0.3.2 (January 20, 2015)
+
+  - fix series method
+  - add more test for better test coverage
+
+## 0.3.1 (January 20, 2015)
+
+  - use ov gem for multimethod
+  - use hashie for normalize params key names
+  - fix zap2it url params after updated official documentation
+
 ## 0.3.0 (September 5, 2014)
 
   - two way to pass attributes: hash attributes or simple multi attributes (in correct order)

data/lib/thetvdb_api/attributes_mapping/search/get_episode.rb

@@ -3,4 +3,5 @@ require 'hashie'
 class ThetvdbApi::AttributesMapping::Search::GetEpisode < Hashie::Trash
   property :seriesid, from: :series_id
   property :airdate, from: :air_date
+  property :language
 end

data/lib/thetvdb_api/series.rb

@@ -50,7 +50,7 @@ class ThetvdbApi::Series < ThetvdbApi::Base
   # param:
   #   find_url(1234, 'de')
   # output: url string
-  let :find_url, Any do |id, language|
+  let :find_url, Any, String do |id, language|
     find_url(id: id, language: language)
   end
 
@@ -113,7 +113,7 @@ class ThetvdbApi::Series < ThetvdbApi::Base
   # param:
   #   find_full_url(1234, 'de')
   # output: url string
-  let :find_full_url, Any do |id, language|
+  let :find_full_url, Any, String do |id, language|
     find_full_url(id: id, language: language)
   end
 

data/lib/thetvdb_api/version.rb

@@ -1,3 +1,3 @@
 module ThetvdbApi
-  VERSION = '0.3.1'
+  VERSION = '0.3.2'
 end

data/spec/functionals/episode_spec.rb

@@ -9,9 +9,13 @@ describe ThetvdbApi::Episode do
   let(:faraday_stubs) do
     Faraday::Adapter::Test::Stubs.new do |stub|
       stub.get('/api/123456789/series/1234/default/1/1/en.xml') { [200, { content_type: 'xml' }, episode_data] }
+      stub.get('/api/123456789/series/1234/default/1/1/de.xml') { [200, { content_type: 'xml' }, episode_data] }
       stub.get('/api/123456789/series/1234/dvd/1/1/en.xml') { [200, { content_type: 'xml' }, episode_data] }
+      stub.get('/api/123456789/series/1234/dvd/1/1/de.xml') { [200, { content_type: 'xml' }, episode_data] }
       stub.get('/api/123456789/series/1234/absolute/1/en.xml') { [200, { content_type: 'xml' }, episode_data] }
+      stub.get('/api/123456789/series/1234/absolute/1/de.xml') { [200, { content_type: 'xml' }, episode_data] }
       stub.get('/api/123456789/episodes/1234/en.xml') { [200, { content_type: 'xml' }, episode_data] }
+      stub.get('/api/123456789/episodes/1234/de.xml') { [200, { content_type: 'xml' }, episode_data] }
     end
   end
 
@@ -27,12 +31,24 @@ describe ThetvdbApi::Episode do
     end
 
     context 'normal attributes' do
-      it 'should return Faraday::Response class' do
-        expect(model.find_by_default_order(1234, 1, 1)).to be_a(Faraday::Response)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find_by_default_order(1234, 1, 1)).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find_by_default_order(1234, 1, 1).body).to be_a(Hash)
+        end
       end
 
-      it 'should return Hash class for body reponse' do
-        expect(model.find_by_default_order(1234, 1, 1).body).to be_a(Hash)
+      context 'with optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find_by_default_order(1234, 1, 1, 'de')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find_by_default_order(1234, 1, 1, 'de').body).to be_a(Hash)
+        end
       end
     end
   end
@@ -47,10 +63,20 @@ describe ThetvdbApi::Episode do
     end
 
     context 'normal attributes' do
-      it 'should return correct url' do
-        expect(
-          model.find_by_default_order_url(1234, 1, 1)
-        ).to eq('http://thetvdb.com/api/123456789/series/1234/default/1/1/en.xml')
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.find_by_default_order_url(1234, 1, 1)
+          ).to eq('http://thetvdb.com/api/123456789/series/1234/default/1/1/en.xml')
+        end
+      end
+
+      context 'with optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.find_by_default_order_url(1234, 1, 1, 'de')
+          ).to eq('http://thetvdb.com/api/123456789/series/1234/default/1/1/de.xml')
+        end
       end
     end
   end
@@ -67,12 +93,24 @@ describe ThetvdbApi::Episode do
     end
 
     context 'normal attributes' do
-      it 'should return Faraday::Response class' do
-        expect(model.find_by_dvd_order(1234, 1, 1)).to be_a(Faraday::Response)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find_by_dvd_order(1234, 1, 1)).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find_by_dvd_order(1234, 1, 1).body).to be_a(Hash)
+        end
       end
 
-      it 'should return Hash class for body reponse' do
-        expect(model.find_by_dvd_order(1234, 1, 1).body).to be_a(Hash)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find_by_dvd_order(1234, 1, 1, 'de')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find_by_dvd_order(1234, 1, 1, 'de').body).to be_a(Hash)
+        end
       end
     end
   end
@@ -87,10 +125,20 @@ describe ThetvdbApi::Episode do
     end
 
     context 'normal attributes' do
-      it 'should return correct url' do
-        expect(
-          model.find_by_dvd_order_url(1234, 1, 1)
-        ).to eq('http://thetvdb.com/api/123456789/series/1234/dvd/1/1/en.xml')
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.find_by_dvd_order_url(1234, 1, 1)
+          ).to eq('http://thetvdb.com/api/123456789/series/1234/dvd/1/1/en.xml')
+        end
+      end
+
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.find_by_dvd_order_url(1234, 1, 1, 'de')
+          ).to eq('http://thetvdb.com/api/123456789/series/1234/dvd/1/1/de.xml')
+        end
       end
     end
   end
@@ -107,12 +155,24 @@ describe ThetvdbApi::Episode do
     end
 
     context 'normal attributes' do
-      it 'should return Faraday::Response class' do
-        expect(model.find_by_absolute_order(1234, 1)).to be_a(Faraday::Response)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find_by_absolute_order(1234, 1)).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find_by_absolute_order(1234, 1).body).to be_a(Hash)
+        end
       end
 
-      it 'should return Hash class for body reponse' do
-        expect(model.find_by_absolute_order(1234, 1).body).to be_a(Hash)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find_by_absolute_order(1234, 1, 'de')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find_by_absolute_order(1234, 1, 'de').body).to be_a(Hash)
+        end
       end
     end
   end
@@ -127,10 +187,20 @@ describe ThetvdbApi::Episode do
     end
 
     context 'normal attributes' do
-      it 'should return correct url' do
-        expect(
-          model.find_by_absolute_order_url(1234, 1)
-        ).to eq('http://thetvdb.com/api/123456789/series/1234/absolute/1/en.xml')
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.find_by_absolute_order_url(1234, 1)
+          ).to eq('http://thetvdb.com/api/123456789/series/1234/absolute/1/en.xml')
+        end
+      end
+
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.find_by_absolute_order_url(1234, 1, 'de')
+          ).to eq('http://thetvdb.com/api/123456789/series/1234/absolute/1/de.xml')
+        end
       end
     end
   end
@@ -147,12 +217,24 @@ describe ThetvdbApi::Episode do
     end
 
     context 'normal attributes' do
-      it 'should return Faraday::Response class' do
-        expect(model.find(1234)).to be_a(Faraday::Response)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find(1234)).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find(1234).body).to be_a(Hash)
+        end
       end
 
-      it 'should return Hash class for body reponse' do
-        expect(model.find(1234).body).to be_a(Hash)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find(1234, 'de')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find(1234, 'de').body).to be_a(Hash)
+        end
       end
     end
   end
@@ -167,10 +249,20 @@ describe ThetvdbApi::Episode do
     end
 
     context 'normal attributes' do
-      it 'should return correct url' do
-        expect(
-          model.find_url(1234)
-        ).to eq('http://thetvdb.com/api/123456789/episodes/1234/en.xml')
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.find_url(1234)
+          ).to eq('http://thetvdb.com/api/123456789/episodes/1234/en.xml')
+        end
+      end
+
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.find_url(1234, 'de')
+          ).to eq('http://thetvdb.com/api/123456789/episodes/1234/de.xml')
+        end
       end
     end
   end

data/spec/functionals/search_spec.rb

@@ -11,9 +11,15 @@ describe ThetvdbApi::Search do
   let(:faraday_stubs) do
     Faraday::Adapter::Test::Stubs.new do |stub|
       stub.get('/api/GetSeries.php?language=en&seriesname=Supernatural') { [200, { content_type: 'xml' }, get_series_data] }
+      stub.get('/api/GetSeries.php?language=de&seriesname=Supernatural') { [200, { content_type: 'xml' }, get_series_data] }
       stub.get('/api/GetSeriesByRemoteID.php?language=en&imdbid=tt0290978') { [200, { content_type: 'xml' }, get_series_by_remote_data] }
+      stub.get('/api/GetSeriesByRemoteID.php?language=de&imdbid=tt0290978') { [200, { content_type: 'xml' }, get_series_by_remote_data] }
       stub.get('/api/GetSeriesByRemoteID.php?language=en&zap2it=SH01234') { [200, { content_type: 'xml' }, get_series_by_remote_data] }
-      stub.get('/api/GetEpisodeByAirDate.php?language=en&airdate=2007-09-24&apikey=123456789&language=en&seriesid=80348') do
+      stub.get('/api/GetSeriesByRemoteID.php?language=de&zap2it=SH01234') { [200, { content_type: 'xml' }, get_series_by_remote_data] }
+      stub.get('/api/GetEpisodeByAirDate.php?language=en&airdate=2007-09-24&apikey=123456789&seriesid=80348') do
+        [200, { content_type: 'xml' }, get_episode_data]
+      end
+      stub.get('/api/GetEpisodeByAirDate.php?language=de&airdate=2007-09-24&apikey=123456789&seriesid=80348') do
         [200, { content_type: 'xml' }, get_episode_data]
       end
     end
@@ -31,12 +37,24 @@ describe ThetvdbApi::Search do
     end
 
     context 'normal attributes' do
-      it 'should return Faraday::Response class' do
-        expect(model.get_series('Supernatural')).to be_a(Faraday::Response)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.get_series('Supernatural')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.get_series('Supernatural').body).to be_a(Hash)
+        end
       end
 
-      it 'should return Hash class for body reponse' do
-        expect(model.get_series('Supernatural').body).to be_a(Hash)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.get_series('Supernatural', 'de')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.get_series('Supernatural', 'de').body).to be_a(Hash)
+        end
       end
     end
   end
@@ -51,10 +69,20 @@ describe ThetvdbApi::Search do
     end
 
     context 'normal attributes' do
-      it 'should return correct url' do
-        expect(
-          model.get_series_url('Supernatural')
-        ).to eq('http://thetvdb.com/api/GetSeries.php?language=en&seriesname=Supernatural')
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.get_series_url('Supernatural')
+          ).to eq('http://thetvdb.com/api/GetSeries.php?language=en&seriesname=Supernatural')
+        end
+      end
+
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.get_series_url('Supernatural', 'de')
+          ).to eq('http://thetvdb.com/api/GetSeries.php?language=de&seriesname=Supernatural')
+        end
       end
     end
   end
@@ -105,44 +133,88 @@ describe ThetvdbApi::Search do
 
   describe '.get_series_by_imdb_id' do
     context 'normal attributes' do
-      it 'should return Faraday::Response class' do
-        expect(model.get_series_by_imdb_id('tt0290978')).to be_a(Faraday::Response)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.get_series_by_imdb_id('tt0290978')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.get_series_by_imdb_id('tt0290978').body).to be_a(Hash)
+        end
       end
 
-      it 'should return Hash class for body reponse' do
-        expect(model.get_series_by_imdb_id('tt0290978').body).to be_a(Hash)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.get_series_by_imdb_id('tt0290978', 'de')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.get_series_by_imdb_id('tt0290978', 'de').body).to be_a(Hash)
+        end
       end
     end
   end
 
   describe '.get_series_by_imdb_id_url' do
     context 'normal attributes' do
-      it 'should return correct url' do
-        expect(
-          model.get_series_by_imdb_id_url('tt0290978')
-        ).to eq('http://thetvdb.com/api/GetSeriesByRemoteID.php?language=en&imdbid=tt0290978')
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.get_series_by_imdb_id_url('tt0290978')
+          ).to eq('http://thetvdb.com/api/GetSeriesByRemoteID.php?language=en&imdbid=tt0290978')
+        end
+      end
+
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.get_series_by_imdb_id_url('tt0290978', 'de')
+          ).to eq('http://thetvdb.com/api/GetSeriesByRemoteID.php?language=de&imdbid=tt0290978')
+        end
       end
     end
   end
 
   describe '.get_series_by_zap2it_id' do
     context 'normal attributes' do
-      it 'should return Faraday::Response class' do
-        expect(model.get_series_by_zap2it_id('SH01234')).to be_a(Faraday::Response)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.get_series_by_zap2it_id('SH01234')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.get_series_by_zap2it_id('SH01234').body).to be_a(Hash)
+        end
       end
 
-      it 'should return Hash class for body reponse' do
-        expect(model.get_series_by_zap2it_id('SH01234').body).to be_a(Hash)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.get_series_by_zap2it_id('SH01234', 'de')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.get_series_by_zap2it_id('SH01234', 'de').body).to be_a(Hash)
+        end
       end
     end
   end
 
   describe '.get_series_by_zap2it_id_url' do
     context 'normal attributes' do
-      it 'should return correct url' do
-        expect(
-          model.get_series_by_zap2it_id_url('SH01234')
-        ).to eq('http://thetvdb.com/api/GetSeriesByRemoteID.php?language=en&zap2it=SH01234')
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.get_series_by_zap2it_id_url('SH01234')
+          ).to eq('http://thetvdb.com/api/GetSeriesByRemoteID.php?language=en&zap2it=SH01234')
+        end
+      end
+
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.get_series_by_zap2it_id_url('SH01234', 'de')
+          ).to eq('http://thetvdb.com/api/GetSeriesByRemoteID.php?language=de&zap2it=SH01234')
+        end
       end
     end
   end
@@ -159,12 +231,24 @@ describe ThetvdbApi::Search do
     end
 
     context 'normal attributes' do
-      it 'should return Faraday::Response class' do
-        expect(model.get_episode(80348, '2007-09-24')).to be_a(Faraday::Response)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.get_episode(80348, '2007-09-24')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.get_episode(80348, '2007-09-24').body).to be_a(Hash)
+        end
       end
 
-      it 'should return Hash class for body reponse' do
-        expect(model.get_episode(80348, '2007-09-24').body).to be_a(Hash)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.get_episode(80348, '2007-09-24', 'de')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.get_episode(80348, '2007-09-24', 'de').body).to be_a(Hash)
+        end
       end
     end
   end
@@ -179,10 +263,20 @@ describe ThetvdbApi::Search do
     end
 
     context 'normal attributes' do
-      it 'should return correct url' do
-        expect(
-          model.get_episode_url(80348, '2007-09-24')
-        ).to eq('http://thetvdb.com/api/GetEpisodeByAirDate.php?apikey=123456789&language=en&seriesid=80348&airdate=2007-09-24')
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.get_episode_url(80348, '2007-09-24')
+          ).to eq('http://thetvdb.com/api/GetEpisodeByAirDate.php?apikey=123456789&language=en&seriesid=80348&airdate=2007-09-24')
+        end
+      end
+
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(
+            model.get_episode_url(80348, '2007-09-24', 'de')
+          ).to eq('http://thetvdb.com/api/GetEpisodeByAirDate.php?apikey=123456789&language=de&seriesid=80348&airdate=2007-09-24')
+        end
       end
     end
   end

data/spec/functionals/series_spec.rb

@@ -10,7 +10,9 @@ describe ThetvdbApi::Series do
   let(:faraday_stubs) do
     Faraday::Adapter::Test::Stubs.new do |stub|
       stub.get('/api/123456789/series/1234/en.xml') { [200, { content_type: 'xml' }, series_data] }
+      stub.get('/api/123456789/series/1234/de.xml') { [200, { content_type: 'xml' }, series_data] }
       stub.get('/api/123456789/series/1234/all/en.xml') { [200, { content_type: 'xml' }, full_series_data] }
+      stub.get('/api/123456789/series/1234/all/de.xml') { [200, { content_type: 'xml' }, full_series_data] }
     end
   end
   
@@ -26,12 +28,24 @@ describe ThetvdbApi::Series do
     end
 
     context 'normal attributes' do
-      it 'should return Faraday::Response class' do
-        expect(model.find(1234)).to be_a(Faraday::Response)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find(1234)).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find(1234).body).to be_a(Hash)
+        end
       end
 
-      it 'should return Hash class for body reponse' do
-        expect(model.find(1234).body).to be_a(Hash)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find(1234, 'de')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find(1234, 'de').body).to be_a(Hash)
+        end
       end
     end
   end
@@ -44,8 +58,16 @@ describe ThetvdbApi::Series do
     end
 
     context 'normal attributes' do
-      it 'should return correct url' do
-        expect(model.find_url(1234)).to eq('http://thetvdb.com/api/123456789/series/1234/en.xml')
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(model.find_url(1234)).to eq('http://thetvdb.com/api/123456789/series/1234/en.xml')
+        end
+      end
+
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(model.find_url(1234, 'de')).to eq('http://thetvdb.com/api/123456789/series/1234/de.xml')
+        end
       end
     end
   end
@@ -62,12 +84,24 @@ describe ThetvdbApi::Series do
     end
 
     context 'normal attributes' do
-      it 'should return Faraday::Response class' do
-        expect(model.find_full(1234)).to be_a(Faraday::Response)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find_full(1234)).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find_full(1234).body).to be_a(Hash)
+        end
       end
 
-      it 'should return Hash class for body reponse' do
-        expect(model.find_full(1234).body).to be_a(Hash)
+      context 'without optional attribute' do
+        it 'should return Faraday::Response class' do
+          expect(model.find_full(1234, 'de')).to be_a(Faraday::Response)
+        end
+
+        it 'should return Hash class for body reponse' do
+          expect(model.find_full(1234, 'de').body).to be_a(Hash)
+        end
       end
     end
   end
@@ -80,8 +114,16 @@ describe ThetvdbApi::Series do
     end
 
     context 'normal attributes' do
-      it 'should return correct url' do
-        expect(model.find_full_url(1234)).to eq('http://thetvdb.com/api/123456789/series/1234/all/en.xml')
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(model.find_full_url(1234)).to eq('http://thetvdb.com/api/123456789/series/1234/all/en.xml')
+        end
+      end
+
+      context 'without optional attribute' do
+        it 'should return correct url' do
+          expect(model.find_full_url(1234, 'de')).to eq('http://thetvdb.com/api/123456789/series/1234/all/de.xml')
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: thetvdb_api
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Krzysztof Wawer