themoviedb 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 166055b6cba5ab74aa7f8959d58f0efd12f908ff
-  data.tar.gz: bb037509ef8cde00343b786f92cdf3a048669aab
+  metadata.gz: 4841a9b8af1e16aca5ce1df17d174ac6d278b7e8
+  data.tar.gz: d118439af3bbe6b4452756921704c929ec46832d
 SHA512:
-  metadata.gz: ccf100be48cedee1cc87887f05a15747302b1fdd1ea7dde14090542f7cff16521401cec4adecd0e7903ae77722021a90691ac936b79da5b3bce03fc7fefc8444
-  data.tar.gz: ba5b785ec47a6e9f026377281b2753c450ed425656a63dcdbb23e00e048250875056a6799a48ec80a7ad2f38b1781bd5fdebc5f4c7f68738159df4e8d854c4ee
+  metadata.gz: 2c0b53885f021caa05da2eabed934b0f8028c530d55c25e73155835188cc8fdca7ed70f6c9281017bd3d3052de3a4e552ceff4ab655d249b2f06fdf0e88541fa
+  data.tar.gz: 13eed0665d2a7091bd49bacf6416382185bed100a63035c6a9d24b0f54b3d1c3f31e3d94208bd7e47b6fcb7bf4523d7602aec06f1b0999b57b944f27160a6792

data/lib/themoviedb/api.rb

@@ -1,4 +1,5 @@
 module Tmdb
+  class InvalidApiKeyError < StandardError ;  end
   class Api
     include HTTParty
     base_uri 'api.themoviedb.org/3/'
@@ -32,6 +33,8 @@ module Tmdb
 
     def self.set_response(hash)
       @@response = hash
+      # Detect 401 Unauthorized error, which indicates invalid API key
+      raise Tmdb::InvalidApiKeyError if hash['code'].to_i == 401
     end
   end
 end

data/lib/themoviedb/search.rb

@@ -16,7 +16,7 @@ module Tmdb
       self
     end
 
-    def primary_realease_year(year)
+    def primary_release_year(year)
       @params[:primary_release_year] = year.to_s
       self
     end

data/lib/themoviedb/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Tmdb
-  VERSION = '1.0.0'.freeze
+  VERSION = '1.0.1'.freeze
 end

data/spec/invalid_api_key_spec.rb

@@ -0,0 +1,24 @@
+require 'rspec'
+require 'spec_helper'
+
+describe 'invalid API key' do
+  after(:all) { Tmdb::Api.key($VALID_API_KEY) }
+  it 'raises error for nil key' do
+    Tmdb::Api.key(nil)
+    VCR.use_cassette 'api_key/nil_key' do
+      expect { Tmdb::Movie.search('batman') }.to raise_error(Tmdb::InvalidApiKeyError)
+    end
+  end
+  it 'raises error for empty string key' do
+    Tmdb::Api.key('')
+    VCR.use_cassette 'api_key/empty_string' do
+      expect { Tmdb::Movie.search('batman') }.to raise_error(Tmdb::InvalidApiKeyError)
+    end
+  end
+  it 'raises error invalid nonempty key' do
+    Tmdb::Api.key('bad-key')
+    VCR.use_cassette 'api_key/invalid_key' do
+      expect { Tmdb::Movie.search('batman') }.to raise_error(Tmdb::InvalidApiKeyError)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -8,7 +8,8 @@
 require_relative '../lib/themoviedb.rb'
 require 'vcr'
 
-Tmdb::Api.key('8a221fc31fcdf12a8af827465574ffc9')
+$VALID_API_KEY = '8a221fc31fcdf12a8af827465574ffc9'
+Tmdb::Api.key($VALID_API_KEY)
 
 VCR.configure do |c|
   # the directory where your cassettes will be saved

data/spec/vcr/api_key/empty_string.yml

@@ -0,0 +1,41 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://api.themoviedb.org/3/search/movie?api_key=&query=batman
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - application/json
+      Content-Type:
+      - application/json
+  response:
+    status:
+      code: 401
+      message: Unauthorized
+    headers:
+      Content-Type:
+      - application/json;charset=utf-8
+      Date:
+      - Sun, 07 Feb 2016 19:36:58 GMT
+      Server:
+      - openresty
+      X-Ratelimit-Limit:
+      - '40'
+      X-Ratelimit-Remaining:
+      - '38'
+      X-Ratelimit-Reset:
+      - '1454873828'
+      Content-Length:
+      - '86'
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"status_code":7,"status_message":"Invalid API key: You must be granted
+        a valid key."}'
+    http_version: 
+  recorded_at: Sun, 07 Feb 2016 19:37:00 GMT
+recorded_with: VCR 3.0.1

data/spec/vcr/api_key/invalid_key.yml

@@ -0,0 +1,41 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://api.themoviedb.org/3/search/movie?api_key=bad-key&query=batman
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - application/json
+      Content-Type:
+      - application/json
+  response:
+    status:
+      code: 401
+      message: Unauthorized
+    headers:
+      Content-Type:
+      - application/json;charset=utf-8
+      Date:
+      - Sun, 07 Feb 2016 19:36:58 GMT
+      Server:
+      - openresty
+      X-Ratelimit-Limit:
+      - '40'
+      X-Ratelimit-Remaining:
+      - '37'
+      X-Ratelimit-Reset:
+      - '1454873828'
+      Content-Length:
+      - '86'
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"status_code":7,"status_message":"Invalid API key: You must be granted
+        a valid key."}'
+    http_version: 
+  recorded_at: Sun, 07 Feb 2016 19:37:00 GMT
+recorded_with: VCR 3.0.1

data/spec/vcr/api_key/nil_key.yml

@@ -0,0 +1,41 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://api.themoviedb.org/3/search/movie?api_key=&query=batman
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - application/json
+      Content-Type:
+      - application/json
+  response:
+    status:
+      code: 401
+      message: Unauthorized
+    headers:
+      Content-Type:
+      - application/json;charset=utf-8
+      Date:
+      - Sun, 07 Feb 2016 19:36:58 GMT
+      Server:
+      - openresty
+      X-Ratelimit-Limit:
+      - '40'
+      X-Ratelimit-Remaining:
+      - '39'
+      X-Ratelimit-Reset:
+      - '1454873828'
+      Content-Length:
+      - '86'
+      Connection:
+      - keep-alive
+    body:
+      encoding: UTF-8
+      string: '{"status_code":7,"status_message":"Invalid API key: You must be granted
+        a valid key."}'
+    http_version: 
+  recorded_at: Sun, 07 Feb 2016 19:37:00 GMT
+recorded_with: VCR 3.0.1

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: themoviedb
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Ahmet Abdi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-01 00:00:00.000000000 Z
+date: 2016-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -106,11 +106,15 @@ files:
 - lib/themoviedb/version.rb
 - spec/company_spec.rb
 - spec/find_spec.rb
+- spec/invalid_api_key_spec.rb
 - spec/movie_spec.rb
 - spec/person_spec.rb
 - spec/spec/vcr/find/search_imdb.yml
 - spec/spec_helper.rb
 - spec/tv_spec.rb
+- spec/vcr/api_key/empty_string.yml
+- spec/vcr/api_key/invalid_key.yml
+- spec/vcr/api_key/nil_key.yml
 - spec/vcr/company/detail.yml
 - spec/vcr/company/movies.yml
 - spec/vcr/find/search_imdb.yml
@@ -176,6 +180,7 @@ signing_key:
 specification_version: 4
 summary: A Ruby wrapper for the The Movie Database API.
 test_files:
+- spec/invalid_api_key_spec.rb
 - spec/company_spec.rb
 - spec/spec_helper.rb
 - spec/tv_spec.rb
@@ -205,6 +210,9 @@ test_files:
 - spec/vcr/movie/trailers_for_id.yml
 - spec/vcr/company/movies.yml
 - spec/vcr/company/detail.yml
+- spec/vcr/api_key/nil_key.yml
+- spec/vcr/api_key/invalid_key.yml
+- spec/vcr/api_key/empty_string.yml
 - spec/vcr/find/search_imdb.yml
 - spec/vcr/find/search_tvdb.yml
 - spec/vcr/tv/crew.yml