theme-check 1.10.2 → 1.10.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c21a0e8261a92b4eff6c415ca4205bb9e5f0b91c48cd9f2e4f6fb6a14adfe69c
-  data.tar.gz: 8dd16b772e87d56a174b9053c2fc4791457d79774b30e4b8813178224e8e7db2
+  metadata.gz: c2774c1d3e2e9b8fa7dab0fdd4174dbfd3e625c608af349c30f526f00a6b9123
+  data.tar.gz: 69bdb078be8aa938b2dec75a62206840586ae1a015620ec3c9ce727e49fc2e07
 SHA512:
-  metadata.gz: 03ac611f090d34741494bad1c9dd199ae90716c7bf10c2a99c0ae6e28aa5456d53c342ac3888bf683d4cfecb37605595586d720393f220f695379b6c1d5e3186
-  data.tar.gz: bc21703838ffa3606830505bfdc7d76b0fd675f402b7c062fe3ddd893ff62bb451fe57d44e77de8c6f99886546c0a261de9146d02833c81a10ec1c0c9e5ffc4e
+  metadata.gz: aa83efd1994e95fd12defc06b13567fac6e80fd830fb870f7a50b650424b8ed339848271ac35c608b6bc40a3e884665a3136c1f75e150be937be8b78e74df9fc
+  data.tar.gz: 848e2752ecc6e6bb4b0954663dac298f869a191d0b4b146fd488b8a9a442a5573a1c716c84658b2654431f96db1572309c70991a2e29e37c1bf82bd337c79edd

data/CHANGELOG.md

@@ -1,4 +1,15 @@
 
+v1.10.3 / 2022-06-16
+==================
+
+  * Support app drop in theme app extensions ([#566](https://github.com/shopify/theme-check/issues/566))
+  * Fix requiring custom check when root is specified ([#565](https://github.com/shopify/theme-check/issues/565))
+  * Fix TranslationKeyExists.on_end issue ([#587](https://github.com/shopify/theme-check/issues/587))
+  * Fix bad link on check documentation ([#575](https://github.com/shopify/theme-check/issues/575))
+  * Update TEMPLATE.md.erb to use shopify.dev URL
+  * Fixed broken URL ([#574](https://github.com/shopify/theme-check/issues/574))
+  * Fix unknown configuration issue for UndefinedObject checker ([#568](https://github.com/shopify/theme-check/issues/568))
+
 v1.10.2 / 2022-03-07
 ====================
 

data/config/default.yml

@@ -101,6 +101,7 @@ UndefinedObject:
   enabled: true
   ignore: []
   exclude_snippets: true
+  config_type: :default
 
 RequiredDirectories:
   enabled: true

data/config/theme_app_extension.yml

@@ -89,6 +89,7 @@ UndefinedObject:
   enabled: true
   ignore: []
   exclude_snippets: true
+  config_type: :theme_app_extension
 
 RequiredDirectories:
   enabled: false

data/data/shopify_liquid/theme_app_extension_objects.yml

@@ -0,0 +1,2 @@
+---
+- app

data/docs/api/check.md

@@ -12,4 +12,4 @@ There are three types of checks currently supported:
 
 - [`LiquidCheck`](/docs/api/liquid_check.md)
 - [`HtmlCheck`](/docs/api/html_check.md)
-- [`JsonCheck`](/docs/api/html_check.md)
+- [`JsonCheck`](/docs/api/json_check.md)

data/docs/checks/TEMPLATE.md.erb

@@ -34,7 +34,7 @@ The following example contains the default configuration for this check:
 | Parameter | Description |
 | --- | --- |
 | enabled | Whether the check is enabled. |
-| severity | The [severity](https://shopify.developers/themes/tools/theme-check/configuration#check-severity) of the check. |
+| severity | The [severity](https://shopify.dev/themes/tools/theme-check/configuration#check-severity) of the check. |
 | other_option | A description of the option. |
 
 ## Disabling this check

data/docs/checks/schema_json_format.md

@@ -59,7 +59,7 @@ SchemaJsonFormat:
 | Parameter | Description |
 | --- | --- |
 | enabled | Whether the check is enabled. |
-| severity | The [severity](https://shopify.developers/themes/tools/theme-check/configuration#check-severity) of the check. |
+| severity | The [severity](https://shopify.dev/themes/tools/theme-check/configuration#check-severity) of the check. |
 | start_level | The indentation level. If you prefer an indented schema, set this to 1. |
 | indent | The character(s) used for indentation levels. |
 

data/lib/theme_check/checks/translation_key_exists.rb

@@ -48,6 +48,7 @@ module ThemeCheck
 
     def key_exists?(key, pointer)
       key.split(".").each do |token|
+        return false unless pointer.is_a?(Hash)
         return false unless pointer.key?(token)
         pointer = pointer[token]
       end

data/lib/theme_check/checks/undefined_object.rb

@@ -55,7 +55,8 @@ module ThemeCheck
       end
     end
 
-    def initialize(exclude_snippets: true)
+    def initialize(config_type: :default, exclude_snippets: true)
+      @config_type = config_type
       @exclude_snippets = exclude_snippets
       @files = {}
     end
@@ -111,6 +112,9 @@ module ThemeCheck
       shopify_plus_objects = ThemeCheck::ShopifyLiquid::Object.plus_labels
       shopify_plus_objects.freeze
 
+      theme_app_extension_objects = ThemeCheck::ShopifyLiquid::Object.theme_app_extension_labels
+      theme_app_extension_objects.freeze
+
       each_template do |(name, info)|
         if 'templates/customers/reset_password' == name
           # NOTE: `email` is exceptionally exposed as a theme object in
@@ -121,6 +125,8 @@ module ThemeCheck
           #       the checkout template
           # https://shopify.dev/docs/themes/theme-templates/checkout-liquid#optional-objects
           check_object(info, all_global_objects + shopify_plus_objects)
+        elsif config_type == :theme_app_extension
+          check_object(info, all_global_objects + theme_app_extension_objects)
         else
           check_object(info, all_global_objects)
         end
@@ -129,6 +135,8 @@ module ThemeCheck
 
     private
 
+    attr_reader :config_type
+
     def ignore?(node)
       @exclude_snippets && node.theme_file.snippet?
     end

data/lib/theme_check/config.rb

@@ -209,7 +209,8 @@ module ThemeCheck
 
     def resolve_requires
       self["require"]&.each do |path|
-        require(File.join(@root, path))
+        file_to_require = @root.join(path).realpath
+        require(file_to_require.to_s)
       end
     end
   end

data/lib/theme_check/shopify_liquid/object.rb

@@ -13,6 +13,10 @@ module ThemeCheck
       def plus_labels
         @plus_labels ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/plus_objects.yml"))
       end
+
+      def theme_app_extension_labels
+        @theme_app_extension_labels ||= YAML.load(File.read("#{__dir__}/../../../data/shopify_liquid/theme_app_extension_objects.yml"))
+      end
     end
   end
 end

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "1.10.2"
+  VERSION = "1.10.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 1.10.2
+  version: 1.10.3
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-03-07 00:00:00.000000000 Z
+date: 2022-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid
@@ -84,6 +84,7 @@ files:
 - data/shopify_liquid/objects.yml
 - data/shopify_liquid/plus_objects.yml
 - data/shopify_liquid/tags.yml
+- data/shopify_liquid/theme_app_extension_objects.yml
 - data/shopify_translation_keys.yml
 - dev.yml
 - docs/api/check.md
@@ -300,7 +301,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.20
+rubygems_version: 3.3.3
 signing_key: 
 specification_version: 4
 summary: A Shopify Theme Linter