theme-check 1.10.1 → 1.10.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 131d90a928b4130827c6e41ea99ccd852e650417e88baceb66910ff083cf3aaa
-  data.tar.gz: a754d8b221da85eea053ce6f7547c9cad5a3a1e5f7a41562d61922a1278abe5d
+  metadata.gz: c21a0e8261a92b4eff6c415ca4205bb9e5f0b91c48cd9f2e4f6fb6a14adfe69c
+  data.tar.gz: 8dd16b772e87d56a174b9053c2fc4791457d79774b30e4b8813178224e8e7db2
 SHA512:
-  metadata.gz: 8e2bc230eee811d2d0d8b62a09d11b3b88f2e54939f0c1aeda843d3f8d8455e34d0379aa89a9f388401d4ebb593a00abdfbb57357717fb9167bf7a73fb89943d
-  data.tar.gz: f901b9cd064ee47fa39a6b661524e2d4eafc52b6cda54aceabd4ff371c1d562cfb43967c666642b1ef4d1c1b72cb793ab3cf202bfaee2a5f80aedb1840335155
+  metadata.gz: 03ac611f090d34741494bad1c9dd199ae90716c7bf10c2a99c0ae6e28aa5456d53c342ac3888bf683d4cfecb37605595586d720393f220f695379b6c1d5e3186
+  data.tar.gz: bc21703838ffa3606830505bfdc7d76b0fd675f402b7c062fe3ddd893ff62bb451fe57d44e77de8c6f99886546c0a261de9146d02833c81a10ec1c0c9e5ffc4e

data/CHANGELOG.md

@@ -1,4 +1,10 @@
 
+v1.10.2 / 2022-03-07
+====================
+
+  * Handle nil paths in json_printer's sort_by ([#561](https://github.com/shopify/theme-check/issues/561))
+  * Prevent bad render tags from passing theme-check ([#559](https://github.com/shopify/theme-check/issues/559))
+
 v1.10.1 / 2022-02-24
 ====================
 

data/lib/theme_check/json_printer.rb

@@ -25,7 +25,7 @@ module ThemeCheck
             styleCount: path_offenses.count { |offense| offense[:severity] == Check::SEVERITY_VALUES[:style] },
           }
         end
-        .sort_by { |o| o[:path] }
+        .sort_by { |o| o[:path] || Pathname.new('') }
     end
   end
 end

data/lib/theme_check/tags.rb

@@ -125,7 +125,23 @@ module ThemeCheck
     end
 
     class Render < Liquid::Tag
-      SYNTAX = /((?:#{Liquid::QuotedString}|#{Liquid::VariableSegment})+)(\s+(with|#{Liquid::Render::FOR})\s+(#{Liquid::QuotedFragment}+))?(\s+(?:as)\s+(#{Liquid::VariableSegment}+))?/o
+      SYNTAX = %r{
+        (
+          ## for {% render "snippet" %}
+          #{Liquid::QuotedString}+ |
+          ## for {% render block %}
+          ## We require the variable # segment to be at the beginning of the
+          ## string (with \A). This is to prevent code like {% render !foo! %}
+          ## from parsing
+          \A#{Liquid::VariableSegment}+
+        )
+        ## for {% render "snippet" with product as p %}
+        ## or {% render "snippet" for products p %}
+        (\s+(with|#{Liquid::Render::FOR})\s+(#{Liquid::QuotedFragment}+))?
+        (\s+(?:as)\s+(#{Liquid::VariableSegment}+))?
+        ## variables passed into the tag (e.g. {% render "snippet", var1: value1, var2: value2 %}
+        ## are not matched by this regex and are handled by Liquid::Render.initialize
+      }xo
 
       disable_tags "include"
 
@@ -134,7 +150,7 @@ module ThemeCheck
       def initialize(tag_name, markup, options)
         super
 
-        raise SyntaxError, options[:locale].t("errors.syntax.render") unless markup =~ SYNTAX
+        raise Liquid::SyntaxError, options[:locale].t("errors.syntax.render") unless markup =~ SYNTAX
 
         template_name = Regexp.last_match(1)
         with_or_for = Regexp.last_match(3)

data/lib/theme_check/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ThemeCheck
-  VERSION = "1.10.1"
+  VERSION = "1.10.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: theme-check
 version: !ruby/object:Gem::Version
-  version: 1.10.1
+  version: 1.10.2
 platform: ruby
 authors:
 - Marc-André Cournoyer
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-02-24 00:00:00.000000000 Z
+date: 2022-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: liquid