thegarage-gitx 2.13.0 → 2.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3970bcceec2fdffef729443705a5533f089e25b5
-  data.tar.gz: c42d584f27788dfd2491149895442665ce04fb92
+  metadata.gz: 3c76b9142f428f3c146f42e9ebb4cae36f5aa3e4
+  data.tar.gz: c1beddf110f6ef5d34179bfec65fbcf79e9bd48c
 SHA512:
-  metadata.gz: 09941f7c3d161f8a7e8bb9f1167484713d2d12dc40d8fc4ecfddc93a37f51d93ee20319919650205b34ebe8a96ac83c0e0e042a83f2a3f3da237091357bd04c3
-  data.tar.gz: d8960f7276396f466d4c606b1e73355cd2a2db010502f1292e787fccc04b5f06bbe17ff411119bfc68fdbd66e28ef0472fb97ea9134abf9a7128c0e50a1d5fee
+  metadata.gz: 5eb433fa613fe8740d57436d16707cd6cd21929ee003916619e8edf060447fb70b7eb410927b9f2f09f791f8decc0da728da91597059f02979120ad1b7491805
+  data.tar.gz: 689de10ba6d60de808582ab64144a573c4c760ee38614483e097f76be766f7fdb8ca9031a53d9ed157e5d1c8c43c4343e66697ccdcb6b313bd8a30503acdd49e

data/lib/thegarage/gitx/cli/review_command.rb

@@ -70,17 +70,17 @@ module Thegarage
 
         def bump_pull_request(pull_request)
           comment = comment_from_template(pull_request, BUMP_COMMENT_PREFIX, BUMP_COMMENT_FOOTER)
-          set_review_status('pending', 'Peer review in progress')
+          update_review_status(pull_request, 'pending', 'Peer review in progress')
         end
 
         def reject_pull_request(pull_request)
           comment = comment_from_template(pull_request, REJECTION_COMMENT_PREFIX, REJECTION_COMMENT_FOOTER)
-          set_review_status('failure', 'Peer review rejected')
+          update_review_status(pull_request, 'failure', 'Peer review rejected')
         end
 
         def approve_pull_request(pull_request)
           comment = comment_from_template(pull_request, APPROVAL_COMMENT_PREFIX, APPROVAL_COMMENT_FOOTER)
-          set_review_status('success', 'Peer review approved')
+          update_review_status(pull_request, 'success', 'Peer review approved')
         end
 
         def comment_from_template(pull_request, prefix, footer)
@@ -89,11 +89,6 @@ module Thegarage
           comment = comment.gsub(footer, '').chomp.strip
           github_client.add_comment(github_slug, pull_request.number, comment)
         end
-
-        def set_review_status(state, description)
-          latest_commit = repo.head.target_id
-          update_review_status(latest_commit, state, description)
-        end
       end
     end
   end

data/lib/thegarage/gitx/github.rb

@@ -52,7 +52,8 @@ module Thegarage
       end
 
       # Update build status with peer review status
-      def update_review_status(commit_sha, state, description)
+      def update_review_status(pull_request, state, description)
+        commit_sha = pull_request.head.sha
         github_client.create_status(github_slug, commit_sha, state, context: REVIEW_CONTEXT, description: description)
       end
 

data/lib/thegarage/gitx/version.rb

@@ -1,5 +1,5 @@
 module Thegarage
   module Gitx
-    VERSION = '2.13.0'
+    VERSION = '2.13.1'
   end
 end

data/spec/fixtures/vcr_cassettes/pull_request_does_exist_with_success_status.yml

@@ -75,7 +75,7 @@ http_interactions:
       - d818ddef80f4c7d10683dd483558952a
     body:
       encoding: UTF-8
-      string: '[{"html_url":"https://path/to/html/pull/request","issue_url":"https://api/path/to/issue/url","number":10,"head":{"ref":"branch_name"}}]'
+      string: '[{"html_url":"https://path/to/html/pull/request","issue_url":"https://api/path/to/issue/url","number":10,"head":{"ref":"branch_name", "sha": "e12da4"}}]'
     http_version:
   recorded_at: Tue, 05 Aug 2014 16:36:03 GMT
 - request:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: thegarage-gitx
 version: !ruby/object:Gem::Version
-  version: 2.13.0
+  version: 2.13.1
 platform: ruby
 authors:
 - Ryan Sonnek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-16 00:00:00.000000000 Z
+date: 2015-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rugged