thegamesdb 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 477e3d9d2b073a86b77e82e6032a49f7c196e9eb9493ddbe233d5d1a569a4a95
-  data.tar.gz: 968a97e6b32aa648e40c443aca798c80eae9bec40275a350a2e762215a78fbcf
+  metadata.gz: 12c293f7e4d38a962ebdafd40e21165cb71650c9aee29fa81b70ba0917295f5b
+  data.tar.gz: 9788fcbbdf42b1aca4f4f50f20af5e6dbba5dc429e15c5e0da086a4b3c624eb8
 SHA512:
-  metadata.gz: c6a757afd1711766e6de821fd4f7470751ba757e2b001db9ed013619ea106d7ac02ffd29f151324469cb474f58e019e585a983c448fc4165bffbb7fcf1768835
-  data.tar.gz: 90a01c2548018e0c3f6366bf13494fe67d9425e3230ec893684fb9ec09ad2ccb32fef56e578dc74a783fe942dc59669670e23f92cbedf9b633e5a783c127a140
+  metadata.gz: b07a86d3b08940ce014eefd42d40d3de159c192365ce9d5561180ef71a4afb981e19dc681947d37e3cdfbd2972c06da1e5bcf68fed962fa8bee62e679acb27b7
+  data.tar.gz: 86c4ce64e7033b456603294a166b385492463e714bbfb22fe4aaedffd596fa2770149286592a0098032e8653cfb73b8be5c6c160c615c38047e754dc55ab37d7

data/.travis.yml

@@ -4,9 +4,10 @@ env:
 language: ruby
 rvm:
   - 2.3.8
-  - 2.4.7
-  - 2.5.6
-  - 2.6.4
+  - 2.4.9
+  - 2.5.7
+  - 2.6.5
+  - 2.7.0
   - truffleruby
   - ruby-head
 install: bundle install
@@ -18,3 +19,6 @@ script:
   - bundle exec rake test
 after_script:
   - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
+allow_failures:
+  - rvm: ruby-head
+  - rvm: truffleruby

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 1.1.2
+* Internal changes: update API endpoint url (adds `v1`), update tests
+
 ## 1.1.1
 * Adds `platform_id` parameter to `games_by_name`
 * Adds `page` parameter to `games_by_name`

data/README.md

@@ -78,6 +78,13 @@ Gamesdb.games_by_platform_id(7)
  => [{:name=>"Donkey Kong", :id=>5, :release_date=>"1982-01-01", :developers=>[6037]}, {:name=>"Bionic Commando", :id=>76, :release_date=>"1988-12-06", :developers=>[1436]}, {:name=>"Super Mario Bros. 3", :id=>112, :release_date=>"1990-02-12", :developers=>[6055]}, {:name=>"The Legend of Zelda", :id=>113, :release_date=>"1987-07-01", :developers=>[6055]}, {:name=>"Kirby's Adventure", :id=>121, :release_date=>"1993-03-26", :developers=>[3694]}, {:name=>"Metroid", :id=>123, :release_date=>"1987-08-15", :developers=>[6051]}, {:name=>"Mega Man 5", :id=>125, :release_date=>"1992-12-04", :developers=>[1436]}, {:name=>"Kid Icarus", :id=>130, :release_date=>"1986-12-18", :developers=>[6037]}, {:name=>"Lemmings", :id=>133, :release_date=>"1991-02-14", :developers=>[2404]}, {:name=>"Castlevania", :id=>135, :release_date=>"1987-05-01", :developers=>[4765]}, {:name=>"Super Mario Bros.", :id=>140, :release_date=>"1985-09-13", :developers=>[6042]}, ...
  ]
 ```
+
+Supports comma delimited list:
+
+```ruby
+Gamesdb.games_by_platform_id("4950,4948")
+```
+
 - [x] /Games/Images
 
 Usage:

data/lib/thegamesdb.rb

@@ -5,16 +5,16 @@ require 'json'
 
 # Client for TheGamesDB API (thegamesdb.net)
 module Gamesdb
-  BASE_URL = 'https://api.thegamesdb.net/'.freeze
+  BASE_URL = 'https://api.thegamesdb.net/v1/'.freeze
   IMAGES_BASE_URL = 'https://legacy.thegamesdb.net/banners/'.freeze
 
   # Method for listing platform's games
-  # TODO: check (and test) that we support ',' delimited list
-  # https://api.thegamesdb.net/#/operations/Games/GamesByPlatformID
+  #
+  # See: https://api.thegamesdb.net/#/operations/Games/GamesByPlatformID
   #
   # Parameters: platform id (int), page (int)
   #
-  # == Returns:
+  # = Returns:
   # Array of Hashes with games info
   #
   def self.games_by_platform_id(platform_id, page = 1)
@@ -237,14 +237,6 @@ module Gamesdb
     games
   end
 
-  def self.process_game(game)
-    game[:id] = game[:id].to_i
-    game[:name] = game.delete(:GameTitle)
-    game[:title] = game[:name]
-    game[:platform] = game.delete(:Platform)
-    game
-  end
-
   def self.symbolize_keys(hash)
     hash.keys.each do |key|
       hash[key.to_sym] = hash.delete(key)

data/lib/thegamesdb/version.rb

@@ -1,4 +1,4 @@
 # Gem version
 module Gamesdb
-  VERSION = '1.1.1'.freeze
+  VERSION = '1.1.2'.freeze
 end

data/test/games_test.rb

@@ -110,8 +110,7 @@ describe 'Gamesdb - games', :vcr do
       end
 
       it 'should return an empty array' do
-        @images.must_be_kind_of Array
-        @images.must_equal []
+        @images.must_be_kind_of Hash
       end
     end
   end

data/test/platform_test.rb

@@ -8,7 +8,7 @@ describe 'GamesDB - platforms', :vcr do
 
     it 'should get gaming platforms' do
       @platforms.count.wont_be :<, 0
-      @platforms.count.must_equal 109
+      @platforms.count.must_equal 110
     end
 
     it 'should have a valid name' do
@@ -39,7 +39,7 @@ describe 'GamesDB - platforms', :vcr do
     end
   end
 
-  describe 'platform_games pages' do
+  describe 'games by platform' do
     before do
       platforms = Gamesdb.platforms
       @first_page = Gamesdb.games_by_platform_id(platforms[0][:id])
@@ -58,6 +58,23 @@ describe 'GamesDB - platforms', :vcr do
     end
   end
 
+  describe 'games by platform parameters' do
+    before do
+      @games1 = Gamesdb.games_by_platform_id(4950)
+      @games2 = Gamesdb.games_by_platform_id(4948)
+      @games3 = Gamesdb.games_by_platform_id("4950,4948")
+    end
+
+    it 'supports comma separated list' do
+      @games1.count.must_equal 20
+      @games2.count.must_equal 1
+      @games3.count.must_equal 20
+
+      (@games3 - @games1).must_equal @games2
+    end
+
+  end
+
   describe 'platform' do
     describe 'assigning basic info' do
       before do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: thegamesdb
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Fernando Briano
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-11 00:00:00.000000000 Z
+date: 2020-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler