tfa 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 47c5413e1e1629847f5b3a930e26650a0318993b
-  data.tar.gz: dfde14c6b7e4bb9011819319dc0990f2d4798647
+  metadata.gz: 24e830bb0060ce472fd83b1a72cedca8b21e68bb
+  data.tar.gz: dfffb8e6ca0d88e6bffea3fadc7adae6af6b9f38
 SHA512:
-  metadata.gz: fc9085378b59b702147c9e8d97e890460c0060563b3ac60a962c5db0f252ac9da3d5359b278a4aabcdd16bcc932384821f036620611affc86a2ea0a97b052443
-  data.tar.gz: a7231f4b3f853a36eab71af8e35189324e42062218a1e36baa540bffbfa86f73e09e8ec4bda19139df65873b51eabf2aca46eb3c4ba018368cce9c3c1e5e78fe
+  metadata.gz: 9c3877dab4a1f13f06664aede58b0c835547c4285d0bf147c099eb12f87d047a2dcb72593ed4ac136ed725104df14e35d7c73a193b6d63e0a901fa240b79acc3
+  data.tar.gz: bf4ba1c1523aca58a5b7f772e9a4d4c02d5ebb9b86eba31e419e62c6b6608671bb8e213ea6e8501adfe211a3655f47565853ccaa33345e95043768616549df88

data/lib/tfa/cli.rb

@@ -7,16 +7,17 @@ module TFA
 
     desc "add NAME SECRET", "add a new secret to the database"
     def add(name, secret)
-      AddCommand.new(storage).run([name, secret])
+      storage.save(name, secret)
+      "Added #{name}"
     end
 
     desc "show NAME", "shows the secret for the given key"
     def show(name = nil)
-      ShowCommand.new(storage).run([name].compact)
+      name ? storage.secret_for(name) : storage.all
     end
 
     desc "totp NAME", "generate a Time based One Time Password"
-    def totp(name)
+    def totp(name = nil)
       TotpCommand.new(storage).run([name])
     end
 

data/lib/tfa/storage.rb

@@ -1,10 +1,18 @@
 module TFA
   class Storage
+    include Enumerable
+
     def initialize(filename:)
       @storage = PStore.new(File.join(Dir.home, ".#{filename}.pstore"))
     end
 
-    def all_secrets
+    def each
+      all.each do |each|
+        yield each
+      end
+    end
+
+    def all
       open_readonly do |storage|
         storage.roots.map { |key| { key => storage[key] } }
       end

data/lib/tfa/totp_command.rb

@@ -4,9 +4,9 @@ module TFA
       @storage = storage
     end
 
-    def run(arguments)
-      return password_for(secret_for(arguments.first)) if valid?(arguments)
-      all_passwords
+    def run(name)
+      secret = secret_for(name)
+      secret ? password_for(secret) : all_passwords
     end
 
     private
@@ -16,19 +16,13 @@ module TFA
     end
 
     def all_passwords
-      secrets = @storage.all_secrets
-      secrets.each do |hash|
+      @storage.each do |hash|
         hash[hash.keys.first] = password_for(hash[hash.keys.first])
       end
-      secrets
     end
 
     def secret_for(key)
       @storage.secret_for(key)
     end
-
-    def valid?(arguments)
-      arguments.any? && secret_for(arguments.first)
-    end
   end
 end

data/lib/tfa/version.rb

@@ -1,3 +1,3 @@
 module TFA
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/lib/tfa.rb

@@ -1,9 +1,6 @@
 require "pstore"
 require "rotp"
 require "tfa/version"
-require "tfa/add_command"
-require "tfa/show_command"
 require "tfa/totp_command"
-require "tfa/usage_command"
-require "tfa/cli"
 require "tfa/storage"
+require "tfa/cli"

data/spec/lib/totp_command_spec.rb

@@ -13,7 +13,7 @@ module TFA
 
         it "returns a time based one time password for the authentication secret given" do
           storage.save('development', secret)
-          expect(subject.run(["development"])).to eql(code_for(secret))
+          expect(subject.run("development")).to eql(code_for(secret))
         end
       end
 
@@ -24,8 +24,8 @@ module TFA
         it "returns the one time password for all keys" do
           storage.save('development', development_secret)
           storage.save('staging', staging_secret)
-          expect(subject.run([])).to eql([
-            { 'development' => code_for(development_secret) }, 
+          expect(subject.run(nil)).to eql([
+            { 'development' => code_for(development_secret) },
             { 'staging' => code_for(staging_secret) }
           ])
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tfa
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - mo khan
@@ -97,15 +97,11 @@ files:
 - Rakefile
 - bin/tfa
 - lib/tfa.rb
-- lib/tfa/add_command.rb
 - lib/tfa/cli.rb
-- lib/tfa/show_command.rb
 - lib/tfa/storage.rb
 - lib/tfa/totp_command.rb
-- lib/tfa/usage_command.rb
 - lib/tfa/version.rb
 - spec/lib/console_spec.rb
-- spec/lib/show_command_spec.rb
 - spec/lib/totp_command_spec.rb
 - spec/spec_helper.rb
 - tfa.gemspec
@@ -135,6 +131,5 @@ specification_version: 4
 summary: A CLI to manage your one time passwords.
 test_files:
 - spec/lib/console_spec.rb
-- spec/lib/show_command_spec.rb
 - spec/lib/totp_command_spec.rb
 - spec/spec_helper.rb

data/lib/tfa/add_command.rb

@@ -1,13 +0,0 @@
-module TFA
-  class AddCommand
-    def initialize(storage)
-      @storage = storage
-    end
-
-    def run(arguments)
-      name = arguments.first
-      @storage.save(arguments.first, arguments.last)
-      "Added #{name}"
-    end
-  end
-end

data/lib/tfa/show_command.rb

@@ -1,12 +0,0 @@
-module TFA
-  class ShowCommand
-    def initialize(storage)
-      @storage = storage
-    end
-
-    def run(arguments)
-      return @storage.secret_for(arguments.last) if arguments.any?
-      @storage.all_secrets
-    end
-  end
-end

data/lib/tfa/usage_command.rb

@@ -1,16 +0,0 @@
-module TFA
-  class UsageCommand
-    def initialize(storage)
-      @storage = storage
-    end
-
-    def run(arguments)
-      <<-MESSAGE
-Try:
-  - tfa add develoment <secret>
-  - tfa show development
-  - tfa totp development
-      MESSAGE
-    end
-  end
-end

data/spec/lib/show_command_spec.rb

@@ -1,26 +0,0 @@
-module TFA
-  describe ShowCommand do
-    subject { ShowCommand.new(storage) }
-    let(:storage) { Storage.new(filename: SecureRandom.uuid) }
-
-    describe "#run" do
-      context "when looking up the secret for a specific key" do
-        it "retrieves the secret associated with the key given" do
-          secret = SecureRandom.uuid
-          storage.save('production', secret)
-          result = subject.run(['production'])
-          expect(result).to eql(secret)
-        end
-      end
-
-      context "when a specific name is not given" do
-        it "returns all the secrets" do
-          storage.save('development', "1")
-          storage.save('staging', "2")
-          storage.save('production', "3")
-          expect(subject.run([])).to eql([{"development" => "1"}, { "staging" => "2" }, { "production" => "3" }])
-        end
-      end
-    end
-  end
-end